Fix coverity #29352
authorTobias Markus <tobbi@mozilla-uk.org>
Mon, 23 Feb 2015 21:16:22 +0000 (22:16 +0100)
committerTobias Markus <tobbi@mozilla-uk.org>
Mon, 23 Feb 2015 21:16:22 +0000 (22:16 +0100)
src/scripting/serialize.cpp
src/scripting/squirrel_util.cpp

index ff3c859..ccbfd20 100644 (file)
@@ -99,8 +99,8 @@ void save_squirrel_table(HSQUIRRELVM vm, SQInteger table_idx, Writer& writer)
       }
       case OT_BOOL: {
         SQBool val;
-        sq_getbool(vm, -1, &val);
-        writer.write(key, val == SQTrue);
+        if(SQ_SUCCEEDED(sq_getbool(vm, -1, &val)))
+          writer.write(key, val == SQTrue);
         break;
       }
       case OT_STRING: {
index 5fd15b4..46cb6c7 100644 (file)
@@ -37,11 +37,12 @@ std::string squirrel2string(HSQUIRRELVM v, SQInteger i)
       break;
     case OT_BOOL: {
       SQBool p;
-      sq_getbool(v, i, &p);
-      if (p)
-        os << "true";
-      else
-        os << "false";
+      if SQ_SUCCEEDED(sq_getbool(v, i, &p)) {
+        if (p)
+          os << "true";
+        else
+          os << "false";
+      }
       break;
     }
     case OT_INTEGER: {