[PATCH] fetch.c: Remove some duplicated code in process()
authorSergey Vlasov <vsu@altlinux.ru>
Wed, 21 Sep 2005 16:34:14 +0000 (20:34 +0400)
committerJunio C Hamano <junkio@cox.net>
Wed, 21 Sep 2005 19:32:32 +0000 (12:32 -0700)
It does not matter if we call prefetch() or set the TO_SCAN flag before
or after adding the object to process_queue.  However, doing it before
object_list_insert() allows us to kill 3 lines of duplicated code.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Junio C Hamano <junkio@cox.net>
fetch.c

diff --git a/fetch.c b/fetch.c
index 390de99..3074f5f 100644 (file)
--- a/fetch.c
+++ b/fetch.c
@@ -138,18 +138,15 @@ static int process(struct object *obj)
                /* We already have it, so we should scan it now. */
                if (obj->flags & TO_SCAN)
                        return 0;
-               object_list_insert(obj, process_queue_end);
-               process_queue_end = &(*process_queue_end)->next;
                obj->flags |= TO_SCAN;
-               return 0;
+       } else {
+               if (obj->flags & COMPLETE)
+                       return 0;
+               prefetch(obj->sha1);
        }
-       if (obj->flags & COMPLETE)
-               return 0;
+               
        object_list_insert(obj, process_queue_end);
        process_queue_end = &(*process_queue_end)->next;
-
-       prefetch(obj->sha1);
-               
        return 0;
 }