daemon: Provide missing argument for logerror() call.
authorMark Wooding <mdw@distorted.org.uk>
Fri, 3 Feb 2006 20:27:02 +0000 (20:27 +0000)
committerJunio C Hamano <junkio@cox.net>
Sat, 4 Feb 2006 07:33:20 +0000 (23:33 -0800)
Could cause a crash if --base-path set.  Unlikely to be a security the
concern: message doesn't go to the client, so we can't leak anything
(except by dumping core), and we've already forked, so it's not a denial
of service.

Signed-off-by: Mark Wooding <mdw@distorted.org.uk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
daemon.c

index bb014fa..532bb0c 100644 (file)
--- a/daemon.c
+++ b/daemon.c
@@ -147,7 +147,7 @@ static char *path_ok(char *dir)
                static char rpath[PATH_MAX];
                if (*dir != '/') {
                        /* Forbid possible base-path evasion using ~paths. */
-                       logerror("'%s': Non-absolute path denied (base-path active)");
+                       logerror("'%s': Non-absolute path denied (base-path active)", dir);
                        return NULL;
                }
                snprintf(rpath, PATH_MAX, "%s%s", base_path, dir);