From 3602864950048219eb2981be13d902cc60117da2 Mon Sep 17 00:00:00 2001 From: Alan Pevec Date: Wed, 12 Aug 2009 00:53:00 +0200 Subject: [PATCH] libvirt plugin: Re-connect to libvirtd if connecting fails. https://bugzilla.redhat.com/show_bug.cgi?id=480997 Signed-off-by: Alan Pevec Signed-off-by: Florian Forster --- src/libvirt.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 5acff29a..6ba08fbc 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -49,6 +49,8 @@ static const char *config_keys[] = { /* Connection. */ static virConnectPtr conn = 0; +static char *conn_string = NULL; +static int conn_count = 0; /* Seconds between list refreshes, 0 disables completely. */ static int interval = 60; @@ -153,14 +155,14 @@ lv_config (const char *key, const char *value) il_interface_devices = ignorelist_create (1); if (strcasecmp (key, "Connection") == 0) { - if (conn != 0) { + if (conn_count++ != 0) { ERROR ("Connection may only be given once in config file"); return 1; } - conn = virConnectOpenReadOnly (value); - if (!conn) { - VIRT_ERROR (NULL, "connection failed"); - return 1; + conn_string = strdup(value); + if (conn_string == NULL) { + ERROR ("libvirt plugin: Connection strdup failed."); + return -1; } return 0; } @@ -253,10 +255,11 @@ lv_read (void) int i; if (conn == NULL) { - ERROR ("libvirt plugin: Not connected. Use Connection in " - "config file to supply connection URI. For more information " - "see "); - return -1; + conn = virConnectOpenReadOnly (conn_string); + if (conn == NULL) { + ERROR ("libvirt plugin: Not connected."); + return -1; + } } time (&t); @@ -264,8 +267,12 @@ lv_read (void) /* Need to refresh domain or device lists? */ if ((last_refresh == (time_t) 0) || ((interval > 0) && ((last_refresh + interval) <= t))) { - if (refresh_lists () != 0) + if (refresh_lists () != 0) { + if (conn != NULL) + virConnectClose (conn); + conn = NULL; return -1; + } last_refresh = t; } -- 2.11.0