From 12ba7eaf1d8188ff85439abb98c5ce64cc81b319 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Tue, 5 Jul 2005 12:12:50 -0700 Subject: [PATCH] Remove unnecessary usage of strncmp() in git-rev-list arg parsing. Not only is it unnecessary, it incorrectly allows extraneous characters at the end of the argument. Junio noticed the --merge-order thing, and Jon points out that if we fix that one, we should fix --show-breaks too. --- rev-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rev-list.c b/rev-list.c index 82500637..0d3c7741 100644 --- a/rev-list.c +++ b/rev-list.c @@ -462,11 +462,11 @@ int main(int argc, char **argv) limited = 1; continue; } - if (!strncmp(arg, "--merge-order", 13)) { + if (!strcmp(arg, "--merge-order")) { merge_order = 1; continue; } - if (!strncmp(arg, "--show-breaks", 13)) { + if (!strcmp(arg, "--show-breaks")) { show_breaks = 1; continue; } -- 2.11.0