From 0bbb85cf0a4d087409b1887f5073cd25d35e383c Mon Sep 17 00:00:00 2001
From: Marc Fournier <marc.fournier@camptocamp.com>
Date: Tue, 28 Oct 2014 18:35:55 +0100
Subject: [PATCH] varnish: monitor VSM usage stats, made available in V4

---
 src/collectd.conf.in  |  1 +
 src/collectd.conf.pod |  6 ++++++
 src/varnish.c         | 33 ++++++++++++++++++++++++++++++++-
 3 files changed, 39 insertions(+), 1 deletion(-)

diff --git a/src/collectd.conf.in b/src/collectd.conf.in
index 80e1d5cd..0583c006 100644
--- a/src/collectd.conf.in
+++ b/src/collectd.conf.in
@@ -1179,6 +1179,7 @@
 #      CollectUptime false
 #      CollectVCL false
 #      CollectWorkers false
+#      CollectVSM false           # Varnish 4 only
 #   </Instance>
 #</Plugin>
 
diff --git a/src/collectd.conf.pod b/src/collectd.conf.pod
index ac0ff2ab..1ba85006 100644
--- a/src/collectd.conf.pod
+++ b/src/collectd.conf.pod
@@ -6322,6 +6322,7 @@ Synopsis:
      CollectSM          false
      CollectTotals      false
      CollectWorkers     false
+     CollectVSM         false
    </Instance>
  </Plugin>
 
@@ -6431,6 +6432,11 @@ Number of total (available + discarded) VCL (config files). False by default.
 
 Collect statistics about worker threads. False by default.
 
+=item B<CollectVSM> B<true>|B<false>
+
+Collect statistics about Varnish's shared memory usage (used by the logging and
+statisticss subsystems). False by default.
+
 =back
 
 =head2 Plugin C<virt>
diff --git a/src/varnish.c b/src/varnish.c
index 517258e2..38efcdc8 100644
--- a/src/varnish.c
+++ b/src/varnish.c
@@ -78,6 +78,9 @@ struct user_config_s {
 #endif
 	_Bool collect_vcl;
 	_Bool collect_workers;
+#if HAVE_VARNISH_V4
+	_Bool collect_vsm;
+#endif
 };
 typedef struct user_config_s user_config_t; /* }}} */
 
@@ -561,6 +564,23 @@ static void varnish_monitor (const user_config_t *conf, /* {{{ */
 #endif
 #endif
 	}
+
+#if HAVE_VARNISH_V4
+	if (conf->collect_vsm)
+	{
+		/* Free VSM space */
+		varnish_submit_gauge (conf->instance, "vsm", "bytes", "free",              stats->vsm_free);
+		/* Used VSM space */
+		varnish_submit_gauge (conf->instance, "vsm", "bytes", "used",              stats->vsm_used);
+		/* Cooling VSM space */
+		varnish_submit_gauge (conf->instance, "vsm", "bytes", "cooling",           stats->vsm_cooling);
+		/* Overflow VSM space */
+		varnish_submit_gauge (conf->instance, "vsm", "bytes", "overflow",          stats->vsm_overflow);
+		/* Total overflowed VSM space */
+		varnish_submit_derive (conf->instance, "vsm", "total_bytes", "overflowed", stats->vsm_overflowed);
+	}
+#endif
+
 } /* }}} void varnish_monitor */
 
 #if HAVE_VARNISH_V3 || HAVE_VARNISH_V4
@@ -688,6 +708,9 @@ static int varnish_config_apply_default (user_config_t *conf) /* {{{ */
 #endif
 	conf->collect_vcl         = 0;
 	conf->collect_workers     = 0;
+#if HAVE_VARNISH_V4
+	conf->collect_vsm         = 0;
+#endif
 
 	return (0);
 } /* }}} int varnish_config_apply_default */
@@ -815,6 +838,10 @@ static int varnish_config_instance (const oconfig_item_t *ci) /* {{{ */
 			cf_util_get_boolean (child, &conf->collect_vcl);
 		else if (strcasecmp ("CollectWorkers", child->key) == 0)
 			cf_util_get_boolean (child, &conf->collect_workers);
+#if HAVE_VARNISH_V4
+		else if (strcasecmp ("CollectVSM", child->key) == 0)
+			cf_util_get_boolean (child, &conf->collect_vsm);
+#endif
 		else
 		{
 			WARNING ("Varnish plugin: Ignoring unknown "
@@ -853,7 +880,11 @@ static int varnish_config_instance (const oconfig_item_t *ci) /* {{{ */
 			&& !conf->collect_uptime
 #endif
 			&& !conf->collect_vcl
-			&& !conf->collect_workers)
+			&& !conf->collect_workers
+#if HAVE_VARNISH_V4
+			&& !conf->collect_vsm
+#endif
+	)
 	{
 		WARNING ("Varnish plugin: No metric has been configured for "
 				"instance \"%s\". Disabling this instance.",
-- 
2.11.0