Junio C Hamano [Thu, 27 Apr 2006 07:13:34 +0000 (00:13 -0700)]
read-tree: teach 1 and 2 way merges about cache-tree.
This teaches one-way and two-way "read-tree -m" (and its special
form, "read-tree --reset" as well) not to discard cache-tree but
invalidate only the changed parts of the tree. When switching
between related branches, this helps the eventual commit
(i.e. write-tree) by keeping cache-tree valid as much as
possible.
This does not prime cache-tree yet, but we ought to be able to
do that for no-merge (i.e. reading from a tree object) case and,
and also perhaps 1 way merge case.
With this patch applied, switching between the tip of Linux 2.6
kernel tree and a branch that touches one path (fs/ext3/Makefile)
from it invalidates only 3 paths out of 1201 cache-tree entries
in the index, and subsequent write-tree takes about a half as
much time as before.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Thu, 27 Apr 2006 05:05:05 +0000 (22:05 -0700)]
update-index: when --unresolve, smudge the relevant cache-tree entries.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Nicolas Pitre [Thu, 27 Apr 2006 03:58:00 +0000 (23:58 -0400)]
use delta index data when finding best delta matches
This patch allows for computing the delta index for each base object
only once and reuse it when trying to find the best delta match.
This should set the mark and pave the way for possibly better delta
generator algorithms.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Thu, 27 Apr 2006 01:32:45 +0000 (18:32 -0700)]
Merge branch 'master' into jc/cache-tree
* master:
t0000-basic: more commit-tree tests.
commit-tree.c: check_valid() microoptimization.
Fix filename verification when in a subdirectory
rebase: typofix.
socksetup: don't return on set_reuse_addr() error
Junio C Hamano [Thu, 27 Apr 2006 01:25:15 +0000 (18:25 -0700)]
t0000-basic: more commit-tree tests.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Nick Hengeveld [Wed, 26 Apr 2006 16:10:01 +0000 (09:10 -0700)]
git-fetch: resolve remote symrefs for HTTP transport
git-fetch validates that a remote ref resolves to a SHA1 prior to calling
git-http-fetch. This adds support for resolving a few levels of symrefs
to get to the SHA1.
Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
sean [Wed, 26 Apr 2006 14:49:38 +0000 (10:49 -0400)]
Add --continue and --abort options to git-rebase.
git rebase [--onto <newbase>] <upstream> [<branch>]
git rebase --continue
git rebase --abort
Add "--continue" to restart the rebase process after
manually resolving conflicts. The user is warned if
there are still differences between the index and the
working files.
Add "--abort" to restore the original branch, and
remove the .dotest working files.
Some minor additions to the git-rebase documentation.
[jc: fix that applies to the maintenance track has been dealt
with separately.]
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 22:09:27 +0000 (15:09 -0700)]
revision parsing: make "rev -- paths" checks stronger.
If you don't have a "--" marker, then:
- all of the arguments we are going to assume are pathspecs
must exist in the working tree.
- none of the arguments we parsed as revisions could be
interpreted as a filename.
so that there really isn't any possibility of confusion in case
somebody does have a revision that looks like a pathname too.
The former rule has been in effect; this implements the latter.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Thu, 27 Apr 2006 00:08:00 +0000 (17:08 -0700)]
Merge branch 'fix'
* fix:
commit-tree.c: check_valid() microoptimization.
Fix filename verification when in a subdirectory
rebase: typofix.
socksetup: don't return on set_reuse_addr() error
Junio C Hamano [Wed, 26 Apr 2006 23:55:25 +0000 (16:55 -0700)]
commit-tree.c: check_valid() microoptimization.
There is no point reading the whole object just to make sure it exists and
it is of the expected type. We added sha1_object_info() for such need
after this code was written, so use it.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Linus Torvalds [Wed, 26 Apr 2006 17:15:54 +0000 (10:15 -0700)]
Fix filename verification when in a subdirectory
When we are in a subdirectory of a git archive, we need to take the prefix
of that subdirectory into accoung when we verify filename arguments.
Noted by Matthias Lederhofer
This also uses the improved error reporting for all the other git commands
that use the revision parsing interfaces, not just git-rev-parse. Also, it
makes the error reporting for mixed filenames and argument flags clearer
(you cannot put flags after the start of the pathname list).
[jc: with fix to a trivial typo noticed by Timo Hirvonen]
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 19:07:42 +0000 (12:07 -0700)]
rebase: typofix.
Noticed by Sean.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 10:29:09 +0000 (03:29 -0700)]
Merge branch 'master' into jc/cache-tree
* master:
commit-tree: allow generic object name for the tree as well.
Makefile: remove and create xdiff library from scratch.
t0000-basic: Add ls-tree recursive test back.
Libified diff-index: backward compatibility fix.
Libify diff-index.
Libify diff-files.
Makefile: remove and create libgit.a from scratch.
Document the configuration file
Document git-var -l listing also configuration variables
rev-parse: better error message for ambiguous arguments
make update-index --chmod work with multiple files and --stdin
socksetup: don't return on set_reuse_addr() error
Fix "git show --stat"
git-update-index --unresolve
Add git-unresolve <paths>...
Add colordiff for git to contrib/colordiff.
gitk: Let git-rev-list do the argument list parsing
Junio C Hamano [Wed, 26 Apr 2006 10:18:51 +0000 (03:18 -0700)]
commit-tree: allow generic object name for the tree as well.
We use get_sha1() for -p (parent) objects, but still used
get_sha1_hex() for the tree. Just to be consistent, allow
extended SHA1 expression for the tree object name.
Note that this is not to encourage funky things like this:
git-commit-tree HEAD^{tree} -p HEAD
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 10:12:58 +0000 (03:12 -0700)]
Makefile: remove and create xdiff library from scratch.
... in the same spirit as
71459c193d04870076efa0a387c317390b53e3e2.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 09:27:59 +0000 (02:27 -0700)]
t0000-basic: Add ls-tree recursive test back.
When we updated ls-tree recursive output to omit the tree nodes,
246cc52f388cae8ca99e5a12b8458c9bfa467765 adjusted the old test
so that we do not expect to see trees in its output. Later,
with
0f8f45cb4a7e664b396f73c25891da46b953b8b8, we added back the
ability to show both with -t option, but we forgot to update the
test as well.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 06:59:28 +0000 (23:59 -0700)]
git-cvsserver: typofixes
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 06:40:09 +0000 (23:40 -0700)]
diff --stat: show complete rewrites consistently.
The patch format shows complete rewrite as deletion of all old lines
followed by addition of all new lines. Count lines consistenly with
that when doing diffstat.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Paul Mackerras [Wed, 26 Apr 2006 06:32:59 +0000 (16:32 +1000)]
Merge branch 'new'
Junio C Hamano [Wed, 26 Apr 2006 06:12:21 +0000 (23:12 -0700)]
Merge branch 'jc/diff'
* jc/diff:
Libified diff-index: backward compatibility fix.
Libify diff-index.
Libify diff-files.
Junio C Hamano [Wed, 26 Apr 2006 06:11:17 +0000 (23:11 -0700)]
Makefile: remove and create libgit.a from scratch.
Foolishly I renamed diff.o around which caused an old diff.o
taken out of libgit.a and got linked into resulting binary and
exhibited mysterious breakage for many people. This borrows
from the kernel Makefile (scripts/Makefile.build) to first remove
the target and then recreate.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 00:40:24 +0000 (17:40 -0700)]
test-dump-cache-tree: report number of subtrees.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 26 Apr 2006 00:40:02 +0000 (17:40 -0700)]
cache-tree: sort the subtree entries.
Not that this makes practical performance difference; the kernel tree
for example has 200 or so directories that have subdirectory, and the
largest ones have 57 of them (fs and drivers). With a test to apply
600 patches with git-apply and git-write-tree, this did not make more
than one per-cent of a difference, but it is a good cleanup.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Martin Langhoff [Wed, 26 Apr 2006 00:26:16 +0000 (12:26 +1200)]
git-cvsexportcommit: Add -f(orce) and -m(essage prefix) flags, small cleanups.
Junio C Hamano [Tue, 25 Apr 2006 23:37:08 +0000 (16:37 -0700)]
Teach fsck-objects about cache-tree.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Josef Weidendorfer [Tue, 18 Apr 2006 21:53:07 +0000 (23:53 +0200)]
[PATCH] gitk: Add a visual tag for remote refs
This patch partly changes the background color for remote refs.
It makes it easy to quickly distinguish remote refs from local
developer branches.
I ignore remote HEADs, as these really should be drawn as
aliases to other heads. But there is no simple way to
detect that HEADs really are aliases for other refs via
"git-ls-remote".
Signed-off-by: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Paul Mackerras [Tue, 25 Apr 2006 11:21:10 +0000 (21:21 +1000)]
gitk: add menu item for editing the current view
This allows the user to change the name of the view, whether it is
permanent, and the list of files/directories for the view.
Signed-off-by: Paul Mackerras <paulus@samba.org>
Paul Mackerras [Tue, 25 Apr 2006 07:12:46 +0000 (17:12 +1000)]
gitk: Implement "permanent" views (stored in ~/.gitk)
With this the user can now mark a view as "permanent" and it will
appear in the list every time gitk is started (until it is deleted).
Also tidied up the view definition window, and changed the view
menu to use radiobuttons for the view selections so there is some
feedback as to which is the current view.
Signed-off-by: Paul Mackerras <paulus@samba.org>
Serge E. Hallyn [Tue, 18 Apr 2006 13:11:06 +0000 (08:11 -0500)]
socksetup: don't return on set_reuse_addr() error
The set_reuse_addr() error case was the only error case in
socklist() where we returned rather than continued. Not sure
why. Either we must free the socklist, or continue. This patch
continues on error.
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
(cherry picked from
0032d548db56eac9ea09b4ba05843365f6325b85 commit)
Petr Baudis [Mon, 24 Apr 2006 22:59:30 +0000 (00:59 +0200)]
Deprecate usage of git-var -l for getting config vars list
This has been an unfortunate sideway in the git API evolution.
We use git-repo-config for all the other .git/config interaction
so let's also use git-repo-config -l for the variable listing.
Signed-off-by: Petr Baudis <pasky@suse.cz>
Petr Baudis [Mon, 24 Apr 2006 22:59:25 +0000 (00:59 +0200)]
git-repo-config --list support
This adds git-repo-config --list (or git-repo-config -l) support,
similar to what git-var -l does now (to be phased out so that we
have a single sane interface to the config file instead of fragmented
and confused API).
Signed-off-by: Petr Baudis <pasky@suse.cz>
Nicolas Pitre [Tue, 25 Apr 2006 03:07:47 +0000 (23:07 -0400)]
split the diff-delta interface
This patch splits the diff-delta interface into index creation and delta
generation. A wrapper is provided to preserve the diff-delta() call.
This will allow for an optimization in pack-objects.c where the source
object could be fixed and a full window of objects tentatively tried
against
that same source object without recomputing the source index each time.
This patch only restructure things, plus a couple cleanups for good
measure. There is no performance change yet.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Junio C Hamano [Tue, 25 Apr 2006 05:26:57 +0000 (22:26 -0700)]
Merge branch 'fix'
* fix:
Document the configuration file
Document git-var -l listing also configuration variables
rev-parse: better error message for ambiguous arguments
Petr Baudis [Mon, 24 Apr 2006 22:59:33 +0000 (00:59 +0200)]
Document the configuration file
This patch adds a Documentation/config.txt file included by git-repo-config
and currently aggregating hopefully all the available git plumbing / core
porcelain configuration variables, as well as briefly describing the format.
It also updates an outdated bit of the example in git-repo-config(1).
Signed-off-by: Petr Baudis <pasky@suse.cz>
Petr Baudis [Mon, 24 Apr 2006 22:59:28 +0000 (00:59 +0200)]
Document git-var -l listing also configuration variables
Signed-off-by: Petr Baudis <pasky@suse.cz>
Paul Mackerras [Tue, 25 Apr 2006 00:00:03 +0000 (10:00 +1000)]
rev-parse: better error message for ambiguous arguments
Currently, if git-rev-parse encounters an argument that is neither a
recognizable revision name nor the name of an existing file or
directory, and it hasn't encountered a "--" argument, it prints an
error message saying "No such file or directory". This can be
confusing for users, including users of programs such as gitk that
use git-rev-parse, who may then think that they can't ask about the
history of files that no longer exist.
This makes it print a better error message, one that points out the
ambiguity and tells the user what to do to fix it.
Signed-off-by: Paul Mackerras <paulus@samba.org>
Junio C Hamano [Tue, 25 Apr 2006 04:18:58 +0000 (21:18 -0700)]
index: make the index file format extensible.
... and move the cache-tree data into it.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Mon, 24 Apr 2006 22:12:42 +0000 (15:12 -0700)]
cache-tree: protect against "git prune".
We reused the cache-tree data without verifying the tree object
still exists. Recompute in cache_tree_update() an otherwise
valid cache-tree entry when the tree object disappeared.
This is not usually a problem, but theoretically without this
fix things can break when the user does something like this:
- read-index from a side branch
- write-tree the result
- remove the side branch with "git branch -D"
- remove the unreachable objects with "git prune"
- write-tree what is in the index.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Mon, 24 Apr 2006 09:08:35 +0000 (02:08 -0700)]
Merge branch 'ar/chmod-series'
* ar/chmod-series:
make update-index --chmod work with multiple files and --stdin
Junio C Hamano [Mon, 24 Apr 2006 09:08:28 +0000 (02:08 -0700)]
Merge branch 'sh/daemon'
* sh/daemon:
socksetup: don't return on set_reuse_addr() error
Junio C Hamano [Mon, 24 Apr 2006 09:06:40 +0000 (02:06 -0700)]
Merge branch 'jc/cc-stat'
* jc/cc-stat:
Fix "git show --stat"
Junio C Hamano [Mon, 24 Apr 2006 09:05:55 +0000 (02:05 -0700)]
Merge branch 'jc/unresolve'
* jc/unresolve:
git-update-index --unresolve
Add git-unresolve <paths>...
Junio C Hamano [Mon, 24 Apr 2006 09:05:07 +0000 (02:05 -0700)]
Merge branch 'jc/color'
* jc/color:
Add colordiff for git to contrib/colordiff.
Junio C Hamano [Mon, 24 Apr 2006 08:39:01 +0000 (01:39 -0700)]
Merge git://git.kernel.org/pub/scm/gitk/gitk
* git://git.kernel.org/pub/scm/gitk/gitk:
gitk: Let git-rev-list do the argument list parsing
Junio C Hamano [Mon, 24 Apr 2006 03:20:25 +0000 (20:20 -0700)]
Add test-dump-cache-tree
This was useful in diagnosing the corrupt index.aux format
problem. But do not bother building or installing it by
default.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Mon, 24 Apr 2006 07:23:54 +0000 (00:23 -0700)]
Use cache-tree in update-index.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sun, 23 Apr 2006 23:52:52 +0000 (16:52 -0700)]
Invalidate cache-tree entries for touched paths in git-apply.
This updates git-apply to maintain cache-tree information. With
this and the previous write-tree patch, repeated "apply --index"
followed by "write-tree" on a huge tree will hopefully become
faster.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sun, 23 Apr 2006 23:52:35 +0000 (16:52 -0700)]
Update write-tree to use cache-tree.
The updated write-tree reads from $GIT_DIR/index.aux to pick up
subtree objects information, updates the cache-tree with the
index, and updates index.aux file after writing a tree out of
the index file.
Until update-index and other programs that modify the index are
updated to maintain index.aux file, the index.aux file written
by the last write-tree will become stale immediately after they
update the index, which will result in the whole tree
recomputation just like the original write-tree.
The idea is to convert those commands to invalidate cache-tree
whenever they touch the index entries, and write updated
index.aux out. After the index is updated with them, write-tree
will be able to reuse the parts of the cache-tree that have not
been touched.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sun, 23 Apr 2006 23:52:20 +0000 (16:52 -0700)]
Add cache-tree.
The cache_tree data structure is to cache tree object names that
would result from the current index file.
The idea is to have an optional file to record each tree object
name that corresponds to a directory path in the cache when we
run write_cache(), and read it back when we run read_cache().
During various index manupulations, we selectively invalidate
the parts so that the next write-tree can bypass regenerating
tree objects for unchanged parts of the directory hierarchy.
We could perhaps make the cache-tree data an optional part of
the index file, but that would involve the index format updates,
so unless we need it for performance reasons, the current plan
is to use a separate file, $GIT_DIR/index.aux to store this
information and link it with the index file with the checksum
that is already used for index file integrity check.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sun, 23 Apr 2006 23:52:08 +0000 (16:52 -0700)]
read-cache/write-cache: optionally return cache checksum SHA1.
read_cache_1() and write_cache_1() takes an extra parameter
*sha1 that returns the checksum of the index file when non-NULL.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Paul Mackerras [Sun, 23 Apr 2006 12:47:07 +0000 (22:47 +1000)]
Merge branch 'master' into new
Paul Mackerras [Sun, 23 Apr 2006 12:45:55 +0000 (22:45 +1000)]
gitk: Use git-rev-parse only to identify file/dir names on cmd line
This uses git-rev-parse --no-revs --no-flags to give us just the
file and directory names on the command line, so that we can create
the "Command line" view if any were specified. All other arguments
just get passed to git-rev-list (without a pass through git-rev-parse).
Signed-off-by: Paul Mackerras <paulus@samba.org>
Paul Mackerras [Sun, 23 Apr 2006 08:00:24 +0000 (18:00 +1000)]
gitk: Let git-rev-list do the argument list parsing
This is a fix for a problem reported by Jim Radford where an argument
list somewhere overflows on repositories with lots of tags. In fact
it's now unnecessary to use git-rev-parse since git-rev-list can take
all the arguments that git-rev-parse can. This is inspired by but not
the same as the solutions suggested by Jim Radford and Linus Torvalds.
Signed-off-by: Paul Mackerras <paulus@samba.org>
Alex Riesen [Sun, 23 Apr 2006 07:01:29 +0000 (09:01 +0200)]
make update-index --chmod work with multiple files and --stdin
The patch makes "--chmod=-x" and "--chmod=+x" act like "--add"
and "--remove" to affect the behaviour of the command for the
rest of the path parameters, not just the following one.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sat, 22 Apr 2006 10:58:04 +0000 (03:58 -0700)]
Libified diff-index: backward compatibility fix.
"diff-index -m" does not mean "do not ignore merges", but means
"pretend missing files match the index".
The previous round tried to address this, but failed because
setup_revisions() ate "-m" flag before the caller had a chance
to intervene.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sat, 22 Apr 2006 10:06:13 +0000 (03:06 -0700)]
git-fmt-patch: thinkofix to show [PATCH] properly.
Updating "subject" variable without changing the hardcoded
number of bytes to memcpy from it would not help much.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sat, 22 Apr 2006 09:43:00 +0000 (02:43 -0700)]
Libify diff-index.
The second installment to libify diff brothers. The pathname
arguments are checked more strictly than before because we now
use the revision.c::setup_revisions() infrastructure.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sat, 22 Apr 2006 06:57:45 +0000 (23:57 -0700)]
Libify diff-files.
This is the first installment to libify diff brothers.
The updated diff-files uses revision.c::setup_revisions()
infrastructure to parse its command line arguments, which means
the pathname arguments are checked more strictly than before.
The tests are adjusted to separate possibly missing paths from
the rest of arguments with double-dashes, to show the kosher
way.
As Linus pointed out, renaming diff.c to diff-lib.c was simply
stupid, so I am renaming it back. The new diff-lib.c is to
contain pieces extracted from diff brothers.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sat, 22 Apr 2006 02:39:04 +0000 (19:39 -0700)]
Fix "git show --stat"
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 12 Apr 2006 06:05:14 +0000 (23:05 -0700)]
Add colordiff for git to contrib/colordiff.
I hacked it up to teach it the git extended diff headers, made
it not to read the whole patch in the array.
Also, the original program, when arguments are given, ran "diff"
with the given arguments and showed the output from it. Of
course, I changed it to run "git diff" ;-).
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Sat, 22 Apr 2006 05:03:07 +0000 (22:03 -0700)]
Merge branch 'jc/diff'
* jc/diff:
diff --stat: do not drop rename information.
Junio C Hamano [Sat, 22 Apr 2006 04:56:13 +0000 (21:56 -0700)]
Makefile: dependency for builtin-help.o
builtin-help.c wants to include common-cmds.h which is a
generated file.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Fri, 21 Apr 2006 20:19:58 +0000 (13:19 -0700)]
Merge branch 'master' into jc/fmt-patch
* master:
Split up builtin commands into separate files from git.c
git-log produces no output
fix pack-object buffer size
mailinfo: decode underscore used in "Q" encoding properly.
Reintroduce svn pools to solve the memory leak.
pack-objects: do not stop at object that is "too small"
git-commit --amend: two fixes.
get_tree_entry(): make it available from tree-walk
sha1_name.c: no need to include diff.h; tree-walk.h will do.
sha1_name.c: prepare to make get_tree_entry() reusable from others.
get_sha1() shorthands for blob/tree objects
pre-commit hook: complain about conflict markers.
git-merge: a bit more readable user guidance.
diff: move diff.c to diff-lib.c to make room.
git log: don't do merge diffs by default
Allow "git repack" users to specify repacking window/depth
Document git-clone --reference
Fix filename scaling for binary files
Fix uninteresting tags in new revision parsing
Conflicts:
Adjusted the addition of fmt-patch to match the recent split
from git.c to builtin.log.c.
Linus Torvalds [Fri, 21 Apr 2006 17:27:34 +0000 (10:27 -0700)]
Split up builtin commands into separate files from git.c
Right now it split it into "builtin-log.c" for log-related commands
("log", "show" and "whatchanged"), and "builtin-help.c" for the
informational commands (usage printing and "help" and "version").
This just makes things easier to read, I find.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Fri, 21 Apr 2006 20:14:30 +0000 (13:14 -0700)]
Merge branch 'fix'
* fix:
git-log produces no output
Linus Torvalds [Fri, 21 Apr 2006 19:25:13 +0000 (12:25 -0700)]
git-log produces no output
When $PAGER is set to 'less -i', we used to fail because we
assumed the $PAGER is a command and simply exec'ed it.
Try exec first, and then run it through shell if it fails. This
allows even funkier PAGERs like these ;-):
PAGER='sed -e "s/^/`date`: /" | more'
PAGER='contrib/colordiff.perl | less -RS'
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Fri, 21 Apr 2006 07:45:40 +0000 (00:45 -0700)]
Merge branch 'fix'
* fix:
fix pack-object buffer size
mailinfo: decode underscore used in "Q" encoding properly.
Reintroduce svn pools to solve the memory leak.
pack-objects: do not stop at object that is "too small"
Nicolas Pitre [Thu, 20 Apr 2006 21:25:37 +0000 (17:25 -0400)]
fix pack-object buffer size
The input line has 40 _chars_ of sha1 and no 20 _bytes_. It should also
account for the space before the pathname, and the terminating \n and \0.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Fri, 21 Apr 2006 07:06:58 +0000 (00:06 -0700)]
mailinfo: decode underscore used in "Q" encoding properly.
Quoted-Printable (RFC 2045) and the "Q" encoding (RFC 2047) are
subtly different; the latter is used on the mail header and an
underscore needs to be decoded to 0x20.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Santi_Béjar [Mon, 27 Mar 2006 11:26:01 +0000 (13:26 +0200)]
Reintroduce svn pools to solve the memory leak.
Introduced in
4802426.
Signed-off-by: Santi Béjar <sbejar@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Fri, 21 Apr 2006 06:36:22 +0000 (23:36 -0700)]
pack-objects: do not stop at object that is "too small"
Because we sort the delta window by name-hash and then size,
hitting an object that is too small to consider as a delta base
for the current object does not mean we do not have better
candidate in the window beyond it.
Noticed by Shawn Pearce, analyzed by Nico, Linus and me.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Paul Mackerras [Fri, 21 Apr 2006 00:35:31 +0000 (10:35 +1000)]
gitk: Remember the view in the history list
When moving backwards or forwards through the history list, this
automatically switches the view so that each point that we jump to
is shown in the same view that it was originally displayed in.
Signed-off-by: Paul Mackerras <paulus@samba.org>
Junio C Hamano [Thu, 20 Apr 2006 19:45:02 +0000 (12:45 -0700)]
rename internal format-patch wip
Otherwise "git format-patch" would invoke unfinished internal one that
does only --stdout
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Thu, 20 Apr 2006 09:52:04 +0000 (02:52 -0700)]
Merge branch 'fix'
* fix:
git-commit --amend: two fixes.
Junio C Hamano [Thu, 20 Apr 2006 08:20:56 +0000 (01:20 -0700)]
git-commit --amend: two fixes.
When running "git commit --amend" only to fix the commit log
message without any content change, we mistakenly showed the
git-status output that says "nothing to commit" without
commenting it out.
If you have already run update-index but you want to amend the
top commit, "git commit --amend --only" without any paths should
have worked, because --only means "starting from the base
commit, update-index these paths only to prepare the index to
commit, and perform the commit". However, we refused -o without
paths.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Thu, 20 Apr 2006 06:52:05 +0000 (23:52 -0700)]
git-update-index --unresolve
Retire git-unresolve and make it into "git-update-index --unresolve".
It processes all paths that follow.
During a merge, you would mark a path that is dealt with with:
$ git update-index hello
and you would "undo" it with:
$ git update-index --unresolve hello
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Thu, 20 Apr 2006 03:41:14 +0000 (20:41 -0700)]
diff --stat: do not drop rename information.
When a verbatim rename or copy is detected, we did not show
anything on the "diff --stat" for the filepair. This makes it
to show the rename information.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 19:51:29 +0000 (12:51 -0700)]
Add git-unresolve <paths>...
This is an attempt to address the issue raised on #git channel
recently by Carl Worth.
After a conflicted automerge, "git diff" shows a combined diff
to give you how the tentative automerge result differs from
what came from each branch. During a complex merge, it is
tempting to be able to resolve a few paths at a time, mark
them "I've dealt with them" with git-update-index to unclutter
the next "git diff" output, and keep going. However, when the
final result does not compile or otherwise found to be a
mismerge, the workflow to fix the mismerged paths suddenly
changes to "git diff HEAD -- path" (to get a diff from our
HEAD before merging) and "git diff MERGE_HEAD -- path" (to get
a diff from theirs), and it cannot show the combined anymore.
With git-unresolve <paths>..., the versions from our branch and
their branch for specified blobs are placed in stage #2 and
stage #3, without touching the working tree files. This gives
you the combined diff back for easier review, along with
"diff --ours" and "diff --theirs".
One thing it does not do is to place the base in stage #1; this
means "diff --base" would behave differently between the run
immediately after a conflicted three-way merge, and the run
after an update-index by mistake followed by a git-unresolve.
We could theoretically run merge-base between HEAD and
MERGE_HEAD to find which tree to place in stage #1, but
reviewing "diff --base" is not that useful so....
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 22:57:45 +0000 (15:57 -0700)]
Merge branch 'lt/xsha1'
* lt/xsha1:
get_tree_entry(): make it available from tree-walk
sha1_name.c: no need to include diff.h; tree-walk.h will do.
sha1_name.c: prepare to make get_tree_entry() reusable from others.
get_sha1() shorthands for blob/tree objects
Junio C Hamano [Wed, 19 Apr 2006 22:41:55 +0000 (15:41 -0700)]
Merge branch 'maint'
* maint:
pre-commit hook: complain about conflict markers.
git-merge: a bit more readable user guidance.
Junio C Hamano [Wed, 19 Apr 2006 22:12:02 +0000 (15:12 -0700)]
diff: move diff.c to diff-lib.c to make room.
Now I am not doing any real "git-diff in C" yet, but this would
help before doing so.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 21:58:24 +0000 (14:58 -0700)]
pre-commit hook: complain about conflict markers.
Several <<< or === or >>> characters at the beginning of a line
is very likely to be leftover conflict markers from a failed
automerge the user resolved incorrectly, so detect them.
As usual, this can be defeated with "git commit --no-verify" if
you really do want to have those files, just like changes that
introduce trailing whitespaces.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 21:54:27 +0000 (14:54 -0700)]
git-merge: a bit more readable user guidance.
We said "fix up by hand" after failed automerge, which was a big
"Huh? Now what?". Be a bit more explicit without being too
verbose. Suggested by Carl Worth.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 22:16:08 +0000 (15:16 -0700)]
Minor tweak on subject line in --pretty=email
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 21:05:47 +0000 (14:05 -0700)]
get_tree_entry(): make it available from tree-walk
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 18:56:53 +0000 (11:56 -0700)]
sha1_name.c: no need to include diff.h; tree-walk.h will do.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 18:56:07 +0000 (11:56 -0700)]
sha1_name.c: prepare to make get_tree_entry() reusable from others.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Linus Torvalds [Wed, 19 Apr 2006 17:20:49 +0000 (10:20 -0700)]
git log: don't do merge diffs by default
I personally prefer "ignore_merges" to be on by default, because quite
often the merge diff is distracting and not interesting. That's true both
with "-p" and with "--stat" output.
If you want output from merges, you can trivially use the "-m", "-c" or
"--cc" flags to tell that you're interested in merges, which also tells
the diff generator what kind of diff to do (for --stat, any of the three
will do, of course, but they differ for plain patches or for
--patch-with-stat).
This trivial patch just removes the two lines that tells "git log" not to
ignore merges. It will still show the commit log message, of course, due
to the "always_show_header" part.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Linus Torvalds [Wed, 19 Apr 2006 17:05:12 +0000 (10:05 -0700)]
Allow "git repack" users to specify repacking window/depth
.. but don't even bother documenting it. I don't think any normal person
is supposed to ever really care, but it simplifies testing when you want
to use the "git repack" wrapper rather than forcing you to use the core
programs (which already do support the window/depth arguments, of course).
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Wed, 19 Apr 2006 09:25:29 +0000 (02:25 -0700)]
Merge branch 'fix'
* fix:
Document git-clone --reference
Fix filename scaling for binary files
Linus Torvalds [Tue, 18 Apr 2006 23:45:16 +0000 (16:45 -0700)]
get_sha1() shorthands for blob/tree objects
This is a fairly straightforward patch to allow "get_sha1()" to also have
shorthands for tree and blob objects.
The syntax is very simple and intuitive: you can specify a tree or a blob
by simply specifying <revision>:<path>, and get_sha1() will do the SHA1
lookup from the tree for you.
You can currently do it with "git ls-tree <rev> <path>" and parsing the
output, but that's actually pretty awkward.
With this, you can do something like
git cat-file blob v1.2.4:Makefile
to get the contents of "Makefile" at revision v1.2.4.
Now, this isn't necessarily something you really need all that often, but
the concept itself is actually pretty powerful. We could, for example,
allow things like
git diff v0.99.6:git-commit-script..v1.3.0:git-commit.sh
to see the difference between two arbitrary files in two arbitrary
revisions. To do that, the only thing we'd have to do is to make
git-diff-tree accept two blobs to diff, in addition to the two trees it
now expects.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Linus Torvalds [Wed, 19 Apr 2006 03:31:41 +0000 (20:31 -0700)]
Fix uninteresting tags in new revision parsing
When I unified the revision argument parsing, I introduced a simple bug
wrt tags that had been marked uninteresting. When it was preparing for the
revision walk, it would mark all the parent commits of an uninteresting
tag correctly uninteresting, but it would forget about the commit itself.
This means that when I just did my 2.6.17-rc2 release, and my scripts
generated the log for "v2.6.17-rc1..v2.6.17-rc2", everything was fine,
except the commit pointed to by 2.6.17-rc1 (which shouldn't have been
there) was included. Even though it should obviously have been marked as
being uninteresting.
Not a huge deal, and the fix is trivial.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Shawn Pearce [Wed, 19 Apr 2006 00:19:48 +0000 (20:19 -0400)]
Document git-clone --reference
The new --reference flag introduced to git-clone in
GIT 1.3.0 was not documented but is rather handy.
So document it.
Also corrected a minor issue with the documentation for the
-s flag; the info/alternates file name was spelled wrong.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Tue, 18 Apr 2006 23:45:27 +0000 (16:45 -0700)]
Tentative built-in format-patch.
This only does --stdout right now. To write into separate files
with pretty-printed filenames like the real thing does, it needs
a bit mroe work.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Jonas Fonseca [Tue, 18 Apr 2006 21:26:43 +0000 (23:26 +0200)]
Fix filename scaling for binary files
Set maximum filename length for binary files so that scaling won't be
triggered and result in invalid string access.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Serge E. Hallyn [Tue, 18 Apr 2006 13:11:06 +0000 (08:11 -0500)]
socksetup: don't return on set_reuse_addr() error
The set_reuse_addr() error case was the only error case in
socklist() where we returned rather than continued. Not sure
why. Either we must free the socklist, or continue. This patch
continues on error.
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano [Tue, 18 Apr 2006 20:57:22 +0000 (13:57 -0700)]
Merge branch 'jc/pager-cat'
* jc/pager-cat:
Do not fork PAGER=cat
Junio C Hamano [Tue, 18 Apr 2006 20:56:36 +0000 (13:56 -0700)]
Merge branch 'lt/logopt'
* lt/logopt:
Fix "git log --stat": make sure to set recursive with --stat.
combine-diff: show diffstat with the first parent.
git.c: LOGSIZE is unused after log printing cleanup.
Log message printout cleanups (#3): fix --pretty=oneline
Log message printout cleanups (#2)
Log message printout cleanups
rev-list --header: output format fix
Fixes for option parsing
log/whatchanged/show - log formatting cleanup.
Simplify common default options setup for built-in log family.
Tentative built-in "git show"
Built-in git-whatchanged.
rev-list option parser fix.
Split init_revisions() out of setup_revisions()
Fix up rev-list option parsing.
Fix up default abbrev in setup_revisions() argument parser.
Common option parsing for "git log --diff" and friends
Junio C Hamano [Tue, 18 Apr 2006 20:15:18 +0000 (13:15 -0700)]
GIT 1.3.0
Signed-off-by: Junio C Hamano <junkio@cox.net>
Jonas Fonseca [Mon, 6 Mar 2006 05:24:44 +0000 (06:24 +0100)]
Add git-annotate(1) and git-blame(1)
[jc: with entries in git.txt]
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Junio C Hamano <junkio@cox.net>