Ruben Kerkhof [Sat, 4 Jul 2015 17:52:52 +0000 (19:52 +0200)]
collectd.conf: order plugins alphabetically again
Ruud van Melick [Tue, 30 Jun 2015 16:08:49 +0000 (16:08 +0000)]
Fix Perl errors
"my" variable $cmd masks earlier declaration in same scope at /tmp/contrib_collectd2html.pl line 223.
syntax error at /tmp/contrib_collectd2html.pl line 219, near "$span qw(1hour 1day 1week 1month)"
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 221.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 224.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 225.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 232.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 237.
syntax error at /tmp/contrib_collectd2html.pl line 245, near "}"
Michal Humpula [Mon, 6 Jul 2015 11:43:43 +0000 (13:43 +0200)]
bind: fix zone count check
Florian Forster [Fri, 3 Jul 2015 08:46:14 +0000 (10:46 +0200)]
collectd.conf(5): Add documentation.
Also add example config to src/collectd.conf.in
Florian Forster [Fri, 3 Jul 2015 08:45:37 +0000 (10:45 +0200)]
mqtt plugin: Change some default values.
* qos: 0 for publishers, 2 for subscribers
* store_rates: true
* clean_session: true
Florian Forster [Fri, 3 Jul 2015 08:44:35 +0000 (10:44 +0200)]
mqtt plugin: Use the "name" argument for the callback name.
Florian Forster [Fri, 3 Jul 2015 08:43:38 +0000 (10:43 +0200)]
mqtt plugin: Increase keepalive interval to 60s.
This is the default used by the Mosquitto tools. The new define makes
it possible to easily override this at compile time.
Florian Forster [Fri, 3 Jul 2015 08:42:44 +0000 (10:42 +0200)]
mqtt plugin: Add myself to list of authors, copyright holders.
Florian Forster [Fri, 21 Nov 2014 16:41:17 +0000 (17:41 +0100)]
mqtt plugin: Add proof-of-concept subscriber code.
Publisher and subscriber should now be able to send metrics to one another.
Florian Forster [Fri, 21 Nov 2014 15:03:22 +0000 (16:03 +0100)]
mqtt plugin: Send only the acutally used part of the payload buffer.
Florian Forster [Fri, 21 Nov 2014 12:17:54 +0000 (13:17 +0100)]
mqtt plugin: Let "client ID" default to the hostname.
The MQTT documentation says that this needs to be unique and stable, so
I think the hostname is the best match for this.
Florian Forster [Fri, 21 Nov 2014 11:05:39 +0000 (12:05 +0100)]
mqtt plugin: Add support for multiple brokers.
Also adds support for authentication and configuring a couple of settings
(QoS, rates, retention).
Florian Forster [Fri, 21 Nov 2014 10:23:01 +0000 (11:23 +0100)]
mqtt plugin: Correctly check the return value of format_topic().
Florian Forster [Fri, 21 Nov 2014 09:39:50 +0000 (10:39 +0100)]
mqtt plugin: Use the thread-safe sstrerror().
Florian Forster [Fri, 21 Nov 2014 09:38:55 +0000 (10:38 +0100)]
mqtt plugin: Don't use <stdbool.h>.
Instead, use the standard _Bool type.
Florian Forster [Thu, 20 Nov 2014 19:05:50 +0000 (20:05 +0100)]
mqtt plugin: Add preliminary configuration support.
Florian Forster [Thu, 20 Nov 2014 17:26:02 +0000 (18:26 +0100)]
mqtt plugin: Rename mqtt_publish_message() to publish().
Florian Forster [Thu, 20 Nov 2014 17:25:21 +0000 (18:25 +0100)]
mqtt plugin: Change message format to one topic per metric.
The payload now includes all data sources and the timestamp. The payload
is formatted with the existing format_values() function, which removed
quite a couple of lines of code.
Florian Forster [Thu, 20 Nov 2014 17:19:37 +0000 (18:19 +0100)]
mqtt plugin: Concurrency fixes, pick up conf->lock in publish.
Florian Forster [Thu, 20 Nov 2014 16:42:42 +0000 (17:42 +0100)]
mqtt plugin: Compile fixes.
This compiles with libmosquitto 0.15.0. It appears newer versions of the
library have some interface changes, so we should add a version check.
Luckily, libmosquitto provides everything we need.
Florian Forster [Thu, 20 Nov 2014 16:38:15 +0000 (17:38 +0100)]
configure.ac, src/Makefile.am: Add mqtt to the build system.
Marc Falzon [Wed, 19 Nov 2014 16:41:30 +0000 (17:41 +0100)]
Initial import
Marc Falzon [Wed, 19 Nov 2014 16:29:33 +0000 (17:29 +0100)]
Initial commit
Florian Forster [Fri, 3 Jul 2015 13:15:09 +0000 (15:15 +0200)]
serial plugin: Fix -Wshorten-64-to-32 warning.
serial.c:87:28: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
len = strlen (fields[0]) - 1;
~ ~~~~~~~~~~~~~~~~~~~^~~
serial.c:96:10: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
len = strlen (fields[i]);
~ ^~~~~~~~~~~~~~~~~~
Florian Forster [Fri, 3 Jul 2015 13:06:28 +0000 (15:06 +0200)]
src/utils_ignorelist.c: Reimplement ignorelist_append_regex().
There's a signed / unsigned conversion in that function ...
... aaaaand it's fully rewritten. Oops.
Florian Forster [Fri, 3 Jul 2015 11:55:24 +0000 (13:55 +0200)]
collectd-tg: Remove use of NAN.
This broke the build under Solaris, once again *sigh*.
collectd-tg.c: In function ‘dtime’:
collectd-tg.c:108:12: error: ‘NAN’ undeclared (first use in this function)
return NAN;
^
Dagobert Michelsen [Thu, 18 Jun 2015 13:28:36 +0000 (15:28 +0200)]
Take out explicit definitions as they are already checked via enable_standards in configure.ac.
Fixes: #978
Florian Forster [Fri, 3 Jul 2015 10:31:32 +0000 (12:31 +0200)]
collectd-tg: Move _POSIX_C_SOURCE and friends to the Makefile.
Apparently defining this in the source files confuses Solaris' libc.
Thanks to @dago for looking into this.
Hopefully fixes: #978
Florian Forster [Fri, 3 Jul 2015 09:52:50 +0000 (11:52 +0200)]
collectdctl: Fix -Wsign-conversion warnings.
Also fixes a shadowed local variable warning.
Florian Forster [Fri, 3 Jul 2015 09:49:07 +0000 (11:49 +0200)]
collectd-nagios: Fix -Wsign-conversion warnings.
Florian Forster [Fri, 3 Jul 2015 09:44:28 +0000 (11:44 +0200)]
collectd-tg: Fix unintentional cast from double to time_t.
This fix is likely incomplete: the printf() line is probably executed way
too often now.
Florian Forster [Fri, 3 Jul 2015 06:23:29 +0000 (08:23 +0200)]
utils_cache.c, scale target: Don't re-implement counter wrap-around logic.
Yves Mettier [Wed, 1 Jul 2015 15:10:30 +0000 (16:10 +0100)]
Added MetaDataSet to target_set
Florian Forster [Mon, 29 Jun 2015 15:56:37 +0000 (17:56 +0200)]
src/daemon/utils_subst_test.c: Actually add unit test.
D'oh!
Florian Forster [Mon, 29 Jun 2015 15:32:44 +0000 (17:32 +0200)]
src/daemon/utils_subst.c: Sanitize buffer offsets better.
The previous implementation broke when off1 / off2 were outside of "string"
but within "buflen". It also had problems if the replacement string was
too long. This new implementation truncates the buffer as expected and
is properly tested.
Florian Forster [Mon, 29 Jun 2015 10:52:03 +0000 (12:52 +0200)]
write_riemann plugin: Ensure that "statuses" is always initialized.
Hopefully fixes "Uninitialized argument value" warning.
Florian Forster [Mon, 29 Jun 2015 10:50:51 +0000 (12:50 +0200)]
src/daemon/common.[ch]: Improve signature of value_to_rate().
Passing in "value" as a derive_t and returning the rate as a value_t is
just inconvenient and wrong. Instead, pass "value" as a value_t and return
the rate in a gauge_t. While at it, move the state pointer to the end of
the argument list.
Florian Forster [Mon, 29 Jun 2015 07:51:12 +0000 (09:51 +0200)]
src/daemon/common_test.c: Fix "decimal constant is unsigned only in ISO C90" warning.
Florian Forster [Sun, 28 Jun 2015 13:05:45 +0000 (15:05 +0200)]
Merge branch 'collectd-5.5'
Florian Forster [Sun, 28 Jun 2015 13:05:36 +0000 (15:05 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Florian Forster [Sun, 28 Jun 2015 13:00:49 +0000 (15:00 +0200)]
src/daemon/common.c: Fix handling of counter_t in value_to_rate().
Also fixes an off-by-one error in counter_diff() and adds a unit test for
the function.
Florian Forster [Sun, 28 Jun 2015 12:05:05 +0000 (14:05 +0200)]
src/daemon/common.c: Fix off-by-one error in escape_slashes().
Partial cherry-pick of
0cba91923be9326224f8434e4aae7691f7b6dad1.
Florian Forster [Sun, 28 Jun 2015 12:08:02 +0000 (14:08 +0200)]
src/daemon/common.c: Add unit test for escape_string().
Florian Forster [Sun, 28 Jun 2015 12:05:05 +0000 (14:05 +0200)]
src/daemon/common.c: Fix off-by-one error in escape_slashes().
This also adds a unit test for this issue.
Marc Fournier [Fri, 26 Jun 2015 06:09:47 +0000 (08:09 +0200)]
Merge branch 'collectd-5.5'
Conflicts:
src/write_redis.c
Florian Forster [Thu, 25 Jun 2015 20:37:20 +0000 (22:37 +0200)]
Merge remote-tracking branch 'github/pr/1097'
Landry Breuil [Wed, 24 Jun 2015 04:48:16 +0000 (06:48 +0200)]
properly handle error cases when kvm_read fails (#1094)
Florian Forster [Thu, 25 Jun 2015 20:34:26 +0000 (22:34 +0200)]
Merge remote-tracking branch 'github/pr/1093'
Marek Becka [Wed, 24 Jun 2015 15:39:55 +0000 (11:39 -0400)]
don't report inodes if fs doesn't provide f_files and f_ffree
Florian Forster [Thu, 25 Jun 2015 20:18:27 +0000 (22:18 +0200)]
write_redis plugin: Call freeReplyObject() for each redisReply.
Florian Forster [Thu, 25 Jun 2015 20:11:17 +0000 (22:11 +0200)]
write_redis plugin: Use the prefix for the "values" set, too.
Make the code match the documentation and use the prefix for the set of all
metrics, too. Also add documentation for the "Prefix" option and let the
default prefix be set at compile time.
Florian Forster [Thu, 25 Jun 2015 19:40:27 +0000 (21:40 +0200)]
Merge remote-tracking branch 'github/pr/1082'
Florian Forster [Thu, 25 Jun 2015 10:36:42 +0000 (12:36 +0200)]
Fix signed / unsigned comparison errors.
A lot of loop counters need to be size_t now, because values_len and ds_num
are now of that type.
Florian Forster [Thu, 25 Jun 2015 09:31:19 +0000 (11:31 +0200)]
src/daemon/common.c: Add parse_values() unit test.
Florian Forster [Thu, 25 Jun 2015 09:30:46 +0000 (11:30 +0200)]
src/daemon/plugin.h: Change "values_len" to type "size_t".
Florian Forster [Tue, 23 Jun 2015 12:26:55 +0000 (14:26 +0200)]
src/Makefile.am: Move tests towards the libraries tested.
Sebastian Pfahl [Mon, 15 Jun 2015 14:07:57 +0000 (14:07 +0000)]
removed separator between prefix and the rest of the key
Ruben Kerkhof [Mon, 22 Jun 2015 19:24:09 +0000 (21:24 +0200)]
Remove unmaintained Fedora contrib files
Florian Forster [Fri, 19 Jun 2015 18:08:24 +0000 (20:08 +0200)]
Merge branch 'collectd-5.5'
Florian Forster [Fri, 19 Jun 2015 18:03:08 +0000 (20:03 +0200)]
barometer plugin: Fix "Allocator sizeof operand mismatch" warning.
Florian Forster [Fri, 19 Jun 2015 17:27:27 +0000 (19:27 +0200)]
write_sensu plugin: Fix debug message.
It still referenced the variables, which have been removed in
1c4008c3216edbc9c7cbeffd1c597c9b32e8f64d.
Florian Forster [Fri, 19 Jun 2015 14:28:01 +0000 (16:28 +0200)]
Merge branch 'collectd-5.5'
Florian Forster [Fri, 19 Jun 2015 14:27:26 +0000 (16:27 +0200)]
write_sensu plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 14:26:53 +0000 (16:26 +0200)]
turbostat plugin: Fix "Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131)" warning.
Florian Forster [Fri, 19 Jun 2015 14:26:12 +0000 (16:26 +0200)]
openvpn plugin: Fix "Dead assignment" warning.
Florian Forster [Fri, 19 Jun 2015 13:11:39 +0000 (15:11 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Florian Forster [Fri, 19 Jun 2015 11:06:34 +0000 (13:06 +0200)]
src/utils_cmd_flush.c: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
src/utils_rrdcreate.c: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
src/utils_ignorelist.c: Fix memory leak.
Turns out, regfree(3) cleans up the memory allocated by regcomp(3), but
not the pointer itself.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
src/utils_cmd_putval.c: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
utils_cache plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
rrdtool plugin: Add assertion.
This helps the static code analysis to figure out that memory is not
leaking after all.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
powerdns plugin: Fix memory leak.
While at it, replace the powerdns_config_add_string() function.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
memcachec plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
java plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
ipvs plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
gmond plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
curl_xml plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
curl_json plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
curl plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
collectdmon: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 08:54:02 +0000 (10:54 +0200)]
apache plugin: Fix memory leak.
Florian Forster [Fri, 19 Jun 2015 05:05:22 +0000 (07:05 +0200)]
src/utils_cache.c: Fix two memory leaks.
* Free "times" pointer if it is not returned to the user.
* Free (re)alloc'ed pointers when strdup() fails.
Florian Forster [Thu, 18 Jun 2015 15:46:03 +0000 (17:46 +0200)]
snmp plugin: Fix "Assigned value is garbage or undefined" warning.
Florian Forster [Thu, 18 Jun 2015 15:45:52 +0000 (17:45 +0200)]
src/utils_latency.c: Fix "Assigned value is garbage or undefined" warning.
Florian Forster [Thu, 18 Jun 2015 15:31:03 +0000 (17:31 +0200)]
threshold plugin: Fix "Dead assignment" warnings.
Florian Forster [Thu, 18 Jun 2015 14:55:53 +0000 (16:55 +0200)]
Merge branch 'collectd-5.5'
Florian Forster [Thu, 18 Jun 2015 14:52:09 +0000 (16:52 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Florian Forster [Thu, 18 Jun 2015 14:45:23 +0000 (16:45 +0200)]
modbus plugin: Make sure variable is initialized.
This was introduced by the merge
(
09c6a320f3cb36b5dbb2c2ce43858f33be7acf9b).
Florian Forster [Thu, 18 Jun 2015 14:09:10 +0000 (16:09 +0200)]
stats plugin: Link with libm (-lm).
Fixes a bug reported by @Tenzer:
symbol lookup error: /usr/lib/collectd/statsd.so: undefined symbol: log
Florian Forster [Thu, 18 Jun 2015 13:31:11 +0000 (15:31 +0200)]
tail plugin: Make sure variable is initialized.
This was introduced by the merge
(
09c6a320f3cb36b5dbb2c2ce43858f33be7acf9b).
Florian Forster [Thu, 18 Jun 2015 13:27:54 +0000 (15:27 +0200)]
Fix "Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131)" warnings.
Florian Forster [Thu, 18 Jun 2015 12:45:02 +0000 (14:45 +0200)]
threshold plugin: Fix "Dead increment" warnings.
Florian Forster [Thu, 18 Jun 2015 11:36:02 +0000 (13:36 +0200)]
Fix "Argument with 'nonnull' attribute passed null" warnings.
Florian Forster [Thu, 18 Jun 2015 11:05:23 +0000 (13:05 +0200)]
Merge branch 'collectd-5.5'
Florian Forster [Thu, 18 Jun 2015 11:05:14 +0000 (13:05 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Florian Forster [Thu, 18 Jun 2015 07:16:18 +0000 (09:16 +0200)]
threshold plugin: Fix "Dead assignment" warning.
Florian Forster [Thu, 18 Jun 2015 07:16:18 +0000 (09:16 +0200)]
ted plugin: Fix "Dead assignment" warning.
Florian Forster [Thu, 18 Jun 2015 07:16:18 +0000 (09:16 +0200)]
tail_csv plugin: Fix "Dead assignment" warning.
Florian Forster [Thu, 18 Jun 2015 08:27:42 +0000 (10:27 +0200)]
tail plugin: Fix "Dead assignment" warning.