Florian Forster [Sun, 27 Nov 2016 13:58:42 +0000 (14:58 +0100)]
src/utils_latency_config.c: Avoid nested compound literals.
So GCC 4.6 doesn't crash.
Florian Forster [Sun, 27 Nov 2016 07:02:39 +0000 (08:02 +0100)]
src/daemon/utils_match.[ch]: Rename UTILS_MATCH_CF_GAUGE_LATENCY to UTILS_MATCH_CF_GAUGE_DIST.
Florian Forster [Sun, 20 Nov 2016 21:53:34 +0000 (22:53 +0100)]
tail plugin: Rename DSType from Latency to Distribution.
This is a more flexible naming owing to the fact that percentiles and other
distribution parameters are interesting for a variety of metrics, not just
latencies.
The config handling is now completely in src/utils_latency_config.c so
that other plugins, such as the cURL plugin, can easily reuse the module
with consistent config handling.
Florian Forster [Wed, 12 Oct 2016 15:25:13 +0000 (17:25 +0200)]
src/utils_latency{,_config}.[ch]: Reformat new code with clang-format.
Florian Forster [Wed, 12 Oct 2016 15:15:10 +0000 (17:15 +0200)]
collectd.conf(5): Update the "LatencyRate" option.
Florian Forster [Wed, 12 Oct 2016 07:15:49 +0000 (09:15 +0200)]
src/utils_latency.[ch]: get_rate(): Make lower bound exclusive.
This has a bunch of benefits:
* You can easily iterate over a range of latencies without counting
latencies twice. This was previously tricky because both borders were
considered to be inclusive.
* When lower equals upper, the returned value is now zero.
Previously, it was a value very close to zero, but not zero. The exact
value depended on the bucket width, an information not easily
available to the caller.
Florian Forster [Tue, 11 Oct 2016 15:27:11 +0000 (17:27 +0200)]
src/utils_latency.[ch]: Remove latency_counter_get_start_time().
Florian Forster [Tue, 11 Oct 2016 15:25:58 +0000 (17:25 +0200)]
src/utils_latency.[ch]: Improve accuracy, update unit test.
Pavel Rochnyack [Mon, 19 Sep 2016 17:32:54 +0000 (23:32 +0600)]
DSType latency: Improved after PR code review
Pavel Rochnyack [Sat, 7 May 2016 17:26:15 +0000 (23:26 +0600)]
+ liblatency: Added utils_latency_config code
+ tail plugin: DSType Latency added
Pavel Rochnyack [Sat, 7 May 2016 16:09:09 +0000 (22:09 +0600)]
+ utils_latency: Cleaned latency_counter_get_rate() from debugging
Pavel Rochnyack [Sat, 7 May 2016 15:55:16 +0000 (21:55 +0600)]
+ utils_latency: Added latency_counter_get_rate()
Pavel Rochnyack [Sat, 7 May 2016 07:01:33 +0000 (13:01 +0600)]
+ User_data destroy callback added to match_create_callback() in utils_match
Florian Forster [Sun, 27 Nov 2016 06:24:55 +0000 (07:24 +0100)]
Merge remote-tracking branch 'github/pr/2058'
Florian Forster [Sat, 26 Nov 2016 18:00:19 +0000 (19:00 +0100)]
amqp, write_graphite and write_kafka plugins: Implement the "[Graphite]PreserveSeparator" option.
Fixes: #419
Florian Forster [Sat, 26 Nov 2016 17:46:36 +0000 (18:46 +0100)]
src/utils_format_graphite.[ch]: Implement the GRAPHITE_PRESERVE_SEPARATOR flag.
brockcj [Sat, 26 Nov 2016 03:32:54 +0000 (21:32 -0600)]
Add config boolean for logical CPU naming for turbostat plugin
Florian Forster [Fri, 25 Nov 2016 19:59:53 +0000 (20:59 +0100)]
Merge remote-tracking branch 'github/pr/2052'
Florian Forster [Fri, 25 Nov 2016 16:27:10 +0000 (17:27 +0100)]
Merge remote-tracking branch 'github/pr/2054'
Florian Forster [Fri, 25 Nov 2016 09:08:49 +0000 (10:08 +0100)]
src/utils_format_graphite.[ch]: Add unit test.
First step towards fixing issue #419.
Denis Silakov [Wed, 23 Nov 2016 15:58:52 +0000 (18:58 +0300)]
Check for virConnectListAllDomains availability before using it - appeared in 0.10.2
Marc Fournier [Wed, 23 Nov 2016 06:00:12 +0000 (07:00 +0100)]
collectd.spec: enable write_prometheus
Matthias Bethke [Tue, 22 Nov 2016 17:36:12 +0000 (00:36 +0700)]
use deterministic time values in MockDaemon
Matthias Bethke [Tue, 22 Nov 2016 16:53:30 +0000 (23:53 +0700)]
recognize seconds with and without fractional part
Matthias Bethke [Tue, 22 Nov 2016 16:37:33 +0000 (23:37 +0700)]
pass fractional seconds upwards as floats
Matthias Bethke [Tue, 22 Nov 2016 16:35:36 +0000 (23:35 +0700)]
allow fractional seconds in listval_filter()
Matthias Bethke [Tue, 22 Nov 2016 16:30:37 +0000 (23:30 +0700)]
update MockDaemon to report fractional seconds
Matthias Bethke [Tue, 22 Nov 2016 16:22:19 +0000 (23:22 +0700)]
fix indentation (consistently use tabs)
Denis Silakov [Tue, 22 Nov 2016 15:17:16 +0000 (18:17 +0300)]
virt plugin: get domains using virConnectListAllDomains
Ruben Kerkhof [Mon, 21 Nov 2016 13:37:53 +0000 (14:37 +0100)]
Merge pull request #2046 from rubenk/cleanup-dpdk-detection
Cleanup dpdk detection
Florian Forster [Mon, 21 Nov 2016 07:33:42 +0000 (08:33 +0100)]
Merge remote-tracking branch 'github/pr/2040'
Ruben Kerkhof [Sat, 19 Nov 2016 10:47:00 +0000 (11:47 +0100)]
Fix Lua header detection
checking lua.h usability... yes
checking lua.h presence... no
configure: WARNING: lua.h: accepted by the compiler, rejected by the
preprocessor!
configure: WARNING: lua.h: proceeding with the compiler's result
checking for lua.h... yes
checking lauxlib.h usability... yes
checking lauxlib.h presence... no
configure: WARNING: lauxlib.h: accepted by the compiler, rejected by the
preprocessor!
configure: WARNING: lauxlib.h: proceeding with the compiler's result
checking for lauxlib.h... yes
checking lualib.h usability... yes
checking lualib.h presence... no
configure: WARNING: lualib.h: accepted by the compiler, rejected by the
preprocessor!
configure: WARNING: lualib.h: proceeding with the compiler's result
checking for lualib.h... yes
AC_CHECK_HEADERS uses the preprocessor directly, which doesn't use
CFLAGS. Fixes detection of the lua-5.1 compat libs on Fedora Rawhide.
Florian Forster [Sat, 19 Nov 2016 13:26:27 +0000 (14:26 +0100)]
src/daemon/plugin.c: Address review comments.
Ruben Kerkhof [Sat, 19 Nov 2016 16:31:23 +0000 (17:31 +0100)]
Rewrite the check for libdpdk
This fixes various issues, like us not picking up the right include path
and testing for the library in the wrong location.
We now allow you to override the CPPFLAGS and LDFLAGS by doing
./configure LIBDPDK_CPPFLAGS="-I/path/to/your/libdpdk_headers" LIBDPDK_LDFLAGS="-L/path/to/your/libdpdk.so -Wl,--no-as-needed"
The nice thing is that these settings are now logged and remembered
between configure runs.
Ruben Kerkhof [Sat, 19 Nov 2016 10:58:36 +0000 (11:58 +0100)]
Enable detection of libdpdk by default
Otherwise we never exercise this check and it will just bitrot.
Taras Chornyi [Sat, 19 Nov 2016 16:02:22 +0000 (17:02 +0100)]
dpdkstat: Added support for dpdk 16.07.
Ruben Kerkhof [Sat, 19 Nov 2016 12:16:57 +0000 (13:16 +0100)]
README: do not point users to non-existing file
Florian Forster [Sat, 19 Nov 2016 07:10:47 +0000 (08:10 +0100)]
configure.ac: Improve detection and usage of pthread_set_name_np(3).
Marc Fournier [Wed, 16 Nov 2016 09:12:10 +0000 (10:12 +0100)]
contrib/README: sort items
Marc Fournier [Wed, 16 Nov 2016 09:10:10 +0000 (10:10 +0100)]
contrib/docker: add instructions to README
Marc Fournier [Wed, 16 Nov 2016 09:00:44 +0000 (10:00 +0100)]
contrib/docker: add minimal example config file
Marc Fournier [Wed, 12 Oct 2016 05:14:20 +0000 (07:14 +0200)]
contrib/docker: add basic Dockerfile & config files
Marc Fournier [Wed, 5 Oct 2016 06:09:09 +0000 (08:09 +0200)]
contrib/docker: add LD_PRELOAD wrapper to fopen/open/opendir syscalls
Marc Fournier [Wed, 16 Nov 2016 06:49:25 +0000 (07:49 +0100)]
mqtt, gps: add name parameter to plugin_thread_create()
Manuel Luis Sanmartín Rozada [Sun, 9 Feb 2014 15:03:03 +0000 (16:03 +0100)]
Explain the need for _GNU_SOURCE
Manuel Luis Sanmartín Rozada [Sat, 8 Feb 2014 22:13:01 +0000 (23:13 +0100)]
Add support to set the thread name.
Florian Forster [Tue, 15 Nov 2016 08:34:57 +0000 (09:34 +0100)]
write_prometheus plugin: Escape label values.
Fixes: #2035
Florian Forster [Fri, 11 Nov 2016 20:24:21 +0000 (21:24 +0100)]
Merge remote-tracking branch 'github/pr/1967'
Florian Forster [Fri, 11 Nov 2016 19:42:36 +0000 (20:42 +0100)]
write_prometheus plugin: Use the "static" macro to specify PROMETHEUS_DEFAULT_STALENESS_DELTA.
Fixes:
write_prometheus.c:56:1: error: initializer element is not constant
static cdtime_t staleness_delta = PROMETHEUS_DEFAULT_STALENESS_DELTA;
^
Florian Forster [Mon, 24 Oct 2016 07:03:32 +0000 (09:03 +0200)]
write_prometheus plugin: Don't allocate metric families in prom_missing().
Marc Fournier [Tue, 1 Nov 2016 10:15:24 +0000 (11:15 +0100)]
write_prometheus: add support for libmicrohttpd 0.9.45+
Add switch on MHD_VERSION to support both legacy and modern MHD functions.
`MHD_create_response_from_data()` is deprecated since libmicrohttpd
0.9.5 and makes the build fail since 0.9.45.
Florian Forster [Sat, 1 Oct 2016 19:22:12 +0000 (21:22 +0200)]
write_prometheus plugin: Improve performance of metric_cmp().
This function is a hotspot because it is used by bsearch() to look up
metrics in a metric family. This simple (though non-obvious) change
brings prom_write() complexity down from 3000 instructions/call to 2640
instructions/call, i.e. a 12% improvement.
Florian Forster [Sat, 1 Oct 2016 08:12:41 +0000 (10:12 +0200)]
write_prometheus plugin: Optimize metric_family_get_metric().
Profiling showed that prom_write() spent 73% of its time in this
function. 36% of time was spent in metric_create() and 19% was spent in
metric_destroy().
This patch replaces these two calls by a stack allocation, reducing the
time prom_write() spends in metric_family_get_metric() to 42%.
Florian Forster [Thu, 29 Sep 2016 19:38:24 +0000 (21:38 +0200)]
write_prometheus plugin: New plugin for exposing metrics to Prometheus.
Florian Forster [Fri, 11 Nov 2016 13:34:20 +0000 (14:34 +0100)]
collectd-tg: Fix sleep interval.
nanosleep() was called with the current time, meaning that it would
block for years. This correctly subtracts "now" from the metric's time
and only sleeps for the duration between the two.
Florian Forster [Mon, 7 Nov 2016 07:52:38 +0000 (08:52 +0100)]
Merge branch 'collectd-5.6'
Florian Forster [Mon, 7 Nov 2016 07:43:17 +0000 (08:43 +0100)]
Merge branch 'collectd-5.5' into collectd-5.6
Florian Forster [Mon, 7 Nov 2016 06:03:17 +0000 (07:03 +0100)]
Merge remote-tracking branch 'github/pr/2026' into collectd-5.5
Florian Forster [Sat, 5 Nov 2016 21:32:49 +0000 (22:32 +0100)]
apcups plugin: Skip metrics not reported by the UPS.
Fixes: #2025
Florian Forster [Sun, 6 Nov 2016 21:17:02 +0000 (22:17 +0100)]
write_kafka plugin: Fix support for librdkafka 0.9.0.
Use rd_kafka_set_logger() only when rd_kafka_conf_set_log_cb() is not
available:
write_kafka.c: In function 'kafka_handle':
write_kafka.c:119:6: error: 'rd_kafka_set_logger' is deprecated (declared at /usr/local/include/librdkafka/rdkafka.h:2400) [-Werror=deprecated-declarations]
rd_kafka_set_logger(ctx->kafka, kafka_log);
^
Fixes: #2029
Florian Forster [Sun, 6 Nov 2016 19:40:36 +0000 (20:40 +0100)]
Merge remote-tracking branch 'github/pr/2027' into collectd-5.5
Florian Forster [Sun, 6 Nov 2016 09:21:35 +0000 (10:21 +0100)]
modbus plugin: Avoid sizeof(struct sockaddr).
The previous version failed on FreeBSD with:
modbus.c: In function 'mb_read_data':
modbus.c:476:21: error: storage size of 'sockaddr' isn't known
struct sockaddr sockaddr;
^
Florian Forster [Sun, 6 Nov 2016 10:10:54 +0000 (11:10 +0100)]
src/write_riemann_threshold.h: Various fixes.
* Add license header. Simply copied src/write_riemann_threadhold.c's license.
* Make header self-contained. "plugin.h" is needed for data_source_t and
value_list_t.
* Add names to the parameters and write documentation for the only exported
function.
Florian Forster [Sun, 6 Nov 2016 09:34:22 +0000 (10:34 +0100)]
write_riemann plugin: Fix order of includes.
The previous version failed on Solaris with:
In file included from ./daemon/collectd.h:31:0,
from write_riemann.c:36:
./config.h:1619:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]
#define _FILE_OFFSET_BITS 64
^
Florian Forster [Wed, 2 Nov 2016 08:36:48 +0000 (09:36 +0100)]
Merge branch 'collectd-5.6'
Florian Forster [Wed, 2 Nov 2016 08:20:57 +0000 (09:20 +0100)]
Merge branch 'collectd-5.5' into collectd-5.6
Florian Forster [Wed, 2 Nov 2016 08:04:00 +0000 (09:04 +0100)]
src/daemon/utils_tail_match.c: Use match_value_reset().
Marc Fournier [Tue, 1 Nov 2016 10:54:26 +0000 (11:54 +0100)]
configure.ac: make finding java deterministic
The sort order of the `find` command proves to be dependent on external
factors, which makes `./configure` pick different java versions on
different systems, making the whole build non-reproducible (see
https://reproducible-builds.org/ for more details).
Adding a call to `sort`, with the locale forced, fixes this issue.
Fixes: #1523
Florian Forster [Tue, 1 Nov 2016 06:58:57 +0000 (07:58 +0100)]
src/daemon/utils_match.c: Add GAUGE_PERSIST logic to default_callback().
Florian Forster [Mon, 31 Oct 2016 15:57:40 +0000 (16:57 +0100)]
src/daemon/utils_match.c: Improve readability of reset logic.
Florian Forster [Mon, 31 Oct 2016 15:53:43 +0000 (16:53 +0100)]
collectd.conf(5): Fix typos.
Florian Forster [Sun, 30 Oct 2016 20:42:49 +0000 (21:42 +0100)]
battery plugin: Fix type in a warning.
Florian Forster [Sun, 30 Oct 2016 20:40:04 +0000 (21:40 +0100)]
tail plugin: Implement the "GaugePersist" type.
Ruben Kerkhof [Sun, 30 Oct 2016 10:58:51 +0000 (11:58 +0100)]
zfs_arc: remove double metric
I accidentally added prefetch_metadata_misses in
61635f3 but we
already had that metric.
Fixes #1963
Florian Forster [Sat, 29 Oct 2016 20:08:32 +0000 (22:08 +0200)]
Merge remote-tracking branch 'github/pr/2012' into collectd-5.6
Pavel Rochnyack [Sat, 29 Oct 2016 12:25:15 +0000 (18:25 +0600)]
openvpn: Fixed openvpn_read() on empty configuration.
When plugin loaded without configuration, it starts to spam logs with message
'read-function of plugin `openvpn' failed'.
Issue: #1932
Florian Forster [Fri, 28 Oct 2016 13:04:11 +0000 (15:04 +0200)]
src/daemon/common.c: Rewrite check_capability() using cap_get_bound().
capget(2) is Linux specific and the use of the raw syscalls is
discouraged. Also, there have been interesting crashes on some systems.
Issue: #2009
Florian Forster [Fri, 28 Oct 2016 11:44:05 +0000 (13:44 +0200)]
Merge branch 'pr/2004'
Florian Forster [Fri, 28 Oct 2016 11:32:27 +0000 (13:32 +0200)]
collectd.conf(5): Improve the "BlockDeviceFormat" and "BlockDeviceFormatBasename" sections.
Florian Forster [Fri, 28 Oct 2016 08:45:23 +0000 (10:45 +0200)]
virt plugin: Fix indentation and some whitespace.
Florian Forster [Fri, 28 Oct 2016 08:44:47 +0000 (10:44 +0200)]
virt plugin: Use the IS_TRUE() macro.
Florian Forster [Fri, 28 Oct 2016 11:43:46 +0000 (13:43 +0200)]
virt plugin: Add comment for <libgen.h> include.
Deyan Chepishev [Fri, 28 Oct 2016 08:31:19 +0000 (11:31 +0300)]
virt.c modifications to bring it in accordance with "octo" comments
Deyan Chepishev [Fri, 28 Oct 2016 06:40:24 +0000 (09:40 +0300)]
plugin virt, collectd.conf.in, collectd.conf.pod eddited to be according to comments from collectd members
Florian Forster [Fri, 28 Oct 2016 05:17:17 +0000 (07:17 +0200)]
write_kafka plugin: Reintroduce the "Key Random" setting.
Fixes: #1977
Florian Forster [Fri, 28 Oct 2016 05:25:26 +0000 (07:25 +0200)]
Merge remote-tracking branch 'github/pr/2006'
Florian Forster [Fri, 28 Oct 2016 05:22:59 +0000 (07:22 +0200)]
Merge remote-tracking branch 'github/pr/2006'
Florian Forster [Thu, 27 Oct 2016 20:13:37 +0000 (22:13 +0200)]
src/daemon/common_test.c: Avoid nesting composite literals.
This crashed GCC 4.6 on Precise.
Florian Forster [Thu, 27 Oct 2016 19:29:43 +0000 (21:29 +0200)]
Merge remote-tracking branch 'github/pr/2001'
Florian Forster [Thu, 27 Oct 2016 19:19:35 +0000 (21:19 +0200)]
curl plugin: Don't use CDTIME_T_TO_DOUBLE() within a composite literal.
GCC 4.6 has a problem with the original code:
curl.c: In function 'cc_submit_response_time':
curl.c:644:26: internal compiler error: Segmentation fault
This is essentially a shot in the dark, trying to fix this issue.
Florian Forster [Wed, 26 Oct 2016 20:48:51 +0000 (22:48 +0200)]
gps plugin: Replace busy loop with pthread_cond_timedwait().
Florian Forster [Wed, 26 Oct 2016 18:59:32 +0000 (20:59 +0200)]
Various: Simplify code using composite literals.
Ruben Kerkhof [Wed, 26 Oct 2016 17:33:44 +0000 (19:33 +0200)]
Merge branch 'collectd-5.6'
Ruben Kerkhof [Wed, 26 Oct 2016 17:31:01 +0000 (19:31 +0200)]
Merge pull request #2005 from rpv-tomsk/issue-1996
write_http: Fixed DS type check
Pavel Rochnyack [Wed, 26 Oct 2016 17:27:36 +0000 (23:27 +0600)]
write_http: Fixed DS type check
Closes: #1996
Deyan Chepishev [Wed, 26 Oct 2016 15:16:29 +0000 (18:16 +0300)]
fixed typo in the Man
Deyan Chepishev [Wed, 26 Oct 2016 15:10:47 +0000 (18:10 +0300)]
Modified plugin virt.c
Added options:
BlockDeviceFormat
BlockDeviceFormatBasename
Florian Forster [Wed, 26 Oct 2016 15:09:17 +0000 (17:09 +0200)]
src/daemon/utils_time.h: Use composite literals in all macros.
This allows to take the address of all these macros. Unfortunately, this
means we require special macors for initializing static variables, but
fortunately this is not very commonly done.
Florian Forster [Wed, 26 Oct 2016 14:46:29 +0000 (16:46 +0200)]
src/daemon/utils_time.h: Return structs from CDTIME_T_TO_TIME{VAL,SPEC}.
Since these are macros use composite literals, you can even take the
address of these struct, which is very handy for calling nanosleep()
and friends.
Florian Forster [Wed, 26 Oct 2016 07:31:47 +0000 (09:31 +0200)]
src/daemon/utils_cache.c: Refactor uc_check_timeout().