collectd.git
16 years agoUpdated the TODO file.
Florian Forster [Thu, 16 Oct 2008 19:22:20 +0000 (21:22 +0200)]
Updated the TODO file.

16 years agosrc/plugin.[ch]: Added support for "filter" callbacks.
Sebastian Harl [Wed, 15 Oct 2008 07:28:15 +0000 (09:28 +0200)]
src/plugin.[ch]: Added support for "filter" callbacks.

This type of callback is very similar to write callbacks:

  int (*) (const data_set_t *, value_list_t *)

The return value of that callback indicates what further actions are to be
taken. It may be a bitwise OR of any of the following new flags:
FILTER_NOWRITE or FILTER_NOTHRESHOLD_CHECK. If both flags are used (which
equals the flag FILTER_IGNORE), the value list is ignored completely.

If more than one such callback is available, the respective return values are
bitwise OR'ed. If they "sum" up to FILTER_IGNORE, no further callbacks are
executed (lazy evaluation).

This type of callback may be used for the following purposes:

 * rewrite information included in the value list (e.g. the instance
   name)

 * discard certain information on a fine-grained level based on the
   information provided by the data set and value list

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.5'
Florian Forster [Fri, 10 Oct 2008 07:02:33 +0000 (09:02 +0200)]
Merge branch 'collectd-4.5'

Conflicts:

configure.in

16 years agoMerge branch 'collectd-4.4' into collectd-4.5
Florian Forster [Fri, 10 Oct 2008 07:01:54 +0000 (09:01 +0200)]
Merge branch 'collectd-4.4' into collectd-4.5

16 years agosrc/utils_cache.c: Fix a serious memory leak.
Florian Forster [Fri, 10 Oct 2008 06:17:22 +0000 (08:17 +0200)]
src/utils_cache.c: Fix a serious memory leak.

Whenever a data set went missing, the its name (the `key'; up to (5*64)+4
bytes) was not free'd.

Thanks to Niraj Tolia for reporting this :)

16 years agosrc/configfile.c: Fix a minor memory leak.
Florian Forster [Thu, 9 Oct 2008 06:43:48 +0000 (08:43 +0200)]
src/configfile.c: Fix a minor memory leak.

Thanks to Niraj Tolia for reporting this :)

16 years agonetwork plugin: Fix a minor memory leak.
Florian Forster [Thu, 9 Oct 2008 06:43:20 +0000 (08:43 +0200)]
network plugin: Fix a minor memory leak.

Thanks to Niraj Tolia for reporting this :)

16 years agosrc/collectd.conf.in: Add a configuration stump for the dbi plugin.
Florian Forster [Tue, 7 Oct 2008 14:41:07 +0000 (16:41 +0200)]
src/collectd.conf.in: Add a configuration stump for the dbi plugin.

16 years agoperl plugin: Fix a compiler warning.
Florian Forster [Tue, 7 Oct 2008 07:42:27 +0000 (09:42 +0200)]
perl plugin: Fix a compiler warning.

With unknown config options the `current_status' variable would have
been accessed uninitialized.

16 years agoMerge branch 'master' of git://git.verplant.org/collectd
Florian Forster [Tue, 7 Oct 2008 07:29:04 +0000 (09:29 +0200)]
Merge branch 'master' of git://git.verplant.org/collectd

16 years agoAdded .mailmap.
Sebastian Harl [Fri, 22 Aug 2008 12:31:51 +0000 (14:31 +0200)]
Added .mailmap.

This file is used by e.g. git-shortlog to map author E-mail addresses to real
author names. The file currently includes mappings for the old SVN logins as
well as a few cases where people where using different E-mail addresses.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Added cURL website to the prerequisites section.
Sebastian Harl [Mon, 6 Oct 2008 16:33:59 +0000 (18:33 +0200)]
README: Added cURL website to the prerequisites section.

The site is working now and I could verify that it's correct ;-)

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosnmp plugin: Added folding marker for the configuration handling.
Florian Forster [Tue, 7 Oct 2008 07:23:07 +0000 (09:23 +0200)]
snmp plugin: Added folding marker for the configuration handling.

16 years agocollectd-nagios(1): Make the documentation easier to read, more correct and fix errors.
Florian Forster [Mon, 6 Oct 2008 21:53:37 +0000 (23:53 +0200)]
collectd-nagios(1): Make the documentation easier to read, more correct and fix errors.

16 years agoREADME: Added websites for all prerequisites.
Sebastian Harl [Sun, 5 Oct 2008 13:07:40 +0000 (15:07 +0200)]
README: Added websites for all prerequisites.

I did not include the curl website (http://curl.haxx.se/) so far - the site
was not available when testing it.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigure.in: Correct the `--enable-<plugin>' code.
Florian Forster [Mon, 6 Oct 2008 13:35:42 +0000 (15:35 +0200)]
configure.in: Correct the `--enable-<plugin>' code.

The new behavior is documented in the `README' file, too.

16 years agoconfigure.in: Let configure bail out on missing dependencies
Bruno Prémont [Sun, 5 Oct 2008 12:09:08 +0000 (14:09 +0200)]
configure.in: Let configure bail out on missing dependencies

The patch below adds check in AC_PLUGIN() that verifies if the
dependencies are met for any enabled plugin.

In case some dependency is missing (default is disabled and enabled
is selected) configure will fail after dumping summary so all
dependency issues are visible in a single configure pass.

A later addition would be to list requirements (dependencies, OS/Kernel
restrictions) for all plugins in an easily accessible location (e.g.
INSTALL file)

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/collectd-nagios.c: Improve handling of lines returned from `GETVAL'.
Florian Forster [Mon, 6 Oct 2008 09:46:59 +0000 (11:46 +0200)]
src/collectd-nagios.c: Improve handling of lines returned from `GETVAL'.

Then selecting only certain data sources with the `-d' option, the program
would try to read more lines from the server than the server reports, resulting
in the communication never finishing.

This patch resolves that problem and introduces a couple other error handling
blocks.

Thanks to Fabian Linzberger for pointing this out.

16 years agonetlink plugin: Fix an incorrect format string.
Florian Forster [Sun, 5 Oct 2008 10:12:52 +0000 (12:12 +0200)]
netlink plugin: Fix an incorrect format string.

16 years agocollectd.conf(5): Add documentation about the dbi plugin.
Florian Forster [Sat, 4 Oct 2008 20:13:35 +0000 (22:13 +0200)]
collectd.conf(5): Add documentation about the dbi plugin.

16 years agoREADME: Add the dbi plugin and the libdbi dependency.
Florian Forster [Sat, 4 Oct 2008 20:13:22 +0000 (22:13 +0200)]
README: Add the dbi plugin and the libdbi dependency.

16 years agodbi plugin: Add a plugin to query databases.
Florian Forster [Sat, 4 Oct 2008 15:11:02 +0000 (17:11 +0200)]
dbi plugin: Add a plugin to query databases.

The plugin uses the `dbi' library which provides a database independent
interface. It has only been tested with MySQL so far, so ymmv.

The configuration is similar to the PostgreSQL plugin: You define
queries and databases which execute those queries every $interval
seconds.

16 years agoconfigure.in: Ordered the `--with-*' arguments.
Florian Forster [Sat, 4 Oct 2008 09:21:07 +0000 (11:21 +0200)]
configure.in: Ordered the `--with-*' arguments.

16 years agoconfigure.in: Unify the --with-* arguments.
Florian Forster [Sat, 4 Oct 2008 09:13:31 +0000 (11:13 +0200)]
configure.in: Unify the --with-* arguments.

Renamed `--with-rrdtool' to `--with-librrd' and `--with-lm-sensors' to
`--with-libsensors'.

16 years agoconfigure.in: Insert folding markers.
Florian Forster [Sat, 4 Oct 2008 08:59:30 +0000 (10:59 +0200)]
configure.in: Insert folding markers.

This hopefully makes the file a little easier to read..

16 years agoMerge branch 'collectd-4.5'
Florian Forster [Fri, 3 Oct 2008 21:18:28 +0000 (23:18 +0200)]
Merge branch 'collectd-4.5'

16 years agoMerge branch 'collectd-4.4' into collectd-4.5
Florian Forster [Fri, 3 Oct 2008 21:14:44 +0000 (23:14 +0200)]
Merge branch 'collectd-4.4' into collectd-4.5

Conflicts:

src/utils_ignorelist.c

16 years agosrc/utils_ignorelist.c: Fix an off-by-one errror when adding regular expressions.
Florian Forster [Fri, 3 Oct 2008 21:11:47 +0000 (23:11 +0200)]
src/utils_ignorelist.c: Fix an off-by-one errror when adding regular expressions.

Resolves: #20

16 years agocollectdmon: Do not block SIGCHLD.
Sebastian Harl [Thu, 2 Oct 2008 13:25:10 +0000 (15:25 +0200)]
collectdmon: Do not block SIGCHLD.

There is no reason to do so as we do not need to synchronize any waitpid()
calls. In fact, doing so was wrong because waitpid() should then return with
an error according to POSIX. This was still working so far since waitpid()
would not return until all children terminated and this is all we really care
about.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd.conf(5): Briefly document "OKAY"-notifications.
Sebastian Harl [Thu, 2 Oct 2008 13:05:51 +0000 (15:05 +0200)]
collectd.conf(5): Briefly document "OKAY"-notifications.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Added missing plugins.
Sebastian Harl [Thu, 2 Oct 2008 13:08:09 +0000 (15:08 +0200)]
README: Added missing plugins.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Updated information about librrd and libstatgrab.
Sebastian Harl [Thu, 2 Oct 2008 13:07:20 +0000 (15:07 +0200)]
README: Updated information about librrd and libstatgrab.

The info about librrd still talked about "client mode" while libstatgrab still
mentioned that CPU and disk statistics would not be supported.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Mention the shipped copy of libiptc.
Sebastian Harl [Thu, 2 Oct 2008 13:04:44 +0000 (15:04 +0200)]
README: Mention the shipped copy of libiptc.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agolibiptc: Included a copy of xtables.h and libxtc.h.
Sebastian Harl [Thu, 2 Oct 2008 13:02:18 +0000 (15:02 +0200)]
libiptc: Included a copy of xtables.h and libxtc.h.

The shipped copy of "xtables.h" is now used instead of the one possibly
available on the system. This avoids possible inconsistencies between the
shipped version of libiptc and the one available on the system. Also, it
removes the dependency on the iptables development files.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoAdded src/libiptc/README.collectd.
Sebastian Harl [Thu, 2 Oct 2008 12:58:45 +0000 (14:58 +0200)]
Added src/libiptc/README.collectd.

This file is used to explain why libiptc is included in collectd, which
iptables version it's taken from and what changes have been applied.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agolibiptc: Updated from version 1.4.0 to 1.4.1.1.
Sebastian Harl [Thu, 2 Oct 2008 12:56:12 +0000 (14:56 +0200)]
libiptc: Updated from version 1.4.0 to 1.4.1.1.

This brings the library in sync with the latest stable upstream release. Now,
libiptc.c:standard_target_map() is declared static in the upstream sources, so
we no longer need to modify that ourselves.

The update includes, amongst others, fixes for a build failure with glibc 2.8,
some compiler warnings, an incorrect ruleset dump (netfilter issue #104) and a
scalability issue for chain list "name" searching.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoipvs plugin: Use sizeof() instead of a constant.
Sebastian Harl [Thu, 2 Oct 2008 12:54:06 +0000 (14:54 +0200)]
ipvs plugin: Use sizeof() instead of a constant.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoiptables plugin, utils_ignorelist: Fixed an off-by-one error each.
Sebastian Harl [Thu, 2 Oct 2008 12:53:06 +0000 (14:53 +0200)]
iptables plugin, utils_ignorelist: Fixed an off-by-one error each.

Those were introduced when unifying the string handling in commit 5f9ec13b in
cases where the exact length of the string to be copied is passed to sstrncpy
instead of the size of the destination buffer.

In case of the iptables plugin this prevented the table or chain name to match
correctly as the user configuration was truncated. In case of the ignorelist a
given regex was truncated.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.5'
Florian Forster [Fri, 3 Oct 2008 11:35:56 +0000 (13:35 +0200)]
Merge branch 'collectd-4.5'

16 years agoMerge branch 'collectd-4.4' into collectd-4.5
Florian Forster [Fri, 3 Oct 2008 11:35:45 +0000 (13:35 +0200)]
Merge branch 'collectd-4.4' into collectd-4.5

16 years agobuild.sh: Check for more (all?) programs needed.
Florian Forster [Fri, 3 Oct 2008 11:30:58 +0000 (13:30 +0200)]
build.sh: Check for more (all?) programs needed.

16 years agocollection.cgi: Added support for the memcached-specific types.
Sebastian Harl [Sat, 20 Sep 2008 14:34:39 +0000 (16:34 +0200)]
collection.cgi: Added support for the memcached-specific types.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Disable plugin after fatal configuration errors.
Sebastian Harl [Tue, 16 Sep 2008 13:40:14 +0000 (15:40 +0200)]
perl plugin: Disable plugin after fatal configuration errors.

Currently, the only such case is the failure to bootstrap the Perl interpreter
and Collectd module. This fixes a segfault that happened when trying to
configure Perl plugins in that case.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/plugin.c: Increase the plugin_log() message buffer to 1024 bytes.
Sebastian Harl [Tue, 16 Sep 2008 13:38:48 +0000 (15:38 +0200)]
src/plugin.c: Increase the plugin_log() message buffer to 1024 bytes.

512 bytes is not enough for some perl error messages.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Log the perl error messages if bootstrapping Collectd failed.
Sebastian Harl [Tue, 16 Sep 2008 13:36:18 +0000 (15:36 +0200)]
perl plugin: Log the perl error messages if bootstrapping Collectd failed.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosnmp plugin: Use the complaint mechanism for reporting connection errors.
Florian Forster [Mon, 29 Sep 2008 12:57:38 +0000 (14:57 +0200)]
snmp plugin: Use the complaint mechanism for reporting connection errors.

In big setups these messages flood the logfile and make it unreadable.

Signed-off-by: Florian Forster <octo@noris.net>
16 years agosrc/utils_complain.h: Rename `C_COMPLAIN_INIT' to `C_COMPLAIN_INIT_STATIC'.
Florian Forster [Mon, 29 Sep 2008 12:56:43 +0000 (14:56 +0200)]
src/utils_complain.h: Rename `C_COMPLAIN_INIT' to `C_COMPLAIN_INIT_STATIC'.

Because it can only be used when initializing during declaration. A macro
for initializing a struct by pointer as been added with the previous name,
i. e. `C_COMPLAIN_INIT(c)'.

Signed-off-by: Florian Forster <octo@noris.net>
16 years agocontrib/collection3: Added graphs for `apache_{bytes,requests}'.
Florian Forster [Mon, 22 Sep 2008 12:00:31 +0000 (14:00 +0200)]
contrib/collection3: Added graphs for `apache_{bytes,requests}'.

16 years agocontrib/collection3: Use `instance' rather than `plugin_instance'
Florian Forster [Mon, 22 Sep 2008 12:00:02 +0000 (14:00 +0200)]
contrib/collection3: Use `instance' rather than `plugin_instance'

for all the `disk_*' graphs.

16 years agosnmp plugin: Improve parsing of strings to values.
Florian Forster [Mon, 22 Sep 2008 11:57:29 +0000 (13:57 +0200)]
snmp plugin: Improve parsing of strings to values.

The ``strings'' returned by the Net-SNMP library may not be null
terminated. What the fuck were those guys thinking? At least there's a
`val_len' member in `struct variable_list' we can use to determine the
amount of bytes we need to copy.

16 years agointerface plugin: Use src/utils_ignorelist.[ch].
Florian Forster [Wed, 17 Sep 2008 12:19:10 +0000 (14:19 +0200)]
interface plugin: Use src/utils_ignorelist.[ch].

The interface plugin was still using the (very first) implementation of
that ignore functionality - without the regex support :/

16 years agocollection3/etc/collection.conf: Added some mysql stuff.
Florian Forster [Wed, 17 Sep 2008 11:42:59 +0000 (13:42 +0200)]
collection3/etc/collection.conf: Added some mysql stuff.

16 years agorrdcached plugin: Add the four new statistics that were added to RRDCacheD.
Florian Forster [Sun, 14 Sep 2008 14:25:37 +0000 (16:25 +0200)]
rrdcached plugin: Add the four new statistics that were added to RRDCacheD.

16 years agoMerge branch 'master' into ff/rrdcached
Florian Forster [Sun, 14 Sep 2008 14:25:08 +0000 (16:25 +0200)]
Merge branch 'master' into ff/rrdcached

Conflicts:

src/rrdtool.c

16 years agoAUTHORS: Fixed typo.
Florian Forster [Sat, 13 Sep 2008 15:52:54 +0000 (17:52 +0200)]
AUTHORS: Fixed typo.

16 years agocollectd.conf(5): Fixed typo.
Florian Forster [Sat, 13 Sep 2008 15:32:03 +0000 (17:32 +0200)]
collectd.conf(5): Fixed typo.

16 years agocollectd.conf(5): Changed the default socket paths of the powerdns plugin.
Florian Forster [Fri, 12 Sep 2008 14:27:35 +0000 (16:27 +0200)]
collectd.conf(5): Changed the default socket paths of the powerdns plugin.

16 years agopowerdns plugin: Use `LOCALSTATEDIR' instead of "/var".
Boian Berberov [Fri, 12 Sep 2008 14:20:10 +0000 (16:20 +0200)]
powerdns plugin: Use `LOCALSTATEDIR' instead of "/var".

I was working on updating Gentoo's ebuild and I noticed that localstatedir was
not used in certain places.  Please review these patches and consider them.

Boian Berberov

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigure: Allow `--with-libperl=/path/to/binary', too. collectd-4.5.0
Florian Forster [Fri, 5 Sep 2008 08:50:16 +0000 (10:50 +0200)]
configure: Allow `--with-libperl=/path/to/binary', too.

That way one can specify an alternative path, without setting the global
`CFLAGS' and `LDFLAGS' variables.

16 years agoconfigure: Get the check for libperl in sync with the way it's used.
Sebastian Harl [Thu, 4 Sep 2008 13:55:30 +0000 (15:55 +0200)]
configure: Get the check for libperl in sync with the way it's used.

 * Define PERL_NO_GET_CONTEXT.
 * Use the API functions without the Perl_ prefix.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.4'
Florian Forster [Thu, 4 Sep 2008 13:01:23 +0000 (15:01 +0200)]
Merge branch 'collectd-4.4'

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Thu, 4 Sep 2008 13:01:06 +0000 (15:01 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agoprocesses plugin: Fix a format string. collectd-4.3
Florian Forster [Thu, 4 Sep 2008 13:00:40 +0000 (15:00 +0200)]
processes plugin: Fix a format string.

16 years agoapple_sensors plugin: Add a missing semicolon.
Florian Forster [Thu, 4 Sep 2008 12:58:57 +0000 (14:58 +0200)]
apple_sensors plugin: Add a missing semicolon.

16 years agoBumped version to 4.5.0.
Florian Forster [Thu, 4 Sep 2008 08:52:34 +0000 (10:52 +0200)]
Bumped version to 4.5.0.

16 years agoMerge branch 'collectd-4.4'
Florian Forster [Thu, 4 Sep 2008 08:49:13 +0000 (10:49 +0200)]
Merge branch 'collectd-4.4'

Conflicts:

ChangeLog

16 years agoChangeLog: Added an entry about the ability to configure Perl plugins.
Sebastian Harl [Tue, 2 Sep 2008 11:03:08 +0000 (13:03 +0200)]
ChangeLog: Added an entry about the ability to configure Perl plugins.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoChangeLog: Be slightly more specific about the features of the PostgreSQL plugin.
Sebastian Harl [Tue, 2 Sep 2008 11:02:30 +0000 (13:02 +0200)]
ChangeLog: Be slightly more specific about the features of the PostgreSQL plugin.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoBumped version to 4.4.3; Updated ChangeLog. collectd-4.4.3
Florian Forster [Mon, 1 Sep 2008 11:37:27 +0000 (13:37 +0200)]
Bumped version to 4.4.3; Updated ChangeLog.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Mon, 1 Sep 2008 06:04:10 +0000 (08:04 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

Conflicts:

ChangeLog
version-gen.sh

16 years agoChangeLog: Entry for 4.3.4: Bring plugins in alphabetical order.
Florian Forster [Mon, 1 Sep 2008 06:01:33 +0000 (08:01 +0200)]
ChangeLog: Entry for 4.3.4: Bring plugins in alphabetical order.

16 years agoBumped version to 4.3.3; Updated ChangeLog. collectd-4.3.4
Florian Forster [Sun, 31 Aug 2008 13:11:15 +0000 (15:11 +0200)]
Bumped version to 4.3.3; Updated ChangeLog.

16 years agofilecount plugin: s/\<strncpy\>/sstrncpy/g
Alessandro Iurlano [Thu, 28 Aug 2008 19:16:17 +0000 (21:16 +0200)]
filecount plugin: s/\<strncpy\>/sstrncpy/g

16 years agoCollectd::Unixsock: Update `putnotif', fix a bug in `getval', better debug output.
Florian Forster [Wed, 27 Aug 2008 15:46:05 +0000 (17:46 +0200)]
Collectd::Unixsock: Update `putnotif', fix a bug in `getval', better debug output.

The `putnotif' method now handles identifiers and options with spaces
correctly. The `getval' plugin now reads the returned data line wise,
which is the right thing to do anyway. The new `_debug' function prints
debugging output if the (module)global $Debug variable is set.

16 years agounixsock plugin: Improve two debug messages.
Florian Forster [Wed, 27 Aug 2008 15:42:43 +0000 (17:42 +0200)]
unixsock plugin: Improve two debug messages.

16 years agocollectd-{exec,unixsock}(5): Documented how to pass identifiers with spaces.
Florian Forster [Wed, 27 Aug 2008 15:42:26 +0000 (17:42 +0200)]
collectd-{exec,unixsock}(5): Documented how to pass identifiers with spaces.

16 years agosrc/utils_cmd_putnotif.[ch]: Change parsing to allow quoted strings.
Florian Forster [Wed, 27 Aug 2008 15:41:46 +0000 (17:41 +0200)]
src/utils_cmd_putnotif.[ch]: Change parsing to allow quoted strings.

This completes all the commands, now quoted strings should be accepted
anywhere.

16 years agosrc/utils_parse_option.c: Null-terminate parsed quoted strings.
Florian Forster [Wed, 27 Aug 2008 15:38:40 +0000 (17:38 +0200)]
src/utils_parse_option.c: Null-terminate parsed quoted strings.

16 years agosrc/Makefile.am: Link the exec plugin with utils_parse_option.
Florian Forster [Wed, 27 Aug 2008 14:00:01 +0000 (16:00 +0200)]
src/Makefile.am: Link the exec plugin with utils_parse_option.

16 years agosrc/utils_cmd_listval.[ch]: Use the new parsing mechanism here, too.
Florian Forster [Wed, 27 Aug 2008 13:59:22 +0000 (15:59 +0200)]
src/utils_cmd_listval.[ch]: Use the new parsing mechanism here, too.

16 years agosrc/utils_cmd_putval.[ch]: Allow identifiers to include spaces.
Florian Forster [Wed, 27 Aug 2008 13:49:09 +0000 (15:49 +0200)]
src/utils_cmd_putval.[ch]: Allow identifiers to include spaces.

16 years agosnmp plugin: Fix an off by one error.
Florian Forster [Wed, 27 Aug 2008 10:08:33 +0000 (12:08 +0200)]
snmp plugin: Fix an off by one error.

The last character of an table instance was truncated. Fortunately empty
strings were caught, so that uninitialized memory was never accessed.

This patch also reverts f782b378: If returning with an error when a string
is empty causes the entire read to fail.

16 years agosrc/utils_cmd_getval.[ch]: Fix handling of identifiers with spaces.
Florian Forster [Wed, 27 Aug 2008 09:59:53 +0000 (11:59 +0200)]
src/utils_cmd_getval.[ch]: Fix handling of identifiers with spaces.

The getval handler now uses the `parse_string' function in
`utils_parse_option' to handle quoted strings correctly.

16 years agosrc/utils_parse_option.[ch]: Add `parse_string'.
Florian Forster [Wed, 27 Aug 2008 09:58:09 +0000 (11:58 +0200)]
src/utils_parse_option.[ch]: Add `parse_string'.

This function can be used by the command handlers to parse simple string
arguments. It's used by `parse_option', too, to avoid redundand code.

Signed-off-by: Florian Forster <octo@noris.net>
16 years agosrc/collectd.conf.in: Add the filecount plugin.
Florian Forster [Wed, 27 Aug 2008 08:50:44 +0000 (10:50 +0200)]
src/collectd.conf.in: Add the filecount plugin.

16 years agoMerge branch 'collectd-4.4'
Florian Forster [Wed, 27 Aug 2008 08:13:24 +0000 (10:13 +0200)]
Merge branch 'collectd-4.4'

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Wed, 27 Aug 2008 08:12:55 +0000 (10:12 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agocollectd.conf(5): onewire plugin: Added a note about working chips.
Florian Forster [Wed, 27 Aug 2008 08:11:23 +0000 (10:11 +0200)]
collectd.conf(5): onewire plugin: Added a note about working chips.

16 years agocollectd.conf(5): onewire plugin: Mark the `Device' option as required.
Florian Forster [Wed, 27 Aug 2008 08:05:37 +0000 (10:05 +0200)]
collectd.conf(5): onewire plugin: Mark the `Device' option as required.

16 years agoonewire plugin: Remove the "Alias" config option.
Florian Forster [Wed, 27 Aug 2008 08:05:02 +0000 (10:05 +0200)]
onewire plugin: Remove the "Alias" config option.

It's not implemented and not documented and it's easy enough to add back
in when somebody cares to implement it.

16 years agoonewire plugin: Imported the code for DS2409 hubs.
Florian Forster [Wed, 27 Aug 2008 08:04:19 +0000 (10:04 +0200)]
onewire plugin: Imported the code for DS2409 hubs.

16 years agocollectd.conf(5), README: Added a note that the onewire plugin is experimental.
Florian Forster [Wed, 27 Aug 2008 06:55:49 +0000 (08:55 +0200)]
collectd.conf(5), README: Added a note that the onewire plugin is experimental.

16 years agoChangeLog: Added the onewire plugin.
Florian Forster [Wed, 27 Aug 2008 06:55:19 +0000 (08:55 +0200)]
ChangeLog: Added the onewire plugin.

It's marked as experimental.

16 years agopostgresql plugin: Check for and report query redefinitions.
Sebastian Harl [Tue, 26 Aug 2008 14:16:55 +0000 (16:16 +0200)]
postgresql plugin: Check for and report query redefinitions.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agopostgresql plugin: Check for and report MinPGVersion > MaxPGVersion.
Sebastian Harl [Tue, 26 Aug 2008 14:15:37 +0000 (16:15 +0200)]
postgresql plugin: Check for and report MinPGVersion > MaxPGVersion.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agopostgresql plugin: Disable queries that do not include an SQL query string.
Sebastian Harl [Tue, 26 Aug 2008 14:14:36 +0000 (16:14 +0200)]
postgresql plugin: Disable queries that do not include an SQL query string.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd.conf(5): Documented the postgresql {Min,Max}PGVersion options.
Sebastian Harl [Tue, 26 Aug 2008 14:12:01 +0000 (16:12 +0200)]
collectd.conf(5): Documented the postgresql {Min,Max}PGVersion options.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agopostgresql_default.conf: Split "queries" query into two versions.
Sebastian Harl [Tue, 26 Aug 2008 14:11:26 +0000 (16:11 +0200)]
postgresql_default.conf: Split "queries" query into two versions.

The "n_tup_hot_upd" column has been added in 8.3. The two versions of the
"queries" query now take that into account by defining different SQL queries
for versions up to 8.2.99 and versions starting with 8.3.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agopostgresql_default.conf: Limit query "table_states" to versions >= 8.3.
Sebastian Harl [Tue, 26 Aug 2008 14:10:20 +0000 (16:10 +0200)]
postgresql_default.conf: Limit query "table_states" to versions >= 8.3.

The "n_live_tup" and "n_dead_tup" columns of the pg_stat_tables view were not
available before that version.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agopostgresql plugin: Added {Min,Max}PGVersion configuration options.
Sebastian Harl [Tue, 26 Aug 2008 14:09:27 +0000 (16:09 +0200)]
postgresql plugin: Added {Min,Max}PGVersion configuration options.

Those options may be used to specify the minimum and maximum version of
PostgreSQL which is required for some query. This may be used to automatically
configure the plugin for a heterogeneous environment while using the same
configuration file on all hosts.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>