Deyan Chepishev [Fri, 28 Oct 2016 08:31:19 +0000 (11:31 +0300)]
virt.c modifications to bring it in accordance with "octo" comments
Deyan Chepishev [Fri, 28 Oct 2016 06:40:24 +0000 (09:40 +0300)]
plugin virt, collectd.conf.in, collectd.conf.pod eddited to be according to comments from collectd members
Deyan Chepishev [Wed, 26 Oct 2016 15:16:29 +0000 (18:16 +0300)]
fixed typo in the Man
Deyan Chepishev [Wed, 26 Oct 2016 15:10:47 +0000 (18:10 +0300)]
Modified plugin virt.c
Added options:
BlockDeviceFormat
BlockDeviceFormatBasename
Ruben Kerkhof [Mon, 24 Oct 2016 15:36:22 +0000 (17:36 +0200)]
Merge pull request #1997 from rpv-tomsk/issue-1995
powerdns plugin: Improved error reporting
Pavel Rochnyack [Thu, 20 Oct 2016 14:24:14 +0000 (20:24 +0600)]
powerdns plugin: Improved error reporting
Show socket path in log messages.
Closes: #1995
Florian Forster [Fri, 14 Oct 2016 20:51:04 +0000 (22:51 +0200)]
Merge remote-tracking branch 'github/pr/1749'
Florian Forster [Wed, 12 Oct 2016 14:57:19 +0000 (16:57 +0200)]
Merge branch 'pr/1609'
Florian Forster [Wed, 12 Oct 2016 14:56:58 +0000 (16:56 +0200)]
nginx plugin: Add comment, fix indentation.
Add a comment reminding us to remove the "handled" metric in a later
major release. Also fixes mixes tab/space indenting.
Florian Forster [Tue, 11 Oct 2016 06:49:29 +0000 (08:49 +0200)]
Merge remote-tracking branch 'github/pr/1981'
Florian Forster [Tue, 11 Oct 2016 06:36:15 +0000 (08:36 +0200)]
Merge remote-tracking branch 'github/pr/1980'
Marc Fournier [Mon, 10 Oct 2016 19:04:20 +0000 (21:04 +0200)]
bind: fix 2 typos spotted by Debian's lintian tool
authorative -> authoritative
dupliate -> duplicate
Despite this mistake is also found in the collectd-5.5 and 5.6 lines,
the fix is scheduled for 5.7.0 because it will change 2 VL's
type_instances, possibly breaking users' dashboards or alerting.
Marc Fournier [Mon, 10 Oct 2016 19:04:03 +0000 (21:04 +0200)]
Merge branch 'collectd-5.6'
Marc Fournier [Mon, 10 Oct 2016 18:58:19 +0000 (20:58 +0200)]
Merge branch 'collectd-5.5' into collectd-5.6
Marc Fournier [Mon, 10 Oct 2016 18:50:00 +0000 (20:50 +0200)]
fix one typo spotted by Debian's lintian tool
Marc Fournier [Mon, 10 Oct 2016 18:55:56 +0000 (20:55 +0200)]
fix a couple of typos spotted by Debian's lintian tool
Marc Fournier [Mon, 10 Oct 2016 18:47:30 +0000 (20:47 +0200)]
collectd.spec: increment changelog to mention 5.6.1
Marc Fournier [Mon, 10 Oct 2016 18:44:03 +0000 (20:44 +0200)]
collectd.spec: add new intel_rdt plugin
Pavel Rochnyack [Mon, 10 Oct 2016 04:33:28 +0000 (10:33 +0600)]
processes plugin: Do not gather processes IO and context switch data when unneeded
Victor Demonchy [Mon, 10 Oct 2016 13:28:22 +0000 (15:28 +0200)]
Bump version number in redhat spec
Pavel Rochnyack [Mon, 10 Oct 2016 07:25:07 +0000 (13:25 +0600)]
processes plugin: Fix counters initialization / spikes
processes plugin generates spikes on (re)start. That is caused by
wrong counter logic: When collectd (re)started, monitored processes,
which was started before collectd, have non-zero values in
cpu_user/cpu_system/vmem_minflt/vmem_majflt, so `want_init` is false.
What produces spike.
At other hand, processes which are started between read cycles, should
be fully accounted without initialization. So, we must skip only first
cycle for these counters.
Pavel Rochnyack [Mon, 10 Oct 2016 07:07:55 +0000 (13:07 +0600)]
processes plugin: Remove unused fields from structures
Fields cpu_user, cpu_system, vmem_minflt, vmem_majflt are always equal to zero for new entries (which are passed to ps_list_add()).
Values of these fields are not used in `procstat_t` entries too. So, that can be safely removed.
Pavel Rochnyack [Wed, 9 Mar 2016 10:39:22 +0000 (16:39 +0600)]
nginx plugin: Report failed connections
Florian Forster [Sat, 8 Oct 2016 05:48:15 +0000 (07:48 +0200)]
Merge remote-tracking branch 'github/pr/1958' into collectd-5.5
Florian Forster [Fri, 7 Oct 2016 13:52:00 +0000 (15:52 +0200)]
Bump version to 5.6.1; Update ChangeLog.
Florian Forster [Fri, 7 Oct 2016 06:51:29 +0000 (08:51 +0200)]
Merge branch 'collectd-5.5' into collectd-5.6
Florian Forster [Fri, 7 Oct 2016 06:44:53 +0000 (08:44 +0200)]
Merge remote-tracking branch 'github/pr/1961' into collectd-5.5
Florian Forster [Thu, 6 Oct 2016 20:41:24 +0000 (22:41 +0200)]
Merge branch 'pr/1970'
Florian Forster [Thu, 6 Oct 2016 20:39:58 +0000 (22:39 +0200)]
intel_rdt plugin: Filter through clang-format.
Florian Forster [Thu, 6 Oct 2016 20:36:53 +0000 (22:36 +0200)]
intel_rdt plugin: Include "collectd.h" as first header.
Pshyk, SerhiyX [Thu, 6 Oct 2016 11:19:56 +0000 (12:19 +0100)]
rdtmon: Rename 'rdtmon' plugin to 'intel_rdt'.
Change-Id: Id23eb96fd37e6d4fc5fdf7e7ed58d9e74a33cca0
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
Florian Forster [Wed, 5 Oct 2016 06:52:56 +0000 (08:52 +0200)]
Merge remote-tracking branch 'github/pr/1973'
Florian Forster [Wed, 5 Oct 2016 06:51:50 +0000 (08:51 +0200)]
Merge branch 'pr/1975'
Florian Forster [Wed, 5 Oct 2016 06:51:29 +0000 (08:51 +0200)]
memcached plugin: Clarify documentation and a comment.
Pshyk, SerhiyX [Tue, 4 Oct 2016 14:31:58 +0000 (15:31 +0100)]
rdtmon: Addressed PR comments
1. use size_t type for all arrays and indexes
2. change malloc()/memset() to calloc()
3. fix minor code style issues
4. add range validation of core id values
5. use 'bytes' type for LLC value
6. add 'memory_bandwidth' type for MBM values
Change-Id: I5e577dcda19bc9799e7b79f9d0334c6f21b60f0d
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
Marc Fournier [Tue, 4 Oct 2016 21:46:45 +0000 (23:46 +0200)]
write_graphite: remove linking against libyajl (#1976)
write_graphite doesn't have anything to do with json. This seems to have
been accidentally added in
30c1111.
Fixes https://bugs.debian.org/839771
Pavel Rochnyack [Tue, 4 Oct 2016 18:54:34 +0000 (00:54 +0600)]
memcached: Added Address option
Florian Forster [Tue, 4 Oct 2016 18:56:05 +0000 (20:56 +0200)]
CONTRIBUTING.md: Note that plugins must be added to README.
Florian Forster [Tue, 4 Oct 2016 14:39:57 +0000 (16:39 +0200)]
README: Move mqtt and grpc to the right section.
Florian Forster [Tue, 4 Oct 2016 08:42:14 +0000 (10:42 +0200)]
README: Improve build requirements.
Florian Forster [Tue, 4 Oct 2016 08:29:51 +0000 (10:29 +0200)]
docs/BUILD.java.md: Move java build instructions out of README.
Florian Forster [Tue, 4 Oct 2016 08:19:48 +0000 (10:19 +0200)]
docs/BUILD.dpdkstat.md: Move dpdkstat build instructions out of README.
Marc Fournier [Tue, 4 Oct 2016 18:53:00 +0000 (20:53 +0200)]
collectd.spec: the dpdk is actually called dpdkstat...
Marc Fournier [Mon, 3 Oct 2016 20:16:23 +0000 (22:16 +0200)]
collectd.spec: add dpdk plugin
Florian Forster [Fri, 30 Sep 2016 14:01:54 +0000 (16:01 +0200)]
grpc plugin: Fix compile error.
Weirdly, this only surfaces when building with CFLAGS="-O0 -g".
In file included from ./daemon/common.h:33:0,
from grpc.cc:44:
grpc.cc: In member function 'virtual grpc::Status CollectdImpl::PutValues(grpc::ServerContext*, grpc::ServerReader<collectd::PutValuesRequest>*, collectd::PutValuesResponse*)':
./daemon/plugin.h:113:56: sorry, unimplemented: non-trivial designated initializers not supported
#define VALUE_LIST_INIT { .values = NULL, .meta = NULL }
^
grpc.cc:294:22: note: in expansion of macro 'VALUE_LIST_INIT'
value_list_t vl = VALUE_LIST_INIT;
^
Pshyk, SerhiyX [Tue, 27 Sep 2016 11:02:30 +0000 (12:02 +0100)]
rdtmon: Fix formatting of collectd pod file.
Change-Id: I94d5e7c877bd99a5da8e725efef0bd700f339016
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
Pshyk, SerhiyX [Mon, 19 Sep 2016 13:21:43 +0000 (14:21 +0100)]
rdtmon: Implement RDT monitoring plugin
The rdtmon plugin collects information provided by monitoring features of
Intel Resource Director Technology (Intel(R) RDT) like Cache Monitoring
Technology (CMT), Memory Bandwidth Monitoring (MBM).
Change-Id: Ie45344c1035c522fcd918a1dd2427a2da2e173bb
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
Florian Forster [Wed, 28 Sep 2016 21:12:43 +0000 (23:12 +0200)]
CONTRIBUTING.md: Fix typos.
Florian Forster [Wed, 28 Sep 2016 20:13:08 +0000 (22:13 +0200)]
Merge branch 'collectd-5.6'
Florian Forster [Wed, 28 Sep 2016 11:54:00 +0000 (13:54 +0200)]
src/daemon/utils_cache.h: Improve documentation for uc_iterator_get_next().
Florian Forster [Wed, 28 Sep 2016 19:27:54 +0000 (21:27 +0200)]
src/daemon/plugin.[ch]: Make the user_data_t* const.
That is, user_data_t* passed to register_* functions. The actual callbacks
are still getting a user_data_t* since they, in theory, would be able to
modify the pointer stored in .data.
Issue: #1954
Florian Forster [Wed, 28 Sep 2016 19:23:49 +0000 (21:23 +0200)]
src/daemons/plugin.c: Don't modify user_data_t* in plugin_register_flush().
Fixes: #1954
Florian Forster [Wed, 28 Sep 2016 18:58:04 +0000 (20:58 +0200)]
Revert "write_graphite: remove #ifndefs"
This reverts commit
de80d27fe7023c2e377674b4cc341e539388b98e.
Fixes: #1953
Florian Forster [Wed, 28 Sep 2016 15:53:34 +0000 (17:53 +0200)]
write_http plugin: Don't register a flush callback unconditionally.
Fixes: #1955
Florian Forster [Wed, 28 Sep 2016 13:24:52 +0000 (15:24 +0200)]
Merge remote-tracking branch 'github/pr/1962'
Florian Forster [Wed, 28 Sep 2016 13:23:05 +0000 (15:23 +0200)]
Merge remote-tracking branch 'github/pr/1956'
Florian Forster [Wed, 28 Sep 2016 13:21:04 +0000 (15:21 +0200)]
Merge remote-tracking branch 'github/pr/1952'
Chao Yang [Mon, 26 Sep 2016 15:13:57 +0000 (11:13 -0400)]
cpu: Fix cpu aggregation on AIX change codeing style
Chao Yang [Fri, 23 Sep 2016 13:36:00 +0000 (09:36 -0400)]
cpu: Fix cpu aggregation on AIX
Taras Chornyi [Mon, 26 Sep 2016 09:37:01 +0000 (10:37 +0100)]
dpdkstat: Changed log severity to Error
Akos Vandra [Sun, 25 Sep 2016 15:01:11 +0000 (17:01 +0200)]
add missing ;
Akos Vandra [Sun, 25 Sep 2016 14:25:41 +0000 (16:25 +0200)]
Ability to run in tainted mode for spamassasin plugin.
Sebastian Harl [Sun, 25 Sep 2016 11:40:57 +0000 (13:40 +0200)]
Use readdir() instead of the deprecated readdir_r().
Cf. https://sourceware.org/ml/libc-alpha/2016-02/msg00093.html
Sebastian Harl [Sun, 25 Sep 2016 11:23:43 +0000 (13:23 +0200)]
Declare loop variable in the loop expression.
Sebastian Harl [Fri, 10 Jun 2016 19:59:03 +0000 (21:59 +0200)]
valgrind.FreeBSD.suppress: Suppress bogus invalid read in all call chains.
Sebastian Harl [Fri, 10 Jun 2016 18:50:04 +0000 (20:50 +0200)]
Link libcmds (used for testing) against -lm.
FreeBSD requires this for isfinite().
Sebastian Harl [Wed, 8 Jun 2016 22:37:58 +0000 (00:37 +0200)]
command parser: Add support for parser options.
These can be used to tune the parser behavior. For now, there's an option to
specify the default hostname in an identifier.
Sebastian Harl [Wed, 8 Jun 2016 22:36:18 +0000 (00:36 +0200)]
parse_identifier: Make hostname optional, if a default has been specified.
Sebastian Harl [Sun, 5 Jun 2016 19:43:56 +0000 (21:43 +0200)]
utils_cmds_test: Add various unit tests for the command parser.
Sebastian Harl [Sun, 5 Jun 2016 19:41:39 +0000 (21:41 +0200)]
command parser: Set command type to UNKNOWN upon failure.
Sebastian Harl [Sun, 5 Jun 2016 19:40:57 +0000 (21:40 +0200)]
PUTVAL command: Fix memory leaks and duplicate frees.
Sebastian Harl [Sun, 5 Jun 2016 19:40:13 +0000 (21:40 +0200)]
LISTVAL command: Add missing cmd_destroy_listval().
Sebastian Harl [Sun, 5 Jun 2016 16:39:36 +0000 (18:39 +0200)]
command parser: Add support for the GETVAL command.
Implement the generic interface for GETVAL and switch the GETVAL
implementation to use the generic interface.
Sebastian Harl [Sun, 5 Jun 2016 16:08:47 +0000 (18:08 +0200)]
command parser: Add support for the LISTVAL command.
Implement the generic interface for LISTVAL and switch the LISTVAL
implementation to use the generic interface.
Sebastian Harl [Sun, 5 Jun 2016 15:50:58 +0000 (17:50 +0200)]
command parser: Add support for the FLUSH command.
That is, implement the generic interface for FLUSH and switch the FLUSH
implementation to use the generic interface.
Sebastian Harl [Sun, 5 Jun 2016 14:44:39 +0000 (16:44 +0200)]
plugin.h: Introduce the identifier_t type with pointer fields.
This serves two purposes:
- Allow field values of arbitrary length.
- Reuse the identifier in other places.
Renamed identifier_t from utils_vl_lookup to lookup_identifier_t.
Sebastian Harl [Sun, 5 Jun 2016 13:23:41 +0000 (15:23 +0200)]
command parser: Add a vector-based interface.
The new interface expects a parsed list of fields. Parsing of input buffers
is now done centrally in the generic code and the existing parser is a
wrapper around this and the new vector-based parser. The actual command
parsers (PUTVAL for now) receive the parsed list of fields.
As a side-effect, this changes the parser behavior a little:
- "foo=a string with spaces or \\ special characters" is now valid syntax
for specifying options in addition to foo="value with spaces, etc.".
- foo= is now a valid option even without quotes around the empty value.
Sebastian Harl [Sun, 5 Jun 2016 11:59:49 +0000 (13:59 +0200)]
Add a generic interface for parsing the text protocol.
Implement it for PUTVAL for now.
The text protocol is used in multiple places and the parser will avoid code
duplication in client programs which can, instead, use it to generate the
respective requests.
Use the 'cmd_' prefix for public functions related to command handling.
Sebastian Harl [Sat, 24 Sep 2016 11:28:59 +0000 (13:28 +0200)]
README: Document gRPC's client (sender) support.
Sebastian Harl [Sat, 24 Sep 2016 11:27:53 +0000 (13:27 +0200)]
gRPC plugin: Add Florian to copyright holders.
Sebastian Harl [Sat, 24 Sep 2016 11:05:06 +0000 (13:05 +0200)]
RRDCacheD plugin: Improve various RRD-related error messages.
Sebastian Harl [Sat, 24 Sep 2016 10:55:40 +0000 (12:55 +0200)]
RRDCacheD plugin: Try to reconnect upon failed operations.
The RRD client library does not provide means to check the status of a
connection and there's no way to detect that the connection is broken after,
for example, the daemon restarted. To work around that, try to reconnect if
any client operation fails.
Reported via https://bugs.debian.org/657877
Chao Yang [Fri, 23 Sep 2016 14:48:53 +0000 (10:48 -0400)]
commom: Fixed AIX doesn't have MSG_DONTWAIT
Taras Chornyi [Thu, 22 Sep 2016 10:22:40 +0000 (11:22 +0100)]
dpdkstat: Fixed issue with unused var when configured w/o debug
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Florian Forster [Wed, 21 Sep 2016 13:25:07 +0000 (15:25 +0200)]
Merge remote-tracking branch 'github/pr/631'
Florian Forster [Wed, 21 Sep 2016 09:58:39 +0000 (11:58 +0200)]
Tree wide: Don't set vl.host to hostname_g in plugin code.
Issue: #1951
Florian Forster [Wed, 21 Sep 2016 09:32:20 +0000 (11:32 +0200)]
src/daemon/plugin.c: Don't copy values twice.
A copy of the values was made in plugin_dispatch_values_internal(). This
code predates the "write queue", which means that each value list (and
its values) are copied anyway and vl->values will always point to heap
memory.
Florian Forster [Wed, 21 Sep 2016 09:28:11 +0000 (11:28 +0200)]
src/daemon/plugin.c: Initialize vl->host in plugin_value_list_clone().
Issue: #1951
Florian Forster [Wed, 21 Sep 2016 06:48:56 +0000 (08:48 +0200)]
Merge branch 'pr/1649'
Florian Forster [Wed, 21 Sep 2016 06:48:12 +0000 (08:48 +0200)]
dpkgstat plugin: Filter through clang-format.
Marc Fournier [Tue, 20 Sep 2016 19:23:09 +0000 (21:23 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Taras Chornyi [Mon, 19 Sep 2016 16:47:04 +0000 (17:47 +0100)]
dpdkstat: Fixed issue with incorrect argc calculation
Changed log messages to use PRIuN defines
Change-Id: I1433fbd6443c3d0a956c04670f93615042b40577
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Florian Forster [Mon, 19 Sep 2016 14:14:42 +0000 (16:14 +0200)]
Merge remote-tracking branch 'github/pr/1942'
Florian Forster [Mon, 19 Sep 2016 14:13:08 +0000 (16:13 +0200)]
Merge remote-tracking branch 'github/pr/1939'
Benjamin Gilbert [Mon, 19 Sep 2016 06:42:52 +0000 (01:42 -0500)]
Update email address
Benjamin Gilbert [Wed, 11 Mar 2015 04:28:36 +0000 (00:28 -0400)]
hddtemp: Improve robustness of test
Don't rely on signedness of buffer_size.
Benjamin Gilbert [Tue, 3 Jun 2014 20:15:24 +0000 (16:15 -0400)]
hddtemp: Lift 1024-byte response limit
Dynamically scale the response buffer, up to a maximum of 1 MB.
Benjamin Gilbert [Tue, 3 Jun 2014 14:32:41 +0000 (10:32 -0400)]
hddtemp: Lift 32-device limit
Instead of building an array of fields and then walking it, split into
fields as we go.
Taras Chornyi [Mon, 19 Sep 2016 05:35:59 +0000 (08:35 +0300)]
dpdkstat: Addressed PR comments
1) Added missing option description
2) Replaced strerror with sstrerror
3) Do not return from helper code
4) Use generic collectd Interval implementation
5) Removed "\n" from log messages
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Rinigus [Sun, 18 Sep 2016 18:11:04 +0000 (21:11 +0300)]
parse_value_file: adding strstripnewline back