Florian Forster [Sun, 18 Aug 2013 07:58:13 +0000 (09:58 +0200)]
curl_json plugin: Random minor improvements.
I did these changes while wrapping my head around the new array code.
* Added a comment to explain the cj_cb_map_key() function.
* Renamed some variabled and the arguments of the cj_cb_map_key() function.
* Renamed the "ignore" argument to "update_key" (inversing its meaning).
Florian Forster [Sun, 18 Aug 2013 07:04:45 +0000 (09:04 +0200)]
Merge remote-tracking branches 'github/pr/392' and 'github/pr/399' into jr/json
Florian Forster [Fri, 16 Aug 2013 10:31:01 +0000 (12:31 +0200)]
src/types.db: Remove the maximum value for "latency".
Github: #400
Florian Forster [Fri, 16 Aug 2013 09:27:25 +0000 (11:27 +0200)]
Merge remote-tracking branch 'github/master'
Florian Forster [Fri, 16 Aug 2013 09:26:27 +0000 (11:26 +0200)]
Merge remote-tracking branch 'github/pr/404'
Jim Radford [Wed, 14 Aug 2013 18:54:04 +0000 (11:54 -0700)]
Update clean.sh
Marc Fournier [Fri, 26 Jul 2013 15:35:44 +0000 (17:35 +0200)]
statsd plugin: add TimerCount option
The "count" name was chosen over "num" to match the naming scheme
used by the node.js implementation.
Marc Fournier [Fri, 26 Jul 2013 13:24:37 +0000 (15:24 +0200)]
statsd plugin: add TimerSum option
Marc Fournier [Fri, 26 Jul 2013 13:10:08 +0000 (15:10 +0200)]
statsd plugin: add TimerLower and TimerUpper options
The "lower" and "upper" names were chosen over "min" and "max"
to match the naming scheme used by the node.js implementation.
Jim Radford [Wed, 14 Aug 2013 01:59:23 +0000 (01:59 +0000)]
fix .gitignore of lcc_features.h
Jim Radford [Wed, 14 Aug 2013 01:45:09 +0000 (01:45 +0000)]
.gitignore collectd-tg
Jim Radford [Wed, 14 Aug 2013 00:57:58 +0000 (17:57 -0700)]
curl_json plugin: warn when config expects a map and a number is provided
Moves the warning for strings in the number callback which was being called anyway.
This also serves to fix parsing numbers represented as JSON strings which was inadvertantly broken when adding array support.
Jim Radford [Sat, 10 Aug 2013 19:13:09 +0000 (12:13 -0700)]
curl_json plugin: add an example of array access to the documented uWSGI example
Jim Radford [Sat, 10 Aug 2013 19:11:29 +0000 (12:11 -0700)]
curl_json plugin: document the new Sock option
Jim Radford [Sat, 10 Aug 2013 16:06:44 +0000 (09:06 -0700)]
curl_json plugin: free the socket name
Jim Radford [Thu, 8 Aug 2013 16:33:36 +0000 (09:33 -0700)]
curl_json plugin: style cleanups
Jim Radford [Thu, 8 Aug 2013 16:31:46 +0000 (09:31 -0700)]
curl_json plugin: use sstrerr for thread safety
Jim Radford [Wed, 7 Aug 2013 20:05:02 +0000 (13:05 -0700)]
curl_json plugin: support getting json from a Unix socket as well as a URL
Jim Radford [Wed, 7 Aug 2013 19:39:51 +0000 (12:39 -0700)]
curl_json plugin: separate the cj_curl_perform in to the curl and yajl parts
Jim Radford [Sat, 10 Aug 2013 19:23:29 +0000 (12:23 -0700)]
curl_json plugin: document being able to access arrays
Jim Radford [Sat, 10 Aug 2013 17:25:02 +0000 (10:25 -0700)]
curl_json plugin: support arrays
Allow access to data in JSON arrays. For example
{ workers: [ { requests: 10 }, { requests: 10 } ] }
can all be accessed with
workers/*/requests
or just one by using the index.
workers/1/requests
Marc Fournier [Fri, 9 Aug 2013 15:23:48 +0000 (17:23 +0200)]
disable fields not available in varnish 2.0.x
Several fields were added in commit
8775392. 3 of them make the build
fail when varnish 2.0.x is used. This patch makes them available only
when using varnish 3.x.
The commit message of
8775392 gives more detail on the rationale behind
this way of doing.
Marc Fournier [Fri, 9 Aug 2013 15:06:28 +0000 (17:06 +0200)]
Merge remote-tracking branch 'origin/pr/376'
Marc Fournier [Thu, 8 Aug 2013 15:06:11 +0000 (17:06 +0200)]
update copyright and authors list
Marc Fournier [Thu, 8 Aug 2013 12:07:45 +0000 (14:07 +0200)]
remove redundant inclusion of time.h
Bert Vermeulen [Thu, 8 Aug 2013 08:17:23 +0000 (10:17 +0200)]
Add sigrok to README/AUTHORS
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Wed, 7 Aug 2013 06:39:28 +0000 (08:39 +0200)]
Merge branch 'ff/statsd'
Florian Forster [Wed, 7 Aug 2013 06:39:08 +0000 (08:39 +0200)]
Merge branch 'pr/381'
Florian Forster [Wed, 7 Aug 2013 06:39:00 +0000 (08:39 +0200)]
src/collectd.conf.in: Unify indentation.
Florian Forster [Wed, 7 Aug 2013 06:33:13 +0000 (08:33 +0200)]
sigrok plugin: Ensure consistent logging prefix.
* Make sure all logging is using the "sigrok plugin: " prefix.
* Improved logging when handling the "LogLevel" option.
* Renamed free_drvopts() to sigrok_free_drvopts(). All functions now use the
"sigrok_" prefix.
* Don't abort parsing a "Device" block when encountering an incorrect number of
arguments. The cf_util_* functions will complain about that.
Florian Forster [Wed, 7 Aug 2013 06:14:16 +0000 (08:14 +0200)]
collectd.conf(5): sigrok plugin: Improve markup.
Marc Fournier [Wed, 7 Aug 2013 05:55:01 +0000 (07:55 +0200)]
use pkg-config to locate libmnl and configure netlink plugin
Florian Forster [Fri, 19 Jul 2013 05:39:47 +0000 (07:39 +0200)]
rrdtool plugin: Minor performance improvement.
Replace the value_list_to_string() function with a version which is optimized
for data sets with a single data source. The original function is still used
for data sets with multiple data sources. This allows to reduce the number of
calls to snprintf() in this (very common) case, resulting in ~2% speedup.
Bert Vermeulen [Mon, 5 Aug 2013 20:33:55 +0000 (22:33 +0200)]
sigrok: Update docs to reflect config keyword change
Bert Vermeulen [Mon, 5 Aug 2013 20:21:41 +0000 (22:21 +0200)]
sigrok: Change 'interval' option to 'MinimumInterval', and allow 0
A MinimumInterval of 0 means whatever the device sends gets dispatched
to collectd. This is the default.
Bert Vermeulen [Wed, 31 Jul 2013 09:30:16 +0000 (11:30 +0200)]
Fix temperature type to be unit-agnostic
The minimum value of -273.15 implies Celcius, which is not necessarily
what is used for this type.
Bert Vermeulen [Wed, 31 Jul 2013 09:29:53 +0000 (11:29 +0200)]
add sound pressure level type
Bert Vermeulen [Wed, 31 Jul 2013 09:24:36 +0000 (11:24 +0200)]
Use value types according to sigrok measured quantity
Bert Vermeulen [Tue, 30 Jul 2013 21:12:26 +0000 (23:12 +0200)]
Code consistency fixes
Bert Vermeulen [Mon, 29 Jul 2013 23:03:00 +0000 (01:03 +0200)]
Code cleanup
Bert Vermeulen [Mon, 29 Jul 2013 21:47:25 +0000 (23:47 +0200)]
Config errors should not be fatal
Bert Vermeulen [Mon, 29 Jul 2013 20:38:09 +0000 (22:38 +0200)]
Factor out device initialization
Bert Vermeulen [Mon, 29 Jul 2013 18:08:00 +0000 (20:08 +0200)]
Use gcc-specific __attribute__ to mark unused parameter
Bert Vermeulen [Fri, 26 Jul 2013 12:00:23 +0000 (14:00 +0200)]
sigrok plugin
Florian Forster [Fri, 26 Jul 2013 13:18:43 +0000 (15:18 +0200)]
stats plugin: Don't check the value of '(value_t).derive'.
statsd_parse_value() will write to (value_t).gauge, so don't read from another
member of the union. This also fixes problems with counter values being zero,
for whatever that is supposed to be useful for.
Github: #358
Bert Vermeulen [Wed, 10 Jul 2013 21:54:13 +0000 (23:54 +0200)]
sigrok: build system setup
Andreas Henriksson [Thu, 25 Jul 2013 20:26:32 +0000 (22:26 +0200)]
Fix pointer confusion for nested attribute parsing
A reference to a pointer is passed as data,
the resulting attribute payload should be stored in
the dereferenced location to return it to the caller.
Marc Fournier [Mon, 22 Jul 2013 14:34:04 +0000 (16:34 +0200)]
update build system to reflect switch to libmnl
"./configure" was previously checking for libnetlink and setting
"-lmnl" if found, which was obviously calling for trouble. With
this patch, the last references to libnetlink are dead and buried.
NB: linux/netlink.h and friends are still included here and there
though, but these are not related to libnetlink.
Marc Fournier [Mon, 22 Jul 2013 10:54:24 +0000 (12:54 +0200)]
update README to mention libmnl dependency
Marc Fournier [Mon, 22 Jul 2013 10:02:13 +0000 (12:02 +0200)]
netlink: __attribute__ usage clarification
As requested by @octo in GitHub#376.
Marc Fournier [Mon, 22 Jul 2013 09:23:25 +0000 (11:23 +0200)]
netlink: comments & cleanup
Marc Fournier [Mon, 22 Jul 2013 09:03:42 +0000 (11:03 +0200)]
netlink: indentation & whitespace/tab consistency
Marc Fournier [Fri, 19 Jul 2013 18:48:40 +0000 (20:48 +0200)]
Merge remote-tracking branch 'origin/pr/371'
Marc Fournier [Fri, 19 Jul 2013 14:23:56 +0000 (16:23 +0200)]
netlink: fix segfault & make advanced options work again
A type mismatch and offset mistake was preventing the interface list
from getting iterated. This was making collectd segfault when the
"QDisc", "Class" or "Filter" options were enabled.
Marc Fournier [Thu, 18 Jul 2013 10:07:35 +0000 (12:07 +0200)]
libmnl: fix 2 mistakes preventing building with --enable-debug
Andreas Henriksson [Mon, 10 Jun 2013 21:26:19 +0000 (23:26 +0200)]
More fixing of netlink build with different HAVE_...
Andreas Henriksson [Mon, 10 Jun 2013 21:18:04 +0000 (23:18 +0200)]
Restructure to compile with all combos of HAVE_TCA_STATS(2)
We want to compile with all combinations of
HAVE_TCA_STATS(2) set/unset and at the same time
protect against submitting the stats twice (if both
are supported).
Introduce "stats_found" and set and attribute on it
to avoid having the compiler complain about it.
This allows us to bury the specific structs under
each HAVE_TCA_STATS(2) #if ...
Andreas Henriksson [Mon, 10 Jun 2013 21:00:24 +0000 (23:00 +0200)]
Fix HAVE_TCA_STATS(2) checks in configure.in
Andreas Henriksson [Mon, 10 Jun 2013 20:56:54 +0000 (22:56 +0200)]
Fix netlink.c to (almost) build
Andreas Henriksson [Mon, 10 Jun 2013 20:42:43 +0000 (22:42 +0200)]
Update configure script to link with -lmnl
Andreas Henriksson [Mon, 10 Jun 2013 20:41:21 +0000 (22:41 +0200)]
Initial libmnl porting attempt
Marc Fournier [Wed, 17 Jul 2013 10:05:49 +0000 (12:05 +0200)]
df: remove trailing whitespaces
Marc Fournier [Wed, 17 Jul 2013 09:59:57 +0000 (11:59 +0200)]
df: rename percentage types to a more generic name
Blake Matheny [Wed, 6 Feb 2013 12:04:47 +0000 (07:04 -0500)]
Add support for incr/decr counts
Marc Fournier [Mon, 15 Jul 2013 16:01:39 +0000 (18:01 +0200)]
replace nginx_{accepts,handled} DSs
reusing an existing DS is preferred. GH#227.
Patrick Shan [Thu, 3 Jan 2013 03:58:59 +0000 (14:58 +1100)]
* change nginx plugin for collectd to submit "nginx_accepts" and
* "nginx_handled"
Marc Fournier [Mon, 15 Jul 2013 09:11:43 +0000 (11:11 +0200)]
add 2 missing data types for df percentages
Florian Forster [Sun, 14 Jul 2013 06:27:31 +0000 (08:27 +0200)]
tail plugin: Remove custom string config function.
Florian Forster [Sat, 13 Jul 2013 09:24:39 +0000 (11:24 +0200)]
Merge branch 'ym/limit_write_queue_length'
Florian Forster [Sat, 13 Jul 2013 09:24:27 +0000 (11:24 +0200)]
Merge branch 'collectd-5.3'
Conflicts:
src/plugin.c
Florian Forster [Sat, 13 Jul 2013 09:23:32 +0000 (11:23 +0200)]
Merge branch 'collectd-5.2' into collectd-5.3
Florian Forster [Sat, 13 Jul 2013 09:19:54 +0000 (11:19 +0200)]
src/plugin.c: Some fixes for write limits.
* Log an error once per second.
* Coding style fixes.
* Separate function for calculating drop probability.
Florian Forster [Sat, 13 Jul 2013 09:15:01 +0000 (11:15 +0200)]
src/configfile.c: Rename options to "WriteQueueLimit{High,Low}".
The original names are a bit long.
Yves Mettier [Fri, 26 Apr 2013 09:50:18 +0000 (11:50 +0200)]
Fixed a bug with WriteQueueLengthLimitHigh is null/uninitialized
Signed-off-by: Florian Forster <octo@collectd.org>
Yves Mettier [Tue, 26 Mar 2013 17:25:33 +0000 (18:25 +0100)]
Fixes for code quality
Signed-off-by: Florian Forster <octo@collectd.org>
Yves Mettier [Thu, 14 Mar 2013 15:57:43 +0000 (16:57 +0100)]
fixed a bug in doc near new WriteQueueLengthLimit*
Signed-off-by: Florian Forster <octo@collectd.org>
Yves Mettier [Thu, 14 Mar 2013 15:45:02 +0000 (16:45 +0100)]
Added new WriteQueueLengthLimit (drop values when bigger)
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Sat, 13 Jul 2013 06:20:28 +0000 (08:20 +0200)]
src/plugin.c: Free the "data_sets" AVL tree.
This pops up every time I investigate memory leaks and it's annoying me.
Florian Forster [Sat, 13 Jul 2013 05:46:20 +0000 (07:46 +0200)]
write_graphite plugin: Don't call close() on invalid file descriptors.
Florian Forster [Sat, 13 Jul 2013 05:42:18 +0000 (07:42 +0200)]
write_graphite plugin: Don't call close() on invalid file descriptors.
Florian Forster [Sat, 13 Jul 2013 05:38:05 +0000 (07:38 +0200)]
write_graphite plugin: Actually check the return value of wg_send_message().
Assignment to "status" was missing.
Florian Forster [Fri, 12 Jul 2013 16:56:15 +0000 (18:56 +0200)]
statsd plugin: Store values internally as double.
While the documentation states that "values should generally be integers", this
"should" is not taken in the strict RFC meaning. For compatibility with Etsy's
statsd, handle everything as a double up until the last possible moment.
Florian Forster [Fri, 12 Jul 2013 16:23:20 +0000 (18:23 +0200)]
Merge branch 'collectd-5.3'
Conflicts:
src/collectd.conf.pod
Florian Forster [Fri, 12 Jul 2013 16:21:31 +0000 (18:21 +0200)]
Merge branch 'collectd-5.2' into collectd-5.3
Florian Forster [Fri, 12 Jul 2013 16:19:29 +0000 (18:19 +0200)]
rrdtool, rrdcached plugins: Re-implement value_list_to_filename().
Faster version without snprintf().
Florian Forster [Fri, 12 Jul 2013 16:17:19 +0000 (18:17 +0200)]
csv plugin: Re-implement value_list_to_filename().
The new implementation is faster, because it doesn't use snprintf().
Florian Forster [Thu, 11 Jul 2013 15:58:37 +0000 (17:58 +0200)]
src/common.c: Reimplement format_name for performance.
This is used from uc_update(), i.e. for every value list dispatched, and was
one of the most expensive functions thanks to snprintf().
This reduces total time spent in the format_name() function from 7.78% to 1.89%
during a network stress test.
Florian Forster [Thu, 11 Jul 2013 12:58:32 +0000 (14:58 +0200)]
statsd plugin: Make metric names case-sensitive.
The StatsD by etsy is case sensitive, so we should do the same. Also, strcmp()
should have better performance than strcasecmp().
Florian Forster [Thu, 11 Jul 2013 11:08:11 +0000 (13:08 +0200)]
statsd plugin: Don't use strtok_r() to split multi-metric packets.
Profiling has shown that it is one of the bottle-necks.
Florian Forster [Thu, 11 Jul 2013 11:03:12 +0000 (13:03 +0200)]
statsd plugin: Dont'a call common.c:parse_value().
parse_value() is doing a strdup() do it can remove trailing whitespace.
We don't need that for the statsd protocol, so we just call strtoull()
instead, improving performance but a couple of percent again.
Florian Forster [Thu, 11 Jul 2013 08:12:54 +0000 (10:12 +0200)]
statsd plugin: Avoid calling snprintf() in the hot path.
snprintf() is very expensive and the alternative is simple. This shaves
off about 7% of the time spent handling events.
Florian Forster [Thu, 11 Jul 2013 08:11:14 +0000 (10:11 +0200)]
statsd plugin: Remove the prefix in the counter and gauge handlers.
The prefix is added in statsd_metric_lookup_unsafe(), so we don't need
to do this here anymore. Since snprintf() is expensive, this increases
performance considerably.
Pierre-Yves Ritschard [Mon, 8 Jul 2013 07:06:35 +0000 (09:06 +0200)]
Test for end of oid tree without breaking collection loop.
Florian Forster [Wed, 3 Jul 2013 16:21:08 +0000 (18:21 +0200)]
Merge branch 'fix-stringio-python2.7' of git://github.com/aelse/collectd
Florian Forster [Wed, 3 Jul 2013 09:51:46 +0000 (11:51 +0200)]
Merge branch 'fix-dstype-ordinal-decode_network_values' of git://github.com/aelse/collectd
Florian Forster [Wed, 3 Jul 2013 05:46:40 +0000 (07:46 +0200)]
Merge branch 'vbartoni/df'
Florian Forster [Wed, 3 Jul 2013 05:46:15 +0000 (07:46 +0200)]
df plugin: Remove trailing white space.
Alexander Else [Mon, 1 Jul 2013 07:02:19 +0000 (17:02 +1000)]
fixes StringIO unicode handling in python 2.7
Alexander Else [Mon, 1 Jul 2013 06:17:12 +0000 (16:17 +1000)]
decode_network_values dstype is ordinal value of string literal
Matt Blair [Mon, 24 Jun 2013 17:11:25 +0000 (10:11 -0700)]
fix the build