Ruben Kerkhof [Sun, 24 Apr 2016 10:48:42 +0000 (12:48 +0200)]
Merge pull request #1564 from rpv-tomsk/disk-plugin
disk plugin: send disk_merged,disk_io_time,pending_operations only when real data exists for device
Ruben Kerkhof [Sat, 23 Apr 2016 19:28:31 +0000 (21:28 +0200)]
AC_CONFIG_SRCDIR needs to point to a unique file
AC_CONFIG_SRCDIR is a bit of a misnomer, in that it should
point to a unique file in the top source directory, not to
the directory itself.
Ruben Kerkhof [Sat, 23 Apr 2016 15:35:39 +0000 (17:35 +0200)]
rrdtool plugin: fix thread-safety detection
librrd 1.6.0 is now threadsafe and librrd_th is gone.
Since there doesn't seem to be a way to detect that librrd
is threadsafe, use pkg-config to check for 1.6.0 or newer instead.
The logic is now as follows:
Check for librrd >= 1.6.0 with pkg-config
If not found, look for rrd_update_r in librrd_th.
If not found, look for rrd_update in librrd and assume librrd is not
thread safe.
Ruben Kerkhof [Sat, 23 Apr 2016 13:22:52 +0000 (15:22 +0200)]
HAVE_THREADSAFE_LIBRRD is either defined or not
Ruben Kerkhof [Sat, 23 Apr 2016 13:06:03 +0000 (15:06 +0200)]
rrdtool check: stop linking in libm
Ruben Kerkhof [Sat, 23 Apr 2016 13:03:03 +0000 (15:03 +0200)]
rrdtool check: no need to save CPPFLAGS
There's no need to save CPPFLAGS when we're just
checking a library.
Ruben Kerkhof [Sat, 23 Apr 2016 13:00:26 +0000 (15:00 +0200)]
rrdtool check: no need to save LDFLAGS
There's no need to save LDFLAGS when we're just
checking a header.
Ruben Kerkhof [Sat, 23 Apr 2016 12:54:34 +0000 (14:54 +0200)]
liboconfig: enable dependency tracking
Nowadays there's no reason not too.
Also remove the foreign option, since we set that as default
in configure.ac already.
Ruben Kerkhof [Sat, 23 Apr 2016 12:08:07 +0000 (14:08 +0200)]
sfree: don't check for NULL before calling free
free(NULL) is safe to call
Ruben Kerkhof [Sat, 23 Apr 2016 12:05:21 +0000 (14:05 +0200)]
Merge branch 'cppcheck'
Ruben Kerkhof [Sat, 23 Apr 2016 11:57:27 +0000 (13:57 +0200)]
bind plugin: space after realloc
Ruben Kerkhof [Sat, 23 Apr 2016 11:41:04 +0000 (13:41 +0200)]
amqp: plug leak on realloc failure
Ruben Kerkhof [Sat, 23 Apr 2016 11:35:09 +0000 (13:35 +0200)]
realloc: remove unnecessary casts of return value
Ruben Kerkhof [Sat, 23 Apr 2016 10:33:49 +0000 (12:33 +0200)]
match_value: condition is always true
[src/match_value.c:338]: (style) Condition 'value_matches==0' is always true
Ruben Kerkhof [Sat, 23 Apr 2016 10:13:21 +0000 (12:13 +0200)]
apache plugin: len is unsigned
[src/apache.c:140]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:12:31 +0000 (12:12 +0200)]
ascent plugin: len is unsigned
[src/ascent.c:157]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:11:41 +0000 (12:11 +0200)]
battery plugin: remove assignment with no effect
[src/battery.c:361] -> [src/battery.c:372]: (performance) Variable 'capacity_charged' is reassigned a value before the old one has been used.
Ruben Kerkhof [Sat, 23 Apr 2016 10:09:33 +0000 (12:09 +0200)]
bind plugin: len is unsigned
[src/bind.c:280]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:08:13 +0000 (12:08 +0200)]
curl plugin: prev can't be NULL here
[src/curl.c:548] -> [src/curl.c:546]: (warning) Either the condition 'prev!=0' is redundant or there is possible null pointer dereference: prev.
Ruben Kerkhof [Sat, 23 Apr 2016 10:07:23 +0000 (12:07 +0200)]
curl plugin: len is unsigned
[src/curl.c:98]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:06:38 +0000 (12:06 +0200)]
curl_json plugin: len is unsigned
[src/curl_json.c:119]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:03:06 +0000 (12:03 +0200)]
curl_xml plugin: remove useless assigment
list has local storage class
[src/curl_xml.c:173]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
Ruben Kerkhof [Sat, 23 Apr 2016 10:02:14 +0000 (12:02 +0200)]
curl_xml plugin: len is unsigned
[src/curl_xml.c:117]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:01:27 +0000 (12:01 +0200)]
collectd.c: dirlen is unsigned
[src/daemon/collectd.c:199]: (style) Checking if unsigned variable 'dirlen' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 10:00:37 +0000 (12:00 +0200)]
common.c: fields_num is unsigned
[src/daemon/common.c:338]: (style) Checking if unsigned variable 'fields_num' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 09:59:27 +0000 (11:59 +0200)]
common_test.c: sfree always sets ptr to NULL
[src/daemon/common_test.c:93]: (style) Condition 'ptr==0' is always true
Ruben Kerkhof [Sat, 23 Apr 2016 09:57:25 +0000 (11:57 +0200)]
plugin.c: fix potential null pointer dereference
[src/daemon/plugin.c:2095] -> [src/daemon/plugin.c:2091]: (warning) Either the condition 'vl==0' is redundant or there is possible null pointer dereference: vl.
Ruben Kerkhof [Sat, 23 Apr 2016 09:52:02 +0000 (11:52 +0200)]
utils_ignorelist.c: remove useless assignment
[src/daemon/utils_ignorelist.c:238]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
Ruben Kerkhof [Sat, 23 Apr 2016 09:49:58 +0000 (11:49 +0200)]
dbi plugin: remove assignment with no effect
[src/dbi.c:513] -> [src/dbi.c:518]: (performance) Variable 'res' is reassigned a value before the old one has been used.
Ruben Kerkhof [Sat, 23 Apr 2016 09:44:41 +0000 (11:44 +0200)]
liboconfig/oconfig.c: remove unneeded assigment
[src/liboconfig/oconfig.c:224]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
Ruben Kerkhof [Sat, 23 Apr 2016 09:39:47 +0000 (11:39 +0200)]
memcachec plugin: prev can't be NULL here
[src/memcachec.c:392] -> [src/memcachec.c:390]: (warning) Either the condition 'prev!=0' is redundant or there is possible null pointer dereference: prev.
Ruben Kerkhof [Sat, 23 Apr 2016 09:35:26 +0000 (11:35 +0200)]
openvpn plugin: plug leak on realloc failure
[src/openvpn.c:715]: (error) Common realloc mistake: 'vpn_list' nulled but not freed upon failure
Ruben Kerkhof [Sat, 23 Apr 2016 09:30:57 +0000 (11:30 +0200)]
openvpn plugin: use sizeof(*pointer) instead of sizeof(type)
Ruben Kerkhof [Sat, 23 Apr 2016 09:30:19 +0000 (11:30 +0200)]
openvpn plugin: remove unnecessary cast
Ruben Kerkhof [Sat, 23 Apr 2016 09:27:12 +0000 (11:27 +0200)]
memcached plugin: remove assignment with no effect
[src/memcached.c:176] -> [src/memcached.c:180]: (performance) Variable 'fd' is reassigned a value before the old one has been used.
Ruben Kerkhof [Sat, 23 Apr 2016 09:24:08 +0000 (11:24 +0200)]
network plugin: output_len is unsigned
[src/network.c:937]: (style) Checking if unsigned variable 'output_len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 09:22:00 +0000 (11:22 +0200)]
perl plugin: remove assignments with no effect
[src/perl.c:2079] -> [src/perl.c:2082]: (performance) Variable 't' is reassigned a value before the old one has been used.
Ruben Kerkhof [Sat, 23 Apr 2016 09:13:02 +0000 (11:13 +0200)]
processes plugin: check boundary first
[src/processes.c:1042]: (style) Array index 'name_start_pos' is used before limits check.
Ruben Kerkhof [Sat, 23 Apr 2016 09:10:25 +0000 (11:10 +0200)]
snmp plugin: initialize res sooner
Ruben Kerkhof [Sat, 23 Apr 2016 09:08:56 +0000 (11:08 +0200)]
snmp plugin: remove statement with no effect
res has local scope, and we return immediately after.
Ruben Kerkhof [Sat, 23 Apr 2016 09:07:38 +0000 (11:07 +0200)]
snmp plugin: res can't be NULL here
[src/snmp.c:1761] -> [src/snmp.c:1777]: (warning) Either the condition 'res!=0' is redundant or there is possible null pointer dereference: res.
Ruben Kerkhof [Sat, 23 Apr 2016 09:00:31 +0000 (11:00 +0200)]
threshold.c: remove assignment with no effect.
[src/threshold.c:81] -> [src/threshold.c:87]: (performance) Variable 'th_ptr' is reassigned a value before the old one has been used.
Ruben Kerkhof [Sat, 23 Apr 2016 08:57:08 +0000 (10:57 +0200)]
utils_db_query.c: plug leak on error
Ruben Kerkhof [Sat, 23 Apr 2016 08:56:10 +0000 (10:56 +0200)]
utils_db_query.c: remove unnecessary cast
Ruben Kerkhof [Sat, 23 Apr 2016 08:52:22 +0000 (10:52 +0200)]
network plugin: fd_num is unsigned
[src/network.c:2314]: (style) Checking if unsigned variable 'fd_num' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:50:48 +0000 (10:50 +0200)]
nginx plugin: len is unsigned
[src/nginx.c:74]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:48:11 +0000 (10:48 +0200)]
olsrd plugin: buffer_len is unsigned
[src/olsrd.c:666]: (style) Checking if unsigned variable 'buffer_len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:46:29 +0000 (10:46 +0200)]
processes plugin: ps->num_lwp is unsigned long
[src/processes.c:1095]: (style) Checking if unsigned variable 'num_lwp' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:44:43 +0000 (10:44 +0200)]
processes plugin: len is unsigned
[src/processes.c:1219]: (style) Checking if unsigned variable 'len' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:42:52 +0000 (10:42 +0200)]
utils_db_query.c: r->instances_num is unsigned
[src/utils_db_query.c:237]: (style) Checking if unsigned variable 'instances_num' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:41:07 +0000 (10:41 +0200)]
utils_format_json.c: offset is unsigned
[src/utils_format_json.c:300]: (style) Checking if unsigned variable 'offset' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:40:01 +0000 (10:40 +0200)]
rrdcreate.c: ds_num is unsigned
[src/utils_rrdcreate.c:358]: (style) Checking if unsigned variable 'ds_num' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:38:35 +0000 (10:38 +0200)]
write_graphite: send_buf_fill is unsigned
[src/write_graphite.c:183]: (style) Checking if unsigned variable 'send_buf_fill' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:36:50 +0000 (10:36 +0200)]
write_http plugin: send_buffer_fill is unsigned
Ruben Kerkhof [Sat, 23 Apr 2016 08:35:23 +0000 (10:35 +0200)]
write_tsdb plugin: send_buf_fill can't be < 0
[src/write_tsdb.c:145]: (style) Checking if unsigned variable 'send_buf_fill' is less than zero.
Ruben Kerkhof [Sat, 23 Apr 2016 08:32:36 +0000 (10:32 +0200)]
zone plugin: plug leak on error
[src/zone.c:124]: (error) Memory leak: ret
Ruben Kerkhof [Sat, 23 Apr 2016 08:28:27 +0000 (10:28 +0200)]
zookeeper plugin: remove useless initialization
[src/zookeeper.c:162] -> [src/zookeeper.c:166]: (performance) Variable 'sk' is reassigned a value before the old one has been used.
Ruben Kerkhof [Sat, 23 Apr 2016 08:25:40 +0000 (10:25 +0200)]
daemon/common.c: remove unused function
Found with cppcheck
Marc Fournier [Fri, 22 Apr 2016 20:22:44 +0000 (22:22 +0200)]
Merge remote-tracking branch 'origin/pr/1239'
Ruben Kerkhof [Thu, 21 Apr 2016 20:19:10 +0000 (22:19 +0200)]
Merge pull request #1608 from rpv-tomsk/plugin-xencpu-public
xencpu plugin: RFC release
Pavel Rochnyack [Mon, 7 Mar 2016 05:47:14 +0000 (12:47 +0700)]
xencpu plugin: Plugin to collect CPU load under Xen
Fixed remarks of code review:
* Removed static pointer initialization
* Tabs replaced by spaces
* Added check for xenctrl.h
* Changed order of libraries check, added argument quotes
* Added plugin documentation
Marc Fournier [Tue, 19 Apr 2016 14:08:44 +0000 (16:08 +0200)]
configure.ac: fix typo
Marc Fournier [Tue, 19 Apr 2016 13:51:48 +0000 (15:51 +0200)]
RPM specfile: temporarily disable building write_riemann
cf. #986
Pierre-Yves Ritschard [Mon, 18 Apr 2016 13:34:25 +0000 (15:34 +0200)]
write_kafka: botch previous commit, spotted by @ciomaire
Pierre-Yves Ritschard [Mon, 18 Apr 2016 12:51:32 +0000 (14:51 +0200)]
Merge pull request #1672 from collectd/feature/recent-rdkafka
write_kafka: do not call depreciated functions unless necessary
Pierre-Yves Ritschard [Mon, 18 Apr 2016 12:50:28 +0000 (14:50 +0200)]
write_kafka: do not call depreciated functions unless necessary
Pierre-Yves Ritschard [Mon, 18 Apr 2016 08:11:36 +0000 (10:11 +0200)]
Merge pull request #986 from algernon/f/riemann/rcc
write_riemann: TLS support via riemann-c-client
Pierre-Yves Ritschard [Mon, 18 Apr 2016 08:10:47 +0000 (10:10 +0200)]
Merge branch 'master' into f/riemann/rcc
Ruben Kerkhof [Sat, 16 Apr 2016 13:14:09 +0000 (15:14 +0200)]
plugin.c: fix indentation of comment
Ruben Kerkhof [Sat, 16 Apr 2016 11:54:16 +0000 (13:54 +0200)]
virt plugin: compare pointer to NULL, not 0
Found with coccinelle
Ruben Kerkhof [Sat, 16 Apr 2016 11:52:34 +0000 (13:52 +0200)]
turbostat plugin: reset the right variable
Ruben Kerkhof [Sat, 16 Apr 2016 11:49:01 +0000 (13:49 +0200)]
tail_csv plugin: set pointer to NULL not 0
Found with coccinelle
Ruben Kerkhof [Sat, 16 Apr 2016 11:46:07 +0000 (13:46 +0200)]
collectctl: compare pointer with NULL not 0
Found with coccinelle
Ruben Kerkhof [Sat, 16 Apr 2016 11:58:02 +0000 (13:58 +0200)]
pyvalues.c: remove unneccesary semicolon
Found with Coccinelle
Ruben Kerkhof [Fri, 15 Apr 2016 19:43:57 +0000 (21:43 +0200)]
configure.ac: indent plugin list
Ruben Kerkhof [Fri, 15 Apr 2016 19:27:10 +0000 (21:27 +0200)]
configure.ac: keep plugin lists sorted
Ruben Kerkhof [Fri, 15 Apr 2016 19:04:04 +0000 (21:04 +0200)]
Merge branch 'collectd-5.5'
Ruben Kerkhof [Fri, 15 Apr 2016 19:03:46 +0000 (21:03 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Brandon Arp [Fri, 15 Apr 2016 18:37:44 +0000 (11:37 -0700)]
fix potential curl plugin curl_slist_append memory leak
make sure that we dont leak memory if curl_slist_append returns null
Ruben Kerkhof [Fri, 15 Apr 2016 18:40:11 +0000 (20:40 +0200)]
Merge pull request #1634 from BrandonArp/add_write_http_headers
add http headers functionality to write_http plugin
Brandon Arp [Thu, 24 Mar 2016 23:44:46 +0000 (16:44 -0700)]
add http headers functionality to write_http plugin
Ruben Kerkhof [Fri, 15 Apr 2016 11:22:38 +0000 (13:22 +0200)]
collectd.service: correct comment
We don't actually wait 10 seconds. The default is 100ms.
Ruben Kerkhof [Fri, 15 Apr 2016 10:14:09 +0000 (12:14 +0200)]
collectd.service: wait for network-online.target
Wait for network-online.target, not network.target
See https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Ruben Kerkhof [Fri, 15 Apr 2016 10:13:27 +0000 (12:13 +0200)]
collectd.service: extend Description
Ruben Kerkhof [Fri, 15 Apr 2016 10:13:04 +0000 (12:13 +0200)]
collectd.service: add links to man pages
Ruben Kerkhof [Fri, 15 Apr 2016 09:49:57 +0000 (11:49 +0200)]
Merge pull request #1208 from jy2wong/master
Fix void* arithmetic warning (-Wpointer-arith)
Ruben Kerkhof [Fri, 15 Apr 2016 09:32:49 +0000 (11:32 +0200)]
Merge branch 'collectd-5.5'
Ruben Kerkhof [Fri, 15 Apr 2016 09:32:22 +0000 (11:32 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Jim Quinn [Mon, 21 Mar 2016 16:40:24 +0000 (12:40 -0400)]
Fix process plugin memory leak [solaris]
Pierre-Yves Ritschard [Fri, 15 Apr 2016 08:32:41 +0000 (10:32 +0200)]
write_riemann: add documentation
Pierre-Yves Ritschard [Thu, 14 Apr 2016 08:13:00 +0000 (10:13 +0200)]
write_riemann: do not read responses twice
Pierre-Yves Ritschard [Thu, 14 Apr 2016 08:12:27 +0000 (10:12 +0200)]
write_riemann: do not deadlock when sending from flush
Pierre-Yves Ritschard [Thu, 14 Apr 2016 08:11:18 +0000 (10:11 +0200)]
write_riemann: add a BatchFlushTimeout option
Pierre-Yves Ritschard [Thu, 14 Apr 2016 08:09:38 +0000 (10:09 +0200)]
write_riemann: kill old protobuf files
Gergely Nagy [Thu, 14 Apr 2016 07:55:38 +0000 (09:55 +0200)]
Merge pull request #1 from pyr/f/riemann/rcc
write_riemann: avoid deadlocks, rate limit log messages.
Pierre-Yves Ritschard [Wed, 13 Apr 2016 21:22:33 +0000 (23:22 +0200)]
write_riemann: reorder host struct
Pierre-Yves Ritschard [Wed, 13 Apr 2016 21:15:29 +0000 (23:15 +0200)]
write_riemann: use a single complaint field for send errors
Pierre-Yves Ritschard [Wed, 13 Apr 2016 20:59:51 +0000 (22:59 +0200)]
write_riemann: use the complain mechanism to rate limit connection failure logs
Pierre-Yves Ritschard [Wed, 13 Apr 2016 20:17:57 +0000 (22:17 +0200)]
write_riemann: avoid deadlock on connection failures
Ruben Kerkhof [Wed, 13 Apr 2016 16:33:08 +0000 (18:33 +0200)]
Fix segfault in network plugin
While cleaning up malloc calls in
1ebf2f31, I cleaned up one too many.
Fixes #1667