Sebastian Harl [Sun, 28 Oct 2007 08:57:17 +0000 (09:57 +0100)]
plugin.h: Make DEBUG() a noop when compiling without debugging support.
This saves a couple of useless calls to plugin_log() which the compiler
does not detect and remove itself.
A couple of DEBUG()'s in the apcups, hddtemp, mbmon and ntpd plugins have
been upgraded to INFO()'s. All of them provide error messages of failed
system / libc calls which should be available to the user somehow.
Besides, they use a local string buffer which generates an "unused
variable" warning if DEBUG() expands to a noop.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Sebastian Harl [Fri, 26 Oct 2007 13:07:50 +0000 (15:07 +0200)]
README: Added section about configuring, building and installing collectd.
This section contains basic information about the "--enabled-<plugin>"
configuration option as well as adopting the installation target.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Fri, 26 Oct 2007 08:50:43 +0000 (10:50 +0200)]
src/common.c: Serialize access to `strerror' if `strerror_r' doesn't exist.
Apparently this is a problem under Solaris 9..
Ronan Cadet [Fri, 26 Oct 2007 08:28:37 +0000 (10:28 +0200)]
Build system: Fixed a bug in the detection of the snmp library.
Hello,
During the creation of a rpm on Mandriva 2007.1 from tar.bz2 sources, and by
activate almost all options, I found something that seems a bug to me in the
configure file, line 33251 (concerning the snmp plugin)
Florian Forster [Thu, 25 Oct 2007 21:13:27 +0000 (23:13 +0200)]
Build system: Set the appropriate CPPFLAGS and LDFLAGS when checking for librrd and it's header.
Florian Forster [Thu, 25 Oct 2007 21:11:54 +0000 (23:11 +0200)]
rrdtool plugin: Include the `rrd.h' header file in `rrdtool.c', not `collectd.h'.
This caused an error when --with-rrdtool was used to have the header file in a
non-standard directory, because the appropriate CFLAGS were not passed to all
plugins.
Florian Forster [Thu, 25 Oct 2007 18:05:08 +0000 (20:05 +0200)]
types.db: Raise the maximum value of `ps_cputime' from 1s/1s to 16s/1s..
This should work with machines with up to 16 processors..
Florian Forster [Wed, 24 Oct 2007 18:51:51 +0000 (20:51 +0200)]
Bumped version to 4.1.3; Updated ChangeLog.
Florian Forster [Wed, 24 Oct 2007 18:49:33 +0000 (20:49 +0200)]
contrib/PerlLib/Collectd.pm: Bumped version to 4.1.3.
Sebastian Harl [Mon, 22 Oct 2007 22:05:17 +0000 (00:05 +0200)]
configure.in: Added "rrdtool" to the module summary.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Fri, 12 Oct 2007 16:35:10 +0000 (18:35 +0200)]
Beautifying some more debug messages..
Florian Forster [Fri, 12 Oct 2007 16:33:59 +0000 (18:33 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
src/rrdtool.c
Florian Forster [Fri, 12 Oct 2007 16:32:53 +0000 (18:32 +0200)]
Beautifying many debug messages..
Florian Forster [Fri, 12 Oct 2007 16:22:51 +0000 (18:22 +0200)]
rrdtool plugin: Wait for the `queue thread' to exit..
..before returning from the shutdown function.
Florian Forster [Fri, 12 Oct 2007 16:20:25 +0000 (18:20 +0200)]
network plugin: Flush the buffer in the `shutdown' function..
Florian Forster [Fri, 12 Oct 2007 16:09:29 +0000 (18:09 +0200)]
xmms plugin: Return `-1' when values could be read but are weird.
Sebastian Harl [Sun, 7 Oct 2007 13:02:36 +0000 (15:02 +0200)]
README: Improved formatting.
Indent all paragraphs by two spaces and break lines after 79 characters.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Sebastian Harl [Sun, 7 Oct 2007 13:01:50 +0000 (15:01 +0200)]
README: Added a note about collectd and chkrootkit.
chkrootkit reports collectd as a packet sniffer, which most probably is a
false positive if using the "dns" plugin.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Tue, 9 Oct 2007 16:00:35 +0000 (18:00 +0200)]
ChangeLog: Added the change to the rrdtool build stuff..
Florian Forster [Sat, 6 Oct 2007 09:10:19 +0000 (11:10 +0200)]
collectd.conf.in: Removed advanced and possibly harmfull settings..
Users were simply un-commenting everything without knowing what the settings
did, so removing possibly harmful settings seems reasonable.
Florian Forster [Thu, 4 Oct 2007 13:34:57 +0000 (15:34 +0200)]
snmp plugin: Improve the timing method, so that hosts are queried more steadily.
Florian Forster [Thu, 4 Oct 2007 13:12:50 +0000 (15:12 +0200)]
rrdtool plugin: Use the right variables when calling `rrd_update'..
*argl*
Florian Forster [Thu, 4 Oct 2007 13:09:24 +0000 (15:09 +0200)]
rrdtool plugin: Removed unused variables.
Florian Forster [Thu, 4 Oct 2007 10:26:26 +0000 (12:26 +0200)]
rrdtool plugin: Use the thread-safe `librrd_th' if available.
Florian Forster [Thu, 4 Oct 2007 08:31:00 +0000 (10:31 +0200)]
collectd-snmp(5): Added a note about the interpreted environment variables.
Florian Forster [Thu, 4 Oct 2007 06:44:41 +0000 (08:44 +0200)]
snmp plugin: Print a warning if querying a host takes longer than the confiured interval.
Matt Peterson [Sat, 29 Sep 2007 08:01:34 +0000 (10:01 +0200)]
collectd.conf(5): Fix some typos and mis-formulations.
Florian Forster [Fri, 28 Sep 2007 14:42:20 +0000 (16:42 +0200)]
Merge branch 'pull/collectd-4.1' into collectd-4.1
Florian Forster [Fri, 28 Sep 2007 14:42:13 +0000 (16:42 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Fri, 28 Sep 2007 13:55:44 +0000 (15:55 +0200)]
Bumped version to 4.1.2; Updated ChangeLog.
Florian Forster [Fri, 28 Sep 2007 13:46:46 +0000 (15:46 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
ChangeLog
configure.in
contrib/PerlLib/Collectd.pm
Florian Forster [Fri, 28 Sep 2007 13:43:41 +0000 (15:43 +0200)]
Bumped version to 4.0.9; Updated ChangeLog.
Florian Forster [Fri, 28 Sep 2007 11:45:39 +0000 (13:45 +0200)]
Merge branch 'collectd-3.11' into collectd-4.0
Conflicts:
ChangeLog
configure.in
src/wireless.c
Florian Forster [Fri, 28 Sep 2007 11:00:23 +0000 (13:00 +0200)]
Bumped version to 3.11.7; Updated ChangeLog.
Florian Forster [Fri, 28 Sep 2007 10:41:21 +0000 (12:41 +0200)]
Merge branch 'ff/collection' into collectd-4.0
Florian Forster [Fri, 28 Sep 2007 10:41:17 +0000 (12:41 +0200)]
contrib/collection.cgi: Add a vertical legend to `meta_graph_memory'.
Florian Forster [Fri, 28 Sep 2007 10:32:28 +0000 (10:32 +0000)]
contrib/collection.cgi: Fix the `charge' and `current' graphs.
Florian Forster [Fri, 28 Sep 2007 10:19:19 +0000 (12:19 +0200)]
Merge branch 'pull/collectd-4.1' into collectd-4.1
Florian Forster [Fri, 28 Sep 2007 08:26:49 +0000 (10:26 +0200)]
collectd.conf(5): Make it more clear that rrdtool's `StepSize' and `HeartBeat' should not be set.
This has caused some problems with users of the snmp plugin.
Sebastian Harl [Thu, 27 Sep 2007 16:25:25 +0000 (18:25 +0200)]
Added myplugin.c to contrib/examples/.
This is a sample/template C plugin.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Sebastian Harl [Thu, 27 Sep 2007 16:24:40 +0000 (18:24 +0200)]
Added MyPlugin.pm to contrib/examples/.
This is a sample/template Perl plugin.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Thu, 27 Sep 2007 16:12:44 +0000 (16:12 +0000)]
snmp plugin: Improved the error messages in the init code.
Florian Forster [Thu, 27 Sep 2007 15:58:41 +0000 (15:58 +0000)]
snmp plugin: Fix a segfault when a host times out but more data should be queried.
Florian Forster [Thu, 27 Sep 2007 14:13:02 +0000 (16:13 +0200)]
snmp plugin: Handle `ASN_TIMETICKS' as `counter' if it's known by the SNMP library.
Florian Forster [Thu, 27 Sep 2007 13:34:00 +0000 (15:34 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Sebastian Harl [Thu, 27 Sep 2007 10:25:14 +0000 (12:25 +0200)]
perl plugin: Fixed a possible buffer overflow in get_module_name().
A '\0' might have been written above the buffer array bounds.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Wed, 26 Sep 2007 15:18:31 +0000 (17:18 +0200)]
Merge branch 'pull/collectd-4.1' into collectd-4.1
Florian Forster [Wed, 26 Sep 2007 15:18:13 +0000 (17:18 +0200)]
build system: Fix detection of libraries when giving a directory.
Florian Forster [Sun, 23 Sep 2007 13:14:36 +0000 (15:14 +0200)]
Merge branch 'pull/collectd-4.1' into collectd-4.1
Florian Forster [Tue, 18 Sep 2007 18:51:38 +0000 (20:51 +0200)]
build system: Fixed the improved detection of the Net-SNMP library.
Florian Forster [Tue, 18 Sep 2007 11:45:36 +0000 (13:45 +0200)]
build system: Improve the detection of the Net-SNMP library.
Florian Forster [Sat, 15 Sep 2007 10:30:15 +0000 (12:30 +0200)]
netlink plugin: Don't fail if `IFLA_STATS' doesn't exist for an interface.
Hopefully this fixes problems on my WRT ;)
Florian Forster [Sat, 15 Sep 2007 09:58:52 +0000 (11:58 +0200)]
wireless plugin: Correct the handling of cards returning signal and noise quality as percentage.
Florian Forster [Sat, 15 Sep 2007 09:01:40 +0000 (11:01 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Florian Forster [Sat, 15 Sep 2007 09:01:19 +0000 (11:01 +0200)]
Merge branch 'collectd-3.11' into collectd-4.0
Conflicts:
src/apcups.c
nothing added to commit but untracked files present (use "git add" to track)
Florian Forster [Sat, 15 Sep 2007 08:58:53 +0000 (10:58 +0200)]
apcups plugin: Warn about the irritating name `apcups_charge_pct'.
Florian Forster [Sat, 15 Sep 2007 08:48:25 +0000 (10:48 +0200)]
netlink plugin: Fix build issues under Debian Sarge
or generally older Linux versions.
Florian Forster [Fri, 14 Sep 2007 07:15:06 +0000 (09:15 +0200)]
Merge branch 'ff/apcups' into collectd-4.0
Florian Forster [Fri, 14 Sep 2007 07:11:04 +0000 (09:11 +0200)]
Bumped the version to 4.1.1
Florian Forster [Fri, 14 Sep 2007 06:32:37 +0000 (08:32 +0200)]
build system: Fix yet another issue with the detection of libupsclient.
Florian Forster [Thu, 13 Sep 2007 08:01:23 +0000 (10:01 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
ChangeLog
Florian Forster [Thu, 13 Sep 2007 07:56:04 +0000 (09:56 +0200)]
apcups plugin: Fix reporting of the `load percent' data.
Florian Forster [Wed, 12 Sep 2007 12:57:43 +0000 (14:57 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
contrib/PerlLib/Collectd.pm
nothing added to commit but untracked files present (use "git add" to track)
Florian Forster [Wed, 12 Sep 2007 12:45:30 +0000 (14:45 +0200)]
contrib/PerlLib/Collectd.pm: Bumbed the version to 4.0.8.
Florian Forster [Wed, 12 Sep 2007 09:15:54 +0000 (11:15 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
ChangeLog
configure.in
Florian Forster [Wed, 12 Sep 2007 09:14:33 +0000 (11:14 +0200)]
Bumped version to 4.0.8; updated ChangeLog.
Sebastian Harl [Wed, 12 Sep 2007 08:55:35 +0000 (10:55 +0200)]
plugin.c: Print lt_dlopen() error messages to STDERR as well.
This makes sure the user will get the message on the terminal in any case.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Sebastian Harl [Wed, 12 Sep 2007 08:54:57 +0000 (10:54 +0200)]
Removed some legacy calls to DEBUG().
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Wed, 12 Sep 2007 07:14:45 +0000 (09:14 +0200)]
rrdtool plugin: Use `-b' (begin) when creating rrd-files.
When receiving data from a host that has a clock that lacks behind the servers
clock, the newly created rrd-files had a timestamp that was ten seconds in the
past from the server's point of view. If the client was, for example, 10:00
minutes late, there would therefore be 9:50 minutes of invalid data which cause
warnings, empty graphs and overall missery. This commit changes this behavior
to not use the default `begin' time but set it explicitely based on the
client's time.
Florian Forster [Tue, 11 Sep 2007 09:50:51 +0000 (11:50 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Florian Forster [Tue, 11 Sep 2007 09:50:43 +0000 (11:50 +0200)]
ChangeLog: Documented the fix in the apcups plugin.
Florian Forster [Tue, 11 Sep 2007 09:46:07 +0000 (11:46 +0200)]
Merge branch 'uni/collectd-4.1' into collectd-4.1
Florian Forster [Tue, 11 Sep 2007 09:45:50 +0000 (11:45 +0200)]
Merge branch 'uni/collectd-4.0' into collectd-4.0
Florian Forster [Tue, 11 Sep 2007 09:14:56 +0000 (11:14 +0200)]
apcups plugin: Fix the types used in the plugin.
They still had an `apcups_' prefix which isn't legal anymore.
Florian Forster [Tue, 11 Sep 2007 09:11:25 +0000 (11:11 +0200)]
collectd: Make `mkdir' error messages more identifiable.
Florian Forster [Tue, 11 Sep 2007 09:09:32 +0000 (11:09 +0200)]
netlink plugin: Fix an error-message.
Florian Forster [Mon, 10 Sep 2007 08:49:51 +0000 (10:49 +0200)]
ChangeLog: Documented the changes since 4.1.0.
Florian Forster [Mon, 10 Sep 2007 08:43:49 +0000 (10:43 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
ChangeLog
Florian Forster [Mon, 10 Sep 2007 08:43:19 +0000 (10:43 +0200)]
ChangeLog: Fix a merge bug.
Florian Forster [Mon, 10 Sep 2007 08:41:39 +0000 (10:41 +0200)]
ChangeLog: Added a note about the improved `sstrerror' function.
Florian Forster [Wed, 5 Sep 2007 07:30:01 +0000 (09:30 +0200)]
contrib/collection.cgi: Fix a bug in the `meta_graph_generic_stack' function.
Also add a meta-graph-handler for if_[rt]x_errors.
Florian Forster [Tue, 4 Sep 2007 21:46:12 +0000 (23:46 +0200)]
Merge branch 'pull/collectd-4.1' into collectd-4.1
Florian Forster [Tue, 4 Sep 2007 21:44:50 +0000 (23:44 +0200)]
build system: Include <adm/types.h> when checking for `libnetlink.h'.
Florian Forster [Tue, 4 Sep 2007 08:32:13 +0000 (10:32 +0200)]
netlink plugin: Use the defines to determine where the `libnetlink.h' is.
Florian Forster [Tue, 4 Sep 2007 08:31:38 +0000 (10:31 +0200)]
build system: Check for libnetlink.h in more than one directory.
And some minor cleanups..
Florian Forster [Tue, 4 Sep 2007 08:14:22 +0000 (10:14 +0200)]
build system: Some cosmetic fixes for the libupsclient.
Florian Forster [Mon, 3 Sep 2007 14:00:51 +0000 (16:00 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Florian Forster [Mon, 3 Sep 2007 14:00:23 +0000 (16:00 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Mon, 3 Sep 2007 14:00:11 +0000 (16:00 +0200)]
src/plugin.c: plugin_dispatch_values: Include the interval in the debugging output.
Florian Forster [Mon, 3 Sep 2007 13:59:08 +0000 (15:59 +0200)]
exec plugin: Set the real group, effective group, and real and effective user.
In that order. The manpage and the config template have been updated.
Florian Forster [Fri, 31 Aug 2007 09:52:31 +0000 (11:52 +0200)]
exec plugin: Call `setgid' first so argitary groups can be configured.
Florian Forster [Mon, 3 Sep 2007 12:44:53 +0000 (14:44 +0200)]
sstrerror: Be even more cautios with the return value of `strerror_r'..
I don't trust this GNU implementation one bit.. ;)
Florian Forster [Sun, 2 Sep 2007 17:43:03 +0000 (19:43 +0200)]
contrib/collection.cgi: Display MySQL traffic as bits/s, not bytes/s.
Florian Forster [Sun, 2 Sep 2007 17:28:25 +0000 (19:28 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Florian Forster [Sun, 2 Sep 2007 17:28:09 +0000 (19:28 +0200)]
contrib/collection.cgi: Added meta graph handlers for nfs_procedure, ps_state, swap, mysql_commands, and mysql_handler.
Florian Forster [Sun, 2 Sep 2007 16:38:47 +0000 (18:38 +0200)]
src/common.c: Copy the error-string to the buffer - no matter which implementation is used.
Ulf Zimmermann [Sun, 2 Sep 2007 16:22:24 +0000 (18:22 +0200)]
ChangeLog: Fix a typo.
Florian Forster [Sun, 2 Sep 2007 16:15:36 +0000 (18:15 +0200)]
Merge branch 'collectd-4.0' into collectd-4.1
Conflicts:
contrib/collection.cgi
Sebastian Harl [Sun, 2 Sep 2007 16:07:43 +0000 (18:07 +0200)]
README: Added libnetlink, libnetsnmp and libxmms prerequisites.
Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Florian Forster [Sun, 2 Sep 2007 16:01:05 +0000 (18:01 +0200)]
contrib/collection.cgi: Don't show all the plugins on the host's page.
Waiting for so many graphs to load is no fun. You _have_ to specify the plugins
you're interested in now.