collectd.git
6 years agowrite_gcm plugin: New plugin for Google Cloud Monitoring.
Florian Forster [Sun, 21 Jun 2015 15:59:46 +0000 (17:59 +0200)]
write_gcm plugin: New plugin for Google Cloud Monitoring.

6 years agosrc/utils_format_gcm.[ch]: Implementation of the Stackdriver Monitoring API v3.
Florian Forster [Sat, 20 Jun 2015 13:54:54 +0000 (15:54 +0200)]
src/utils_format_gcm.[ch]: Implementation of the Stackdriver Monitoring API v3.

Docs: https://cloud.google.com/monitoring/api/ref_v3/rest/

6 years agosrc/utils_gce.[ch]: Add utility for Google Compute Engine.
Florian Forster [Sat, 20 Jun 2015 08:02:27 +0000 (10:02 +0200)]
src/utils_gce.[ch]: Add utility for Google Compute Engine.

These functions allow to autodetect some settings when running on
Google Compute Engine (GCE), for example the Project ID, using the
metadata service.

6 years agosrc/utils_oauth.[ch]: Add utility for OAuth authentication.
Florian Forster [Sat, 20 Jun 2015 06:53:24 +0000 (08:53 +0200)]
src/utils_oauth.[ch]: Add utility for OAuth authentication.

6 years agoMerge pull request #2924 from kevin-laatz-intel/dpdk_path_fix
Pavel Rochnyak [Mon, 24 Sep 2018 16:43:52 +0000 (23:43 +0700)]
Merge pull request #2924 from kevin-laatz-intel/dpdk_path_fix

dpdk: fix dpdk runtime config file path

6 years agodpdk: fix dpdk runtime config file path
Kevin Laatz [Tue, 11 Sep 2018 10:01:27 +0000 (11:01 +0100)]
dpdk: fix dpdk runtime config file path

The config path was changed in DPDK by the commit 'adf1d86  eal: move
runtime config file to new location’. As a result, the dpdk plugins won't
be able to link to the DPDK primary application after this change.

This commit adds a compile time check for the DPDK verison being used and
sets the DPDK runtime config file location accordingly.

Suggested-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
6 years agoMerge pull request #2922 from octo/rootfs_prefix
Marc Fournier [Mon, 10 Sep 2018 08:56:33 +0000 (09:56 +0100)]
Merge pull request #2922 from octo/rootfs_prefix

contrib/docker/rootfs_prefix: Add MIT license header.

6 years agocontrib/docker/rootfs_prefix: Add MIT license header.
Florian Forster [Fri, 7 Sep 2018 08:03:26 +0000 (10:03 +0200)]
contrib/docker/rootfs_prefix: Add MIT license header.

On 2018-09-06 Marc Fournier wrote:

Hello Florian !

Yes, sure, sorry to have omitted this! I'm fine with MIT. Glad this is
useful to others :-)

+1 for adding a default "fallback" licence to COPYING. In case this has
unexpected implications, let's just add the MIT licence to root_prefix/* so
Baruch can move forward with his project.

Cheers,
Marc

6 years agoMerge branch 'collectd-5.8'
Ruben Kerkhof [Wed, 5 Sep 2018 06:40:25 +0000 (08:40 +0200)]
Merge branch 'collectd-5.8'

6 years agoMerge pull request #2919 from rubenk/virt-fix-segfault
Ruben Kerkhof [Wed, 5 Sep 2018 06:38:09 +0000 (08:38 +0200)]
Merge pull request #2919 from rubenk/virt-fix-segfault

Fix segfault in libvirt plugin

6 years agovirt plugin: fix segfault on error path
Ruben Kerkhof [Tue, 4 Sep 2018 10:48:12 +0000 (12:48 +0200)]
virt plugin: fix segfault on error path

The libvirt plugin refreshes its list of domains every RefreshInterval
seconds. If a domain crashes after getting the list, getting the stats
for its block devices returns an error. We then try to call
virDomainGetName on an invalid pointer. Fix this.

6 years agofix c_avl_iterator_prev (#2917)
volth [Sun, 2 Sep 2018 12:35:16 +0000 (12:35 +0000)]
fix c_avl_iterator_prev (#2917)

utils_avltree: fix 'c_avl_iterator_prev()' and cover it by tests

6 years agoMerge pull request #2913 from StarryInternet/sensors-humidity
Pavel Rochnyak [Sat, 1 Sep 2018 16:06:12 +0000 (22:06 +0600)]
Merge pull request #2913 from StarryInternet/sensors-humidity

Add support for humidity in sensors plugin

6 years agoadd humidity for lm_sensors version >= 0x431
Sarah Fischmann [Fri, 31 Aug 2018 14:03:00 +0000 (10:03 -0400)]
add humidity for lm_sensors version >= 0x431

6 years agoAuto-Merge pull request #2916 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Thu, 30 Aug 2018 06:48:03 +0000 (08:48 +0200)]
Auto-Merge pull request #2916 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

6 years agonfs: Fix number of fields for NFSv4
Jan-Philipp Litza [Wed, 29 Aug 2018 20:46:49 +0000 (22:46 +0200)]
nfs: Fix number of fields for NFSv4

The previous buffer of 64 fields was too short for the current number of
72+2 fields in NFS 4.2, causing the message

  nfs plugin: Unexpected number of fields for NFSv4 server statistics: 62.

This change, originally proposed in [1], fixes that issue in a
forward-compatible manner by reusing the already known number of fields
from the static arrays.

[1]: https://github.com/collectd/collectd/issues/2076#issuecomment-350466628

6 years agoMerge pull request #2915 from jplitza/fix-2076
Pavel Rochnyak [Thu, 30 Aug 2018 05:14:38 +0000 (11:14 +0600)]
Merge pull request #2915 from jplitza/fix-2076

nfs: Fix number of fields for NFSv4

6 years agonfs: Fix number of fields for NFSv4
Jan-Philipp Litza [Wed, 29 Aug 2018 20:46:49 +0000 (22:46 +0200)]
nfs: Fix number of fields for NFSv4

The previous buffer of 64 fields was too short for the current number of
72+2 fields in NFS 4.2, causing the message

  nfs plugin: Unexpected number of fields for NFSv4 server statistics: 62.

This change, originally proposed in [1], fixes that issue in a
forward-compatible manner by reusing the already known number of fields
from the static arrays.

[1]: https://github.com/collectd/collectd/issues/2076#issuecomment-350466628

6 years agoadd humidity for lm_sensors version >= 0x402
Sarah Fischmann [Wed, 29 Aug 2018 17:00:40 +0000 (13:00 -0400)]
add humidity for lm_sensors version >= 0x402

6 years agoadd support for humidity in sensors plugin
Sarah Fischmann [Wed, 29 Aug 2018 14:18:51 +0000 (10:18 -0400)]
add support for humidity in sensors plugin

6 years agoFix Solaris builds
Pavel Rochnyack [Wed, 29 Aug 2018 14:23:28 +0000 (21:23 +0700)]
Fix Solaris builds

Trying to fix error:

./build.sh: syntax error at line 78: `TOP_SRCDIR=$' unexpected

6 years agoMerge pull request #2864 from jimis/libxml2_configure_fix
Ruben Kerkhof [Wed, 29 Aug 2018 07:55:27 +0000 (09:55 +0200)]
Merge pull request #2864 from jimis/libxml2_configure_fix

Add --with-libxml2 option to configure.

6 years agoMerge pull request #2907 from Stackdriver/pkg-fix
Pavel Rochnyak [Tue, 28 Aug 2018 15:31:01 +0000 (21:31 +0600)]
Merge pull request #2907 from Stackdriver/pkg-fix

Fix warning that pkgdatadir and pkglibdir were previously defined.

6 years agoAdd --with-libxml2 option to configure.
Dimitrios Apostolou [Wed, 18 Jul 2018 22:35:34 +0000 (00:35 +0200)]
Add --with-libxml2 option to configure.

It's now valid to disable building with libxml2, using --without-libxml2. It's
also possible to set a custom prefix --with-libxml2=/custom/path.

6 years agoMerge pull request #2896 from mlichvar/chrony
Pavel Rochnyak [Fri, 24 Aug 2018 09:23:14 +0000 (15:23 +0600)]
Merge pull request #2896 from mlichvar/chrony

chrony: Ignore late responses

6 years agochrony: Ignore late responses
Miroslav Lichvar [Wed, 15 Aug 2018 10:21:36 +0000 (12:21 +0200)]
chrony: Ignore late responses

If a response from chronyd was not received before the timeout (e.g. on a
busy system), it would wait in the receive queue and be processed as a
response of the next request. It would fail the sequence check and cause
the plugin to return with an error. The latest response would wait in
the receive queue and this would repeat forever.

Flush the receive queue before sending a new batch of requests to
prevent this situation from happening.

6 years agoFix warning that pkgdatadir and pkglibdir were previously defined.
campbellsean@google.com [Thu, 23 Aug 2018 14:19:46 +0000 (10:19 -0400)]
Fix warning that pkgdatadir and pkglibdir were previously defined.

6 years agoMerge pull request #2904 from rpv-tomsk/redis-connect-unixsock
Pavel Rochnyak [Thu, 23 Aug 2018 08:12:15 +0000 (14:12 +0600)]
Merge pull request #2904 from rpv-tomsk/redis-connect-unixsock

redis plugin: Added option for connecting via UNIX socket

6 years agoredis plugin: Added option for connecting via UNIX socket
Pavel Rochnyack [Thu, 23 Aug 2018 07:35:19 +0000 (14:35 +0700)]
redis plugin: Added option for connecting via UNIX socket

6 years agoredis plugin: Fix coredump when stopping Collectd with inaccessible Redis server
Pavel Rochnyack [Thu, 23 Aug 2018 07:21:44 +0000 (14:21 +0700)]
redis plugin: Fix coredump when stopping Collectd with inaccessible Redis server

6 years agoMinor codestyle fix
Pavel Rochnyack [Fri, 17 Aug 2018 11:53:13 +0000 (18:53 +0700)]
Minor codestyle fix

6 years agoMerge pull request #2898 from romanek-adam/bugfix/memory-leak-in-plugin-dispatch...
Pavel Rochnyak [Fri, 17 Aug 2018 11:51:13 +0000 (17:51 +0600)]
Merge pull request #2898 from romanek-adam/bugfix/memory-leak-in-plugin-dispatch-multivalue

daemon: make plugin_dispatch_multivalue() obey write queue limits

6 years agodaemon: make plugin_dispatch_multivalue() obey write queue limits (#2897)
Adam Romanek [Fri, 17 Aug 2018 09:24:22 +0000 (11:24 +0200)]
daemon: make plugin_dispatch_multivalue() obey write queue limits (#2897)

6 years agodbi plugin: Removed excessive error reporting
Pavel Rochnyack [Sat, 11 Aug 2018 19:47:15 +0000 (02:47 +0700)]
dbi plugin: Removed excessive error reporting

Latest libdbi code sets BADIDX error when no more rows is
in 'dbi_result_next_row()' (similar to 'dbi_result_prev_row()'
and to match library documentation).

There is confusing errors in Collectd logs due to this change.
Added a 'dbi_result_has_next_row()' check to solve.

Closes: #2894

6 years agoMerge pull request #2882 from Stackdriver/gnulib
Ruben Kerkhof [Wed, 1 Aug 2018 08:22:03 +0000 (10:22 +0200)]
Merge pull request #2882 from Stackdriver/gnulib

Add GNULIB_DIR to LDFLAGS in configure.ac on Windows

6 years agoMerge pull request #2885 from Stackdriver/plugins
Ruben Kerkhof [Wed, 1 Aug 2018 08:19:15 +0000 (10:19 +0200)]
Merge pull request #2885 from Stackdriver/plugins

Enable additional plugins on Windows.

6 years agoEnable additional plugins on Windows.
U-COLLECTD-WIN201\campbellsean [Tue, 31 Jul 2018 18:56:26 +0000 (18:56 +0000)]
Enable additional plugins on Windows.

6 years agoAdd GNULIB_DIR to LDFLAGS in configure.ac on Windows
campbellsean@google.com [Mon, 30 Jul 2018 17:12:16 +0000 (13:12 -0400)]
Add GNULIB_DIR to LDFLAGS in configure.ac on Windows

6 years agoBase port to Windows (#2810)
Sean Campbell [Fri, 27 Jul 2018 13:21:03 +0000 (09:21 -0400)]
Base port to Windows (#2810)

* Update configure.ac / Makefile.am to build for Windows using Cygwin.
* Update build.sh to build for Windows.
* Base port of the daemon.
* Include gnulib as a submodule.

6 years agoconfigure.ac: Split libxml2 and libvirt mix
Pavel Rochnyack [Thu, 26 Jul 2018 05:42:26 +0000 (12:42 +0700)]
configure.ac: Split libxml2 and libvirt mix

6 years agoMerge pull request #2878 from nhuff/freebsd_pending_io
Pavel Rochnyak [Thu, 26 Jul 2018 04:25:29 +0000 (11:25 +0700)]
Merge pull request #2878 from nhuff/freebsd_pending_io

Report number of in progess disk IO requests on FreeBSD.

6 years agoFix formating
Nathan Huff (Admin) [Wed, 25 Jul 2018 20:16:38 +0000 (15:16 -0500)]
Fix formating

6 years agoReport number of in progess disk IO requests on FreeBSD.
Nathan Huff (Admin) [Wed, 25 Jul 2018 20:10:05 +0000 (15:10 -0500)]
Report number of in progess disk IO requests on FreeBSD.

6 years agoRemoved parentheses around return arguments
Pavel Rochnyack [Wed, 25 Jul 2018 17:42:39 +0000 (00:42 +0700)]
Removed parentheses around return arguments

6 years agoamqp1: clang-format
Pavel Rochnyack [Wed, 25 Jul 2018 17:22:26 +0000 (00:22 +0700)]
amqp1: clang-format

6 years agoMerge pull request #2876 from abays/fix_amqp1_typo
Pavel Rochnyak [Wed, 25 Jul 2018 17:17:28 +0000 (00:17 +0700)]
Merge pull request #2876 from abays/fix_amqp1_typo

Fix typo in amqp1 JSON format error message

6 years agoFix typo in amqp1 JSON format error message
Andrew Bays [Wed, 25 Jul 2018 14:24:49 +0000 (10:24 -0400)]
Fix typo in amqp1 JSON format error message

6 years agoprocesses: Fix conversion of 'delay_rate' values. Now they really have seconds per...
Pavel Rochnyack [Sun, 22 Jul 2018 05:43:28 +0000 (12:43 +0700)]
processes: Fix conversion of 'delay_rate' values. Now they really have seconds per second unit.

6 years agoutils_latency: Use plugin name from context to do error reporting
Pavel Rochnyack [Fri, 20 Jul 2018 15:06:36 +0000 (22:06 +0700)]
utils_latency: Use plugin name from context to do error reporting

6 years agoutils_tail: Added plugin name to error reporting
Pavel Rochnyack [Fri, 20 Jul 2018 14:58:39 +0000 (21:58 +0700)]
utils_tail: Added plugin name to error reporting

6 years agotail_csv: Fix typo in Synopsis
Pavel Rochnyack [Wed, 18 Jul 2018 08:16:25 +0000 (15:16 +0700)]
tail_csv: Fix typo in Synopsis

6 years agoMerge branch 'collectd-5.8' into collectd-master
Pavel Rochnyack [Tue, 10 Jul 2018 12:05:59 +0000 (19:05 +0700)]
Merge branch 'collectd-5.8' into collectd-master

6 years agoMerge pull request #2854 from rpv-tomsk/collectd-master
Pavel Rochnyak [Tue, 10 Jul 2018 12:04:47 +0000 (19:04 +0700)]
Merge pull request #2854 from rpv-tomsk/collectd-master

routeros: Use MAC-address when Radio-name is missing

6 years agoFix parsing option for avoiding making BaseDir
Mariusz Bialonczyk [Tue, 10 Jul 2018 09:47:53 +0000 (11:47 +0200)]
Fix parsing option for avoiding making BaseDir

Parsing is broken since:
386ecab4 Reading configuration file is now done outside main().
So after mentioned commit we've got:

collectd: invalid option -- 'B'

This commit fixes this.

6 years agoMerge pull request #2856 from manio/master
Pavel Rochnyak [Tue, 10 Jul 2018 10:29:02 +0000 (17:29 +0700)]
Merge pull request #2856 from manio/master

Fix parsing option for avoiding making BaseDir

6 years agoFix parsing option for avoiding making BaseDir
Mariusz Bialonczyk [Tue, 10 Jul 2018 09:47:53 +0000 (11:47 +0200)]
Fix parsing option for avoiding making BaseDir

Parsing is broken since:
386ecab4 Reading configuration file is now done outside main().
So after mentioned commit we've got:

collectd: invalid option -- 'B'

This commit fixes this.

6 years agorouteros: Use MAC-address when Radio-name is missing
Pavel Rochnyack [Mon, 9 Jul 2018 07:51:33 +0000 (14:51 +0700)]
routeros: Use MAC-address when Radio-name is missing

6 years agorouteros: Fix codestyle of latest change
Pavel Rochnyack [Sun, 8 Jul 2018 14:06:36 +0000 (21:06 +0700)]
routeros: Fix codestyle of latest change

6 years agoMerge branch 'collectd-5.8' into master
Pavel Rochnyack [Sun, 8 Jul 2018 13:11:28 +0000 (20:11 +0700)]
Merge branch 'collectd-5.8' into master

6 years agoMerge pull request #2851 from rpv-tomsk/external-manio-master
Pavel Rochnyak [Sun, 8 Jul 2018 12:47:53 +0000 (19:47 +0700)]
Merge pull request #2851 from rpv-tomsk/external-manio-master

routeros: Add support for temperature and voltage data, fixed typo in 'sectors_written' metric name

6 years agorouteros: Fixed typo in 'sectors_written' metric name
Pavel Rochnyack [Sun, 8 Jul 2018 08:25:51 +0000 (15:25 +0700)]
routeros: Fixed typo in 'sectors_written' metric name

6 years agorouteros: Use 'voltage' and 'temperature' as reported types
Pavel Rochnyack [Sun, 8 Jul 2018 08:24:07 +0000 (15:24 +0700)]
routeros: Use 'voltage' and 'temperature' as reported types

6 years agorouteros: Fixed check of 'Collect*' options
Pavel Rochnyack [Sun, 8 Jul 2018 06:19:01 +0000 (13:19 +0700)]
routeros: Fixed check of 'Collect*' options

6 years agorouteros: Added conditionals around collect_health code
Pavel Rochnyack [Sun, 8 Jul 2018 06:17:11 +0000 (13:17 +0700)]
routeros: Added conditionals around collect_health code

6 years agodoc: add information about routeros CollectHealth option
Mariusz Bialonczyk [Fri, 25 Sep 2015 09:50:29 +0000 (11:50 +0200)]
doc: add information about routeros CollectHealth option

6 years agorouteros: add support for collecting health data
Mariusz Bialonczyk [Fri, 25 Sep 2015 09:44:37 +0000 (11:44 +0200)]
routeros: add support for collecting health data

It includes the voltage and temperature data on supported hardware.

6 years agoAuto-Merge pull request #2850 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Sat, 7 Jul 2018 15:31:54 +0000 (17:31 +0200)]
Auto-Merge pull request #2850 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

6 years agowrite_prometheus: Added MHD_USE_INTERNAL_POLLING_THREAD flag
Pavel Rochnyack [Sat, 7 Jul 2018 14:38:07 +0000 (21:38 +0700)]
write_prometheus: Added MHD_USE_INTERNAL_POLLING_THREAD flag

Since 0.9.53, libmicrohttpd requires explicit setting of this flag.

Closes: #2849

6 years agoturbostat plugin: show error details
Pavel Rochnyack [Thu, 5 Jul 2018 12:27:15 +0000 (19:27 +0700)]
turbostat plugin: show error details

6 years agoMerge pull request #2733 from elfiesmelfie/feat_pcie_aer
Pavel Rochnyak [Thu, 5 Jul 2018 09:03:17 +0000 (16:03 +0700)]
Merge pull request #2733 from elfiesmelfie/feat_pcie_aer

New plugin to read PCIe errors

6 years agopcie_errors: Remove 'pcie_error' from types.db
Pavel Rochnyack [Thu, 5 Jul 2018 08:02:35 +0000 (15:02 +0700)]
pcie_errors: Remove 'pcie_error' from types.db

Plugin does not send metrics, type is not needed to send notifications.

6 years agoMerge pull request #2631 from DanCech/tagged-carbon
Pavel Rochnyak [Thu, 5 Jul 2018 03:41:18 +0000 (10:41 +0700)]
Merge pull request #2631 from DanCech/tagged-carbon

Graphite 1.1+ tag support

6 years agoMerge pull request #2847 from rpv-tomsk/collectd-master
Pavel Rochnyak [Thu, 5 Jul 2018 03:38:33 +0000 (10:38 +0700)]
Merge pull request #2847 from rpv-tomsk/collectd-master

tree-wide: Use interval value from plugin context, do not set 'vl->interval' in plugins more.

6 years agoMerge pull request #2845 from rpv-tomsk/tmpfix
Pavel Rochnyak [Thu, 5 Jul 2018 03:37:36 +0000 (10:37 +0700)]
Merge pull request #2845 from rpv-tomsk/tmpfix

redis plugin: Remove `operations_per_second` metric.

6 years agowrite_kafka: Added Graphite tag support
Pavel Rochnyack [Wed, 4 Jul 2018 13:09:26 +0000 (20:09 +0700)]
write_kafka: Added Graphite tag support

6 years agowrite_graphite: Documented 'UseTags' option
Pavel Rochnyack [Wed, 4 Jul 2018 12:52:04 +0000 (19:52 +0700)]
write_graphite: Documented 'UseTags' option

6 years agoutils_format_graphite: add tests for graphite tag flag
Jacob Lisi [Tue, 7 Nov 2017 21:29:38 +0000 (16:29 -0500)]
utils_format_graphite: add tests for graphite tag flag

6 years agoutils_format_graphite: Add graphite tag support
Dan Cech [Tue, 31 Oct 2017 16:40:43 +0000 (12:40 -0400)]
utils_format_graphite: Add graphite tag support

6 years agocurl plugin: Added 'Interval' option
Pavel Rochnyack [Wed, 4 Jul 2018 07:47:18 +0000 (14:47 +0700)]
curl plugin: Added 'Interval' option

6 years agocurl_xml plugin: Added 'Interval' option
Pavel Rochnyack [Wed, 4 Jul 2018 07:20:54 +0000 (14:20 +0700)]
curl_xml plugin: Added 'Interval' option

6 years agocore: Added plugin name to (some) error reporting
Pavel Rochnyack [Wed, 4 Jul 2018 07:13:36 +0000 (14:13 +0700)]
core: Added plugin name to (some) error reporting

6 years agotree-wide: Use interval value from plugin context
Pavel Rochnyack [Wed, 4 Jul 2018 06:17:21 +0000 (13:17 +0700)]
tree-wide: Use interval value from plugin context

6 years agocore: Cleanup in vl->interval assignment
Pavel Rochnyack [Wed, 4 Jul 2018 06:15:48 +0000 (13:15 +0700)]
core: Cleanup in vl->interval assignment

6 years agocore: Set plugin name in context when plugin is autoloaded
Pavel Rochnyack [Wed, 4 Jul 2018 05:43:10 +0000 (12:43 +0700)]
core: Set plugin name in context when plugin is autoloaded

6 years agocore: Set 'interval' value in plugin context to match read callback interval
Pavel Rochnyack [Wed, 4 Jul 2018 05:00:02 +0000 (12:00 +0700)]
core: Set 'interval' value in plugin context to match read callback interval

6 years agopostgresql: Set correct value to 'interval' query parameter (bugfix)
Pavel Rochnyack [Wed, 4 Jul 2018 04:33:04 +0000 (11:33 +0700)]
postgresql: Set correct value to 'interval' query parameter (bugfix)

6 years agoutils_tail_match: Updated formatting
Pavel Rochnyack [Wed, 4 Jul 2018 03:46:09 +0000 (10:46 +0700)]
utils_tail_match: Updated formatting

6 years agoutils_tail_match: Removed unused variables
Pavel Rochnyack [Wed, 4 Jul 2018 03:43:17 +0000 (10:43 +0700)]
utils_tail_match: Removed unused variables

6 years agoutils_tail_match: Fix formatting
Pavel Rochnyack [Tue, 3 Jul 2018 11:48:02 +0000 (18:48 +0700)]
utils_tail_match: Fix formatting

6 years agoMerge pull request #2840 from elfiesmelfie/fix_deprecated_func
Pavel Rochnyak [Mon, 2 Jul 2018 15:27:25 +0000 (22:27 +0700)]
Merge pull request #2840 from elfiesmelfie/fix_deprecated_func

dpdk: fix deprecation warning

6 years agoMerge branch 'master' into fix_deprecated_func
kevin-laatz-intel [Mon, 2 Jul 2018 14:51:04 +0000 (15:51 +0100)]
Merge branch 'master' into fix_deprecated_func

6 years agostatsd: Improve error reporting
Pavel Rochnyack [Mon, 2 Jul 2018 06:59:53 +0000 (13:59 +0700)]
statsd: Improve error reporting

6 years agoredis plugin: Remove `operations_per_second` metric.
Pavel Rochnyack [Sun, 1 Jul 2018 06:52:31 +0000 (13:52 +0700)]
redis plugin: Remove `operations_per_second` metric.

The `operations_per_second` metric removed as duplicate of other metric and as
it has wrong value also. Collectd should not report wrong values.

Metric `operations_per_second` is based on `instantaneous_ops_per_sec` field
from Redis `INFO` output. That field is calculated based on buffer of 16 values,
updated from `stat_numcommands` once per 100ms.
So, `instantaneous_ops_per_sec` value has average only for last 1.6 seconds.
While Collectd poll period is 10 seconds, statistics for 8.4 seconds is lost.

Herewith, Collectd already has correct metric `total_operations`, based on
`total_commands_processed` field taken from same `stat_numcommands` internally
in Redis. Value of this metric should be used instead of removed metric.

6 years agoMerge pull request #2844 from elfiesmelfie/fix_snmp_agent
Pavel Rochnyak [Fri, 29 Jun 2018 12:56:59 +0000 (19:56 +0700)]
Merge pull request #2844 from elfiesmelfie/fix_snmp_agent

SNMP Agent plugin: Fix coverity scan issues #2814

6 years agodpdk: fix clang issue for deprecated function patch
Kevin Laatz [Wed, 27 Jun 2018 13:10:05 +0000 (14:10 +0100)]
dpdk: fix clang issue for deprecated function patch

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
6 years agocleanup: Remove excessive error reporting
Pavel Rochnyack [Wed, 27 Jun 2018 11:55:47 +0000 (18:55 +0700)]
cleanup: Remove excessive error reporting

These messages already reported in parse_value()

6 years agoAuto-Merge pull request #2838 from rpv-tomsk/collectd-master
collectd bot [Wed, 27 Jun 2018 05:54:35 +0000 (07:54 +0200)]
Auto-Merge pull request #2838 from rpv-tomsk/collectd-master

Automatically merged due to "Automerge" label

6 years agoMerge pull request #2831 from elieyal/patch-3
Pavel Rochnyak [Wed, 27 Jun 2018 05:16:49 +0000 (12:16 +0700)]
Merge pull request #2831 from elieyal/patch-3

network plugin: Add BindAddress option

6 years agoMerge pull request #2834 from rpv-tomsk/plugin-context-master-2
Pavel Rochnyak [Wed, 27 Jun 2018 04:50:04 +0000 (11:50 +0700)]
Merge pull request #2834 from rpv-tomsk/plugin-context-master-2

notify_email: Include all notification parameters into email

6 years agoredis plugin: Report keyspace hitratio
Pavel Rochnyack [Wed, 27 Jun 2018 04:43:52 +0000 (11:43 +0700)]
redis plugin: Report keyspace hitratio