Florian Forster [Tue, 5 Dec 2017 11:15:00 +0000 (12:15 +0100)]
grpc plugin: Implement the VerifyPeer option for servers.
collectd bot [Wed, 29 Nov 2017 12:32:30 +0000 (13:32 +0100)]
Auto-Merge pull request #2584 from octo/coverity
Automatically merged due to "Automerge" label
Florian Forster [Wed, 29 Nov 2017 07:20:38 +0000 (08:20 +0100)]
.travis.yml: Try to work around travis-ci/travis-ci#1975.
Florian Forster [Mon, 27 Nov 2017 21:35:21 +0000 (22:35 +0100)]
.travis.yml: Import list of dependencies from collectd-ci.
Florian Forster [Mon, 27 Nov 2017 21:07:33 +0000 (22:07 +0100)]
.travis.yml: Add coverity addon.
Florian Forster [Tue, 21 Nov 2017 09:39:44 +0000 (10:39 +0100)]
Merge branch 'collectd-5.8'
Florian Forster [Tue, 21 Nov 2017 09:38:52 +0000 (10:38 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
collectd bot [Mon, 20 Nov 2017 14:10:07 +0000 (15:10 +0100)]
Auto-Merge pull request #2565 from octo/cid/37966
Automatically merged due to "Automerge" label
Florian Forster [Mon, 20 Nov 2017 13:26:41 +0000 (14:26 +0100)]
table plugin: Refactor realloc() calls.
Increase the number of elements in the successful path only, instead of
increasing it immediately and decreasing on error.
Florian Forster [Mon, 20 Nov 2017 13:19:46 +0000 (14:19 +0100)]
table plugin: Assert that result_num is zero when result is NULL.
The Coverity check gets confused by the `tbl->results == NULL` check:
due to the check, is assumes that tbl->results *may* be NULL. It then
discovers the dereference in tbl_clear() without realizing that "result"
and "result_num" are linked and that situation can't happen. This
assertion makes this link a bit easier to conclude.
CID: 37966
collectd bot [Mon, 20 Nov 2017 12:06:19 +0000 (13:06 +0100)]
Auto-Merge pull request #2563 from octo/cid/179225
Automatically merged due to "Automerge" label
collectd bot [Mon, 20 Nov 2017 11:49:09 +0000 (12:49 +0100)]
Auto-Merge pull request #2562 from octo/cid/179233
Automatically merged due to "Automerge" label
collectd bot [Mon, 20 Nov 2017 11:36:14 +0000 (12:36 +0100)]
Auto-Merge pull request #2561 from octo/cid/157643
Automatically merged due to "Automerge" label
collectd bot [Mon, 20 Nov 2017 11:15:53 +0000 (12:15 +0100)]
Auto-Merge pull request #2560 from octo/cid/179237
Automatically merged due to "Automerge" label
collectd bot [Mon, 20 Nov 2017 10:42:03 +0000 (11:42 +0100)]
Auto-Merge pull request #2559 from octo/cid/179236
Automatically merged due to "Automerge" label
Florian Forster [Mon, 20 Nov 2017 10:21:41 +0000 (11:21 +0100)]
gps plugin: Properly unlock mutex after waiting.
How did this ever work?!
CID: 158522
Florian Forster [Mon, 20 Nov 2017 10:19:52 +0000 (11:19 +0100)]
write_tsdb plugin: Unlock mutex before destroying it.
CID: 179224
Florian Forster [Mon, 20 Nov 2017 10:18:32 +0000 (11:18 +0100)]
write_graphite plugin: Unlock mutex before destroying it.
CID: 179225
collectd bot [Mon, 20 Nov 2017 10:13:27 +0000 (11:13 +0100)]
Auto-Merge pull request #2558 from octo/refactor/plugin_load_file
Automatically merged due to "Automerge" label
Florian Forster [Mon, 20 Nov 2017 10:13:02 +0000 (11:13 +0100)]
src/utils_ovs.c: Initialize pdb->sock to -1 earlier.
ovs_db_destroy() was called before the field was initialized, leading to
close(0) being called.
Florian Forster [Mon, 20 Nov 2017 10:11:22 +0000 (11:11 +0100)]
src/utils_ovs.c: Assign variable only once.
CID: 179233
Florian Forster [Mon, 20 Nov 2017 10:04:01 +0000 (11:04 +0100)]
set target: Ensure that int being cast to size_t is positive or zero.
CID: 157643
Florian Forster [Mon, 20 Nov 2017 09:50:51 +0000 (10:50 +0100)]
write_sensu plugin: Unlock mutex before destroying it.
CID: 179237
Florian Forster [Mon, 20 Nov 2017 09:43:10 +0000 (10:43 +0100)]
src/utils_format_json.c: Check return values of yajl_gen_* functions.
CID: 179228, 179236, 179239
Florian Forster [Mon, 20 Nov 2017 09:16:56 +0000 (10:16 +0100)]
src/daemon/plugin.c: Refactor plugin_load_file().
Florian Forster [Sat, 18 Nov 2017 08:59:39 +0000 (09:59 +0100)]
Update version to 5.8.0.
Florian Forster [Sat, 18 Nov 2017 08:56:30 +0000 (09:56 +0100)]
Merge branch 'collectd-5.8'
Florian Forster [Sat, 18 Nov 2017 08:55:58 +0000 (09:55 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
collectd bot [Fri, 17 Nov 2017 17:32:21 +0000 (18:32 +0100)]
Auto-Merge pull request #2555 from octo/cid/179231
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 17:20:21 +0000 (18:20 +0100)]
Auto-Merge pull request #2554 from octo/cid/179227
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 17:04:45 +0000 (18:04 +0100)]
Auto-Merge pull request #2553 from octo/cid/179230
Automatically merged due to "Automerge" label
Florian Forster [Fri, 17 Nov 2017 16:26:28 +0000 (17:26 +0100)]
ovs_stats plugin: Fix null dereference of "port".
This also refactors the ovs_stats_update_iface_ext_ids() function to
handle errors, instead of many nested if blocks.
CID: 179231
Florian Forster [Fri, 17 Nov 2017 16:16:39 +0000 (17:16 +0100)]
write_riemann plugin: Unlock mutex before destroying it.
CID: 179227
Florian Forster [Fri, 17 Nov 2017 16:11:32 +0000 (17:11 +0100)]
processes plugin: Fix check for context switch counters.
CID: 179230
collectd bot [Fri, 17 Nov 2017 15:44:07 +0000 (16:44 +0100)]
Auto-Merge pull request #2550 from octo/cid/179234
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 15:32:19 +0000 (16:32 +0100)]
Auto-Merge pull request #2549 from octo/cid/179240
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 15:20:46 +0000 (16:20 +0100)]
Auto-Merge pull request #2548 from octo/cid/42796
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 15:08:50 +0000 (16:08 +0100)]
Auto-Merge pull request #2547 from octo/cid/81390
Automatically merged due to "Automerge" label
Florian Forster [Fri, 17 Nov 2017 14:38:59 +0000 (15:38 +0100)]
ovs_stats plugin: Minor code cleanup.
Florian Forster [Fri, 17 Nov 2017 14:37:57 +0000 (15:37 +0100)]
ovs_stats plugin: Add missing unlock.
CID: 179234
Florian Forster [Fri, 17 Nov 2017 14:29:07 +0000 (15:29 +0100)]
src/utils_ovs.c: Random coding style improvements.
Florian Forster [Fri, 17 Nov 2017 14:28:39 +0000 (15:28 +0100)]
src/utils_ovs.c: Don't set pthread_t to -1, use pthread_equal() to compare.
The assumption that pthread_t is a scalar is not portable.
Florian Forster [Fri, 17 Nov 2017 14:26:13 +0000 (15:26 +0100)]
src/utils_ovs.c: Unlock pdb->mutex before calling ovs_db_callback_remove_all().
CID: 179240
Florian Forster [Fri, 17 Nov 2017 14:15:32 +0000 (15:15 +0100)]
gps plugin: Fix double unlock.
CID: 179241
Florian Forster [Fri, 17 Nov 2017 14:09:59 +0000 (15:09 +0100)]
zfs_arc plugin: Allocate ksp later to avoid memory leak.
CID: 42796
collectd bot [Fri, 17 Nov 2017 14:05:35 +0000 (15:05 +0100)]
Auto-Merge pull request #2546 from octo/cid/179229
Automatically merged due to "Automerge" label
Florian Forster [Fri, 17 Nov 2017 13:56:06 +0000 (14:56 +0100)]
snmp plugin: Ensure that index is within bounds.
CID: 81389, 81390
Florian Forster [Fri, 17 Nov 2017 13:34:39 +0000 (14:34 +0100)]
ovs_stats plugin: Fix a memory leak.
br_name would leak when jumping to cleanup_fail.
CID: 179229
collectd bot [Fri, 17 Nov 2017 13:29:29 +0000 (14:29 +0100)]
Auto-Merge pull request #2540 from octo/cid/141009
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 13:16:58 +0000 (14:16 +0100)]
Auto-Merge pull request #2539 from octo/cid/179243
Automatically merged due to "Automerge" label
collectd bot [Fri, 17 Nov 2017 13:05:01 +0000 (14:05 +0100)]
Auto-Merge pull request #2538 from octo/cid/179244
Automatically merged due to "Automerge" label
Florian Forster [Wed, 15 Nov 2017 21:26:11 +0000 (22:26 +0100)]
libcollectdclient: Ensure vl->values_len is non-zero.
That size_t is then used to declare Variable Length Arrays. Hopefully
this helps to convince Coverity that pkg_values and pkg_values_types are
actually fully initialized.
CID: 141009, 141010
Florian Forster [Wed, 15 Nov 2017 21:03:53 +0000 (22:03 +0100)]
ovs_events plugin: Replace strncpy() with sstrncpy().
CID: 179243
Florian Forster [Wed, 15 Nov 2017 20:38:32 +0000 (21:38 +0100)]
snmp_agent plugin: Fix memory leak.
Allocate "entry" later so that the error handling blocks don't leak it.
CID: 179244
Florian Forster [Fri, 17 Nov 2017 12:18:00 +0000 (13:18 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
collectd bot [Fri, 17 Nov 2017 12:15:19 +0000 (13:15 +0100)]
Auto-Merge pull request #2545 from octo/turbostat
Automatically merged due to "Automerge" label
Florian Forster [Fri, 17 Nov 2017 10:51:43 +0000 (11:51 +0100)]
contrib/format.sh src/msr-index.h src/turbostat.c
Vincent Brillault [Tue, 26 Sep 2017 17:34:03 +0000 (19:34 +0200)]
msr-index: include GPLv2 header
Signed-off-by: Florian Forster <octo@collectd.org>
Vincent Brillault [Mon, 25 Sep 2017 19:21:45 +0000 (21:21 +0200)]
turbostat: import msr-index header from linux
Since Linux 4.12, the kernel does not expose msr-index.h to the userland
anymore. This commit pulls and hardcode the required definitions.
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Wed, 15 Nov 2017 21:31:47 +0000 (22:31 +0100)]
src/daemon/meta_data.c: Fix double unlock.
CID: 179245
Feike Steenbergen [Wed, 15 Nov 2017 07:46:57 +0000 (08:46 +0100)]
Fix documentation typo for PostgreSQL plugin
In collectd/src/postgresql_default.conf the name for the backends
query is plural, yet in the documentation it is singular. This caused
me some lost time when running this plugin.
It is also wrongly listed on the wiki:
https://collectd.org/wiki/index.php/Plugin:PostgreSQL
Signed-off-by: Florian Forster <octo@collectd.org>
collectd bot [Tue, 14 Nov 2017 22:08:48 +0000 (23:08 +0100)]
Auto-Merge pull request #2535 from mfournier/collectd-5.8
Automatically merged due to "Automerge" label
Marc Fournier [Tue, 14 Nov 2017 21:21:33 +0000 (22:21 +0100)]
mcelog: filter through contrib/format.sh
Marc Fournier [Tue, 14 Nov 2017 21:15:11 +0000 (22:15 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
Taras Chornyi [Tue, 14 Nov 2017 17:21:36 +0000 (17:21 +0000)]
Fixed code styling
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
Taras Chornyi [Tue, 14 Nov 2017 17:17:20 +0000 (17:17 +0000)]
Fixed gcc 7 format-truncation errors #2423
Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
collectd bot [Sun, 12 Nov 2017 21:04:11 +0000 (22:04 +0100)]
Auto-Merge pull request #2517 from trustchk/aix
Automatically merged due to "Automerge" label
Florian Forster [Thu, 9 Nov 2017 15:42:22 +0000 (16:42 +0100)]
libcollectdclient/network_parse.c: Implement be{16,64}toh() if not provided by the system.
collectd bot [Thu, 9 Nov 2017 16:08:53 +0000 (17:08 +0100)]
Auto-Merge pull request #2527 from mfournier/varnish_52_compat_on_collectd_58
Automatically merged due to "Automerge" label
Florian Forster [Thu, 9 Nov 2017 15:18:33 +0000 (16:18 +0100)]
varnish plugin: Code cleanup:
* Remove legacy rindex() with the POSIX strrchr().
* Check return value of strrchr().
* Chose non-arbitrary buffer size.
* Use sstrncpy() instead of strcpy().
Florian Forster [Thu, 9 Nov 2017 15:12:10 +0000 (16:12 +0100)]
varnish plugin: Avoid unused variable even harder.
;-)
Marc Fournier [Wed, 8 Nov 2017 21:01:26 +0000 (22:01 +0100)]
varnish plugin: avoid unused variable in V5 block
Marc Fournier [Wed, 8 Nov 2017 20:55:04 +0000 (21:55 +0100)]
varnish plugin: fix build against pre varnish 5.2
Older Varnish versions don't know about VSM_Destroy()
Denes Matetelki [Wed, 8 Nov 2017 13:39:38 +0000 (14:39 +0100)]
running contrib/format.sh on src/varnish.c
Denes Matetelki [Wed, 8 Nov 2017 13:30:20 +0000 (14:30 +0100)]
varnish-cache-5.2 compatibility
Marc Fournier [Wed, 8 Nov 2017 16:26:51 +0000 (17:26 +0100)]
postgresql: fix last sum() related parse errors
These queries return empty values when a database doesn't have any
tables yet, which results in collectd logging this error every Interval:
```
db query utils: udb_result_submit: Parsing `' as derive failed.
```
Related to #1905
collectd bot [Tue, 7 Nov 2017 16:14:55 +0000 (17:14 +0100)]
Auto-Merge pull request #2524 from maryamtahhan/fix_dpdkstats_compilation
Automatically merged due to "Automerge" label
Mytnyk, Volodymyr [Tue, 7 Nov 2017 11:56:54 +0000 (12:56 +0100)]
dpdkstats: Fix compilation issue.
src/dpdkstat.c:128:10: error: unused variable ‘errbuf’ [-Werror=unused-variable]
src/dpdkstat.c:449:10: error: unused variable ‘errbuf’ [-Werror=unused-variable]
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Marc Fournier [Tue, 7 Nov 2017 07:33:05 +0000 (08:33 +0100)]
Merge branch 'collectd-5.8'
collectd bot [Mon, 6 Nov 2017 22:04:51 +0000 (23:04 +0100)]
Auto-Merge pull request #2522 from mfournier/fix-collectd-5.8-build
Automatically merged due to "Automerge" label
Marc Fournier [Mon, 6 Nov 2017 21:25:33 +0000 (22:25 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
Conflicts:
src/netlink.c
Default [Fri, 29 Sep 2017 10:11:25 +0000 (13:11 +0300)]
.spec add (network_parse,server,types), synproxy plugin
added Installed (but unpackaged) file(s) in .spec (RPM)
synproxy disabled by default
collectd bot [Mon, 6 Nov 2017 21:04:38 +0000 (22:04 +0100)]
Auto-Merge pull request #2519 from octo/ff/strerror
Automatically merged due to "Automerge" label
Florian Forster [Mon, 6 Nov 2017 19:54:05 +0000 (20:54 +0100)]
Reformat changed files.
collectd bot [Sun, 5 Nov 2017 06:42:55 +0000 (07:42 +0100)]
Auto-Merge pull request #2516 from trustchk/fix-libcollectdclient-ip_mreq-usage
Automatically merged due to "Automerge" label
collectd bot [Sun, 5 Nov 2017 06:26:30 +0000 (07:26 +0100)]
Auto-Merge pull request #2518 from octo/issue/2510
Automatically merged due to "Automerge" label
trustchk [Thu, 2 Nov 2017 10:31:22 +0000 (10:31 +0000)]
libcollectdclient: fix usage of ip_mreq
On both IBM AIX and Gentoo Linux, the struct `ip_mreq` does not define
the field `imr_address`, plus the compiler throws an error in the
assignment of `sa->s_addr`. With `ip_mreqn` present, the fallback path
for `ip_mreq` is not used and everything works. But AIX does not know
that struct and fails to compile.
Florian Forster [Sun, 5 Nov 2017 05:23:24 +0000 (06:23 +0100)]
netlink plugin: Improve error reporting for mnl_attr_validate2() and mnl_socket_recvfrom().
Issue: #2510
collectd bot [Sat, 4 Nov 2017 21:19:07 +0000 (22:19 +0100)]
Auto-Merge pull request #2514 from octo/collectd-5.8
Automatically merged due to "Automerge" label
Florian Forster [Sat, 4 Nov 2017 20:36:01 +0000 (21:36 +0100)]
Update changelog, bump version to 5.8.0-RC0.
Florian Forster [Sat, 4 Nov 2017 19:54:30 +0000 (20:54 +0100)]
Tree wide: Replace sstrerror() with STRERROR().
Florian Forster [Sat, 4 Nov 2017 19:20:02 +0000 (20:20 +0100)]
Tree wide: Replace sstrerror() with STRERRNO.
Florian Forster [Sat, 4 Nov 2017 18:28:34 +0000 (19:28 +0100)]
daemon/common.h: Add the STRERROR() and STRERRNO macros.
trustchk [Thu, 2 Nov 2017 15:03:21 +0000 (15:03 +0000)]
libcollectdclient: add defines for AIX
This adds two defines that are missing on AIX because they don't have
the endian.h header file. AIX is always big endian, so no further check
is required for that. As I have no access to IBMs XLC compiler, this
patch limits the definitions to GNU GCC.
collectd bot [Sun, 29 Oct 2017 15:12:22 +0000 (16:12 +0100)]
Auto-Merge pull request #2369 from marekbecka/nfs42
Automatically merged due to "Automerge" label
Florian Forster [Sun, 29 Oct 2017 14:34:21 +0000 (15:34 +0100)]
contrib/format.sh src/nfs.c
Marek Becka [Tue, 18 Jul 2017 12:17:43 +0000 (08:17 -0400)]
Add new NFS 4.2 counters on Linux
Florian Forster [Sun, 29 Oct 2017 09:24:02 +0000 (10:24 +0100)]
contrib/format.sh: Fix bashisms.
collectd bot [Thu, 26 Oct 2017 06:09:54 +0000 (08:09 +0200)]
Auto-Merge pull request #2507 from rpv-tomsk/issue-2506
Automatically merged due to "Automerge" label
Pavel Rochnyack [Thu, 26 Oct 2017 05:17:49 +0000 (12:17 +0700)]
Fix hostname_g initialization from gethostname()
Closes: #2506