Ruben Kerkhof [Sun, 24 Jul 2016 15:56:04 +0000 (17:56 +0200)]
curl plugin: correct error message
Ruben Kerkhof [Sun, 24 Jul 2016 15:21:56 +0000 (17:21 +0200)]
modbus plugin: unsigned value can't be negative
Ruben Kerkhof [Sun, 24 Jul 2016 15:15:11 +0000 (17:15 +0200)]
collectd-tg: remove dead code
Ruben Kerkhof [Sun, 24 Jul 2016 15:11:46 +0000 (17:11 +0200)]
fscache plugin: unsigned value can't be negative
Ruben Kerkhof [Sun, 24 Jul 2016 14:47:40 +0000 (16:47 +0200)]
uuid plugin: fix inclusion of libhal.h
Follow up of
34db18b
Ruben Kerkhof [Sun, 24 Jul 2016 14:43:30 +0000 (16:43 +0200)]
configure.ac: always use pkg-config to detect hal
Hal needs dbus, but we need pkg-config to tell us that.
Now that pkg-config is not optional anymore, rewrite the
check to always use it. Also add a check for the header.
Fixes building the uuid plugin on Solaris 11.3
Ruben Kerkhof [Sun, 24 Jul 2016 13:31:56 +0000 (15:31 +0200)]
ganglia plugin: unsigned value can't be negative
Ruben Kerkhof [Sun, 24 Jul 2016 11:56:32 +0000 (13:56 +0200)]
treewide: remove unused includes
Ruben Kerkhof [Sun, 24 Jul 2016 11:56:32 +0000 (13:56 +0200)]
network plugin: use size_t for length and offsets
Ruben Kerkhof [Sun, 24 Jul 2016 11:55:22 +0000 (13:55 +0200)]
Ignore lint files
Ruben Kerkhof [Sun, 24 Jul 2016 11:43:48 +0000 (13:43 +0200)]
apache plugin: fix compiler warning on Solaris
Ruben Kerkhof [Sun, 24 Jul 2016 11:41:00 +0000 (13:41 +0200)]
memcached plugin: fix compiler warning on Solaris
| ud.free_func = (void *) memcached_free;
| ^ line 559, memcached.c
assignment type mismatch:
pointer to function(pointer to void) returning void "=" pointer to void
Casting a function pointer to a void pointer is undefined behaviour
in C (it is defined in POSIX however)
Ruben Kerkhof [Sun, 24 Jul 2016 11:37:14 +0000 (13:37 +0200)]
mysql plugin: remove unneccesary cast
Rinigus [Sun, 24 Jul 2016 11:38:08 +0000 (14:38 +0300)]
fix configure.ac
Ruben Kerkhof [Sun, 24 Jul 2016 11:29:25 +0000 (13:29 +0200)]
network plugin: unsigned variables can't be negative
Ruben Kerkhof [Sun, 24 Jul 2016 11:28:01 +0000 (13:28 +0200)]
utils_dns.c: unsigned variable can't be negative
Ruben Kerkhof [Sun, 24 Jul 2016 11:27:18 +0000 (13:27 +0200)]
utils_dns.c: fix strange linebreak
Ruben Kerkhof [Sun, 24 Jul 2016 11:26:19 +0000 (13:26 +0200)]
rrdtool plugin: unsigned value can't be negative
Ruben Kerkhof [Sun, 24 Jul 2016 11:24:54 +0000 (13:24 +0200)]
ted plugin: 0xAA doesn't fit in a signed char
Ruben Kerkhof [Sun, 24 Jul 2016 11:23:58 +0000 (13:23 +0200)]
openldap plugin: rc is only used once
Ruben Kerkhof [Sun, 24 Jul 2016 11:21:45 +0000 (13:21 +0200)]
interface plugin: val is only used once
Ruben Kerkhof [Sun, 24 Jul 2016 11:19:08 +0000 (13:19 +0200)]
Make chrony compile with Solaris Studio compiler
Ideally we'll have autoconf checks for supported attributes,
will look into that later.
Ruben Kerkhof [Sat, 23 Jul 2016 21:26:14 +0000 (23:26 +0200)]
utils_dns.c: remove dead code
Ruben Kerkhof [Sat, 23 Jul 2016 21:24:46 +0000 (23:24 +0200)]
zone plugin: remove unused code
Ruben Kerkhof [Sat, 23 Jul 2016 21:22:33 +0000 (23:22 +0200)]
collectctl: remove dead code
Ruben Kerkhof [Sat, 23 Jul 2016 13:54:20 +0000 (15:54 +0200)]
teamspeak plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 13:30:44 +0000 (15:30 +0200)]
madwifi plugin: fix buffer overflows
Ruben Kerkhof [Sat, 23 Jul 2016 13:24:47 +0000 (15:24 +0200)]
curl_xml plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 13:23:03 +0000 (15:23 +0200)]
utils_curl_stats.c: fix order of calloc arguments
Ruben Kerkhof [Sat, 23 Jul 2016 13:16:41 +0000 (15:16 +0200)]
libcollectdclient: remove unneccesary cast
Ruben Kerkhof [Sat, 23 Jul 2016 13:07:25 +0000 (15:07 +0200)]
processes plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:59:38 +0000 (14:59 +0200)]
log_logstash plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:57:04 +0000 (14:57 +0200)]
curl_json plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:56:21 +0000 (14:56 +0200)]
conntrack plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:54:32 +0000 (14:54 +0200)]
utils_cmd_putval.c: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:50:17 +0000 (14:50 +0200)]
utils_threshold.c: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 11:35:27 +0000 (13:35 +0200)]
collectd.h: guard define of __attribute__
It might have already been defined to a no-op in <sys/cdefs.h>
Ruben Kerkhof [Sat, 23 Jul 2016 11:34:00 +0000 (13:34 +0200)]
collectd.h: remove unused defines
Ruben Kerkhof [Sat, 23 Jul 2016 11:27:39 +0000 (13:27 +0200)]
collectd.h: fix indentation
Florian Forster [Thu, 21 Jul 2016 05:49:50 +0000 (07:49 +0200)]
Merge branch 'collectd-5.5'
Florian Forster [Thu, 21 Jul 2016 05:49:25 +0000 (07:49 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Florian Forster [Tue, 19 Jul 2016 08:00:37 +0000 (10:00 +0200)]
network plugin: Fix heap overflow in parse_packet().
Emilien Gaspar has identified a heap overflow in parse_packet(), the
function used by the network plugin to parse incoming network packets.
This is a vulnerability in collectd, though the scope is not clear at
this point. At the very least specially crafted network packets can be
used to crash the daemon. We can't rule out a potential remote code
execution though.
Fixes: CVE-2016-6254
Rinigus [Tue, 19 Jul 2016 09:20:30 +0000 (12:20 +0300)]
formatting changes in cpusleep
Ruben Kerkhof [Mon, 18 Jul 2016 18:36:06 +0000 (20:36 +0200)]
Merge pull request #1765 from vincentbernat/fix/kafka-partition-selection
write_kafka: ensure key is properly hashed to select partition
Ruben Kerkhof [Mon, 18 Jul 2016 18:20:40 +0000 (20:20 +0200)]
Merge pull request #1785 from rinigus/master_issue1781
disk plugin: release udev-based name. Fixes #1781
Ruben Kerkhof [Mon, 18 Jul 2016 18:13:55 +0000 (20:13 +0200)]
Merge pull request #1794 from swt2c/smart_use_serial
smart plugin: add option to store data using serial number
Ruben Kerkhof [Sun, 17 Jul 2016 19:02:29 +0000 (21:02 +0200)]
Merge pull request #1796 from tokkee/sh/configure
configure: Use AC_MSG_RESULT to print the config summary.
Sebastian Harl [Sun, 17 Jul 2016 17:08:28 +0000 (19:08 +0200)]
configure: Use AC_MSG_RESULT to print the config summary.
This way, it will show up in config.log as well.
Sebastian Harl [Sun, 17 Jul 2016 16:59:12 +0000 (18:59 +0200)]
configure: Add missing end fold marker (for Vim).
Ruben Kerkhof [Sat, 16 Jul 2016 09:40:35 +0000 (11:40 +0200)]
Merge pull request #1783 from matwey/ntp
ntpd: Check STA_NANO in the server status
Matwey V. Kornilov [Wed, 6 Jul 2016 13:00:55 +0000 (16:00 +0300)]
ntpd: Check STA_NANO in the server status
When STA_NANO is set in ik->status, then results are
expressed in nanoseconds (instead of microseconds by default).
Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
Ruben Kerkhof [Fri, 15 Jul 2016 20:13:47 +0000 (22:13 +0200)]
zookeeper plugin: remove unneccesary cast
Ruben Kerkhof [Fri, 15 Jul 2016 20:04:38 +0000 (22:04 +0200)]
ntpd plugin: remove unneccesary casts
Ruben Kerkhof [Fri, 15 Jul 2016 20:02:08 +0000 (22:02 +0200)]
collectd-nagios: fix some whitespace
Ruben Kerkhof [Fri, 15 Jul 2016 20:01:44 +0000 (22:01 +0200)]
virt plugin: fix some whitespace
Ruben Kerkhof [Fri, 15 Jul 2016 15:02:22 +0000 (17:02 +0200)]
Merge pull request #1793 from rubenk/fix-riemann-plugin-on-32bit-solaris
Fix write_riemann plugin build on 32-bit Solaris
Ruben Kerkhof [Fri, 15 Jul 2016 09:46:52 +0000 (11:46 +0200)]
Fix write_riemann plugin build on 32-bit Solaris
Fixes #1782
CC write_riemann_la-write_riemann.lo
In file included from ./daemon/collectd.h:31:0,
from write_riemann.c:34:
./config.h:1664:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]
#define _FILE_OFFSET_BITS 64
^
In file included from /usr/include/limits.h:17:0,
from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/limits.h:168,
from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/syslimits.h:7,
from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/limits.h:34,
from /opt/csw/include/protobuf-c/protobuf-c.h:200,
from /opt/csw/include/riemann/proto/riemann.pb-c.h:7,
from /opt/csw/include/riemann/attribute.h:21,
from /opt/csw/include/riemann/riemann-client.h:23,
from write_riemann.c:31:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
#define _FILE_OFFSET_BITS 32
^
cc1: all warnings being treated as errors
Makefile:4645: recipe for target 'write_riemann_la-write_riemann.lo'
failed
gmake[3]: *** [write_riemann_la-write_riemann.lo] Error 1
gmake[3]: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/src'
Makefile:4879: recipe for target 'all-recursive' failed
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/src'
Makefile:3209: recipe for target 'all' failed
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/src'
Makefile:572: recipe for target 'all-recursive' failed
gmake: *** [all-recursive] Error 1
gmake: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166'
/home/dam/mgar/pkg/.buildsys/v2/gar//gar.lib.mk:874: die Regel für Ziel
„build-work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/Makefile“
scheiterte
Scott Talbert [Fri, 15 Jul 2016 14:14:28 +0000 (10:14 -0400)]
smart plugin: add option to store data using serial number
Since a device name (e.g., /dev/sda) can change, allow using the serial number
to store SMART data as this will ensure the data for a given drive is always
kept together.
Ruben Kerkhof [Fri, 15 Jul 2016 14:03:15 +0000 (16:03 +0200)]
Merge pull request #1770 from swt2c/smart_ignore_sleep
smart plugin: add IgnoreSleepMode option to ignore sleeping disks
Scott Talbert [Fri, 15 Jul 2016 13:36:30 +0000 (09:36 -0400)]
smart plugin: add IgnoreSleepMode option to ignore sleeping disks
This option enables the smart plugin to use disks that libatasmart mistakenly
reports as asleep. This happens because libatasmart has not been updated to
incorporate support for newer idle states in the ATA spec.
Ruben Kerkhof [Fri, 15 Jul 2016 10:21:08 +0000 (12:21 +0200)]
Merge pull request #1773 from skob/master
Add slow queries statistics to mysql module
skob [Tue, 28 Jun 2016 09:06:31 +0000 (13:06 +0400)]
Add slow queries statistics to mysql module
Ruben Kerkhof [Fri, 15 Jul 2016 08:56:14 +0000 (10:56 +0200)]
Merge pull request #1774 from mmckinst/rdkafka_now_libkafka
rdkafka is called librdkafka
rinigus [Wed, 13 Jul 2016 11:55:44 +0000 (14:55 +0300)]
add ActiveInterfaceOnly option to interface plugin
rinigus [Fri, 8 Jul 2016 12:36:37 +0000 (15:36 +0300)]
disk plugin: release udev-based name. Fixes #1781
Rinigus [Tue, 5 Jul 2016 19:57:11 +0000 (22:57 +0300)]
adding configure check for clock boottime and monotonic
Rinigus [Tue, 5 Jul 2016 19:56:31 +0000 (22:56 +0300)]
typo in error message fixed
rinigus [Tue, 5 Jul 2016 13:01:30 +0000 (16:01 +0300)]
adding CPU sleep plugin
Mark McKinstry [Wed, 29 Jun 2016 14:54:46 +0000 (10:54 -0400)]
rdkafka is called librdkafka
The [spec file for
librdkafka](https://github.com/edenhill/librdkafka/blob/master/packaging/rpm/librdkafka.spec)
calls its package 'librdkafka-devel', not 'rdkafka-devel'. Searching the
web for 'rdkafka-devel RPM' turns up nothing, all the RPMs are named
'librdkafka-devel'.
Vincent Bernat [Wed, 15 Jun 2016 07:53:07 +0000 (09:53 +0200)]
write_kafka: ensure key is properly hashed to select partition
Otherwise, partition is selected solely on the first letter of the
key. If all your hosts are starting with the same letter, everything
ends up in a single partition.
Marc Fournier [Tue, 14 Jun 2016 19:16:43 +0000 (21:16 +0200)]
README: add reference to libxen
Marc Fournier [Tue, 14 Jun 2016 06:19:12 +0000 (08:19 +0200)]
Merge branch 'collectd-5.5'
Marc Fournier [Tue, 14 Jun 2016 06:19:03 +0000 (08:19 +0200)]
README: mention 3 missing plugins
Marc Fournier [Tue, 14 Jun 2016 05:14:49 +0000 (07:14 +0200)]
AUTHORS: mention new contributors and update plugin attributions
Marc Fournier [Tue, 14 Jun 2016 05:44:35 +0000 (07:44 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Marc Fournier [Tue, 14 Jun 2016 05:38:30 +0000 (07:38 +0200)]
src/*.pod: fix minor warnings spotted by podchecker
Marc Fournier [Tue, 14 Jun 2016 05:17:48 +0000 (07:17 +0200)]
collectd.conf.pod: fix minor typos in ntpd plugin section
Marc Fournier [Tue, 14 Jun 2016 04:58:44 +0000 (06:58 +0200)]
doc: add chronyd section to manpage
Ruben Kerkhof [Sat, 11 Jun 2016 10:18:57 +0000 (12:18 +0200)]
Merge pull request #1004 from tokkee/sh/curl
Add support for detailed cURL statistics
Sebastian Harl [Fri, 10 Jun 2016 18:58:05 +0000 (20:58 +0200)]
Language and typo fixes.
Sebastian Harl [Sat, 4 Jun 2016 16:51:44 +0000 (18:51 +0200)]
utils_curl_stats: Drop the nonnull attribute from curl_stats_from_config.
It's not overly useful after all but generates false compiler warnings /
errors on Xenial using CLANG, since we also check the parameter in the
function (which is what we want in the end and there's no risk in actually
calling it with a NULL value).
Sebastian Harl [Mon, 30 May 2016 21:29:05 +0000 (23:29 +0200)]
curl stats: Use cf_util_get_boolean().
Sebastian Harl [Mon, 30 May 2016 21:23:59 +0000 (23:23 +0200)]
curl stats: Simplified some error checks and removed unused code.
Sebastian Harl [Mon, 30 May 2016 21:10:08 +0000 (23:10 +0200)]
configure / curl stats: Check for CURLINFO_APPCONNECT_TIME.
It's available since cURL 7.19 but RHEL5 ships an older version.
Sebastian Harl [Mon, 30 May 2016 20:46:14 +0000 (22:46 +0200)]
collectd.conf(5): Briefly explain MeasureResponseTime vs TotalTime.
Sebastian Harl [Mon, 30 May 2016 20:39:53 +0000 (22:39 +0200)]
curl stats: Use CamelCase identifiers instead of using underscores.
This is more consistent with the usual collectd style but still close enough
to the names used in cURL.
Sebastian Harl [Sat, 18 Apr 2015 19:44:22 +0000 (21:44 +0200)]
collectd.conf(5): Add documentation for cURL statistics.
Sebastian Harl [Sat, 18 Apr 2015 17:36:08 +0000 (19:36 +0200)]
Add request specific statistics to all CURL-based plugins.
All metrics supported by curl_easy_getinfo can be retrieved and dispatched for
each request done through CURL. All statistics are optional and disabled by
default.
Ruben Kerkhof [Fri, 10 Jun 2016 10:27:55 +0000 (12:27 +0200)]
configure.ac: indent and sort some conditionals
Ruben Kerkhof [Fri, 10 Jun 2016 10:23:09 +0000 (12:23 +0200)]
configure.ac: remove obsolete macro
We don't need it anymore. See
http://gnu-autoconf.7623.n7.nabble.com/Bug-389558-autoconf-AC-PROG-GCC-TRADITIONAL-throws-error-in-comparision-td1885.html
Ruben Kerkhof [Fri, 10 Jun 2016 08:46:28 +0000 (10:46 +0200)]
chrony plugin: use ANSI function definitions
chrony.c:392:1: warning: function declaration isn’t a prototype
[-Wstrict-prototypes]
chrony_set_timeout()
^
chrony.c: In function ‘chrony_set_timeout’:
chrony.c:392:1: warning: old-style function definition
[-Wold-style-definition]
chrony.c: At top level:
Ruben Kerkhof [Fri, 10 Jun 2016 08:11:01 +0000 (10:11 +0200)]
Merge pull request #1758 from rubenk/README
README: use https for collectd.org link
Ruben Kerkhof [Fri, 10 Jun 2016 08:10:54 +0000 (10:10 +0200)]
Merge pull request #1759 from rubenk/ansi-function-declaration
uc_get_iterator: use ansi function declaration
Ruben Kerkhof [Fri, 10 Jun 2016 07:48:23 +0000 (09:48 +0200)]
Merge branch 'collectd-5.5'
Ruben Kerkhof [Fri, 10 Jun 2016 07:47:53 +0000 (09:47 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5
Thomas Guthmann [Wed, 8 Jun 2016 03:03:47 +0000 (13:03 +1000)]
Bug#1059 : Remove any white spaces in ethstats stat names (affects VMXNet3 interface)
Ruben Kerkhof [Thu, 9 Jun 2016 21:09:18 +0000 (23:09 +0200)]
uc_get_iterator: use ansi function declaration
In file included from common.c:37:0:
utils_cache.h:76:1: warning: function declaration isn’t a prototype
[-Wstrict-prototypes]
uc_iter_t *uc_get_iterator ();
^
Ruben Kerkhof [Thu, 9 Jun 2016 17:56:56 +0000 (19:56 +0200)]
README: use https for collectd.org link
Ruben Kerkhof [Mon, 6 Jun 2016 08:32:59 +0000 (10:32 +0200)]
Merge pull request #1750 from tokkee/sh/cli
daemon: Let all command line options override global options from the config.
Sebastian Harl [Sun, 5 Jun 2016 22:09:58 +0000 (00:09 +0200)]
configfile: Log errors when trying to access unknown global options.