git.git
18 years agoMerge branch 'jc/boundary' into next
Junio C Hamano [Mon, 17 Apr 2006 05:07:28 +0000 (22:07 -0700)]
Merge branch 'jc/boundary' into next

* jc/boundary:
  rev-list --boundary: show boundary commits even when limited otherwise.
  Makefile fixups.
  gitk: Fix bug caused by missing commitlisted elements

18 years agorev-list --boundary: show boundary commits even when limited otherwise.
Junio C Hamano [Mon, 17 Apr 2006 01:12:49 +0000 (18:12 -0700)]
rev-list --boundary: show boundary commits even when limited otherwise.

The boundary commits are shown for UI like gitk to draw them as
soon as topo-order sorting allows, and should not be omitted by
get_revision() filtering logic.  As long as their immediate
child commits are shown, we should not filter them out.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile fixups.
A Large Angry SCM [Mon, 17 Apr 2006 03:17:38 +0000 (20:17 -0700)]
Makefile fixups.

Signed-off-by: A Large Angry SCM <gitzilla@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge git://git.kernel.org/pub/scm/gitk/gitk
Junio C Hamano [Mon, 17 Apr 2006 01:59:30 +0000 (18:59 -0700)]
Merge git://git.kernel.org/pub/scm/gitk/gitk

* git://git.kernel.org/pub/scm/gitk/gitk:
  gitk: Fix bug caused by missing commitlisted elements

18 years agogitk: Fix bug caused by missing commitlisted elements
Paul Mackerras [Mon, 17 Apr 2006 00:27:59 +0000 (10:27 +1000)]
gitk: Fix bug caused by missing commitlisted elements

This bug was reported by Yann Dirson, and results in an 'Error:
expected boolean value but got ""' dialog when scrolling to the bottom
of the graph under some circumstances.  The issue is that git-rev-list
isn't outputting all the boundary commits when it is asked for commits
affecting only certain files.  We already cope with that by adding the
missing boundary commits in addextraid, but there we weren't adding a
0 to the end of the commitlisted list when we added the extra id to
the end of the displayorder list.

This fixes it by appending 0 to commitlisted in addextraid, thus keeping
commitlisted and displayorder in sync.

Signed-off-by: Paul Mackerras <paulus@samba.org>
18 years agoMerge branch 'master' into next
Junio C Hamano [Mon, 17 Apr 2006 00:03:13 +0000 (17:03 -0700)]
Merge branch 'master' into next

* master:
  reading $GIT_DIR/info/graft - skip comments correctly.

18 years agoMerge branch 'lt/logopt' into next
Junio C Hamano [Mon, 17 Apr 2006 00:02:52 +0000 (17:02 -0700)]
Merge branch 'lt/logopt' into next

* lt/logopt:
  Fixes for option parsing

18 years agoFixes for option parsing
Linus Torvalds [Sun, 16 Apr 2006 22:17:23 +0000 (15:17 -0700)]
Fixes for option parsing

Make sure "git show" always show the header, regardless of whether there
is a diff or not.

Also, make sure "always_show_header" actually works, since generate_header
only tested it in one out of three return paths.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoreading $GIT_DIR/info/graft - skip comments correctly.
Junio C Hamano [Sun, 16 Apr 2006 21:24:56 +0000 (14:24 -0700)]
reading $GIT_DIR/info/graft - skip comments correctly.

Noticed by Yann Dirson.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'lt/logopt' into next
Junio C Hamano [Sun, 16 Apr 2006 10:39:00 +0000 (03:39 -0700)]
Merge branch 'lt/logopt' into next

* lt/logopt:
  log/whatchanged/show - log formatting cleanup.
  Simplify common default options setup for built-in log family.

18 years agolog/whatchanged/show - log formatting cleanup.
Junio C Hamano [Sun, 16 Apr 2006 10:29:10 +0000 (03:29 -0700)]
log/whatchanged/show - log formatting cleanup.

This moves the decision to print the log message, while diff
options are in effect, to log-tree.  It gives behaviour closer
to the traditional one.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSimplify common default options setup for built-in log family.
Junio C Hamano [Sun, 16 Apr 2006 09:42:00 +0000 (02:42 -0700)]
Simplify common default options setup for built-in log family.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into lt/logopt
Junio C Hamano [Sun, 16 Apr 2006 09:31:11 +0000 (02:31 -0700)]
Merge branch 'master' into lt/logopt

* master:
  pager: do not fork a pager if PAGER is set to empty.
  diff-options: add --patch-with-stat
  diff-files --stat: do not dump core with unmerged index.
  Support "git cmd --help" syntax
  diff --stat: do not do its own three-dashes.
  diff-tree: typefix.
  GIT v1.3.0-rc4
  xdiff: post-process hunks to make them consistent.

18 years agoMerge branch 'jc/pager-cat' into next
Junio C Hamano [Sun, 16 Apr 2006 08:49:13 +0000 (01:49 -0700)]
Merge branch 'jc/pager-cat' into next

* jc/pager-cat:
  Do not fork PAGER=cat
  pager: do not fork a pager if PAGER is set to empty.

18 years agoDo not fork PAGER=cat
Junio C Hamano [Sun, 16 Apr 2006 08:46:08 +0000 (01:46 -0700)]
Do not fork PAGER=cat

Unless the user has a nonstandard "cat" command that does not
meow like a cat, this should not break anything and would save an
extra pipe.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agopager: do not fork a pager if PAGER is set to empty.
Johannes Schindelin [Sun, 16 Apr 2006 02:44:25 +0000 (04:44 +0200)]
pager: do not fork a pager if PAGER is set to empty.

This skips an extra pipe, and helps debugging tremendously.

[jc: PAGER=cat is a questionable hack and should be done as a separate
patch. ]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'lt/logopt' into next
Junio C Hamano [Sun, 16 Apr 2006 07:52:55 +0000 (00:52 -0700)]
Merge branch 'lt/logopt' into next

* lt/logopt:
  Tentative built-in "git show"
  Built-in git-whatchanged.
  rev-list option parser fix.
  Split init_revisions() out of setup_revisions()

18 years agoTentative built-in "git show"
Linus Torvalds [Sat, 15 Apr 2006 19:09:56 +0000 (12:09 -0700)]
Tentative built-in "git show"

This uses the "--no-walk" flag that I never actually implemented (but I'm
sure I mentioned it) to make "git show" be essentially the same thing as
"git whatchanged --no-walk".

It just refuses to add more interesting parents to the revision walking
history, so you don't actually get any history, you just get the commit
you asked for.

I was going to add "--no-walk" as a real argument flag to git-rev-list
too, but I'm not sure anybody actually needs it. Although it might be
useful for porcelain, so I left the door open.

[jc: ported to the unified option structure by Linus]

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoBuilt-in git-whatchanged.
Junio C Hamano [Sun, 16 Apr 2006 07:07:41 +0000 (00:07 -0700)]
Built-in git-whatchanged.

Split internal "git log" into reusable piece and add "git
whatchanged".  This is based on the option parsing unification
work Linus did.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agorev-list option parser fix.
Junio C Hamano [Sun, 16 Apr 2006 06:48:27 +0000 (23:48 -0700)]
rev-list option parser fix.

The big option parser unification broke rev-list the big way;
this makes it use options from the parsed revs structure.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSplit init_revisions() out of setup_revisions()
Junio C Hamano [Sun, 16 Apr 2006 06:46:36 +0000 (23:46 -0700)]
Split init_revisions() out of setup_revisions()

Merging all three option parsers related to whatchanged is
unarguably the right thing, but the fallout was too big to scare
me away.  Let's try it once again, but once step at time.

This splits out init_revisions() call from setup_revisions(), so
that the callers can set different defaults to match the
traditional benaviour.

The rev-list command is still broken in a big way, which is the
topic of next step.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'js/diffstat' into next
Junio C Hamano [Sun, 16 Apr 2006 02:35:55 +0000 (19:35 -0700)]
Merge branch 'js/diffstat' into next

* js/diffstat:
  diff-options: add --patch-with-stat
  diff-files --stat: do not dump core with unmerged index.
  Support "git cmd --help" syntax
  diff --stat: do not do its own three-dashes.

18 years agoMerge branch 'lt/show' into next
Junio C Hamano [Sun, 16 Apr 2006 02:31:45 +0000 (19:31 -0700)]
Merge branch 'lt/show' into next

* lt/show:
  Tentative built-in "git show"

18 years agodiff-options: add --patch-with-stat
Johannes Schindelin [Sat, 15 Apr 2006 11:41:18 +0000 (13:41 +0200)]
diff-options: add --patch-with-stat

With this option, git prepends a diffstat in front of the patch.

Since I really, really do not know what a diffstat of a combined diff
("merge diff") should look like, the diffstat is not generated for these.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agodiff-files --stat: do not dump core with unmerged index.
Junio C Hamano [Sun, 16 Apr 2006 01:38:32 +0000 (18:38 -0700)]
diff-files --stat: do not dump core with unmerged index.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSupport "git cmd --help" syntax
Linus Torvalds [Sat, 15 Apr 2006 18:13:49 +0000 (11:13 -0700)]
Support "git cmd --help" syntax

The "--help" argument is special, in that it is (along with "--version")
in that is taken by the "git" program itself rather than the sub-command,
and thus we've had the syntax "git --help cmd".

However, as anybody who has ever used CVS or some similar devil-spawn
program, it's confusing as h*ll when options before the sub-command act
differently from options after the sub-command, so this quick hack just
makes it acceptable to do "git cmd --help" instead, and get the exact same
result.

It may be hacky, but it's simple and does the trick.

Of course, this does not help if you use one of the non-builtin commands
without using the "git" helper. Ie you won't be getting a man-page just
because you do "git-rev-list --help". Don't expect us to be quite _that_
helpful.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoTentative built-in "git show"
Linus Torvalds [Sat, 15 Apr 2006 19:09:56 +0000 (12:09 -0700)]
Tentative built-in "git show"

This uses the "--no-walk" flag that I never actually implemented (but I'm
sure I mentioned it) to make "git show" be essentially the same thing as
"git whatchanged --no-walk".

It just refuses to add more interesting parents to the revision walking
history, so you don't actually get any history, you just get the commit
you asked for.

I was going to add "--no-walk" as a real argument flag to git-rev-list
too, but I'm not sure anybody actually needs it. Although it might be
useful for porcelain, so I left the door open.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agodiff --stat: do not do its own three-dashes.
Junio C Hamano [Sat, 15 Apr 2006 21:02:10 +0000 (14:02 -0700)]
diff --stat: do not do its own three-dashes.

I missed that "git-diff-* --stat" spits out three-dash separator
on its own without being asked.  Remove it.

When we output commit log followed by diff, perhaps --patch-with-stat,
for downstream consumer, we _would_ want the three-dash between
the message and the diff material, but that logic belongs to the
caller, not diff generator.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/logopt' into next
Junio C Hamano [Sat, 15 Apr 2006 11:22:08 +0000 (04:22 -0700)]
Merge branch 'jc/logopt' into next

* jc/logopt: (37 commits)
  1fc70b6
  Author: Junio C Hamano <junkio@cox.net>
  Date:   Sat Apr 15 04:15:07 2006 -0700

      Built-in git-whatchanged

      Now "git log" is in reusable shape, add "git whatchanged" which
      essentially is a synonym with different default for people whose
      fingers are already trained.

      There is a subtle difference from the shell-script version; the
      first line of each entry is now "commit <object name>", instead
      of "diff-tree <object name> (from <object name>)."  I suspect
      that showing the parent name that way is useful, so this may be
      something we would want to fix (the user can say --pretty=raw to
      get that information but that is a bit ugly).

Signed-off-by: Junio C Hamano <junkio@cox.net>
  :100644 100644 22fec3d... 939a34c... M git.c
  ...

18 years agoBuilt-in git-whatchanged
Junio C Hamano [Sat, 15 Apr 2006 11:15:07 +0000 (04:15 -0700)]
Built-in git-whatchanged

Now "git log" is in reusable shape, add "git whatchanged" which
essentially is a synonym with different default for people whose
fingers are already trained.

There is a subtle difference from the shell-script version; the
first line of each entry is now "commit <object name>", instead
of "diff-tree <object name> (from <object name>)."  I suspect
that showing the parent name that way is useful, so this may be
something we would want to fix (the user can say --pretty=raw to
get that information but that is a bit ugly).

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agowhatchanged options parser fix.
Junio C Hamano [Sat, 15 Apr 2006 10:54:32 +0000 (03:54 -0700)]
whatchanged options parser fix.

We need to have two sets of diff_options structure and abbrev
settings, but there is no point having two separate commit
format setting.  Fix the confusion.

Also properly initialize the command options structure.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/logopt' into next
Junio C Hamano [Sat, 15 Apr 2006 10:24:54 +0000 (03:24 -0700)]
Merge branch 'jc/logopt' into next

* jc/logopt:
  Extract "log [diff options]" parser out.
  diff-tree: typefix.

18 years agoExtract "log [diff options]" parser out.
Junio C Hamano [Sat, 15 Apr 2006 10:16:46 +0000 (03:16 -0700)]
Extract "log [diff options]" parser out.

Merging of the log-tree-opt structure with rev-info structure
did not work out very well and it broke things that did not want
diff options and/or rev options.

This is an alternative approach to define a combined interface
that can be used by commands that wants both.  The use of it is
opt-in to reduce the risk of breaking existing programs.

We might want to slurp "setup_revisions() places things in
pending objects list" part from Linus's earlier attempt.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agodiff-tree: typefix.
Junio C Hamano [Sat, 15 Apr 2006 10:22:00 +0000 (03:22 -0700)]
diff-tree: typefix.

Recent diff_tree_setup_paths() update made it take a second
argument of type "struct diff_options", but we passed another
struct that happenes to have that type at the beginning by
mistake.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/simpack' into next
Junio C Hamano [Sat, 15 Apr 2006 09:12:14 +0000 (02:12 -0700)]
Merge branch 'jc/simpack' into next

* jc/simpack:
  Clean-up Geert's similarity fingerprint code.

18 years agoClean-up Geert's similarity fingerprint code.
Junio C Hamano [Sat, 15 Apr 2006 08:32:39 +0000 (01:32 -0700)]
Clean-up Geert's similarity fingerprint code.

This splits Geert's similarity fingerprint code into main
program and fingerprinting function.  The next step would be to
try using this in pack-objects.c::try_delta() -- which would be
a good evaluation.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/logopt' into next
Junio C Hamano [Sat, 15 Apr 2006 08:59:49 +0000 (01:59 -0700)]
Merge branch 'jc/logopt' into next

* jc/logopt:
  Revert all the rev-list option parsing changes.

18 years agoRevert all the rev-list option parsing changes.
Junio C Hamano [Sat, 15 Apr 2006 08:59:40 +0000 (01:59 -0700)]
Revert all the rev-list option parsing changes.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into next
Junio C Hamano [Sat, 15 Apr 2006 06:21:48 +0000 (23:21 -0700)]
Merge branch 'master' into next

* master:
  GIT v1.3.0-rc4

18 years agoGIT v1.3.0-rc4 v1.3.0-rc4
Junio C Hamano [Sat, 15 Apr 2006 06:21:34 +0000 (23:21 -0700)]
GIT v1.3.0-rc4

I've merged everything I think is ready for 1.3.0, so this is
the final round -- hopefully I can release this with minimum
last-minute fixup as v1.3.0 early next week.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'dl/xdiff'
Junio C Hamano [Sat, 15 Apr 2006 05:58:17 +0000 (22:58 -0700)]
Merge branch 'dl/xdiff'

* dl/xdiff:
  xdiff: post-process hunks to make them consistent.

18 years agoMerge branch 'lt/logopt' into next
Junio C Hamano [Sat, 15 Apr 2006 05:44:12 +0000 (22:44 -0700)]
Merge branch 'lt/logopt' into next

* lt/logopt:
  Fix up rev-list option parsing.
  Fix up default abbrev in setup_revisions() argument parser.
  Common option parsing for "git log --diff" and friends

18 years agoFix up rev-list option parsing.
Junio C Hamano [Sat, 15 Apr 2006 05:43:34 +0000 (22:43 -0700)]
Fix up rev-list option parsing.

rev-list does not take diff options, so barf after seeing some.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix up default abbrev in setup_revisions() argument parser.
Junio C Hamano [Sat, 15 Apr 2006 05:19:38 +0000 (22:19 -0700)]
Fix up default abbrev in setup_revisions() argument parser.

The default abbreviation precision should be DEFAULT_ABBREV as before.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoCommon option parsing for "git log --diff" and friends
Linus Torvalds [Fri, 14 Apr 2006 23:52:13 +0000 (16:52 -0700)]
Common option parsing for "git log --diff" and friends

This basically does a few things that are sadly somewhat interdependent,
and nontrivial to split out

 - get rid of "struct log_tree_opt"

   The fields in "log_tree_opt" are moved into "struct rev_info", and all
   users of log_tree_opt are changed to use the rev_info struct instead.

 - add the parsing for the log_tree_opt arguments to "setup_revision()"

 - make setup_revision set a flag (revs->diff) if the diff-related
   arguments were used. This allows "git log" to decide whether it wants
   to show diffs or not.

 - make setup_revision() also initialize the diffopt part of rev_info
   (which we had from before, but we just didn't initialize it)

 - make setup_revision() do all the "finishing touches" on it all (it will
   do the proper flag combination logic, and call "diff_setup_done()")

Now, that was the easy and straightforward part.

The slightly more involved part is that some of the programs that want to
use the new-and-improved rev_info parsing don't actually want _commits_,
they may want tree'ish arguments instead. That meant that I had to change
setup_revision() to parse the arguments not into the "revs->commits" list,
but into the "revs->pending_objects" list.

Then, when we do "prepare_revision_walk()", we walk that list, and create
the sorted commit list from there.

This actually cleaned some stuff up, but it's the less obvious part of the
patch, and re-organized the "revision.c" logic somewhat. It actually paves
the way for splitting argument parsing _entirely_ out of "revision.c",
since now the argument parsing really is totally independent of the commit
walking: that didn't use to be true, since there was lots of overlap with
get_commit_reference() handling etc, now the _only_ overlap is the shared
(and trivial) "add_pending_object()" thing.

However, I didn't do that file split, just because I wanted the diff
itself to be smaller, and show the actual changes more clearly. If this
gets accepted, I'll do further cleanups then - that includes the file
split, but also using the new infrastructure to do a nicer "git diff" etc.

Even in this form, it actually ends up removing more lines than it adds.

It's nice to note how simple and straightforward this makes the built-in
"git log" command, even though it continues to support all the diff flags
too. It doesn't get much simpler that this.

I think this is worth merging soonish, because it does allow for future
cleanup and even more sharing of code. However, it obviously touches
"revision.c", which is subtle. I've tested that it passes all the tests we
have, and it passes my "looks sane" detector, but somebody else should
also give it a good look-over.

[jc: squashed the original and three "oops this too" updates, with
 another fix-up.]

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/bottomless' into next
Junio C Hamano [Sat, 15 Apr 2006 04:56:37 +0000 (21:56 -0700)]
Merge branch 'jc/bottomless' into next

* jc/bottomless:
  rev-list --bisect: limit list before bisecting.
  Clean up trailing whitespace when pretty-printing commits
  "git cmd -h" for shell scripts.
  git-log <diff-options> <paths> documentation
  Retire git-log.sh (take #4)
  stripspace: incomplete line fix (take #2)

18 years agoMerge branch 'js/diffstat'
Junio C Hamano [Sat, 15 Apr 2006 04:55:23 +0000 (21:55 -0700)]
Merge branch 'js/diffstat'

* js/diffstat:
  diff --stat: no need to ask funcnames nor context.
  diff-options: add --stat (take 2)
  diff-options: add --stat (take 2)

18 years agoMerge branch 'jc/fix5500'
Junio C Hamano [Sat, 15 Apr 2006 04:55:22 +0000 (21:55 -0700)]
Merge branch 'jc/fix5500'

* jc/fix5500:
  t5500: test fix

18 years agorev-list --bisect: limit list before bisecting.
Junio C Hamano [Fri, 14 Apr 2006 22:57:32 +0000 (15:57 -0700)]
rev-list --bisect: limit list before bisecting.

I noticed bisect does not work well without both good and bad.
Running this script in git.git repository would give you quite
different results:

#!/bin/sh
        initial=e83c5163316f89bfbde7d9ab23ca2e25604af290

        mid0=`git rev-list --bisect ^$initial --all`

        git rev-list $mid0 | wc -l
        git rev-list ^$mid0 --all | wc -l

        mid1=`git rev-list --bisect --all`

        git rev-list $mid1 | wc -l
        git rev-list ^$mid1 --all | wc -l

The $initial commit is the very first commit you made.  The
first midpoint bisects things evenly as designed, but the latter
does not.

The reason I got interested in this was because I was wondering
if something like the following would help people converting a
huge repository from foreign SCM, or preparing a repository to
be fetched over plain dumb HTTP only:

        #!/bin/sh

        N=4
        P=.git/objects/pack
        bottom=

        while test 0 \< $N
        do
                N=$((N-1))
                if test -z "$bottom"
                then
                        newbottom=`git rev-list --bisect --all`
                else
                        newbottom=`git rev-list --bisect ^$bottom --all`
                fi
                if test -z "$bottom"
                then
                        rev_list="$newbottom"
                elif test 0 = $N
                then
                        rev_list="^$bottom --all"
                else
                        rev_list="^$bottom $newbottom"
                fi
                p=$(git rev-list --unpacked --objects $rev_list |
                    git pack-objects $P/pack)
                git show-index <$P/pack-$p.idx | wc -l
                bottom=$newbottom
        done

The idea is to pack older half of the history to one pack, then
older half of the remaining history to another, to continue a
few times, using finer granularity as we get closer to the tip.

This may not matter, since for a truly huge history, running
bisect number of times could be quite time consuming, and we
might be better off running "git rev-list --all" once into a
temporary file, and manually pick cut-off points from the
resulting list of commits.  After all we are talking about
"approximately half" for such an usage, and older history does
not matter much.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoClean up trailing whitespace when pretty-printing commits
Linus Torvalds [Sat, 15 Apr 2006 04:20:51 +0000 (21:20 -0700)]
Clean up trailing whitespace when pretty-printing commits

Partly because we've messed up and now have some commits with trailing
whitespace, but partly because this also just simplifies the code, let's
remove trailing whitespace from the end when pretty-printing commits.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years ago"git cmd -h" for shell scripts.
Junio C Hamano [Fri, 14 Apr 2006 22:54:51 +0000 (15:54 -0700)]
"git cmd -h" for shell scripts.

Wrappers that use sh-setup took --help but not -h.  Noticed by
Sébastien Pierre.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-log <diff-options> <paths> documentation
Junio C Hamano [Fri, 14 Apr 2006 19:59:09 +0000 (12:59 -0700)]
git-log <diff-options> <paths> documentation

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRetire git-log.sh (take #4)
Junio C Hamano [Fri, 14 Apr 2006 19:47:10 +0000 (12:47 -0700)]
Retire git-log.sh (take #4)

Noticed by Johannes.  We do not install it anymore, but still have
been shipping the source, which was crazy.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agostripspace: incomplete line fix (take #2)
Junio C Hamano [Fri, 14 Apr 2006 19:41:51 +0000 (12:41 -0700)]
stripspace: incomplete line fix (take #2)

This fixes f4ee3eb68906f079dea45de4f1bbb03d68189eb3 breakage, which
added an extra trailing blank line after stripping trailing blank lines
by mistake.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/fix5500' into next
Junio C Hamano [Fri, 14 Apr 2006 07:28:52 +0000 (00:28 -0700)]
Merge branch 'jc/fix5500' into next

* jc/fix5500:
  t5500: test fix

18 years agoMerge branch 'js/diffstat' into next
Junio C Hamano [Fri, 14 Apr 2006 07:28:42 +0000 (00:28 -0700)]
Merge branch 'js/diffstat' into next

* js/diffstat:
  diff --stat: no need to ask funcnames nor context.

18 years agot5500: test fix
Junio C Hamano [Fri, 14 Apr 2006 05:28:06 +0000 (22:28 -0700)]
t5500: test fix

Relying on eye-candy progress bar was fragile to begin with.
Run fetch-pack with -k option, and count the objects that are in
the pack that were transferred from the other end.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agodiff --stat: no need to ask funcnames nor context.
Junio C Hamano [Fri, 14 Apr 2006 04:35:54 +0000 (21:35 -0700)]
diff --stat: no need to ask funcnames nor context.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into next
Junio C Hamano [Fri, 14 Apr 2006 02:05:51 +0000 (19:05 -0700)]
Merge branch 'master' into next

* master:
  Fix-up previous expr changes.

18 years agoFix-up previous expr changes.
Junio C Hamano [Fri, 14 Apr 2006 02:05:38 +0000 (19:05 -0700)]
Fix-up previous expr changes.

The regexp on the right hand side of expr : operator somehow was
broken.

expr 'z+pu:refs/tags/ko-pu' : 'z\+\(.*\)'

does not strip '+'; write 'z+\(.*\)' instead.

We probably should switch to shell based substring post 1.3.0;
that's not bashism but just POSIX anyway.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'js/diffstat' into next
Junio C Hamano [Thu, 13 Apr 2006 23:50:48 +0000 (16:50 -0700)]
Merge branch 'js/diffstat' into next

* js/diffstat:
  diff-options: add --stat (take 2)
  diff-options: add --stat (take 2)

18 years agodiff-options: add --stat (take 2)
Johannes Schindelin [Thu, 13 Apr 2006 23:09:48 +0000 (01:09 +0200)]
diff-options: add --stat (take 2)

... and a fix for an invalid free():

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoxdiff: post-process hunks to make them consistent.
Davide Libenzi [Thu, 13 Apr 2006 23:45:13 +0000 (16:45 -0700)]
xdiff: post-process hunks to make them consistent.

18 years agodiff-options: add --stat (take 2)
Johannes Schindelin [Thu, 13 Apr 2006 22:15:30 +0000 (00:15 +0200)]
diff-options: add --stat (take 2)

Now, you can say "git diff --stat" (to get an idea how many changes are
uncommitted), or "git log --stat".

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoShell utilities: Guard against expr' magic tokens.
Mark Wooding [Thu, 13 Apr 2006 22:01:24 +0000 (22:01 +0000)]
Shell utilities: Guard against expr' magic tokens.

Some words, e.g., `match', are special to expr(1), and cause strange
parsing effects.  Track down all uses of expr and mangle the arguments
so that this isn't a problem.

Signed-off-by: Mark Wooding <mdw@distorted.org.uk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agot3600-rm: skip failed-remove test when we cannot make an unremovable file.
Junio C Hamano [Thu, 13 Apr 2006 18:57:57 +0000 (11:57 -0700)]
t3600-rm: skip failed-remove test when we cannot make an unremovable file.

When running t3600-rm test under fakeroot (or as root), we
cannot make a file unremovable with "chmod a-w .".  Detect this
case early and skip that test.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoUse less memory in "git log"
Linus Torvalds [Thu, 13 Apr 2006 17:01:02 +0000 (10:01 -0700)]
Use less memory in "git log"

This trivially avoids keeping the commit message data around after we
don't need it any more, avoiding a continually growing "git log" memory
footprint.

It's not a huge deal, but it's somewhat noticeable. For the current kernel
tree, doing a full "git log" I got

 - before: /usr/bin/time git log > /dev/null
0.81user 0.02system 0:00.84elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+8851minor)pagefaults 0swaps

 - after: /usr/bin/time git log > /dev/null
0.79user 0.03system 0:00.83elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+5039minor)pagefaults 0swaps

ie the touched pages dropped from 8851 to 5039. For the historic kernel
archive, the numbers are 18357->11037 minor page faults.

We could/should in theory free the commits themselves, but that's really a
lot harder, since during revision traversal we may hit the same commit
twice through different children having it as a parent, even after we've
shown it once (when that happens, we'll silently ignore it next time, but
we still need the "struct commit" to know).

And as the commit message data is clearly the biggest part of the commit,
this is the really easy 60% solution.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-log: do not output excess blank line between commits
Junio C Hamano [Thu, 13 Apr 2006 07:26:21 +0000 (00:26 -0700)]
git-log: do not output excess blank line between commits

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile: $(MAKE) check-docs
Junio C Hamano [Thu, 13 Apr 2006 07:17:19 +0000 (00:17 -0700)]
Makefile: $(MAKE) check-docs

This target lists undocumented commands, and/or whose document
is not referenced from the main git documentation.

For now, there are some exceptions I added primarily because I
lack the energy to document them myself:

 - merge backends (we should really document them)
 - ssh-push/ssh-pull (does anybody still use them?)
 - annotate and blame (maybe after one of them eats the other ;-)

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDocumentation: add a couple of missing docs.
Junio C Hamano [Thu, 13 Apr 2006 07:09:54 +0000 (00:09 -0700)]
Documentation: add a couple of missing docs.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/combine' into next
Junio C Hamano [Wed, 12 Apr 2006 20:24:48 +0000 (13:24 -0700)]
Merge branch 'jc/combine' into next

* jc/combine:
  stripspace: make sure not to leave an incomplete line.
  git-commit: do not muck with commit message when no_edit is set.
  When showing a commit message, do not lose an incomplete line.
  Retire t5501-old-fetch-and-upload test.
  combine-diff: type fix.

18 years agoMerge branch 'master' into jc/combine
Junio C Hamano [Wed, 12 Apr 2006 20:24:04 +0000 (13:24 -0700)]
Merge branch 'master' into jc/combine

* master:
  stripspace: make sure not to leave an incomplete line.
  git-commit: do not muck with commit message when no_edit is set.
  When showing a commit message, do not lose an incomplete line.
  Retire t5501-old-fetch-and-upload test.

18 years agocombine-diff: type fix.
Junio C Hamano [Wed, 12 Apr 2006 20:23:50 +0000 (13:23 -0700)]
combine-diff: type fix.

The variable hunk_end points at a line number, which is
represented as unsigned long by all the other variables.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agostripspace: make sure not to leave an incomplete line.
Junio C Hamano [Wed, 12 Apr 2006 20:10:27 +0000 (13:10 -0700)]
stripspace: make sure not to leave an incomplete line.

When dealing with a commit log message for human consumption, it
never makes sense to keep a log that ends with an incomplete
line, so make it a part of the clean-up process done by
git-stripspace.

Acked-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-commit: do not muck with commit message when no_edit is set.
Junio C Hamano [Wed, 12 Apr 2006 18:45:18 +0000 (11:45 -0700)]
git-commit: do not muck with commit message when no_edit is set.

Spotted by Linus and Darrin Thompson.  When we took a commit
message from -F <file> with an incomplete line, we appended "git
status" output, which ended up attaching a lone "#" at the end.

We still need the "do we have anything to commit?" check by
running "status" (which has to know what to do in different
cases with -i/-o/-a), but there is no point appending its output
to the proposed commit message given by the user.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoWhen showing a commit message, do not lose an incomplete line.
Linus Torvalds [Wed, 12 Apr 2006 18:31:23 +0000 (11:31 -0700)]
When showing a commit message, do not lose an incomplete line.

18 years agoRetire t5501-old-fetch-and-upload test.
Junio C Hamano [Tue, 11 Apr 2006 23:35:39 +0000 (16:35 -0700)]
Retire t5501-old-fetch-and-upload test.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/combine' into next
Junio C Hamano [Tue, 11 Apr 2006 21:34:59 +0000 (14:34 -0700)]
Merge branch 'jc/combine' into next

* jc/combine:
  combine-diff: fix hunks at the end (take #2).
  combine-diff: do not lose hunks with only deletion at end.

18 years agoMerge branch 'jc/diff' into next
Junio C Hamano [Tue, 11 Apr 2006 21:34:53 +0000 (14:34 -0700)]
Merge branch 'jc/diff' into next

* jc/diff:
  blame and friends: adjust to multiple pathspec change.
  git log --full-diff
  tree-diff: do not assume we use only one pathspec

18 years agocombine-diff: fix hunks at the end (take #2).
Junio C Hamano [Tue, 11 Apr 2006 21:31:31 +0000 (14:31 -0700)]
combine-diff: fix hunks at the end (take #2).

The previous round showed the delete-only hunks at the end, but
forgot to mark them interesting when they were.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agocombine-diff: do not lose hunks with only deletion at end.
Junio C Hamano [Tue, 11 Apr 2006 10:13:29 +0000 (03:13 -0700)]
combine-diff: do not lose hunks with only deletion at end.

We used to lose hunks that appear at the end and have only
deletion.  This makes sure that the record beyond the end of
file (which holds such deletions) is examined.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'ds/index' into next
Junio C Hamano [Tue, 11 Apr 2006 18:52:36 +0000 (11:52 -0700)]
Merge branch 'ds/index' into next

* ds/index:
  Replace index() with strchr().
  Solaris 9 also wants our own unsetenv/setenv.
  Retire git-log.sh (take #3)

18 years agoMerge branch 'jc/withraw' into next
Junio C Hamano [Tue, 11 Apr 2006 18:52:01 +0000 (11:52 -0700)]
Merge branch 'jc/withraw' into next

* jc/withraw:
  Separate the raw diff and patch with a newline
  Document --patch-with-raw

18 years agoReplace index() with strchr().
Dennis Stosberg [Tue, 11 Apr 2006 16:37:58 +0000 (18:37 +0200)]
Replace index() with strchr().

strchr() is more portable than index() and is used everywhere in
git already.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSolaris 9 also wants our own unsetenv/setenv.
Dennis Stosberg [Tue, 11 Apr 2006 18:42:26 +0000 (11:42 -0700)]
Solaris 9 also wants our own unsetenv/setenv.

[jc: the original had "index() is evil" but that should be a
separate patch.]

18 years agoRetire git-log.sh (take #3)
Junio C Hamano [Tue, 11 Apr 2006 18:29:36 +0000 (11:29 -0700)]
Retire git-log.sh (take #3)

Do not install built-in commands as separate files -- use
hardlinks instead.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSeparate the raw diff and patch with a newline
Petr Baudis [Tue, 11 Apr 2006 11:30:46 +0000 (13:30 +0200)]
Separate the raw diff and patch with a newline

More friendly for human reading I believe, and possibly friendlier to some
parsers (although only by an epsilon).

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDocument --patch-with-raw
Petr Baudis [Tue, 11 Apr 2006 11:22:17 +0000 (13:22 +0200)]
Document --patch-with-raw

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'eb/apply' into next
Junio C Hamano [Tue, 11 Apr 2006 02:45:30 +0000 (19:45 -0700)]
Merge branch 'eb/apply' into next

* eb/apply:
  Implement limited context matching in git-apply.

18 years agoMerge branch 'jc/withraw' into next
Junio C Hamano [Tue, 11 Apr 2006 02:44:35 +0000 (19:44 -0700)]
Merge branch 'jc/withraw' into next

* jc/withraw:
  diff-* --patch-with-raw
  Retire git-log.sh (take#2)
  Retire git-log.sh
  Retire diffcore-pathspec.
  Improve the git-diff-tree -c/-cc documentation

18 years agodiff-* --patch-with-raw
Junio C Hamano [Tue, 11 Apr 2006 00:36:53 +0000 (17:36 -0700)]
diff-* --patch-with-raw

This new flag outputs the diff-raw output and diff-patch output
at the same time.  Requested by Cogito.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoImplement limited context matching in git-apply.
Eric W. Biederman [Mon, 10 Apr 2006 09:33:06 +0000 (03:33 -0600)]
Implement limited context matching in git-apply.

Ok this really should be the good version.  The option
handling has been reworked to be automation safe.

Currently to import the -mm tree I have to work around
git-apply by using patch.  Because some of Andrews
patches in quilt will only apply with fuzz.

I started out implementing a --fuzz option and then I realized
fuzz is not a very safe concept for an automated system.  What
you really want is a minimum number of context lines that must
match.  This allows policy to be set without knowing how many
lines of context a patch actually provides.   By default
the policy remains to match all provided lines of context.

Allowng git-apply to match a restricted set of context makes
it much easier to import the -mm tree into git.  I am still only
processing  1.5 to 1.6 patches a second for the 692 patches in
2.6.17-rc1-mm2 is still painful but it does help.

If I just loop through all of Andrews patches in order
and run git-apply --index -C1 I process the entire patchset
in 1m53s or about 6 patches per second.  So running
git-mailinfo, git-write-tree, git-commit-tree, and
git-update-ref everytime has a measurable impact,
and shows things can be speeded up even more.

All of these timings were taking on my poor 700Mhz Athlon
with 512MB of ram.  So people with fast machiens should
see much better performance.

When a match is found after the number of context are reduced a
warning is generated.  Since this is a rare event and possibly
dangerous this seems to make sense.  Unless you are patching
a single file the error message is a little bit terse at
the moment, but it should be easy to go back and fix.

I have also updated the documentation for git-apply to reflect
the new -C option that sets the minimum number of context
lines that must match.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRetire git-log.sh (take#2)
Junio C Hamano [Tue, 11 Apr 2006 00:37:58 +0000 (17:37 -0700)]
Retire git-log.sh (take#2)

... and install a replacement properly.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoblame and friends: adjust to multiple pathspec change.
Junio C Hamano [Tue, 11 Apr 2006 01:14:54 +0000 (18:14 -0700)]
blame and friends: adjust to multiple pathspec change.

This makes things that include revision.h build again.

Blame is also built, but I am not sure how well it works (or how
well it worked to begin with) -- it was relying on tree-diff to
be using whatever pathspec was used the last time, which smells
a bit suspicious.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRetire git-log.sh
Junio C Hamano [Tue, 11 Apr 2006 00:37:58 +0000 (17:37 -0700)]
Retire git-log.sh

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit log --full-diff
Junio C Hamano [Mon, 10 Apr 2006 23:40:40 +0000 (16:40 -0700)]
git log --full-diff

Without this flag, "git log -p paths..." shows commits that
touch the specified paths, and diffs about the same specified
paths.  With this, the full diff is shown for commits that touch
the specified paths.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agotree-diff: do not assume we use only one pathspec
Junio C Hamano [Mon, 10 Apr 2006 23:39:11 +0000 (16:39 -0700)]
tree-diff: do not assume we use only one pathspec

The way tree-diff was set up assumed we would use only one set
of pathspec during the entire life of the program.  Move the
pathspec related static variables out to diff_options structure
so that we can filter commits with one set of paths while show
the actual diffs using different set of paths.

I suspect this breaks blame.c, and makes "git log paths..." to
default to the --full-diff, the latter of which is dealt with
the next commit.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into jc/diff
Junio C Hamano [Mon, 10 Apr 2006 23:44:59 +0000 (16:44 -0700)]
Merge branch 'master' into jc/diff

* master:
  Make "--parents" logs also be incremental
  Retire diffcore-pathspec.
  Improve the git-diff-tree -c/-cc documentation

18 years agoMerge branch 'lt/rev'
Junio C Hamano [Mon, 10 Apr 2006 22:58:41 +0000 (15:58 -0700)]
Merge branch 'lt/rev'

* lt/rev:
  Make "--parents" logs also be incremental

18 years agoRetire diffcore-pathspec.
Junio C Hamano [Mon, 10 Apr 2006 22:57:24 +0000 (15:57 -0700)]
Retire diffcore-pathspec.

Nobody except diff-stages used it -- the callers instead filtered
the input to diffcore themselves.  Make diff-stages do that as
well and retire diffcore-pathspec.

Signed-off-by: Junio C Hamano <junkio@cox.net>