collectd.git
17 years agoChangeLog: Documented the fix in the apcups plugin.
Florian Forster [Tue, 11 Sep 2007 09:50:43 +0000 (11:50 +0200)]
ChangeLog: Documented the fix in the apcups plugin.

17 years agoMerge branch 'uni/collectd-4.0' into collectd-4.0
Florian Forster [Tue, 11 Sep 2007 09:45:50 +0000 (11:45 +0200)]
Merge branch 'uni/collectd-4.0' into collectd-4.0

17 years agoapcups plugin: Fix the types used in the plugin.
Florian Forster [Tue, 11 Sep 2007 09:14:56 +0000 (11:14 +0200)]
apcups plugin: Fix the types used in the plugin.

They still had an `apcups_' prefix which isn't legal anymore.

17 years agocollectd: Make `mkdir' error messages more identifiable.
Florian Forster [Tue, 11 Sep 2007 09:11:25 +0000 (11:11 +0200)]
collectd: Make `mkdir' error messages more identifiable.

17 years agoChangeLog: Fix a merge bug.
Florian Forster [Mon, 10 Sep 2007 08:43:19 +0000 (10:43 +0200)]
ChangeLog: Fix a merge bug.

17 years agoChangeLog: Added a note about the improved `sstrerror' function.
Florian Forster [Mon, 10 Sep 2007 08:41:39 +0000 (10:41 +0200)]
ChangeLog: Added a note about the improved `sstrerror' function.

17 years agocontrib/collection.cgi: Fix a bug in the `meta_graph_generic_stack' function.
Florian Forster [Wed, 5 Sep 2007 07:30:01 +0000 (09:30 +0200)]
contrib/collection.cgi: Fix a bug in the `meta_graph_generic_stack' function.

Also add a meta-graph-handler for if_[rt]x_errors.

17 years agoMerge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Mon, 3 Sep 2007 14:00:23 +0000 (16:00 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0

17 years agosstrerror: Be even more cautios with the return value of `strerror_r'..
Florian Forster [Mon, 3 Sep 2007 12:44:53 +0000 (14:44 +0200)]
sstrerror: Be even more cautios with the return value of `strerror_r'..

I don't trust this GNU implementation one bit.. ;)

17 years agocontrib/collection.cgi: Display MySQL traffic as bits/s, not bytes/s.
Florian Forster [Sun, 2 Sep 2007 17:43:03 +0000 (19:43 +0200)]
contrib/collection.cgi: Display MySQL traffic as bits/s, not bytes/s.

17 years agocontrib/collection.cgi: Added meta graph handlers for nfs_procedure, ps_state, swap...
Florian Forster [Sun, 2 Sep 2007 17:28:09 +0000 (19:28 +0200)]
contrib/collection.cgi: Added meta graph handlers for nfs_procedure, ps_state, swap, mysql_commands, and mysql_handler.

17 years agosrc/common.c: Copy the error-string to the buffer - no matter which implementation...
Florian Forster [Sun, 2 Sep 2007 16:38:47 +0000 (18:38 +0200)]
src/common.c: Copy the error-string to the buffer - no matter which implementation is used.

17 years agocontrib/collection.cgi: Don't show all the plugins on the host's page.
Florian Forster [Sun, 2 Sep 2007 16:01:05 +0000 (18:01 +0200)]
contrib/collection.cgi: Don't show all the plugins on the host's page.

Waiting for so many graphs to load is no fun. You _have_ to specify the plugins
you're interested in now.

17 years agocontrib/collection.cgi: Quite some changes, but still incomplete and not very usable..
Florian Forster [Sat, 1 Sep 2007 18:59:27 +0000 (20:59 +0200)]
contrib/collection.cgi: Quite some changes, but still incomplete and not very usable..

17 years agoMerge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Sun, 2 Sep 2007 15:55:38 +0000 (17:55 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0

17 years agoAdded the AC_FUNC_STRERROR_R check.
Sebastian Harl [Sun, 2 Sep 2007 14:24:28 +0000 (16:24 +0200)]
Added the AC_FUNC_STRERROR_R check.

Even though Posix requires "strerror_r" to return an "int", some systems
(e.g. the GNU libc) return a "char *" _and_ ignore the second argument.

sstrerror() (in src/common.c) has been changed to be aware of this and
handle both cases correctly.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
17 years agosrc/plugin.c: Remove a legacy debug message.
Florian Forster [Sat, 1 Sep 2007 18:54:35 +0000 (20:54 +0200)]
src/plugin.c: Remove a legacy debug message.

17 years agocollectd.conf(5): Undo the changes of the previous merge.
Florian Forster [Fri, 31 Aug 2007 14:09:53 +0000 (16:09 +0200)]
collectd.conf(5): Undo the changes of the previous merge.

This problem doesn't exist in this version.

17 years agoMerge branch 'collectd-3.11' into collectd-4.0
Florian Forster [Fri, 31 Aug 2007 14:08:37 +0000 (16:08 +0200)]
Merge branch 'collectd-3.11' into collectd-4.0

Conflicts:

ChangeLog
configure.in

17 years agoBumped version to 3.11.6; Updated ChangeLog. collectd-3.11.6
Florian Forster [Fri, 31 Aug 2007 10:17:48 +0000 (12:17 +0200)]
Bumped version to 3.11.6; Updated ChangeLog.

17 years agoChangeLog: Added a short note about the fix in the processes plugin. collectd-4.0.7
Florian Forster [Tue, 28 Aug 2007 13:23:48 +0000 (15:23 +0200)]
ChangeLog: Added a short note about the fix in the processes plugin.

17 years agomysql plugin: Use a different define to determine if the read functionality should...
Florian Forster [Tue, 28 Aug 2007 13:18:27 +0000 (15:18 +0200)]
mysql plugin: Use a different define to determine if the read functionality should be enabled.

17 years agocollectd.conf(5): Added a note about that trailing whitespace bug.
Florian Forster [Mon, 27 Aug 2007 15:02:04 +0000 (17:02 +0200)]
collectd.conf(5): Added a note about that trailing whitespace bug.

17 years agoBumped version to 4.0.7; Updated ChangeLog.
Florian Forster [Sun, 26 Aug 2007 17:40:19 +0000 (19:40 +0200)]
Bumped version to 4.0.7; Updated ChangeLog.

17 years agoMerge branch 'collectd-3.11' into collectd-4.0
Florian Forster [Sun, 26 Aug 2007 17:07:46 +0000 (19:07 +0200)]
Merge branch 'collectd-3.11' into collectd-4.0

17 years agoprocesses plugin: Fix a possible segfault.
Florian Forster [Sun, 26 Aug 2007 17:07:10 +0000 (19:07 +0200)]
processes plugin: Fix a possible segfault.

17 years agobuild system: Several fixes for libcurl, libmysql, and libupsclient.
Florian Forster [Sun, 26 Aug 2007 13:14:36 +0000 (15:14 +0200)]
build system: Several fixes for libcurl, libmysql, and libupsclient.

libcurl:      Check for CFLAGS using `curl-config --cflags' and use these
      CFLAGS when checking for <curl/curl.h> to allow for weird
      locations of the library.
libmysql:     Cleaned up the checking code.
libupsclient: Check if the header file provides `UPSCONN' or `UPSCONN_t' and
      use the one available. This should fix compile issues with with
      the nut plugin.

17 years agobuild system: Use the libs provided by `mysql_config' to check for the lib itself.
Florian Forster [Fri, 24 Aug 2007 11:57:19 +0000 (13:57 +0200)]
build system: Use the libs provided by `mysql_config' to check for the lib itself.

17 years agoMerge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Fri, 24 Aug 2007 10:12:40 +0000 (12:12 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0

17 years agobuild system: Use `mysql_config' to find the appropriate flags for MySQL.
Florian Forster [Fri, 24 Aug 2007 10:12:23 +0000 (12:12 +0200)]
build system: Use `mysql_config' to find the appropriate flags for MySQL.

17 years agocontrib/collectd2html.pl: Don't invoke the Perl interpreter with `-w'.
Florian Forster [Wed, 22 Aug 2007 15:22:35 +0000 (17:22 +0200)]
contrib/collectd2html.pl: Don't invoke the Perl interpreter with `-w'.

17 years agocontrib/collectd2html.pl: Allow generation of graphs from remote hosts or in an alter...
Eddy Petrișor [Wed, 22 Aug 2007 15:15:34 +0000 (17:15 +0200)]
contrib/collectd2html.pl: Allow generation of graphs from remote hosts or in an alternative directory.

In the contribs area of the package there is a nice collectd2html.pl script
which assumes that the data is present in /var/lib/collectd and infers the
hostname. All fine and dandy, but there is no way to override this. This is
useful if one generates the data on a machine, but generates the graphs on
another one.

With the attached patch now is possible to specify a different host and/or a
different directory for the data.

The added options are '--host-is' and '--data-dir'.

An invocation for a remote host whose rrd files have been placed in
/var/tmp/collectd-remoteh looks like:
 collectd2html.pl --host-is=remoteh --data-dir=/var/tmp/collectd-remoteh

17 years agoMerge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Wed, 22 Aug 2007 14:37:29 +0000 (16:37 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0

17 years agoFixed some typos in the manpages.
Sebastian Harl [Thu, 9 Aug 2007 21:11:50 +0000 (23:11 +0200)]
Fixed some typos in the manpages.

The adjective "performant" does not seem to exist (neither in English nor
in German). I've replaced it with "efficient".

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
17 years agoREADME, contrib/README: Fixed some typos.
Sebastian Harl [Thu, 9 Aug 2007 21:11:03 +0000 (23:11 +0200)]
README, contrib/README: Fixed some typos.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
17 years agonetwork plugin: Allow port arguments to be numeric.
Florian Forster [Sun, 19 Aug 2007 15:19:12 +0000 (17:19 +0200)]
network plugin: Allow port arguments to be numeric.

17 years agoREADME: Added a pointer to the mailinglist.
Florian Forster [Sun, 19 Aug 2007 15:14:14 +0000 (17:14 +0200)]
README: Added a pointer to the mailinglist.

17 years agocontrib/fedora/collectd.spec: Updated for 4.0.6.
Kjell Randa [Sun, 5 Aug 2007 21:39:09 +0000 (23:39 +0200)]
contrib/fedora/collectd.spec: Updated for 4.0.6.

Hi,

Here is an updated version of the F7 rpm spec file.
It now handles updates as well (rpm -U).

When new versions of collectd are out please bump the version tag at the top of
the spec file.
It will then build correct version of collectd.

Regards
Kjell Randa

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
17 years agocollectd(1): Fix typo.
Michael Renzmann [Sat, 4 Aug 2007 10:22:54 +0000 (12:22 +0200)]
collectd(1): Fix typo.

17 years agoBumped version to 4.0.6; Updated ChangeLog. collectd-4.0.6
Florian Forster [Fri, 3 Aug 2007 08:09:47 +0000 (10:09 +0200)]
Bumped version to 4.0.6; Updated ChangeLog.

17 years agoMerge branch 'pull/collectd-4.0' into collectd-4.0
Florian Forster [Tue, 31 Jul 2007 07:29:46 +0000 (09:29 +0200)]
Merge branch 'pull/collectd-4.0' into collectd-4.0

17 years agosrc/collectd.conf.in: Added the `SocketFile' option for the email plugin.
Florian Forster [Tue, 31 Jul 2007 07:29:19 +0000 (09:29 +0200)]
src/collectd.conf.in: Added the `SocketFile' option for the email plugin.

17 years agoFixed Fedora specfile for Fedora 7 and collectd 4.0.5
Kjell Randa [Tue, 31 Jul 2007 07:28:38 +0000 (09:28 +0200)]
Fixed Fedora specfile for Fedora 7 and collectd 4.0.5

Hi,

Here is a working spec file for Fedora 7.
Copy the tar.gz file to /usr/src/redhat/SOURCES and run
  rpmbuild -ba collectd.spec
It has only been tested on  x86_64, but I well see if I can find time to test
on x86 as well.

Upgrade not tested.

The file /etc/collection.conf referenced in collection.cgi is missing in the
tar file and not installed by the spec file.

Regards
Kjell Randa

17 years agosyslog plugin: Call `openlog' right when the plugin is loaded.
Florian Forster [Mon, 30 Jul 2007 20:43:26 +0000 (22:43 +0200)]
syslog plugin: Call `openlog' right when the plugin is loaded.

17 years agosensors plugin: Fix the use of the ignorelist, so it matches the documentation.
Florian Forster [Mon, 30 Jul 2007 18:15:31 +0000 (20:15 +0200)]
sensors plugin: Fix the use of the ignorelist, so it matches the documentation.

17 years agoBumped version to 4.0.5; Updated ChangeLog. collectd-4.0.5
Florian Forster [Thu, 5 Jul 2007 20:02:48 +0000 (22:02 +0200)]
Bumped version to 4.0.5; Updated ChangeLog.

17 years agocollectd-nagios(1): Fix typo.
Florian Forster [Mon, 2 Jul 2007 09:59:46 +0000 (11:59 +0200)]
collectd-nagios(1): Fix typo.

17 years agodns plugin: Added support for the old bind-interface.
Florian Forster [Sun, 1 Jul 2007 07:50:43 +0000 (09:50 +0200)]
dns plugin: Added support for the old bind-interface.

Apparently it is still in use, even in new distributions:
-- 8< --
 bsbuild>uname -a
 OpenBSD bsbuild 4.1 GENERIC#1435 i386
 bsbuild>/usr/sbin/named -v
 BIND 9.3.4
-- >8 --

17 years agosrc/common.c: Allow the `pwbufp' argument to `getpwnam_r' to be NULL.
Florian Forster [Sun, 1 Jul 2007 06:53:18 +0000 (08:53 +0200)]
src/common.c: Allow the `pwbufp' argument to `getpwnam_r' to be NULL.

17 years agoImpelemt an own version of `getpwnam_r'.
Florian Forster [Sat, 30 Jun 2007 21:22:41 +0000 (23:22 +0200)]
Impelemt an own version of `getpwnam_r'.

Since OpenBSD doesn't provide a threadsafe version itself, we need to provide
it in this case.. :/

17 years ago{hddtemp,mbmon,ntpd} plugins: Only use the `AI_ADDRCONFIG' if it's defined.
Florian Forster [Sat, 30 Jun 2007 15:01:04 +0000 (17:01 +0200)]
{hddtemp,mbmon,ntpd} plugins: Only use the `AI_ADDRCONFIG' if it's defined.

17 years agoconfigure.in: Include `sys/types.h' and `sys/param.h' before other `sys/*.h' includes.
Florian Forster [Sat, 30 Jun 2007 14:04:26 +0000 (16:04 +0200)]
configure.in: Include `sys/types.h' and `sys/param.h' before other `sys/*.h' includes.

This fixes build problems under OpenBSD.

17 years agoBumped version to 4.0.4; Updated ChangeLog. collectd-4.0.4
Florian Forster [Sun, 24 Jun 2007 20:41:17 +0000 (22:41 +0200)]
Bumped version to 4.0.4; Updated ChangeLog.

17 years agosrc/collectd-nagios.c: Copy the NAN-defines from `collectd.h'.
Florian Forster [Sun, 24 Jun 2007 20:40:36 +0000 (22:40 +0200)]
src/collectd-nagios.c: Copy the NAN-defines from `collectd.h'.

This should fix the bug reported by Daniel Leite.

17 years agodns plugin: Check for `net/ppp_defs.h' and include it before `net/if_ppp.h' if it...
Florian Forster [Sat, 23 Jun 2007 07:02:13 +0000 (09:02 +0200)]
dns plugin: Check for `net/ppp_defs.h' and include it before `net/if_ppp.h' if it exists.

This hopefully solves build problems under OpenBSD.

17 years agomemory plugin: Fix a typo in the Solaris code.
Daniel Leite [Thu, 21 Jun 2007 08:45:18 +0000 (10:45 +0200)]
memory plugin: Fix a typo in the Solaris code.

17 years agoliboconfig: Added `%option noyywrap' to the scanner.
Florian Forster [Thu, 21 Jun 2007 08:40:49 +0000 (10:40 +0200)]
liboconfig: Added `%option noyywrap' to the scanner.

This should solve the link issues when collectd is built without flex being
installed.

17 years agoload plugin: Fix the Linux code that reads `/proc/loadavg'.
Florian Forster [Thu, 21 Jun 2007 08:39:39 +0000 (10:39 +0200)]
load plugin: Fix the Linux code that reads `/proc/loadavg'.

17 years agocpu, interface plugin: Fix compilation issues under Solaris.
Daniel Leite [Thu, 21 Jun 2007 08:38:24 +0000 (10:38 +0200)]
cpu, interface plugin: Fix compilation issues under Solaris.

17 years agoBumped version to 4.0.3. collectd-4.0.3
Florian Forster [Tue, 19 Jun 2007 19:31:07 +0000 (21:31 +0200)]
Bumped version to 4.0.3.

17 years agoChangeLog, README: Documented the `--with-nan-emulation' option.
Florian Forster [Tue, 19 Jun 2007 19:29:25 +0000 (21:29 +0200)]
ChangeLog, README: Documented the `--with-nan-emulation' option.

17 years agoconfigure: Implemented `--with-nan-emulation' for crosscompiling.
Florian Forster [Tue, 19 Jun 2007 18:48:15 +0000 (20:48 +0200)]
configure: Implemented `--with-nan-emulation' for crosscompiling.

When crosscompiling you cannot do the runtime checks for the (0.0 / 0.0) hack.
With this option you can force this implementation if neccessary.

17 years agosrc/Makefile.am: When building outside the source tree, install will fail
Ezra Peisach [Tue, 19 Jun 2007 06:10:10 +0000 (08:10 +0200)]
src/Makefile.am: When building outside the source tree, install will fail

Signed-off-by: Ezra Peisach <epeisach@med-xtal.bu.edu>
17 years agocsv, rrdtool plugin: Initialize a buffer correctly.
Ezra Peisach [Tue, 19 Jun 2007 06:05:47 +0000 (08:05 +0200)]
csv, rrdtool plugin: Initialize a buffer correctly.

While reading the source code, I found the following:

In csv.c (line 44) and rrdtool.c (line 363) (value_list_to_string) the
following syntax exists:

  memset (buffer, '\0', sizeof (buffer_len));

The sizeof should be removed - assuming that the desire is to zero the buffer
and not the first four (sizeof(int)) bytes.

Based on the code paths - I do not see an information leak - or any security
implications...

17 years agoChangeLog: Added changes for 4.0.3.
Florian Forster [Mon, 18 Jun 2007 16:42:42 +0000 (18:42 +0200)]
ChangeLog: Added changes for 4.0.3.

17 years agoping plugin: Actually check the uid, not the address of `getuid'.
Florian Forster [Mon, 18 Jun 2007 14:56:00 +0000 (16:56 +0200)]
ping plugin: Actually check the uid, not the address of `getuid'.

17 years agocpu plugin: Submit the right values in the Darwin code.
Florian Forster [Wed, 13 Jun 2007 21:21:38 +0000 (23:21 +0200)]
cpu plugin: Submit the right values in the Darwin code.

17 years agoBumped version to 4.0.2; Updated ChangeLog. collectd-4.0.2
Florian Forster [Tue, 12 Jun 2007 06:01:58 +0000 (08:01 +0200)]
Bumped version to 4.0.2; Updated ChangeLog.

17 years agohddtemp, ntpd plugin: Allow numeric `Port' arguments.
Florian Forster [Mon, 11 Jun 2007 10:08:57 +0000 (12:08 +0200)]
hddtemp, ntpd plugin: Allow numeric `Port' arguments.

17 years agoBumped version to 4.0.1; Updated ChangeLog. collectd-4.0.1
Florian Forster [Thu, 7 Jun 2007 08:21:57 +0000 (10:21 +0200)]
Bumped version to 4.0.1; Updated ChangeLog.

17 years agocontrib/collection.cgi: Added graphs for gauge, if_errors, ipt_bytes and ipt_packets.
Florian Forster [Thu, 7 Jun 2007 07:41:01 +0000 (09:41 +0200)]
contrib/collection.cgi: Added graphs for gauge, if_errors, ipt_bytes and ipt_packets.

17 years agoREADME, collectd.conf(5): its/it's in documentation
Evan Miller [Thu, 7 Jun 2007 07:22:44 +0000 (09:22 +0200)]
README, collectd.conf(5): its/it's in documentation

A grammatical pet peeve of mine...

Cheers,

Evan

17 years agocollectd.conf.pod: Fixed a typo.
Sebastian Harl [Tue, 5 Jun 2007 10:57:06 +0000 (12:57 +0200)]
collectd.conf.pod: Fixed a typo.

The rrdtool plugin does not create CSV-files ;-)

Signed-off-by: Sebastian Harl <sh@tokkee.org>
17 years agoiptables plugin: Fix a segfault when a comment is passed in the configuration.
Florian Forster [Wed, 6 Jun 2007 15:35:46 +0000 (17:35 +0200)]
iptables plugin: Fix a segfault when a comment is passed in the configuration.

17 years agoBumped version to 4.0.0; Updated ChangeLog. collectd-4.0.0
Florian Forster [Sun, 3 Jun 2007 17:55:51 +0000 (19:55 +0200)]
Bumped version to 4.0.0; Updated ChangeLog.

17 years agoMarked the perl plugin to be experimental.
Sebastian Harl [Sun, 3 Jun 2007 13:33:27 +0000 (15:33 +0200)]
Marked the perl plugin to be experimental.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
17 years agoAdded Perl module "Collectd" to contrib.
Sebastian Harl [Sun, 3 Jun 2007 13:32:55 +0000 (15:32 +0200)]
Added Perl module "Collectd" to contrib.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
17 years agoMerge branch 'pull/master'
Florian Forster [Sat, 2 Jun 2007 07:25:42 +0000 (09:25 +0200)]
Merge branch 'pull/master'

17 years agocollectd-unixsock(5): Corrected the information about the PUTVAL format.
Florian Forster [Sat, 2 Jun 2007 07:25:31 +0000 (09:25 +0200)]
collectd-unixsock(5): Corrected the information about the PUTVAL format.

17 years agocollectd-exec(5): Documented the recent changes.
Florian Forster [Thu, 31 May 2007 21:34:29 +0000 (23:34 +0200)]
collectd-exec(5): Documented the recent changes.

17 years agoexec plugin: Change the input format so it's identical to the one used in unixsock.
Florian Forster [Thu, 31 May 2007 21:16:41 +0000 (23:16 +0200)]
exec plugin: Change the input format so it's identical to the one used in unixsock.

17 years agounixsock plugin: Moved the `parse_identifier' code to `common.c'
Florian Forster [Thu, 31 May 2007 21:16:06 +0000 (23:16 +0200)]
unixsock plugin: Moved the `parse_identifier' code to `common.c'

The new function `parse_values' in `common.c' can be used to parse
`time:value0:value1:...', as used by RRDTool, the unixsock plugin and, in the
very near future, the exec plugin.

17 years agontpd plugin: Replace `syslog (LOG_ERR, ...)' with `ERROR (...)'.
Florian Forster [Wed, 30 May 2007 06:08:04 +0000 (08:08 +0200)]
ntpd plugin: Replace `syslog (LOG_ERR, ...)' with `ERROR (...)'.

17 years agoMerge branch 'collectd-3.11'
Florian Forster [Wed, 30 May 2007 06:06:48 +0000 (08:06 +0200)]
Merge branch 'collectd-3.11'

Conflicts:

ChangeLog
configure.in

17 years agoBumped version to 3.11.5; Updated ChangeLog. collectd-3.11.5
Florian Forster [Tue, 29 May 2007 20:51:49 +0000 (22:51 +0200)]
Bumped version to 3.11.5; Updated ChangeLog.

17 years agontpd plugin: Fix a possible buffer overflow.
Florian Forster [Tue, 29 May 2007 19:40:07 +0000 (21:40 +0200)]
ntpd plugin: Fix a possible buffer overflow.

17 years agoMerge branch 'pull/master'
Florian Forster [Fri, 25 May 2007 17:51:59 +0000 (19:51 +0200)]
Merge branch 'pull/master'

17 years agonetwork plugin: Prepend the plugin's name to debug messages.
Florian Forster [Fri, 25 May 2007 17:49:24 +0000 (19:49 +0200)]
network plugin: Prepend the plugin's name to debug messages.

17 years agoexec plugin: Print a warning when the returned string is incorrect.
Florian Forster [Fri, 25 May 2007 17:48:56 +0000 (19:48 +0200)]
exec plugin: Print a warning when the returned string is incorrect.

Also the debug messages have been beautified.

17 years agocontrib/migrate-3-4.px: Added usage information.
Florian Forster [Fri, 25 May 2007 17:47:04 +0000 (19:47 +0200)]
contrib/migrate-3-4.px: Added usage information.

17 years agocollectd.c: Added '-t' command line option.
Sebastian Harl [Wed, 23 May 2007 12:21:19 +0000 (14:21 +0200)]
collectd.c: Added '-t' command line option.

This option allows to test the configuration only. The program immediately
exits after parsing the config file. A return code not equal to zero indicates
an error.

Some typos have been fixed as well.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
17 years agomemory plugin: Fix unused variable warning under FreeBSD.
Florian Forster [Wed, 23 May 2007 15:52:00 +0000 (17:52 +0200)]
memory plugin: Fix unused variable warning under FreeBSD.

17 years agoMerge branch 'collectd-3.11'
Florian Forster [Tue, 22 May 2007 15:54:54 +0000 (17:54 +0200)]
Merge branch 'collectd-3.11'

Conflicts:

src/processes.c

17 years agoprocesses plugin: ps_read_tasks will fail under Linux 2.4.
Florian Forster [Tue, 22 May 2007 15:53:23 +0000 (17:53 +0200)]
processes plugin: ps_read_tasks will fail under Linux 2.4.

Take this into account and don't report all processes without tasks as zombies.

17 years agosensors plugin: Let the read-function fail if something isn't right..
Florian Forster [Tue, 22 May 2007 09:44:51 +0000 (11:44 +0200)]
sensors plugin: Let the read-function fail if something isn't right..

..so it gets suspended as it should be.

17 years agoplugin.c: Added a comment that explains why the order of the linked list and callback...
Florian Forster [Mon, 21 May 2007 05:21:28 +0000 (07:21 +0200)]
plugin.c: Added a comment that explains why the order of the linked list and callback are important.

17 years agoplugin.c: Advance the llentry_t pointer before calling the shutdown callback.
Sebastian Harl [Sun, 20 May 2007 20:59:21 +0000 (22:59 +0200)]
plugin.c: Advance the llentry_t pointer before calling the shutdown callback.

> Important note: Unregistering the shutdown callback during shutdown is
> somewhat tricky. Doing that frees the llist_t entry in plugin.c:list_shutdown.
> This might cause a segfault in plugin_shutdown_all () when it tries to access
> the next pointer of that entry. If plugin_unregister_shutdown () is the last
> statement before the return from the shutdown callback this should be save in
> about 99% of all cases. Still there should be some better way to handle this.

This is an imho nice way to fix it.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
17 years agoperl plugin: Unregister all callbacks from collectd when shutting down.
Sebastian Harl [Sun, 20 May 2007 20:58:03 +0000 (22:58 +0200)]
perl plugin: Unregister all callbacks from collectd when shutting down.

If we do not unregister the callbacks there is still an entry point into the
plugin after Perl has been shut down and its memory has been freed. This will
cause segmentation faults if collectd tries to call any of the registered
callbacks, e.g. by some plugin calling plugin_log () during shutdown.

Important note: Unregistering the shutdown callback during shutdown is
somewhat tricky. Doing that frees the llist_t entry in plugin.c:list_shutdown.
This might cause a segfault in plugin_shutdown_all () when it tries to access
the next pointer of that entry. If plugin_unregister_shutdown () is the last
statement before the return from the shutdown callback this should be save in
about 99% of all cases. Still there should be some better way to handle this.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
17 years agosrc/plugin.c: Remove slashed from host, {plugin,type}{,-instance} here.
Florian Forster [Sun, 20 May 2007 07:55:54 +0000 (09:55 +0200)]
src/plugin.c: Remove slashed from host, {plugin,type}{,-instance} here.

A fix in the disk plugin has been removed again.

17 years agoemail, users and vserver plugins: Changed license to GPL v2 only.
Sebastian Harl [Sat, 19 May 2007 21:38:12 +0000 (23:38 +0200)]
email, users and vserver plugins: Changed license to GPL v2 only.

Signed-off-by: Sebastian Harl <sh@tokkee.org>