collectd.git
8 years agoteamspeak plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 13:54:20 +0000 (15:54 +0200)]
teamspeak plugin: fix indentation

8 years agocurl_xml plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 13:24:47 +0000 (15:24 +0200)]
curl_xml plugin: fix indentation

8 years agoutils_curl_stats.c: fix order of calloc arguments
Ruben Kerkhof [Sat, 23 Jul 2016 13:23:03 +0000 (15:23 +0200)]
utils_curl_stats.c: fix order of calloc arguments

8 years agolibcollectdclient: remove unneccesary cast
Ruben Kerkhof [Sat, 23 Jul 2016 13:16:41 +0000 (15:16 +0200)]
libcollectdclient: remove unneccesary cast

8 years agoprocesses plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 13:07:25 +0000 (15:07 +0200)]
processes plugin: fix indentation

8 years agolog_logstash plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:59:38 +0000 (14:59 +0200)]
log_logstash plugin: fix indentation

8 years agocurl_json plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:57:04 +0000 (14:57 +0200)]
curl_json plugin: fix indentation

8 years agoconntrack plugin: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:56:21 +0000 (14:56 +0200)]
conntrack plugin: fix indentation

8 years agoutils_cmd_putval.c: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:54:32 +0000 (14:54 +0200)]
utils_cmd_putval.c: fix indentation

8 years agoutils_threshold.c: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 12:50:17 +0000 (14:50 +0200)]
utils_threshold.c: fix indentation

8 years agocollectd.h: guard define of __attribute__
Ruben Kerkhof [Sat, 23 Jul 2016 11:35:27 +0000 (13:35 +0200)]
collectd.h: guard define of __attribute__

It might have already been defined to a no-op in <sys/cdefs.h>

8 years agocollectd.h: remove unused defines
Ruben Kerkhof [Sat, 23 Jul 2016 11:34:00 +0000 (13:34 +0200)]
collectd.h: remove unused defines

8 years agocollectd.h: fix indentation
Ruben Kerkhof [Sat, 23 Jul 2016 11:27:39 +0000 (13:27 +0200)]
collectd.h: fix indentation

8 years agoMerge branch 'collectd-5.5'
Florian Forster [Thu, 21 Jul 2016 05:49:50 +0000 (07:49 +0200)]
Merge branch 'collectd-5.5'

8 years agoMerge branch 'collectd-5.4' into collectd-5.5
Florian Forster [Thu, 21 Jul 2016 05:49:25 +0000 (07:49 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5

8 years agonetwork plugin: Fix heap overflow in parse_packet().
Florian Forster [Tue, 19 Jul 2016 08:00:37 +0000 (10:00 +0200)]
network plugin: Fix heap overflow in parse_packet().

Emilien Gaspar has identified a heap overflow in parse_packet(), the
function used by the network plugin to parse incoming network packets.

This is a vulnerability in collectd, though the scope is not clear at
this point. At the very least specially crafted network packets can be
used to crash the daemon. We can't rule out a potential remote code
execution though.

Fixes: CVE-2016-6254

8 years agoMerge pull request #1765 from vincentbernat/fix/kafka-partition-selection
Ruben Kerkhof [Mon, 18 Jul 2016 18:36:06 +0000 (20:36 +0200)]
Merge pull request #1765 from vincentbernat/fix/kafka-partition-selection

write_kafka: ensure key is properly hashed to select partition

8 years agoMerge pull request #1785 from rinigus/master_issue1781
Ruben Kerkhof [Mon, 18 Jul 2016 18:20:40 +0000 (20:20 +0200)]
Merge pull request #1785 from rinigus/master_issue1781

disk plugin: release udev-based name. Fixes #1781

8 years agoMerge pull request #1794 from swt2c/smart_use_serial
Ruben Kerkhof [Mon, 18 Jul 2016 18:13:55 +0000 (20:13 +0200)]
Merge pull request #1794 from swt2c/smart_use_serial

smart plugin: add option to store data using serial number

8 years agoMerge pull request #1796 from tokkee/sh/configure
Ruben Kerkhof [Sun, 17 Jul 2016 19:02:29 +0000 (21:02 +0200)]
Merge pull request #1796 from tokkee/sh/configure

configure: Use AC_MSG_RESULT to print the config summary.

8 years agoconfigure: Use AC_MSG_RESULT to print the config summary.
Sebastian Harl [Sun, 17 Jul 2016 17:08:28 +0000 (19:08 +0200)]
configure: Use AC_MSG_RESULT to print the config summary.

This way, it will show up in config.log as well.

8 years agoconfigure: Add missing end fold marker (for Vim).
Sebastian Harl [Sun, 17 Jul 2016 16:59:12 +0000 (18:59 +0200)]
configure: Add missing end fold marker (for Vim).

8 years agoMerge pull request #1783 from matwey/ntp
Ruben Kerkhof [Sat, 16 Jul 2016 09:40:35 +0000 (11:40 +0200)]
Merge pull request #1783 from matwey/ntp

ntpd: Check STA_NANO in the server status

8 years agontpd: Check STA_NANO in the server status
Matwey V. Kornilov [Wed, 6 Jul 2016 13:00:55 +0000 (16:00 +0300)]
ntpd: Check STA_NANO in the server status

When STA_NANO is set in ik->status, then results are
expressed in nanoseconds (instead of microseconds by default).

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
8 years agozookeeper plugin: remove unneccesary cast
Ruben Kerkhof [Fri, 15 Jul 2016 20:13:47 +0000 (22:13 +0200)]
zookeeper plugin: remove unneccesary cast

8 years agontpd plugin: remove unneccesary casts
Ruben Kerkhof [Fri, 15 Jul 2016 20:04:38 +0000 (22:04 +0200)]
ntpd plugin: remove unneccesary casts

8 years agocollectd-nagios: fix some whitespace
Ruben Kerkhof [Fri, 15 Jul 2016 20:02:08 +0000 (22:02 +0200)]
collectd-nagios: fix some whitespace

8 years agovirt plugin: fix some whitespace
Ruben Kerkhof [Fri, 15 Jul 2016 20:01:44 +0000 (22:01 +0200)]
virt plugin: fix some whitespace

8 years agoMerge pull request #1793 from rubenk/fix-riemann-plugin-on-32bit-solaris
Ruben Kerkhof [Fri, 15 Jul 2016 15:02:22 +0000 (17:02 +0200)]
Merge pull request #1793 from rubenk/fix-riemann-plugin-on-32bit-solaris

Fix write_riemann plugin build on 32-bit Solaris

8 years agoFix write_riemann plugin build on 32-bit Solaris
Ruben Kerkhof [Fri, 15 Jul 2016 09:46:52 +0000 (11:46 +0200)]
Fix write_riemann plugin build on 32-bit Solaris

Fixes #1782

CC       write_riemann_la-write_riemann.lo
In file included from ./daemon/collectd.h:31:0,
                 from write_riemann.c:34:
./config.h:1664:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/limits.h:17:0,
                 from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/limits.h:168,
                 from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/syslimits.h:7,
                 from
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/limits.h:34,
                 from /opt/csw/include/protobuf-c/protobuf-c.h:200,
                 from /opt/csw/include/riemann/proto/riemann.pb-c.h:7,
                 from /opt/csw/include/riemann/attribute.h:21,
                 from /opt/csw/include/riemann/riemann-client.h:23,
                 from write_riemann.c:31:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-fixed/sys/feature_tests.h:196:0:
note: this is the location of the previous definition
 #define _FILE_OFFSET_BITS 32
 ^
cc1: all warnings being treated as errors
Makefile:4645: recipe for target 'write_riemann_la-write_riemann.lo'
failed
gmake[3]: *** [write_riemann_la-write_riemann.lo] Error 1
gmake[3]: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/src'
Makefile:4879: recipe for target 'all-recursive' failed
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/src'
Makefile:3209: recipe for target 'all' failed
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/src'
Makefile:572: recipe for target 'all-recursive' failed
gmake: *** [all-recursive] Error 1
gmake: Leaving directory
'/home/dam/mgar/pkg/collectd/trunk/work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166'
/home/dam/mgar/pkg/.buildsys/v2/gar//gar.lib.mk:874: die Regel für Ziel
„build-work/solaris10-i386/build-isa-pentium_pro/collectd-5.5.1.1126.g37fe166/Makefile“
scheiterte

8 years agosmart plugin: add option to store data using serial number
Scott Talbert [Fri, 15 Jul 2016 14:14:28 +0000 (10:14 -0400)]
smart plugin: add option to store data using serial number

Since a device name (e.g., /dev/sda) can change, allow using the serial number
to store SMART data as this will ensure the data for a given drive is always
kept together.

8 years agoMerge pull request #1770 from swt2c/smart_ignore_sleep
Ruben Kerkhof [Fri, 15 Jul 2016 14:03:15 +0000 (16:03 +0200)]
Merge pull request #1770 from swt2c/smart_ignore_sleep

smart plugin: add IgnoreSleepMode option to ignore sleeping disks

8 years agosmart plugin: add IgnoreSleepMode option to ignore sleeping disks
Scott Talbert [Fri, 15 Jul 2016 13:36:30 +0000 (09:36 -0400)]
smart plugin: add IgnoreSleepMode option to ignore sleeping disks

This option enables the smart plugin to use disks that libatasmart mistakenly
reports as asleep.  This happens because libatasmart has not been updated to
incorporate support for newer idle states in the ATA spec.

8 years agoMerge pull request #1773 from skob/master
Ruben Kerkhof [Fri, 15 Jul 2016 10:21:08 +0000 (12:21 +0200)]
Merge pull request #1773 from skob/master

Add slow queries statistics to mysql module

8 years agoAdd slow queries statistics to mysql module
skob [Tue, 28 Jun 2016 09:06:31 +0000 (13:06 +0400)]
Add slow queries statistics to mysql module

8 years agoMerge pull request #1774 from mmckinst/rdkafka_now_libkafka
Ruben Kerkhof [Fri, 15 Jul 2016 08:56:14 +0000 (10:56 +0200)]
Merge pull request #1774 from mmckinst/rdkafka_now_libkafka

rdkafka is called librdkafka

8 years agodisk plugin: release udev-based name. Fixes #1781
rinigus [Fri, 8 Jul 2016 12:36:37 +0000 (15:36 +0300)]
disk plugin: release udev-based name. Fixes #1781

8 years agordkafka is called librdkafka
Mark McKinstry [Wed, 29 Jun 2016 14:54:46 +0000 (10:54 -0400)]
rdkafka is called librdkafka

The [spec file for
librdkafka](https://github.com/edenhill/librdkafka/blob/master/packaging/rpm/librdkafka.spec)
calls its package 'librdkafka-devel', not 'rdkafka-devel'. Searching the
web for 'rdkafka-devel RPM' turns up nothing, all the RPMs are named
'librdkafka-devel'.

8 years agowrite_kafka: ensure key is properly hashed to select partition
Vincent Bernat [Wed, 15 Jun 2016 07:53:07 +0000 (09:53 +0200)]
write_kafka: ensure key is properly hashed to select partition

Otherwise, partition is selected solely on the first letter of the
key. If all your hosts are starting with the same letter, everything
ends up in a single partition.

8 years agoREADME: add reference to libxen
Marc Fournier [Tue, 14 Jun 2016 19:16:43 +0000 (21:16 +0200)]
README: add reference to libxen

8 years agoMerge branch 'collectd-5.5'
Marc Fournier [Tue, 14 Jun 2016 06:19:12 +0000 (08:19 +0200)]
Merge branch 'collectd-5.5'

8 years agoREADME: mention 3 missing plugins
Marc Fournier [Tue, 14 Jun 2016 06:19:03 +0000 (08:19 +0200)]
README: mention 3 missing plugins

8 years agoAUTHORS: mention new contributors and update plugin attributions
Marc Fournier [Tue, 14 Jun 2016 05:14:49 +0000 (07:14 +0200)]
AUTHORS: mention new contributors and update plugin attributions

8 years agoMerge branch 'collectd-5.4' into collectd-5.5
Marc Fournier [Tue, 14 Jun 2016 05:44:35 +0000 (07:44 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5

8 years agosrc/*.pod: fix minor warnings spotted by podchecker
Marc Fournier [Tue, 14 Jun 2016 05:38:30 +0000 (07:38 +0200)]
src/*.pod: fix minor warnings spotted by podchecker

8 years agocollectd.conf.pod: fix minor typos in ntpd plugin section
Marc Fournier [Tue, 14 Jun 2016 05:17:48 +0000 (07:17 +0200)]
collectd.conf.pod: fix minor typos in ntpd plugin section

8 years agodoc: add chronyd section to manpage
Marc Fournier [Tue, 14 Jun 2016 04:58:44 +0000 (06:58 +0200)]
doc: add chronyd section to manpage

8 years agoMerge pull request #1004 from tokkee/sh/curl
Ruben Kerkhof [Sat, 11 Jun 2016 10:18:57 +0000 (12:18 +0200)]
Merge pull request #1004 from tokkee/sh/curl

Add support for detailed cURL statistics

8 years agoLanguage and typo fixes.
Sebastian Harl [Fri, 10 Jun 2016 18:58:05 +0000 (20:58 +0200)]
Language and typo fixes.

8 years agoutils_curl_stats: Drop the nonnull attribute from curl_stats_from_config.
Sebastian Harl [Sat, 4 Jun 2016 16:51:44 +0000 (18:51 +0200)]
utils_curl_stats: Drop the nonnull attribute from curl_stats_from_config.

It's not overly useful after all but generates false compiler warnings /
errors on Xenial using CLANG, since we also check the parameter in the
function (which is what we want in the end and there's no risk in actually
calling it with a NULL value).

8 years agocurl stats: Use cf_util_get_boolean().
Sebastian Harl [Mon, 30 May 2016 21:29:05 +0000 (23:29 +0200)]
curl stats: Use cf_util_get_boolean().

8 years agocurl stats: Simplified some error checks and removed unused code.
Sebastian Harl [Mon, 30 May 2016 21:23:59 +0000 (23:23 +0200)]
curl stats: Simplified some error checks and removed unused code.

8 years agoconfigure / curl stats: Check for CURLINFO_APPCONNECT_TIME.
Sebastian Harl [Mon, 30 May 2016 21:10:08 +0000 (23:10 +0200)]
configure / curl stats: Check for CURLINFO_APPCONNECT_TIME.

It's available since cURL 7.19 but RHEL5 ships an older version.

8 years agocollectd.conf(5): Briefly explain MeasureResponseTime vs TotalTime.
Sebastian Harl [Mon, 30 May 2016 20:46:14 +0000 (22:46 +0200)]
collectd.conf(5): Briefly explain MeasureResponseTime vs TotalTime.

8 years agocurl stats: Use CamelCase identifiers instead of using underscores.
Sebastian Harl [Mon, 30 May 2016 20:39:53 +0000 (22:39 +0200)]
curl stats: Use CamelCase identifiers instead of using underscores.

This is more consistent with the usual collectd style but still close enough
to the names used in cURL.

8 years agocollectd.conf(5): Add documentation for cURL statistics.
Sebastian Harl [Sat, 18 Apr 2015 19:44:22 +0000 (21:44 +0200)]
collectd.conf(5): Add documentation for cURL statistics.

8 years agoAdd request specific statistics to all CURL-based plugins.
Sebastian Harl [Sat, 18 Apr 2015 17:36:08 +0000 (19:36 +0200)]
Add request specific statistics to all CURL-based plugins.

All metrics supported by curl_easy_getinfo can be retrieved and dispatched for
each request done through CURL. All statistics are optional and disabled by
default.

8 years agoconfigure.ac: indent and sort some conditionals
Ruben Kerkhof [Fri, 10 Jun 2016 10:27:55 +0000 (12:27 +0200)]
configure.ac: indent and sort some conditionals

8 years agoconfigure.ac: remove obsolete macro
Ruben Kerkhof [Fri, 10 Jun 2016 10:23:09 +0000 (12:23 +0200)]
configure.ac: remove obsolete macro

We don't need it anymore. See
http://gnu-autoconf.7623.n7.nabble.com/Bug-389558-autoconf-AC-PROG-GCC-TRADITIONAL-throws-error-in-comparision-td1885.html

8 years agochrony plugin: use ANSI function definitions
Ruben Kerkhof [Fri, 10 Jun 2016 08:46:28 +0000 (10:46 +0200)]
chrony plugin: use ANSI function definitions

chrony.c:392:1: warning: function declaration isn’t a prototype
[-Wstrict-prototypes]
 chrony_set_timeout()
 ^
chrony.c: In function ‘chrony_set_timeout’:
chrony.c:392:1: warning: old-style function definition
[-Wold-style-definition]
chrony.c: At top level:

8 years agoMerge pull request #1758 from rubenk/README
Ruben Kerkhof [Fri, 10 Jun 2016 08:11:01 +0000 (10:11 +0200)]
Merge pull request #1758 from rubenk/README

README: use https for collectd.org link

8 years agoMerge pull request #1759 from rubenk/ansi-function-declaration
Ruben Kerkhof [Fri, 10 Jun 2016 08:10:54 +0000 (10:10 +0200)]
Merge pull request #1759 from rubenk/ansi-function-declaration

uc_get_iterator: use ansi function declaration

8 years agoMerge branch 'collectd-5.5'
Ruben Kerkhof [Fri, 10 Jun 2016 07:48:23 +0000 (09:48 +0200)]
Merge branch 'collectd-5.5'

8 years agoMerge branch 'collectd-5.4' into collectd-5.5
Ruben Kerkhof [Fri, 10 Jun 2016 07:47:53 +0000 (09:47 +0200)]
Merge branch 'collectd-5.4' into collectd-5.5

8 years agoBug#1059 : Remove any white spaces in ethstats stat names (affects VMXNet3 interface)
Thomas Guthmann [Wed, 8 Jun 2016 03:03:47 +0000 (13:03 +1000)]
Bug#1059 : Remove any white spaces in ethstats stat names (affects VMXNet3 interface)

8 years agouc_get_iterator: use ansi function declaration
Ruben Kerkhof [Thu, 9 Jun 2016 21:09:18 +0000 (23:09 +0200)]
uc_get_iterator: use ansi function declaration

In file included from common.c:37:0:
utils_cache.h:76:1: warning: function declaration isn’t a prototype
[-Wstrict-prototypes]
 uc_iter_t *uc_get_iterator ();
 ^

8 years agoREADME: use https for collectd.org link
Ruben Kerkhof [Thu, 9 Jun 2016 17:56:56 +0000 (19:56 +0200)]
README: use https for collectd.org link

8 years agoMerge pull request #1750 from tokkee/sh/cli
Ruben Kerkhof [Mon, 6 Jun 2016 08:32:59 +0000 (10:32 +0200)]
Merge pull request #1750 from tokkee/sh/cli

daemon: Let all command line options override global options from the config.

8 years agoconfigfile: Log errors when trying to access unknown global options.
Sebastian Harl [Sun, 5 Jun 2016 22:09:58 +0000 (00:09 +0200)]
configfile: Log errors when trying to access unknown global options.

8 years agodaemon: Let all command line options override global options from the config.
Sebastian Harl [Sun, 5 Jun 2016 22:03:39 +0000 (00:03 +0200)]
daemon: Let all command line options override global options from the config.

This replaces 09fb81e130ad70bf0547cec3d3c349ce8cb092cf which provided a
specific solution for the `PIDFile' option. The new solution is generic and
more nicely abstracted without the need for global variables across multiple
modules.

Fixes #366

8 years agoMerge pull request #1747 from rubenk/write_graphite_check_fd
Sebastian Harl [Sun, 5 Jun 2016 13:34:28 +0000 (15:34 +0200)]
Merge pull request #1747 from rubenk/write_graphite_check_fd

Write graphite check fd

8 years agowg_send_buffer: return error if fd < 0
Ruben Kerkhof [Sun, 5 Jun 2016 12:36:36 +0000 (14:36 +0200)]
wg_send_buffer: return error if fd < 0

CID 116310

8 years agowrite_graphite: remove dead assignment
Ruben Kerkhof [Sun, 5 Jun 2016 12:35:36 +0000 (14:35 +0200)]
write_graphite: remove dead assignment

status is immediately overwritten in the next line.

8 years agoMerge pull request #1746 from rubenk/swrite-check-for-open-fd
Sebastian Harl [Sun, 5 Jun 2016 12:27:11 +0000 (14:27 +0200)]
Merge pull request #1746 from rubenk/swrite-check-for-open-fd

swrite: return error if fd is negative

8 years agoswrite: return error if fd is negative
Ruben Kerkhof [Sun, 5 Jun 2016 11:53:17 +0000 (13:53 +0200)]
swrite: return error if fd is negative

8 years agoMerge pull request #1743 from rubenk/apcups-coverity
Sebastian Harl [Sun, 5 Jun 2016 11:40:20 +0000 (13:40 +0200)]
Merge pull request #1743 from rubenk/apcups-coverity

apcups: ignore result of swrite in net_shutdown

8 years agoapcups: ignore result of swrite in net_shutdown
Ruben Kerkhof [Sun, 5 Jun 2016 11:03:42 +0000 (13:03 +0200)]
apcups: ignore result of swrite in net_shutdown

CID 37945

8 years agoAdd test logs to .gitignore
Ruben Kerkhof [Sun, 5 Jun 2016 10:42:45 +0000 (12:42 +0200)]
Add test logs to .gitignore

8 years agoautomake: disable gzipped tarballs
Ruben Kerkhof [Sat, 4 Jun 2016 22:24:28 +0000 (00:24 +0200)]
automake: disable gzipped tarballs

We only use bz2.

Fixes make distcheck on FreeBSD-11-CURRENT

test -n ""  || find "collectd-5.5.1.1086.g41e7c34" -type d ! -perm -755  -exec chmod u+rwx,go+rx {} \; -o  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o  ! -type d ! -perm -400 -exec chmod a+r {} \; -o  ! -type d ! -perm -444 -exec /bin/sh /home/ruben/src/collectd/libltdl/config/install-sh -c -m a+r {} {} \;  || chmod -R a+r "collectd-5.5.1.1086.g41e7c34"
tardir=collectd-5.5.1.1086.g41e7c34 && tar --format=posix -chf - "$tardir" | BZIP2=${BZIP2--9} bzip2 -c >collectd-5.5.1.1086.g41e7c34.tar.bz2
tardir=collectd-5.5.1.1086.g41e7c34 && tar --format=posix -chf - "$tardir" | GZIP=--best gzip -c >collectd-5.5.1.1086.g41e7c34.tar.gz
if test -d "collectd-5.5.1.1086.g41e7c34"; then  find "collectd-5.5.1.1086.g41e7c34" -type d ! -perm -200 -exec chmod u+w {} ';'  && rm -rf "collectd-5.5.1.1086.g41e7c34"  || { sleep 5 && rm -rf "collectd-5.5.1.1086.g41e7c34"; };  else :; fi
case 'collectd-5.5.1.1086.g41e7c34.tar.gz collectd-5.5.1.1086.g41e7c34.tar.bz2' in  *.tar.gz*)  GZIP=--best gzip -dc collectd-5.5.1.1086.g41e7c34.tar.gz | tar -xf - ;; *.tar.bz2*)  bzip2 -dc collectd-5.5.1.1086.g41e7c34.tar.bz2 | tar -xf - ;; *.tar.lz*)  lzip -dc collectd-5.5.1.1086.g41e7c34.tar.lz | tar -xf - ;; *.tar.xz*)  xz -dc collectd-5.5.1.1086.g41e7c34.tar.xz | tar -xf - ;; *.tar.Z*)  uncompress -c collectd-5.5.1.1086.g41e7c34.tar.Z | tar -xf - ;; *.shar.gz*)  GZIP=--best gzip -dc collectd-5.5.1.1086.g41e7c34.shar.gz | unshar ;; *.zip*)  unzip collectd-5.5.1.1086.g41e7c34.zip ;; esac
tar: Parse error: SCHILY.acl.default
tar: Parse error: SCHILY.acl.default
tar: Error exit delayed from previous errors.
*** Error code 1

Stop.
make: stopped in /usr/home/ruben/src/collectd

8 years agosrc/Makefile: Add valgrind.FreeBSD.suppress to the dist tarball.
Sebastian Harl [Sat, 4 Jun 2016 22:11:33 +0000 (00:11 +0200)]
src/Makefile: Add valgrind.FreeBSD.suppress to the dist tarball.

8 years agoMerge pull request #1742 from tokkee/sh/suppress
Ruben Kerkhof [Sat, 4 Jun 2016 21:05:32 +0000 (23:05 +0200)]
Merge pull request #1742 from tokkee/sh/suppress

Valgrind: Suppress a bogus invalid read on FreeBSD.

8 years agoMerge pull request #1741 from rubenk/fix-leak-in-disk-plugin
Sebastian Harl [Sat, 4 Jun 2016 20:27:09 +0000 (22:27 +0200)]
Merge pull request #1741 from rubenk/fix-leak-in-disk-plugin

Plug a memory leak in disk plugin

8 years agoValgrind: Suppress a bogus invalid read on FreeBSD.
Sebastian Harl [Sat, 4 Jun 2016 20:21:48 +0000 (22:21 +0200)]
Valgrind: Suppress a bogus invalid read on FreeBSD.

Valgrind reports an invalid read in common.c:parse_value. The error is
supposed to happen in strlen() on a just previously strdup()ed string.

Possibly, this is some sort of alignment issue. The read size is reported to
be 4 on a buffer of size 3.

https://bugzilla.redhat.com/show_bug.cgi?id=678518 may also be related.

8 years agoPlug a memory leak in disk plugin
Ruben Kerkhof [Sat, 4 Jun 2016 20:15:15 +0000 (22:15 +0200)]
Plug a memory leak in disk plugin

Introduced by bdbc066 so no need to backport.
CID 116311

8 years agoMakefile: Add testwrapper.sh to dist tarballs.
Sebastian Harl [Sat, 4 Jun 2016 18:27:30 +0000 (20:27 +0200)]
Makefile: Add testwrapper.sh to dist tarballs.

8 years agoMerge pull request #1740 from rubenk/correct-am_cflags
Ruben Kerkhof [Sat, 4 Jun 2016 18:16:56 +0000 (20:16 +0200)]
Merge pull request #1740 from rubenk/correct-am_cflags

Append -Werror to the right flags

8 years agochrony plugin: constify 2 function arguments
Ruben Kerkhof [Sat, 4 Jun 2016 18:11:33 +0000 (20:11 +0200)]
chrony plugin: constify 2 function arguments

Fixes a couple of dozen of these warnings:
chrony.c:889:20: warning: passing 'const char [14]' to parameter of type
'char *' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
  chrony_push_data("clock_stratum", "chrony", (__extension__ ({ unsigned
short int __v, __x = (unsigned short int)
(chrony_resp.body.tracking.f_stratum); if (__builtin_constant_p (__x))
__v = ((unsigned short int) ((((__x) >> 8) & 0xff) | (((__x) & 0xff) <<
8))); else __asm__ ("rorw $8, %w0" : "=r" (__v) : "0" (__x) : "cc");
__v; })));
                   ^~~~~~~~~~~~~~~

8 years agochrony plugin: fix clang warning
Ruben Kerkhof [Sat, 4 Jun 2016 18:07:08 +0000 (20:07 +0200)]
chrony plugin: fix clang warning

chrony.c:745:11: warning: declaration shadows a local variable
[-Wshadow]
      int fh = open("/dev/random", 00);
          ^

8 years agocollectd.spec: add missing %endif
Ruben Kerkhof [Sat, 4 Jun 2016 17:33:55 +0000 (19:33 +0200)]
collectd.spec: add missing %endif

8 years agoconfigure.ac: fix autoreconf warnings
Ruben Kerkhof [Sat, 4 Jun 2016 17:28:22 +0000 (19:28 +0200)]
configure.ac: fix autoreconf warnings

configure.ac:804: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call
detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
configure.ac:804: the top level

8 years agoAppend -Werror to the right flags
Ruben Kerkhof [Sat, 4 Jun 2016 17:20:26 +0000 (19:20 +0200)]
Append -Werror to the right flags

8 years agotestwrapper.sh: Use /bin/sh instead of /bin/bash.
Sebastian Harl [Sat, 4 Jun 2016 17:11:57 +0000 (19:11 +0200)]
testwrapper.sh: Use /bin/sh instead of /bin/bash.

We don't use any bashisms.

8 years agoMerge pull request #1739 from tokkee/sh/memcheck
Ruben Kerkhof [Sat, 4 Jun 2016 16:44:18 +0000 (18:44 +0200)]
Merge pull request #1739 from tokkee/sh/memcheck

unit tests: Run all tests through Valgrind's memcheck, if available.

8 years agoActually add the testwrapper.sh script.
Sebastian Harl [Sat, 4 Jun 2016 16:39:21 +0000 (18:39 +0200)]
Actually add the testwrapper.sh script.

… it's now used for running all tests.

8 years agoconfigure: Drop unneeded AC_SUBST() calls for AC_PATH_PROG() results.
Sebastian Harl [Sat, 4 Jun 2016 16:37:26 +0000 (18:37 +0200)]
configure: Drop unneeded AC_SUBST() calls for AC_PATH_PROG() results.

AC_PATH_PROG calls AC_SUBST for us.

8 years agounit tests: Run all tests through Valgrind's memcheck, if available.
Sebastian Harl [Sat, 4 Jun 2016 16:27:52 +0000 (18:27 +0200)]
unit tests: Run all tests through Valgrind's memcheck, if available.

8 years agocollectd.spec: add new gRPC plugin
Ruben Kerkhof [Sat, 4 Jun 2016 16:31:16 +0000 (18:31 +0200)]
collectd.spec: add new gRPC plugin

Disable it for now as the version of protobuf-compiler
in RHEL and Fedora is too old.

8 years agoceph_test: Free the yajl handle.
Sebastian Harl [Sat, 4 Jun 2016 16:26:44 +0000 (18:26 +0200)]
ceph_test: Free the yajl handle.

8 years agoutils_mount_test: Free dynamically allocated strings.
Sebastian Harl [Sat, 4 Jun 2016 16:25:06 +0000 (18:25 +0200)]
utils_mount_test: Free dynamically allocated strings.

8 years agotesting: Evaluate expressions only once in EXPECT_EQ_STR().
Sebastian Harl [Sat, 4 Jun 2016 16:24:23 +0000 (18:24 +0200)]
testing: Evaluate expressions only once in EXPECT_EQ_STR().