Florian Forster [Tue, 31 Mar 2009 07:45:19 +0000 (09:45 +0200)]
README: Added the `ted' plugin.
Florian Forster [Tue, 17 Mar 2009 08:22:11 +0000 (09:22 +0100)]
ted plugin: Fix some minor issues with Eric's patch.
Remove trailing whitespace, for example.
Eric Reed [Tue, 17 Mar 2009 08:02:18 +0000 (09:02 +0100)]
ted plugin: Some nondescript fixes.
Florian Forster [Sat, 14 Mar 2009 17:52:58 +0000 (18:52 +0100)]
Merge branch 'master' into er/ted
Florian Forster [Sat, 14 Mar 2009 17:52:38 +0000 (18:52 +0100)]
Merge branch 'collectd-4.6'
Florian Forster [Sat, 14 Mar 2009 17:52:19 +0000 (18:52 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 14 Mar 2009 17:49:52 +0000 (18:49 +0100)]
ted plugin: Don't expect a minimum length.
The serial interface apparently can only deliver 255 bytes at once, so
checking if we received ``enough'' (i. e. 278+x) bytes will never work.
Florian Forster [Sat, 14 Mar 2009 17:08:10 +0000 (18:08 +0100)]
Merge branch 'collectd-4.5' of octo@verplant.org:/var/lib/git/collectd into collectd-4.5
Bruno Prémont [Sat, 14 Mar 2009 17:06:58 +0000 (18:06 +0100)]
bind plugin: Actually handle RR cache numbers as `gauge'..
Hi Florian,
Well a working patch was even less trivial as the quick one from
yesterday evening.
Just using a gauge type is not sufficient (only 0 is written to RRD
files), it's also necessary to adjust the bind_xml_stats_handle_view()
as has been done for the memory statistics
Attached is a patch to bind.c (I skipped types.db) which fixes the
cache data collection.
In addition I attached a graph of the cache evolution and memory (for
memory it might be worth giving it an own type as it's not cumulative
at all)
Bruno
Florian Forster [Sat, 14 Mar 2009 17:06:19 +0000 (18:06 +0100)]
bind plugin: "Trivial patch" to make `rr cache' stats work.
Florian Forster [Sat, 14 Mar 2009 16:54:19 +0000 (17:54 +0100)]
contrib/collection3: Use {interface} in `if_octets' graphs.
Florian Forster [Sat, 14 Mar 2009 16:53:55 +0000 (17:53 +0100)]
contrib/collection3: Add graph for `ps_cputime'.
Florian Forster [Sat, 14 Mar 2009 12:31:00 +0000 (13:31 +0100)]
contrib/collection3: Add the "height" parameter.
Florian Forster [Fri, 13 Mar 2009 17:23:20 +0000 (18:23 +0100)]
src/common.c, memory plugin: Fix a potential problem under Solaris.
When the kstat chain has been updated (and init is called again),
get_kstat should overwrite the existing kstat pointer thingy.
Florian Forster [Fri, 13 Mar 2009 15:20:36 +0000 (16:20 +0100)]
contrib/collection3: Fix two minor issues.
Stefan Pfab [Fri, 13 Mar 2009 14:49:02 +0000 (15:49 +0100)]
contrib/collection3: Add "Wirkleistung" graph.
Florian Forster [Fri, 13 Mar 2009 14:43:03 +0000 (15:43 +0100)]
contrib/collection3: Minor HTML work-around for some browsers.
Florian Forster [Fri, 13 Mar 2009 14:42:30 +0000 (15:42 +0100)]
contrib/collection3: Update bin/json.cgi to use the JSON module.
Florian Forster [Fri, 13 Mar 2009 14:39:38 +0000 (15:39 +0100)]
contrib/collection3: Add graph for "Table space" graphs.
Florian Forster [Fri, 13 Mar 2009 14:34:30 +0000 (15:34 +0100)]
contrib/collecion3: Add graphs for `dns_opcode' and `io_octets'.
Florian Forster [Fri, 13 Mar 2009 14:30:54 +0000 (15:30 +0100)]
contrib/collection3: Add the `index' to the parameters.
Florian Forster [Thu, 12 Mar 2009 07:56:36 +0000 (08:56 +0100)]
src/liboping/test_liboping.c: Remove legacy file.
Florian Forster [Mon, 9 Mar 2009 17:48:20 +0000 (18:48 +0100)]
Merge branch 'ff/gmond'
Florian Forster [Mon, 9 Mar 2009 17:48:12 +0000 (18:48 +0100)]
Merge branch 'collectd-4.6'
Florian Forster [Mon, 9 Mar 2009 17:45:46 +0000 (18:45 +0100)]
rrdtool plugin: Beatify a debugging message.
Florian Forster [Mon, 9 Mar 2009 17:45:06 +0000 (18:45 +0100)]
gmond plugin: Add a configuration.
Florian Forster [Mon, 9 Mar 2009 15:39:09 +0000 (16:39 +0100)]
gmond plugin: Add a plugin to receive Ganglia multicast traffic.
Sebastian Harl [Sat, 7 Mar 2009 17:03:42 +0000 (18:03 +0100)]
Merge branch 'sh/collectd-4.5' into sh/collectd-4.6
Conflicts:
contrib/collection3/lib/Collectd/Graph/Common.pm
src/postgresql_default.conf
Sebastian Harl [Sat, 7 Mar 2009 16:43:54 +0000 (17:43 +0100)]
postgresql_default.conf: Make sure the "disk_io" query does not return NULLs.
Starting with some version between 8.3.3 and 8.3.6, pg_statio_*_tables returns
NULL instead of 0 for statistics if no instance of the appropriate relation
exists. PQgetvalue() returns an empty string in that case which would then
result in error messages when udb_result_submit() tries to convert that to a
number.
Now, the "disk_io" query uses PostgreSQL's coalesce() function to make sure 0
is returned instead of NULL.
Florian Forster [Sat, 7 Mar 2009 11:22:10 +0000 (12:22 +0100)]
src/plugin.c: Remove an unused variable.
Florian Forster [Sat, 7 Mar 2009 11:18:32 +0000 (12:18 +0100)]
src/types.db: Removed the `ted' type.
Florian Forster [Sat, 7 Mar 2009 11:17:23 +0000 (12:17 +0100)]
collectd.conf(5): Documented the ted plugin.
Florian Forster [Sat, 7 Mar 2009 10:57:43 +0000 (11:57 +0100)]
ted plugin: Fix some rough edges.
Florian Forster [Sat, 7 Mar 2009 09:33:37 +0000 (10:33 +0100)]
ted plugin: Fix indentation and other style cleanups.
* Removed C++-style comments.
* Fixed a search-and-replace gone bad in the license information.
* Removed whitespaces at the end of line.
Eric Reed [Sat, 7 Mar 2009 08:59:13 +0000 (09:59 +0100)]
ted plugin: Updated ted.c based on Florian's input.
Eric Reed [Sat, 7 Mar 2009 08:56:46 +0000 (09:56 +0100)]
ted plugin: Add plugin for ``The Energy Detective''.
<http://www.theenergydetective.com/>
Tom Throckmorton [Fri, 6 Mar 2009 18:28:26 +0000 (19:28 +0100)]
contrib/exec-nagios.px: Make it possible to run the same script multiple times.
Florian Forster [Fri, 6 Mar 2009 15:53:28 +0000 (16:53 +0100)]
rrdtool plugin: Fix a possible race condition at startup.
On a very busy system, if the network plugin was initialized before the
rrdtool plugin, `rrd_cache_insert' may be called before the RRDtool
plugin is initialized. It would then pass `cache == NULL' to
`c_avl_get', resulting in a segmentation fault.
Sebastian Harl [Thu, 5 Mar 2009 10:49:17 +0000 (11:49 +0100)]
collectd.conf(5): Don't mix spaces and tabs in configuration examples.
Florian Forster [Thu, 5 Mar 2009 08:41:35 +0000 (09:41 +0100)]
contrib/collection3: Fix stacking with NAN values.
Stacked values above NAN values were not drawn previously..
Florian Forster [Thu, 5 Mar 2009 08:35:50 +0000 (09:35 +0100)]
contrib/collection3: Minor cleanups.
Florian Forster [Thu, 5 Mar 2009 08:35:28 +0000 (09:35 +0100)]
contrib/collection3: Add the "IgnoreUnknown" config option.
Used by the "GenericStacked" graphs.
Florian Forster [Thu, 5 Mar 2009 08:33:02 +0000 (09:33 +0100)]
contrib/collection3: Add "Total" to "GenericIO" graphs.
Using the RRDtool 1.2 VDEF syntax.
Florian Forster [Thu, 5 Mar 2009 08:30:06 +0000 (09:30 +0100)]
contrib/collection3: Add the "DataDir" config option.
Florian Forster [Thu, 5 Mar 2009 07:57:29 +0000 (08:57 +0100)]
contrib/collection3/bin/.htaccess: s/SetHandler/AddHandler/
SetHandler doesn't accept a file extension.
Florian Forster [Thu, 5 Mar 2009 07:51:51 +0000 (08:51 +0100)]
contrib/collection3/bin/.htaccess: Add file.
This has been missing. Wonder why nobody complained..?
Sebastian Harl [Wed, 4 Mar 2009 15:50:06 +0000 (16:50 +0100)]
postgresql_default.conf: Added a short usage and copyright header.
Sebastian Harl [Wed, 4 Mar 2009 15:00:53 +0000 (16:00 +0100)]
postgresql plugin: Made variable names more self-explanatory.
Also, while I was at it, improved some error messages.
Sebastian Harl [Wed, 4 Mar 2009 12:39:16 +0000 (13:39 +0100)]
postgresql_default.conf: Don't use the deprecated {Min,Max}PgVersion options.
Florian Forster [Mon, 2 Mar 2009 14:30:11 +0000 (15:30 +0100)]
collectd.conf(5): Mention that `Oracle' doesn't like semicolons..
.. at the end of the SQL statement.
Florian Forster [Mon, 2 Mar 2009 14:27:12 +0000 (15:27 +0100)]
libcollectdclient: Check if the file handle is valid before writing to it.
And free allocated memory when connecting fails. Only assign anything to
the user-provided pointer if `lcc_connect' succeeds. This should make
error-handling much more straight-forward.
Florian Forster [Mon, 2 Mar 2009 08:49:22 +0000 (09:49 +0100)]
snmp plugin: Added a note about a potential bug that needs fixing.
Negative absolute (gauge) values may be casted to an unsigned integer
variable on their way throught he daemon, producing VERY HIGH tempera-
tures in winter..
Florian Forster [Mon, 2 Mar 2009 08:31:37 +0000 (09:31 +0100)]
Merge branch 'bp/php-collection' into collectd-4.5
Bruno Prémont [Sun, 1 Mar 2009 21:20:10 +0000 (22:20 +0100)]
php-collection: Add support for named graph lists as favorites
php-collection: Add support for named graph lists as favorites
php-collection allowed saving and loading a list of graphs from a
cookie.
This patch changes loading/saving to provide support for naming
of favorite graph lists.
When saving a name has to be provided (up to 30 alphanumerical
characters includeing underscore and hyphen.
For loading a named list can be selected from a dropdown list (this list
is refreshed when it gets focus) of available favorites.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bruno Prémont [Sun, 1 Mar 2009 21:20:06 +0000 (22:20 +0100)]
php-collection/functions.php: Escape/avoid problematic characters in RRD commandline
php-collection/functions.php: Escape/avoid problematic characters in RRD commandline
rrdtool does not like '!' in variable names so replace them with '_'.
(bind plugin has them in a few type-instances and type-instance is used
as variable name by MetaGraphs)
Also escape rrdtool field seperators that might appear in file names.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bruno Prémont [Sun, 1 Mar 2009 21:19:59 +0000 (22:19 +0100)]
php-collection/definitions.php: Add MetaGraph definitions for bind plugin
php-collection/definitions.php: Add MetaGraph definitions for bind plugin
Add metagraph definition and matching function for the various
types used by bind plugin.
Adjust the memory MetaGraph function to support bind memory statistics.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bruno Prémont [Sun, 1 Mar 2009 21:19:49 +0000 (22:19 +0100)]
php-collection/graph.php: Add missing error500() function
php-collection/graph.php: Add missing error500() function
When a call to rrdtool fails or some other internal error occurs
a HTTP error with code 500 and matching error image should be
returned, added the missing error500() function which does this
the same way as error404() and error400() functions.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bruno Prémont [Sun, 1 Mar 2009 21:19:43 +0000 (22:19 +0100)]
php-collection: Fixes and multiple saved graph lists
php-collection/functions.php: Fix collectd_flush()
Some obsolete code in collectd_flush() caused PHP Notice errors
and prevented caused the function to return before attempting
to ask collectd to flush cache.
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bruno Prémont [Sun, 1 Mar 2009 21:19:37 +0000 (22:19 +0100)]
php-collection/definitions.php: Add missing MetaGraph for tcp_connections
php-collection/definitions.php: Add missing MetaGraph for tcp_connections
Add missing MetaGraph reference for tcp_connections and fix DS name
for the MetaGraph
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
Bruno Prémont [Mon, 2 Mar 2009 08:24:39 +0000 (09:24 +0100)]
contrib/php-collection: A few more bug-fixes to the graphing scripts.
This removes some obsolete code which prevents flush from working and adds
missing wrapper error500().
Florian Forster [Sun, 1 Mar 2009 08:43:54 +0000 (09:43 +0100)]
src/plugin.c, network, rrdtool: Improved thread shutdown.
Just some comments, info messages and not assigning zero to pthread_t.
Florian Forster [Sun, 1 Mar 2009 08:42:33 +0000 (09:42 +0100)]
ping plugin: Add support for drop rate and standard deviation.
Florian Forster [Sat, 28 Feb 2009 14:40:45 +0000 (15:40 +0100)]
README: Documented the `--with-fp-layout' configure option.
Florian Forster [Sat, 28 Feb 2009 13:14:23 +0000 (14:14 +0100)]
src/collectd.conf.in: Only include very few standard plugins by default.
Available but disabled by default plugins are listed with one hash
mark ("#") in front of them; unavailable plugins are listed with two hash
marks ("##") in front of them.
Plugins loaded by default are:
- syslog || logfile
- rrdtool || network || csv
- cpu
- interface
- load
- memory
Florian Forster [Sat, 28 Feb 2009 13:09:35 +0000 (14:09 +0100)]
protocols plugin: Add to configuration summary and collectd.conf.in.
Florian Forster [Sat, 28 Feb 2009 11:12:54 +0000 (12:12 +0100)]
protocols plugin: Add a plugin which collets protocol information.
Currently a Linux only plugin. This plugin collects information about
IP, TCP, UDP, etc.
Thanks to Ulf Zimmermann for his (indirect) suggestion ;)
Florian Forster [Sat, 28 Feb 2009 09:35:58 +0000 (10:35 +0100)]
Merge branch 'ff/java'
Florian Forster [Sat, 28 Feb 2009 09:35:17 +0000 (10:35 +0100)]
Merge branch 'collectd-4.6'
Florian Forster [Sat, 28 Feb 2009 09:35:04 +0000 (10:35 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 28 Feb 2009 09:29:08 +0000 (10:29 +0100)]
dns plugin: Don't pass a NULL pointer to `pcap_open_live'.
Although the documentation states clearly, that passing a NULL pointer
as device is okay and handled like "any", doing so will crash the daemon
on some systems, most notably *BSDs but Linux users have reported this
behavior, too.
This patch passes "any" when the pointer it NULL, which reportedly
resulted in a different behavior, but still crashing the daemon. We'll
keep trying ;)
Florian Forster [Fri, 27 Feb 2009 13:09:12 +0000 (14:09 +0100)]
oracle plugin: Fix type size issue under 64bit systems.
Under 64bit systems, `ub4' is of a different size than `size_t', so that a
`(size_t *)' cannot be casted to a `(ub4 *)' automatically.
Florian Forster [Tue, 24 Feb 2009 10:42:35 +0000 (11:42 +0100)]
contrib/oracle/create_schema.ddl: Add GPLv2 license information.
In accordance with Roman Klesel,
<
C937BDA691901BFAD72AFEF3@ganga.office.noris.de>
Sebastian Harl [Tue, 24 Feb 2009 10:27:22 +0000 (11:27 +0100)]
src/common.c: Fixed a race condition in check_create_dir().
Between checking for the existence of a directory using stat() and creating
the directory using mkdir(), another thread might have already created the
directory thus causing mkdir() to fail with errno == EEXIST. This case is now
handled sanely, no longer causing the function (and thus some write callback)
to fail in this case.
Most likely, this only happens during startup when creating the data
directories - later, no two threads should try to create the same directory.
Interestingly enough, I frequently encountered this issue on a single core
machine.
Florian Forster [Tue, 24 Feb 2009 10:24:38 +0000 (11:24 +0100)]
collectd.conf(5), collectd-java(5): Updated the documentation for the Java plugin.
Florian Forster [Tue, 24 Feb 2009 09:53:43 +0000 (10:53 +0100)]
collectd-java(5): Documented the `match' and `target' callbacks.
Florian Forster [Tue, 24 Feb 2009 09:13:11 +0000 (10:13 +0100)]
bindings/java/: CollectdMatchFactoryInterface: Add more JavaDoc.
Florian Forster [Tue, 24 Feb 2009 09:12:45 +0000 (10:12 +0100)]
bindings/java/: Unify inline documentation terms.
s/function/method/
Florian Forster [Tue, 24 Feb 2009 09:11:56 +0000 (10:11 +0100)]
java plugin: Add support for `target' callbacks.
With the ``do everything while in the configuration phase'' issues all
sorted out, this was actually kinda easy.
Matches and targets share a lot of code, so that the patch actually isn't
all that large..
Now, the Java plugin is feature-complete \o/
Florian Forster [Tue, 24 Feb 2009 09:16:19 +0000 (10:16 +0100)]
Merge branch 'master' into ff/java
Florian Forster [Tue, 24 Feb 2009 09:15:52 +0000 (10:15 +0100)]
Merge branch 'collectd-4.6'
Florian Forster [Tue, 24 Feb 2009 09:08:29 +0000 (10:08 +0100)]
src/plugin.c: Assure that targets get dynamically allocated memory.
If targets want to replace the values, they will have to use dynamically
allocated memory. If they can't free the values, because the pointer
might point to statically allocated memory, memory will be lost.
Unfortunately stack allocation will not do, since we will then not be able
to detect multiple replacements.
To impose as little a performance issue as possible, the dynamic allo-
cation is only done when either chain is present. If the filter mecha-
nism is not used, the values will not be copied.
Florian Forster [Mon, 23 Feb 2009 17:59:04 +0000 (18:59 +0100)]
java plugin: Add support for `match' callbacks.
Holy crap, that one needed some serious magic.. The problem is, that the
filter chains are created before the initialization functions are run.
Since the Java plugin used to initialize the JVM and load the classes in
the init function, the match callbacks were not available in time.
The behavior is now: Create the JVM as soon as the the first `LoadPlugin'
option is found and load and configure all Java plugins while in the
configuration phase. (I. e. exactly like C plugins.)
Phew, I've earned that beer now.
Florian Forster [Mon, 23 Feb 2009 14:38:29 +0000 (15:38 +0100)]
logfile plugin: Interpret `(notification_t *)->time == 0' as `now'.
Florian Forster [Mon, 23 Feb 2009 14:37:44 +0000 (15:37 +0100)]
java plugin: Expose `plugin_dispatch_notification' to Java plugins.
Florian Forster [Mon, 23 Feb 2009 14:37:01 +0000 (15:37 +0100)]
src/collectd.conf.in: Add `LoadPlugin java'.
Florian Forster [Mon, 23 Feb 2009 14:36:40 +0000 (15:36 +0100)]
src/plugin.c: Fix plugin_dispatch_notification again.
Florian Forster [Mon, 23 Feb 2009 13:57:56 +0000 (14:57 +0100)]
java plugin: Add support for `notification' callbacks.
Florian Forster [Mon, 23 Feb 2009 13:50:03 +0000 (14:50 +0100)]
src/plugin.c: Add a user_data_t pointer to notification callbacks.
Florian Forster [Sun, 22 Feb 2009 23:05:35 +0000 (00:05 +0100)]
bindings/java/: Add some javadoc markup to the interfaces.
Florian Forster [Sun, 22 Feb 2009 22:30:06 +0000 (23:30 +0100)]
collectd-java(5): Fix a typo.
Sebastian Harl [Sun, 22 Feb 2009 21:53:50 +0000 (22:53 +0100)]
Updated various copyright information.
Florian Forster [Sun, 22 Feb 2009 22:18:58 +0000 (23:18 +0100)]
collectd.conf(5): Updated the information on the java plugin.
Florian Forster [Sun, 22 Feb 2009 22:18:43 +0000 (23:18 +0100)]
java plugin: Add support for `log' callbacks.
Florian Forster [Sun, 22 Feb 2009 22:03:00 +0000 (23:03 +0100)]
src/plugin.c: Add a user_data_t pointer to log callbacks.
Sebastian Harl [Sun, 22 Feb 2009 21:53:50 +0000 (22:53 +0100)]
Updated various copyright information.
Florian Forster [Sun, 22 Feb 2009 21:15:47 +0000 (22:15 +0100)]
java plugin: Add support for `flush' callbacks.
Florian Forster [Sun, 22 Feb 2009 20:48:05 +0000 (21:48 +0100)]
src/plugin.c: Add a user_data_t pointer to flush callbacks.
Sebastian Harl [Sun, 22 Feb 2009 20:02:05 +0000 (21:02 +0100)]
collectd-unixsock(5): Slightly improved the description.
Florian Forster [Sun, 22 Feb 2009 18:50:14 +0000 (19:50 +0100)]
Merge branch 'master' into ff/java
Florian Forster [Sun, 22 Feb 2009 18:49:33 +0000 (19:49 +0100)]
Merge branch 'collectd-4.6'
Conflicts:
src/bind.c