collectd.git
6 years agorename plugin to "gpu_nvidia"
Evgeny Naumov [Fri, 26 Oct 2018 22:13:27 +0000 (18:13 -0400)]
rename plugin to "gpu_nvidia"

6 years agofix formatting
Evgeny Naumov [Wed, 24 Oct 2018 00:24:40 +0000 (20:24 -0400)]
fix formatting

6 years agoaddress PR review issues
Evgeny Naumov [Wed, 24 Oct 2018 00:00:02 +0000 (20:00 -0400)]
address PR review issues

6 years agomerge upstream
Evgeny Naumov [Mon, 22 Oct 2018 15:24:20 +0000 (11:24 -0400)]
merge upstream

6 years agochanges from PR review
Evgeny Naumov [Mon, 22 Oct 2018 14:41:06 +0000 (10:41 -0400)]
changes from PR review

6 years agocleanup: Use compound literals for SO_REUSEADDR setsockopt
Pavel Rochnyack [Mon, 22 Oct 2018 02:03:39 +0000 (09:03 +0700)]
cleanup: Use compound literals for SO_REUSEADDR setsockopt

6 years agoMerge pull request #2803 from rorysexton/dev_branch
Pavel Rochnyack [Mon, 22 Oct 2018 01:52:53 +0000 (08:52 +0700)]
Merge pull request #2803 from rorysexton/dev_branch

cpufreq plugin: Read number of p-state transitions and time spent in each p-state

6 years agocpufreq plugin: Address code review comments
Pavel Rochnyack [Sun, 21 Oct 2018 16:51:12 +0000 (23:51 +0700)]
cpufreq plugin: Address code review comments

6 years agocpufreq plugin: Address code review comments
Pavel Rochnyack [Sun, 21 Oct 2018 06:46:10 +0000 (13:46 +0700)]
cpufreq plugin: Address code review comments

6 years agocpufreq plugin: Reviewed p-state statistics code
Pavel Rochnyack [Sat, 20 Oct 2018 17:12:10 +0000 (00:12 +0700)]
cpufreq plugin: Reviewed p-state statistics code

6 years agocpufreq: Review time_in_state metric
Pavel Rochnyack [Sat, 20 Oct 2018 13:00:18 +0000 (20:00 +0700)]
cpufreq: Review time_in_state metric

6 years agocpufreq: Review p-state transitions metric
Pavel Rochnyack [Sat, 20 Oct 2018 12:11:47 +0000 (19:11 +0700)]
cpufreq: Review p-state transitions metric

6 years agoClang format
Sexton, Rory [Fri, 24 Aug 2018 08:53:10 +0000 (09:53 +0100)]
Clang format

6 years agoAddressing comments on previous commit.
Sexton, Rory [Fri, 24 Aug 2018 07:56:54 +0000 (08:56 +0100)]
Addressing comments on previous commit.

6 years agoUpdating cpufreq.c from clang-format
Sexton, Rory [Fri, 1 Jun 2018 14:59:04 +0000 (15:59 +0100)]
Updating cpufreq.c from clang-format

6 years agoExtending cpufreq plugin to read the following additional metrics:
Sexton, Rory [Fri, 1 Jun 2018 14:43:48 +0000 (15:43 +0100)]
Extending cpufreq plugin to read the following additional metrics:
  - number of p-state(cpu frequency) transitions
  - time spent in each p-state

Both metrics are reported by the Linux cpufreq-stats driver:
https://www.kernel.org/doc/Documentation/cpu-freq/cpufreq-stats.txt

6 years agoovs_stats: add macro to populate counters list
Matteo Croce [Thu, 18 Oct 2018 21:25:20 +0000 (23:25 +0200)]
ovs_stats: add macro to populate counters list

Use a stringification macro to populate the counter array. Doing this
instead of duplicating the tokens is less error prone.

Signed-off-by: Matteo Croce <mcroce@redhat.com>
6 years agoMerge pull request #2806 from rorysexton/dev_turbostat_plugin
Pavel Rochnyak [Sat, 20 Oct 2018 11:17:11 +0000 (18:17 +0700)]
Merge pull request #2806 from rorysexton/dev_turbostat_plugin

turbostat plugin: New metrics: P-states,Turboboost,Platform TDP,Uncore bus ratio

6 years agostatsd: Set SO_REUSEADDR on listening socket
Pavel Rochnyack [Fri, 19 Oct 2018 10:37:40 +0000 (17:37 +0700)]
statsd: Set SO_REUSEADDR on listening socket

Closes: #1126
Closes: #1187

6 years agosrc/daemon/utils_cache_mock.c: Add uc_meta_data_{add,get}_signed_int().
Florian Forster [Thu, 18 Oct 2018 16:14:09 +0000 (18:14 +0200)]
src/daemon/utils_cache_mock.c: Add uc_meta_data_{add,get}_signed_int().

Fixes test_format_stackdriver.

6 years agowrite_stackdriver plugin: Remove redundant error message.
Florian Forster [Thu, 18 Oct 2018 15:27:30 +0000 (17:27 +0200)]
write_stackdriver plugin: Remove redundant error message.

A more detailed error is previously logged by wg_call_timeseries_write.

6 years agowrite_stackdriver plugin: Check "http_code" instead of "status".
Florian Forster [Thu, 18 Oct 2018 13:50:19 +0000 (15:50 +0200)]
write_stackdriver plugin: Check "http_code" instead of "status".

6 years agowrite_stackdriver plugin: Check pointer for NULL before dereferencing it.
Florian Forster [Thu, 18 Oct 2018 13:49:37 +0000 (15:49 +0200)]
write_stackdriver plugin: Check pointer for NULL before dereferencing it.

6 years agoMakefile.am: s/EXTRA_LTLIBRARIES/noinst_LTLIBRARIES/
Florian Forster [Thu, 18 Oct 2018 11:28:02 +0000 (13:28 +0200)]
Makefile.am: s/EXTRA_LTLIBRARIES/noinst_LTLIBRARIES/

9a31008108740bf39d86bdfcb86363a71cad7c0c did not make it into the PR
branch. :\

6 years agoMerge remote-tracking branch 'github/pr/2472'
Florian Forster [Thu, 18 Oct 2018 08:49:37 +0000 (10:49 +0200)]
Merge remote-tracking branch 'github/pr/2472'

6 years agoAuto-Merge pull request #2955 from octo/linux-2.4
collectd bot [Mon, 15 Oct 2018 20:12:11 +0000 (22:12 +0200)]
Auto-Merge pull request #2955 from octo/linux-2.4

Automatically merged due to "Automerge" label

6 years agodisk plugin: Drop support for Linux 2.4.
Florian Forster [Mon, 15 Oct 2018 19:17:55 +0000 (21:17 +0200)]
disk plugin: Drop support for Linux 2.4.

6 years agoFix Solaris builds
Pavel Rochnyack [Sun, 14 Oct 2018 11:05:42 +0000 (18:05 +0700)]
Fix Solaris builds

Change introduced in df135922b19890047ebf725e6b82cd1c174c6d52 (#2810) causes build
failure on Solaris:

src/libcollectdclient/server.c: In function ‘server_multicast_join’:
src/libcollectdclient/server.c:103:9: error: unknown field ‘imr_address’ specified in initializer
         .imr_address.s_addr = INADDR_ANY, .imr_multiaddr.s_addr = sa->s_addr,
         ^
src/libcollectdclient/server.c:103:69: error: ‘struct sockaddr_in’ has no member named ‘S_un’
         .imr_address.s_addr = INADDR_ANY, .imr_multiaddr.s_addr = sa->s_addr,
                                                                     ^
src/libcollectdclient/server.c:102:27: error: missing braces around initializer [-Werror=missing-braces]
     struct ip_mreq mreq = {
                           ^
src/libcollectdclient/server.c:102:27: note: (near initialization for ‘mreq’)

Removed this change as not related to WIN32 platform.

6 years agoFix Solaris builds
Pavel Rochnyack [Sun, 14 Oct 2018 10:57:56 +0000 (17:57 +0700)]
Fix Solaris builds

Change introduced in df135922b19890047ebf725e6b82cd1c174c6d52 (#2810) causes build
failure on Solaris:

src/libcollectdclient/server.c: In function ‘server_multicast_join’:
src/libcollectdclient/server.c:103:9: error: unknown field ‘imr_address’ specified in initializer
         .imr_address.s_addr = INADDR_ANY, .imr_multiaddr.s_addr = sa->s_addr,
         ^
src/libcollectdclient/server.c:103:69: error: ‘struct sockaddr_in’ has no member named ‘S_un’
         .imr_address.s_addr = INADDR_ANY, .imr_multiaddr.s_addr = sa->s_addr,
                                                                     ^
src/libcollectdclient/server.c:102:27: error: missing braces around initializer [-Werror=missing-braces]
     struct ip_mreq mreq = {
                           ^
src/libcollectdclient/server.c:102:27: note: (near initialization for ‘mreq’)

Removed this change as not related to WIN32 platform.

6 years agoFix 'make distcheck' (for `master-aggregation` hook)
Pavel Rochnyack [Sun, 14 Oct 2018 10:37:46 +0000 (17:37 +0700)]
Fix 'make distcheck' (for `master-aggregation` hook)

Change introduced in df135922b19890047ebf725e6b82cd1c174c6d52 (#2810)

This change causes error in 'master-aggregation' hook:

ERROR: files left in build directory after distclean:
./liboconfig.la
./libcommon.la
./libmount.la
./libformat_json.la
./libheap.la
./libignorelist.la
./libavltree.la
./libformat_graphite.la
./liblatency.la
./liblookup.la
./libmetadata.la
./libcmds.la

6 years agoAuto-Merge pull request #2950 from octo/ff/wireless
collectd bot [Fri, 12 Oct 2018 16:18:26 +0000 (18:18 +0200)]
Auto-Merge pull request #2950 from octo/ff/wireless

Automatically merged due to "Automerge" label

6 years agowireless plugin: Add bitrate metric.
Florian Forster [Thu, 11 Oct 2018 16:49:50 +0000 (18:49 +0200)]
wireless plugin: Add bitrate metric.

6 years agosrc/utils_format_stackdriver.c: Fix initial value of cumulative metrics.
Florian Forster [Tue, 9 Oct 2018 11:54:50 +0000 (13:54 +0200)]
src/utils_format_stackdriver.c: Fix initial value of cumulative metrics.

The start value of cumulative metrics is stored in the cache. The first
value of a cumulative metric is then skipped, since Stackdriver required
the interval to be non-zero.

While looking into this, I realized that "absolute" metrics are not
cumulative and changed them accordingly.

6 years agoMerge pull request #2947 from baruchsiach/fix-build-gpsd
Pavel Rochnyak [Wed, 10 Oct 2018 03:04:21 +0000 (10:04 +0700)]
Merge pull request #2947 from baruchsiach/fix-build-gpsd

gps plugin: fix build with newer gpsd

6 years agogps plugin: fix build with newer gpsd
Baruch Siach [Tue, 9 Oct 2018 16:57:21 +0000 (19:57 +0300)]
gps plugin: fix build with newer gpsd

gpsd version 3.18 changed the prototype of gps_read(). Make the
gps_read() call depend on GPSD_API_MAJOR_VERSION to fix that.

This fixes build failures like:

gps.c: In function 'cgps_thread':
gps.c:144:11: error: too few arguments to function 'gps_read'
       if (gps_read(&gpsd_conn) == -1) {
   ^~~~~~~~

6 years agoAuto-Merge pull request #2945 from octo/ff/travis
collectd bot [Tue, 9 Oct 2018 15:11:27 +0000 (17:11 +0200)]
Auto-Merge pull request #2945 from octo/ff/travis

Automatically merged due to "Automerge" label

6 years ago.travis.yml: Determine number of CPUs at runtime.
Florian Forster [Tue, 9 Oct 2018 13:53:00 +0000 (15:53 +0200)]
.travis.yml: Determine number of CPUs at runtime.

6 years agoAuto-Merge pull request #2944 from octo/ff/typo
collectd bot [Tue, 9 Oct 2018 13:13:56 +0000 (15:13 +0200)]
Auto-Merge pull request #2944 from octo/ff/typo

Automatically merged due to "Automerge" label

6 years agosrc/daemon/common.h: Fix typo.
Florian Forster [Tue, 9 Oct 2018 11:55:23 +0000 (13:55 +0200)]
src/daemon/common.h: Fix typo.

6 years agoMerge pull request #2903 from ccin2p3/documentation/libvirt
Ruben Kerkhof [Tue, 9 Oct 2018 08:09:12 +0000 (10:09 +0200)]
Merge pull request #2903 from ccin2p3/documentation/libvirt

add some useful info to libvirt manpage

6 years agowrite_stackdriver plugin: Check message for NULL before calling strdup().
Florian Forster [Tue, 9 Oct 2018 07:06:57 +0000 (09:06 +0200)]
write_stackdriver plugin: Check message for NULL before calling strdup().

6 years agowrite_stackdriver plugin: Set HTTP request timeout.
Florian Forster [Tue, 9 Oct 2018 07:06:28 +0000 (09:06 +0200)]
write_stackdriver plugin: Set HTTP request timeout.

6 years agoMerge branch 'collectd-5.8'
Florian Forster [Mon, 8 Oct 2018 09:52:08 +0000 (11:52 +0200)]
Merge branch 'collectd-5.8'

6 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Mon, 8 Oct 2018 09:48:54 +0000 (11:48 +0200)]
Merge branch 'collectd-5.7' into collectd-5.8

6 years agoAuto-Merge pull request #2939 from octo/pr2937-backport
collectd bot [Mon, 8 Oct 2018 09:33:29 +0000 (11:33 +0200)]
Auto-Merge pull request #2939 from octo/pr2937-backport

Automatically merged due to "Automerge" label

6 years agoexec plugin: dynamically allocate grname buffer.
smallem [Thu, 4 Oct 2018 17:54:44 +0000 (13:54 -0400)]
exec plugin: dynamically allocate grname buffer.

Backport of a fix in master.

Fixes: #2696

6 years agoAuto-Merge pull request #2937 from sreedi/fix-2696
collectd bot [Mon, 8 Oct 2018 08:32:35 +0000 (10:32 +0200)]
Auto-Merge pull request #2937 from sreedi/fix-2696

Automatically merged due to "Automerge" label

6 years agowrite_stackdriver plugin: Centralize HTTP calls, add API error handling.
Florian Forster [Sun, 7 Oct 2018 08:21:47 +0000 (10:21 +0200)]
write_stackdriver plugin: Centralize HTTP calls, add API error handling.

This change implements do_post(), a function for doing POST requests.
In case of a user error (a HTTP 4xx status code) the reply is assumed to
be an error and is parsed accordingly.

6 years agoClang format fix.
smallem [Mon, 8 Oct 2018 00:40:12 +0000 (20:40 -0400)]
Clang format fix.

6 years agoMade some Code Optimization changes per review.
smallem [Mon, 8 Oct 2018 00:34:49 +0000 (20:34 -0400)]
Made some Code Optimization changes per review.

6 years agoAuto-Merge pull request #2938 from octo/ff/format_json
collectd bot [Fri, 5 Oct 2018 20:15:01 +0000 (22:15 +0200)]
Auto-Merge pull request #2938 from octo/ff/format_json

Automatically merged due to "Automerge" label

6 years agosrc/utils_format_json.c: Remove chatty debug messages.
Florian Forster [Fri, 5 Oct 2018 19:11:57 +0000 (21:11 +0200)]
src/utils_format_json.c: Remove chatty debug messages.

6 years agosrc/daemon/plugin.h: Fix typo in comment.
Florian Forster [Fri, 5 Oct 2018 19:12:51 +0000 (21:12 +0200)]
src/daemon/plugin.h: Fix typo in comment.

6 years agofixed build issues
smallem [Fri, 5 Oct 2018 04:12:49 +0000 (00:12 -0400)]
fixed build issues

6 years agofixed format issues
smallem [Fri, 5 Oct 2018 03:15:04 +0000 (23:15 -0400)]
fixed format issues

6 years agoRefactored getting effective group id from group name part of fork_child
smallem [Fri, 5 Oct 2018 03:12:31 +0000 (23:12 -0400)]
Refactored getting effective group id from group name part of fork_child

6 years agoVarious files: Remove mode line.
Florian Forster [Mon, 1 Oct 2018 15:40:00 +0000 (17:40 +0200)]
Various files: Remove mode line.

6 years agosrc/utils_format_stackdriver.c: Address code review comments.
Florian Forster [Mon, 1 Oct 2018 15:37:58 +0000 (17:37 +0200)]
src/utils_format_stackdriver.c: Address code review comments.

* Declare and initialize variables on the same line where possible.
* Remove modeline.

6 years agoconfigure.ac: Re-indent whole AC_PLUGIN list.
Florian Forster [Mon, 1 Oct 2018 15:29:41 +0000 (17:29 +0200)]
configure.ac: Re-indent whole AC_PLUGIN list.

6 years agoconfigure.ac: Quote all macro args, put "if" and "then" on same line.
Florian Forster [Mon, 1 Oct 2018 15:24:51 +0000 (17:24 +0200)]
configure.ac: Quote all macro args, put "if" and "then" on same line.

6 years agoMakefile.am: Change "noinst_LTLIBRARIES" to "EXTRA_LTLIBRARIES".
Florian Forster [Thu, 27 Sep 2018 20:02:46 +0000 (22:02 +0200)]
Makefile.am: Change "noinst_LTLIBRARIES" to "EXTRA_LTLIBRARIES".

Required fix after rebasing on master.

6 years agoconfigure: Set default value for plugin_write_stackdriver.
Florian Forster [Mon, 11 Dec 2017 15:38:33 +0000 (16:38 +0100)]
configure: Set default value for plugin_write_stackdriver.

Otherwise the output is going to be something like this when the plugin
cannot be built, which is ugly:

```
    write_sensu . . . . . yes
    write_stackdriver . .
    write_tsdb  . . . . . yes
```

6 years agowrite_stackdriver plugin: Use the "Label" option inside "Resource" blocks.
Florian Forster [Sat, 9 Dec 2017 06:37:35 +0000 (07:37 +0100)]
write_stackdriver plugin: Use the "Label" option inside "Resource" blocks.

The previous implementation was too surprising for users, which is not a good
property for a config option.

6 years agocollectd.conf(5): Improve write_stackdriver documentation.
Florian Forster [Thu, 7 Dec 2017 13:17:20 +0000 (14:17 +0100)]
collectd.conf(5): Improve write_stackdriver documentation.

6 years agoliboauth: Make oauth_create() private and remove oauth_create_p12().
Florian Forster [Thu, 7 Dec 2017 11:05:46 +0000 (12:05 +0100)]
liboauth: Make oauth_create() private and remove oauth_create_p12().

The former is not used externally, the latter is not used at all.

6 years agoMakefile.am: Build libgce ony when liboauth is available.
Florian Forster [Thu, 7 Dec 2017 11:04:08 +0000 (12:04 +0100)]
Makefile.am: Build libgce ony when liboauth is available.

libgce uses oauth_parse_json_token() from liboauth.

6 years agoRename write_gcm to write_stackdriver.
Florian Forster [Mon, 6 Nov 2017 20:26:08 +0000 (21:26 +0100)]
Rename write_gcm to write_stackdriver.

6 years agowrite_gcm plugin: Build only when libyajl 2 is avaiable.
Florian Forster [Mon, 9 Oct 2017 10:59:57 +0000 (12:59 +0200)]
write_gcm plugin: Build only when libyajl 2 is avaiable.

6 years agocollectd.conf: Improve example configs.
Florian Forster [Sat, 20 Jun 2015 06:53:24 +0000 (08:53 +0200)]
collectd.conf: Improve example configs.

6 years agosrc/utils_oauth_test.c: Fix oauth_create_google_json test.
Florian Forster [Sat, 20 Jun 2015 06:53:24 +0000 (08:53 +0200)]
src/utils_oauth_test.c: Fix oauth_create_google_json test.

6 years agoMakefile.am: Fix rebase errors: source files need src/ prefix.
Florian Forster [Sat, 20 Jun 2015 06:53:24 +0000 (08:53 +0200)]
Makefile.am: Fix rebase errors: source files need src/ prefix.

6 years agowrite_gcm plugin: New plugin for Google Cloud Monitoring.
Florian Forster [Sun, 21 Jun 2015 15:59:46 +0000 (17:59 +0200)]
write_gcm plugin: New plugin for Google Cloud Monitoring.

6 years agosrc/utils_format_gcm.[ch]: Implementation of the Stackdriver Monitoring API v3.
Florian Forster [Sat, 20 Jun 2015 13:54:54 +0000 (15:54 +0200)]
src/utils_format_gcm.[ch]: Implementation of the Stackdriver Monitoring API v3.

Docs: https://cloud.google.com/monitoring/api/ref_v3/rest/

6 years agosrc/utils_gce.[ch]: Add utility for Google Compute Engine.
Florian Forster [Sat, 20 Jun 2015 08:02:27 +0000 (10:02 +0200)]
src/utils_gce.[ch]: Add utility for Google Compute Engine.

These functions allow to autodetect some settings when running on
Google Compute Engine (GCE), for example the Project ID, using the
metadata service.

6 years agofixed a missing substitution from merge from master
smallem [Thu, 4 Oct 2018 18:13:09 +0000 (14:13 -0400)]
fixed a missing substitution from merge from master

6 years agofix issue 2696 to dynamically allocate grname buffer in increments of _SC_GETGR_R_SIZ...
smallem [Thu, 4 Oct 2018 17:54:44 +0000 (13:54 -0400)]
fix issue 2696 to dynamically allocate grname buffer in increments of _SC_GETGR_R_SIZE_MAX/_SC_PAGESIZE

6 years agosrc/utils_oauth.[ch]: Add utility for OAuth authentication.
Florian Forster [Sat, 20 Jun 2015 06:53:24 +0000 (08:53 +0200)]
src/utils_oauth.[ch]: Add utility for OAuth authentication.

6 years agoMerge pull request #2924 from kevin-laatz-intel/dpdk_path_fix
Pavel Rochnyak [Mon, 24 Sep 2018 16:43:52 +0000 (23:43 +0700)]
Merge pull request #2924 from kevin-laatz-intel/dpdk_path_fix

dpdk: fix dpdk runtime config file path

6 years agodpdk: fix dpdk runtime config file path
Kevin Laatz [Tue, 11 Sep 2018 10:01:27 +0000 (11:01 +0100)]
dpdk: fix dpdk runtime config file path

The config path was changed in DPDK by the commit 'adf1d86  eal: move
runtime config file to new location’. As a result, the dpdk plugins won't
be able to link to the DPDK primary application after this change.

This commit adds a compile time check for the DPDK verison being used and
sets the DPDK runtime config file location accordingly.

Suggested-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
6 years agoconfig: fix OB1, describe config errors
Evgeny Naumov [Mon, 10 Sep 2018 16:54:43 +0000 (12:54 -0400)]
config: fix OB1, describe config errors

6 years agofix formatting
Evgeny Naumov [Mon, 10 Sep 2018 16:18:06 +0000 (12:18 -0400)]
fix formatting

6 years agocollect more stats
Evgeny Naumov [Mon, 10 Sep 2018 16:13:57 +0000 (12:13 -0400)]
collect more stats

6 years agoadd nvml module
Evgeny Naumov [Mon, 10 Sep 2018 14:32:31 +0000 (10:32 -0400)]
add nvml module

6 years agoMerge pull request #2922 from octo/rootfs_prefix
Marc Fournier [Mon, 10 Sep 2018 08:56:33 +0000 (09:56 +0100)]
Merge pull request #2922 from octo/rootfs_prefix

contrib/docker/rootfs_prefix: Add MIT license header.

6 years agocontrib/docker/rootfs_prefix: Add MIT license header.
Florian Forster [Fri, 7 Sep 2018 08:03:26 +0000 (10:03 +0200)]
contrib/docker/rootfs_prefix: Add MIT license header.

On 2018-09-06 Marc Fournier wrote:

Hello Florian !

Yes, sure, sorry to have omitted this! I'm fine with MIT. Glad this is
useful to others :-)

+1 for adding a default "fallback" licence to COPYING. In case this has
unexpected implications, let's just add the MIT licence to root_prefix/* so
Baruch can move forward with his project.

Cheers,
Marc

6 years agoMerge branch 'collectd-5.8'
Ruben Kerkhof [Wed, 5 Sep 2018 06:40:25 +0000 (08:40 +0200)]
Merge branch 'collectd-5.8'

6 years agoMerge pull request #2919 from rubenk/virt-fix-segfault
Ruben Kerkhof [Wed, 5 Sep 2018 06:38:09 +0000 (08:38 +0200)]
Merge pull request #2919 from rubenk/virt-fix-segfault

Fix segfault in libvirt plugin

6 years agovirt plugin: fix segfault on error path
Ruben Kerkhof [Tue, 4 Sep 2018 10:48:12 +0000 (12:48 +0200)]
virt plugin: fix segfault on error path

The libvirt plugin refreshes its list of domains every RefreshInterval
seconds. If a domain crashes after getting the list, getting the stats
for its block devices returns an error. We then try to call
virDomainGetName on an invalid pointer. Fix this.

6 years agofix c_avl_iterator_prev (#2917)
volth [Sun, 2 Sep 2018 12:35:16 +0000 (12:35 +0000)]
fix c_avl_iterator_prev (#2917)

utils_avltree: fix 'c_avl_iterator_prev()' and cover it by tests

6 years agoMerge pull request #2913 from StarryInternet/sensors-humidity
Pavel Rochnyak [Sat, 1 Sep 2018 16:06:12 +0000 (22:06 +0600)]
Merge pull request #2913 from StarryInternet/sensors-humidity

Add support for humidity in sensors plugin

6 years agoadd humidity for lm_sensors version >= 0x431
Sarah Fischmann [Fri, 31 Aug 2018 14:03:00 +0000 (10:03 -0400)]
add humidity for lm_sensors version >= 0x431

6 years agoAuto-Merge pull request #2916 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Thu, 30 Aug 2018 06:48:03 +0000 (08:48 +0200)]
Auto-Merge pull request #2916 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

6 years agonfs: Fix number of fields for NFSv4
Jan-Philipp Litza [Wed, 29 Aug 2018 20:46:49 +0000 (22:46 +0200)]
nfs: Fix number of fields for NFSv4

The previous buffer of 64 fields was too short for the current number of
72+2 fields in NFS 4.2, causing the message

  nfs plugin: Unexpected number of fields for NFSv4 server statistics: 62.

This change, originally proposed in [1], fixes that issue in a
forward-compatible manner by reusing the already known number of fields
from the static arrays.

[1]: https://github.com/collectd/collectd/issues/2076#issuecomment-350466628

6 years agoMerge pull request #2915 from jplitza/fix-2076
Pavel Rochnyak [Thu, 30 Aug 2018 05:14:38 +0000 (11:14 +0600)]
Merge pull request #2915 from jplitza/fix-2076

nfs: Fix number of fields for NFSv4

6 years agonfs: Fix number of fields for NFSv4
Jan-Philipp Litza [Wed, 29 Aug 2018 20:46:49 +0000 (22:46 +0200)]
nfs: Fix number of fields for NFSv4

The previous buffer of 64 fields was too short for the current number of
72+2 fields in NFS 4.2, causing the message

  nfs plugin: Unexpected number of fields for NFSv4 server statistics: 62.

This change, originally proposed in [1], fixes that issue in a
forward-compatible manner by reusing the already known number of fields
from the static arrays.

[1]: https://github.com/collectd/collectd/issues/2076#issuecomment-350466628

6 years agoadd humidity for lm_sensors version >= 0x402
Sarah Fischmann [Wed, 29 Aug 2018 17:00:40 +0000 (13:00 -0400)]
add humidity for lm_sensors version >= 0x402

6 years agoadd support for humidity in sensors plugin
Sarah Fischmann [Wed, 29 Aug 2018 14:18:51 +0000 (10:18 -0400)]
add support for humidity in sensors plugin

6 years agoFix Solaris builds
Pavel Rochnyack [Wed, 29 Aug 2018 14:23:28 +0000 (21:23 +0700)]
Fix Solaris builds

Trying to fix error:

./build.sh: syntax error at line 78: `TOP_SRCDIR=$' unexpected

6 years agoMerge pull request #2864 from jimis/libxml2_configure_fix
Ruben Kerkhof [Wed, 29 Aug 2018 07:55:27 +0000 (09:55 +0200)]
Merge pull request #2864 from jimis/libxml2_configure_fix

Add --with-libxml2 option to configure.

6 years agoMerge pull request #2907 from Stackdriver/pkg-fix
Pavel Rochnyak [Tue, 28 Aug 2018 15:31:01 +0000 (21:31 +0600)]
Merge pull request #2907 from Stackdriver/pkg-fix

Fix warning that pkgdatadir and pkglibdir were previously defined.