Pavel Rochnyack [Sun, 22 Jul 2018 05:43:28 +0000 (12:43 +0700)]
processes: Fix conversion of 'delay_rate' values. Now they really have seconds per second unit.
Pavel Rochnyack [Fri, 20 Jul 2018 15:06:36 +0000 (22:06 +0700)]
utils_latency: Use plugin name from context to do error reporting
Pavel Rochnyack [Fri, 20 Jul 2018 14:58:39 +0000 (21:58 +0700)]
utils_tail: Added plugin name to error reporting
Pavel Rochnyack [Wed, 18 Jul 2018 08:16:25 +0000 (15:16 +0700)]
tail_csv: Fix typo in Synopsis
Pavel Rochnyack [Tue, 10 Jul 2018 12:05:59 +0000 (19:05 +0700)]
Merge branch 'collectd-5.8' into collectd-master
Pavel Rochnyak [Tue, 10 Jul 2018 12:04:47 +0000 (19:04 +0700)]
Merge pull request #2854 from rpv-tomsk/collectd-master
routeros: Use MAC-address when Radio-name is missing
Mariusz Bialonczyk [Tue, 10 Jul 2018 09:47:53 +0000 (11:47 +0200)]
Fix parsing option for avoiding making BaseDir
Parsing is broken since:
386ecab4 Reading configuration file is now done outside main().
So after mentioned commit we've got:
collectd: invalid option -- 'B'
This commit fixes this.
Pavel Rochnyak [Tue, 10 Jul 2018 10:29:02 +0000 (17:29 +0700)]
Merge pull request #2856 from manio/master
Fix parsing option for avoiding making BaseDir
Mariusz Bialonczyk [Tue, 10 Jul 2018 09:47:53 +0000 (11:47 +0200)]
Fix parsing option for avoiding making BaseDir
Parsing is broken since:
386ecab4 Reading configuration file is now done outside main().
So after mentioned commit we've got:
collectd: invalid option -- 'B'
This commit fixes this.
Pavel Rochnyack [Mon, 9 Jul 2018 07:51:33 +0000 (14:51 +0700)]
routeros: Use MAC-address when Radio-name is missing
Pavel Rochnyack [Sun, 8 Jul 2018 14:06:36 +0000 (21:06 +0700)]
routeros: Fix codestyle of latest change
Pavel Rochnyack [Sun, 8 Jul 2018 13:11:28 +0000 (20:11 +0700)]
Merge branch 'collectd-5.8' into master
Pavel Rochnyak [Sun, 8 Jul 2018 12:47:53 +0000 (19:47 +0700)]
Merge pull request #2851 from rpv-tomsk/external-manio-master
routeros: Add support for temperature and voltage data, fixed typo in 'sectors_written' metric name
Pavel Rochnyack [Sun, 8 Jul 2018 08:25:51 +0000 (15:25 +0700)]
routeros: Fixed typo in 'sectors_written' metric name
Pavel Rochnyack [Sun, 8 Jul 2018 08:24:07 +0000 (15:24 +0700)]
routeros: Use 'voltage' and 'temperature' as reported types
Pavel Rochnyack [Sun, 8 Jul 2018 06:19:01 +0000 (13:19 +0700)]
routeros: Fixed check of 'Collect*' options
Pavel Rochnyack [Sun, 8 Jul 2018 06:17:11 +0000 (13:17 +0700)]
routeros: Added conditionals around collect_health code
Mariusz Bialonczyk [Fri, 25 Sep 2015 09:50:29 +0000 (11:50 +0200)]
doc: add information about routeros CollectHealth option
Mariusz Bialonczyk [Fri, 25 Sep 2015 09:44:37 +0000 (11:44 +0200)]
routeros: add support for collecting health data
It includes the voltage and temperature data on supported hardware.
collectd bot [Sat, 7 Jul 2018 15:31:54 +0000 (17:31 +0200)]
Auto-Merge pull request #2850 from rpv-tomsk/collectd-collectd-5.8
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sat, 7 Jul 2018 14:38:07 +0000 (21:38 +0700)]
write_prometheus: Added MHD_USE_INTERNAL_POLLING_THREAD flag
Since 0.9.53, libmicrohttpd requires explicit setting of this flag.
Closes: #2849
Pavel Rochnyack [Thu, 5 Jul 2018 12:27:15 +0000 (19:27 +0700)]
turbostat plugin: show error details
Pavel Rochnyak [Thu, 5 Jul 2018 09:03:17 +0000 (16:03 +0700)]
Merge pull request #2733 from elfiesmelfie/feat_pcie_aer
New plugin to read PCIe errors
Pavel Rochnyack [Thu, 5 Jul 2018 08:02:35 +0000 (15:02 +0700)]
pcie_errors: Remove 'pcie_error' from types.db
Plugin does not send metrics, type is not needed to send notifications.
Pavel Rochnyak [Thu, 5 Jul 2018 03:41:18 +0000 (10:41 +0700)]
Merge pull request #2631 from DanCech/tagged-carbon
Graphite 1.1+ tag support
Pavel Rochnyak [Thu, 5 Jul 2018 03:38:33 +0000 (10:38 +0700)]
Merge pull request #2847 from rpv-tomsk/collectd-master
tree-wide: Use interval value from plugin context, do not set 'vl->interval' in plugins more.
Pavel Rochnyak [Thu, 5 Jul 2018 03:37:36 +0000 (10:37 +0700)]
Merge pull request #2845 from rpv-tomsk/tmpfix
redis plugin: Remove `operations_per_second` metric.
Pavel Rochnyack [Wed, 4 Jul 2018 13:09:26 +0000 (20:09 +0700)]
write_kafka: Added Graphite tag support
Pavel Rochnyack [Wed, 4 Jul 2018 12:52:04 +0000 (19:52 +0700)]
write_graphite: Documented 'UseTags' option
Jacob Lisi [Tue, 7 Nov 2017 21:29:38 +0000 (16:29 -0500)]
utils_format_graphite: add tests for graphite tag flag
Dan Cech [Tue, 31 Oct 2017 16:40:43 +0000 (12:40 -0400)]
utils_format_graphite: Add graphite tag support
Pavel Rochnyack [Wed, 4 Jul 2018 07:47:18 +0000 (14:47 +0700)]
curl plugin: Added 'Interval' option
Pavel Rochnyack [Wed, 4 Jul 2018 07:20:54 +0000 (14:20 +0700)]
curl_xml plugin: Added 'Interval' option
Pavel Rochnyack [Wed, 4 Jul 2018 07:13:36 +0000 (14:13 +0700)]
core: Added plugin name to (some) error reporting
Pavel Rochnyack [Wed, 4 Jul 2018 06:17:21 +0000 (13:17 +0700)]
tree-wide: Use interval value from plugin context
Pavel Rochnyack [Wed, 4 Jul 2018 06:15:48 +0000 (13:15 +0700)]
core: Cleanup in vl->interval assignment
Pavel Rochnyack [Wed, 4 Jul 2018 05:43:10 +0000 (12:43 +0700)]
core: Set plugin name in context when plugin is autoloaded
Pavel Rochnyack [Wed, 4 Jul 2018 05:00:02 +0000 (12:00 +0700)]
core: Set 'interval' value in plugin context to match read callback interval
Pavel Rochnyack [Wed, 4 Jul 2018 04:33:04 +0000 (11:33 +0700)]
postgresql: Set correct value to 'interval' query parameter (bugfix)
Pavel Rochnyack [Wed, 4 Jul 2018 03:46:09 +0000 (10:46 +0700)]
utils_tail_match: Updated formatting
Pavel Rochnyack [Wed, 4 Jul 2018 03:43:17 +0000 (10:43 +0700)]
utils_tail_match: Removed unused variables
Pavel Rochnyack [Tue, 3 Jul 2018 11:48:02 +0000 (18:48 +0700)]
utils_tail_match: Fix formatting
Pavel Rochnyak [Mon, 2 Jul 2018 15:27:25 +0000 (22:27 +0700)]
Merge pull request #2840 from elfiesmelfie/fix_deprecated_func
dpdk: fix deprecation warning
kevin-laatz-intel [Mon, 2 Jul 2018 14:51:04 +0000 (15:51 +0100)]
Merge branch 'master' into fix_deprecated_func
Pavel Rochnyack [Mon, 2 Jul 2018 06:59:53 +0000 (13:59 +0700)]
statsd: Improve error reporting
Pavel Rochnyack [Sun, 1 Jul 2018 06:52:31 +0000 (13:52 +0700)]
redis plugin: Remove `operations_per_second` metric.
The `operations_per_second` metric removed as duplicate of other metric and as
it has wrong value also. Collectd should not report wrong values.
Metric `operations_per_second` is based on `instantaneous_ops_per_sec` field
from Redis `INFO` output. That field is calculated based on buffer of 16 values,
updated from `stat_numcommands` once per 100ms.
So, `instantaneous_ops_per_sec` value has average only for last 1.6 seconds.
While Collectd poll period is 10 seconds, statistics for 8.4 seconds is lost.
Herewith, Collectd already has correct metric `total_operations`, based on
`total_commands_processed` field taken from same `stat_numcommands` internally
in Redis. Value of this metric should be used instead of removed metric.
Pavel Rochnyak [Fri, 29 Jun 2018 12:56:59 +0000 (19:56 +0700)]
Merge pull request #2844 from elfiesmelfie/fix_snmp_agent
SNMP Agent plugin: Fix coverity scan issues #2814
Kevin Laatz [Wed, 27 Jun 2018 13:10:05 +0000 (14:10 +0100)]
dpdk: fix clang issue for deprecated function patch
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Pavel Rochnyack [Wed, 27 Jun 2018 11:55:47 +0000 (18:55 +0700)]
cleanup: Remove excessive error reporting
These messages already reported in parse_value()
collectd bot [Wed, 27 Jun 2018 05:54:35 +0000 (07:54 +0200)]
Auto-Merge pull request #2838 from rpv-tomsk/collectd-master
Automatically merged due to "Automerge" label
Pavel Rochnyak [Wed, 27 Jun 2018 05:16:49 +0000 (12:16 +0700)]
Merge pull request #2831 from elieyal/patch-3
network plugin: Add BindAddress option
Pavel Rochnyak [Wed, 27 Jun 2018 04:50:04 +0000 (11:50 +0700)]
Merge pull request #2834 from rpv-tomsk/plugin-context-master-2
notify_email: Include all notification parameters into email
Pavel Rochnyack [Wed, 27 Jun 2018 04:43:52 +0000 (11:43 +0700)]
redis plugin: Report keyspace hitratio
Ruben Kerkhof [Tue, 26 Jun 2018 14:08:22 +0000 (16:08 +0200)]
Merge pull request #2837 from abays/fix-collectd-tg-dtime
Use CLOCK_REALTIME for collectd-tg times (fixes issue 2219)
elieyal [Tue, 26 Jun 2018 10:01:04 +0000 (13:01 +0300)]
Updated change from debug to error
As suggest by @rpv-tomsk
Kevin Laatz [Mon, 25 Jun 2018 16:14:34 +0000 (17:14 +0100)]
dpdk: fix deprecation warning
This fixes a warning produced by a change introduced in the latest DPDK
relase caused by a deprecation notice.
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Andrew Bays [Mon, 25 Jun 2018 14:12:07 +0000 (10:12 -0400)]
Use CLOCK_REALTIME for collectd-tg times (fixes issue 2219)
elieyal [Fri, 22 Jun 2018 12:05:59 +0000 (15:05 +0300)]
revert back to DEBUG
will change this later, it's not as simple as it looks.
elieyal [Fri, 22 Jun 2018 09:18:29 +0000 (12:18 +0300)]
chenged debug to error message
Pavel Rochnyack [Fri, 22 Jun 2018 08:07:37 +0000 (15:07 +0700)]
notify_email: Include all notification parameters into email
collectd bot [Fri, 22 Jun 2018 06:34:01 +0000 (08:34 +0200)]
Auto-Merge pull request #2833 from rpv-tomsk/plugin-context-master-2
Automatically merged due to "Automerge" label
Pavel Rochnyack [Fri, 22 Jun 2018 05:01:31 +0000 (12:01 +0700)]
cleanup: cf_util_get* instead of local copy in plugins, prefixed error reporting
Closes: #2011 (superseedes)
Issue: #1949
Issue: #2799
Issue: #2821
elieyal [Thu, 21 Jun 2018 16:19:18 +0000 (19:19 +0300)]
removed some detaild in the BindAddress documentation
Removed some details.
Pavel Rochnyack [Thu, 21 Jun 2018 13:51:58 +0000 (20:51 +0700)]
snmp_agent: Try to fix tests
This adressed to fix Solaris 10 builds.
Issue: #2814
elieyal [Thu, 21 Jun 2018 09:29:19 +0000 (12:29 +0300)]
network plugin: Added documentation to BindAddress option
Added the BindAddress explanation in the network plugin section on how to use the BindAddress.
elieyal [Thu, 21 Jun 2018 08:49:04 +0000 (11:49 +0300)]
Fixed all comments by @rubenk
elieyal [Wed, 20 Jun 2018 14:32:40 +0000 (17:32 +0300)]
Fixed leak and hint
Added suggested fixes
Mozejko, MarcinX [Wed, 13 Jun 2018 06:54:49 +0000 (07:54 +0100)]
SNMP Agent plugin: Fix coverity issues
Change-Id: Icb74f9978833191a390c952a09695ccb60ff8452
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Pavel Rochnyak [Wed, 20 Jun 2018 10:55:56 +0000 (17:55 +0700)]
Merge pull request #2821 from rpv-tomsk/plugin-context-master-2
RFE: Add plugin name field into plugin context use it to improve error reporting
Pavel Rochnyack [Wed, 20 Jun 2018 08:12:37 +0000 (15:12 +0700)]
plugin_mmock.c: Added daemon_log()
Pavel Rochnyack [Wed, 20 Jun 2018 04:11:08 +0000 (11:11 +0700)]
common.c: Use plugin-name prefixed error reporting
elieyal [Wed, 20 Jun 2018 06:24:15 +0000 (09:24 +0300)]
upddated correct file
Sorry,
committed the patch by mistake. now fixed.
elieyal [Wed, 20 Jun 2018 06:21:34 +0000 (09:21 +0300)]
Fixed additional comments
Added "network plugin" prefix to Errors
return -1; added to sfree
Pavel Rochnyack [Wed, 20 Jun 2018 03:49:46 +0000 (10:49 +0700)]
core: Introduced daemon_log() for messages prefixed with plugin name
Pavel Rochnyack [Sat, 16 Jun 2018 05:10:11 +0000 (12:10 +0700)]
bind plugin: Switched to use of cf_util_get_boolean() and cf_util_get_string()
Pavel Rochnyack [Sat, 16 Jun 2018 05:01:50 +0000 (12:01 +0700)]
configfile.c: Use plugin name from plugin context in error reporting
This commit also removes 'plugin: ' prefix from `plugin_log()`.
Pavel Rochnyack [Sat, 16 Jun 2018 04:07:22 +0000 (11:07 +0700)]
Updated codestyle
Florian Forster [Tue, 4 Oct 2016 18:48:17 +0000 (20:48 +0200)]
src/daemon/plugin.[ch]: Add the plugin name to the context.
Issue: #1949
Pavel Rochnyack [Tue, 19 Jun 2018 16:19:34 +0000 (23:19 +0700)]
redis plugin: Fix memleak
Ruben Kerkhof [Tue, 19 Jun 2018 15:15:19 +0000 (17:15 +0200)]
Reset LDFLAGS before testing for strtok_r
They may contain all kinds of things that make the test fail.
See #2823 for details
collectd bot [Tue, 19 Jun 2018 11:57:21 +0000 (13:57 +0200)]
Auto-Merge pull request #2826 from rpv-tomsk/collectd-master
Automatically merged due to "Automerge" label
elieyal [Tue, 19 Jun 2018 11:35:51 +0000 (14:35 +0300)]
Fixed all comments
Pavel Rochnyak [Tue, 19 Jun 2018 10:52:48 +0000 (17:52 +0700)]
Merge pull request #2819 from rpv-tomsk/snmp-fix-2291-1
snmp plugin: HostOID, FilterOID and other options added
Pavel Rochnyack [Tue, 19 Jun 2018 08:43:05 +0000 (15:43 +0700)]
snmp_agent: Try to fix tests
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Tue, 19 Jun 2018 08:25:06 +0000 (15:25 +0700)]
snmp_agent: Try to fix tests
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Tue, 19 Jun 2018 08:08:54 +0000 (15:08 +0700)]
snmp_agent: Remove structure initialization
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Tue, 19 Jun 2018 04:41:42 +0000 (11:41 +0700)]
redis plugin: Added option ReportCpuUsage for reported CPU consumption
Pavel Rochnyack [Tue, 19 Jun 2018 04:11:09 +0000 (11:11 +0700)]
snmp_agent: Replace strndup() with internal implementation
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Mon, 18 Jun 2018 14:34:41 +0000 (21:34 +0700)]
redis plugin: Simplified commands statistics parser
Pavel Rochnyack [Mon, 18 Jun 2018 13:49:29 +0000 (20:49 +0700)]
redis plugin: Added commands statistics reporting
Pavel Rochnyack [Mon, 18 Jun 2018 11:03:51 +0000 (18:03 +0700)]
redis plugin: report CPU usage
elieyal [Mon, 18 Jun 2018 07:59:59 +0000 (10:59 +0300)]
Add Bind Address option
This change allows to Bind Address to an IP address instead of the binding to the Interface Name in the server section.
Example:
<Server "239.192.74.66" "25826">
SecurityLevel Encrypt
Username "user"
Password "secret"
BindAddress "10.9.25.59"
ResolveInterval 14400
</Server>
Credit to: Ofir Hermesh
Pavel Rochnyack [Sun, 17 Jun 2018 13:49:35 +0000 (20:49 +0700)]
redis plugin: Reworked to use plugin_register_complex_read()
Pavel Rochnyack [Sun, 17 Jun 2018 12:37:48 +0000 (19:37 +0700)]
redis plugin: Implemented persistent connections
Pavel Rochnyack [Sun, 17 Jun 2018 12:09:21 +0000 (19:09 +0700)]
write_redis plugin: Fixed bug of Timeout option
Documentation states what Timeout is set in milliseconds.
Code was fixed to match documentation.
Pavel Rochnyack [Sun, 17 Jun 2018 10:22:10 +0000 (17:22 +0700)]
redis plugin: Report query errors
Pavel Rochnyack [Sun, 17 Jun 2018 10:09:11 +0000 (17:09 +0700)]
redis plugin: Update documentation
Pavel Rochnyack [Sun, 17 Jun 2018 10:08:49 +0000 (17:08 +0700)]
redis plugin: Change text of some error messages
Pavel Rochnyack [Sun, 17 Jun 2018 09:10:54 +0000 (16:10 +0700)]
redis plugin: Check for / report connection errors
Pavel Rochnyack [Sun, 17 Jun 2018 08:51:33 +0000 (15:51 +0700)]
redis plugin: Fixed bug of Timeout option
Documentation states what Timeout is set in milliseconds.
Code was fixed to match documentation.