collectd.git
12 years agoethstat plugin: Initialize realloc'ated memory.
Florian Forster [Sun, 23 Sep 2012 10:00:43 +0000 (12:00 +0200)]
ethstat plugin: Initialize realloc'ated memory.

The last element in "interfaces" is not guaranteed to be zeroed, resulting in a
segfault when cf_util_get_string() tries to free the "pointer".

Thanks to Mark T. Voelker for reporting and analyzing this bug!
This should fix Github issue #133.

12 years agoethstat plugin: Fix off-by-one error.
Florian Forster [Sun, 23 Sep 2012 09:56:58 +0000 (11:56 +0200)]
ethstat plugin: Fix off-by-one error.

This hopefully fixes Github issue #135.

12 years agoMerge branch 'collectd-5.0' into collectd-5.1
Florian Forster [Fri, 7 Sep 2012 09:15:24 +0000 (11:15 +0200)]
Merge branch 'collectd-5.0' into collectd-5.1

Conflicts:
src/swap.c

12 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Fri, 7 Sep 2012 09:05:48 +0000 (11:05 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

12 years agocorrected high-resolution time conversions after code review
m4rienf [Thu, 6 Sep 2012 19:25:22 +0000 (21:25 +0200)]
corrected high-resolution time conversions after code review

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoUpdated Adrian Perez' 2009 Python network proto classes
m4rienf [Tue, 4 Sep 2012 18:23:43 +0000 (20:23 +0200)]
Updated Adrian Perez' 2009 Python network proto classes

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agosnmp plugin: Fix error message printed by the "Shift" option.
Dan Thomson [Fri, 7 Sep 2012 02:00:11 +0000 (19:00 -0700)]
snmp plugin: Fix error message printed by the "Shift" option.

I noticed a small error in snmp.c in collectd-5.1.0 (might be
elsewhere). The warning message in csnmp_config_add_data_shift says
"Scale config option" instead of "Shift" config option:
[…]

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agodf plugin: when checking / do it just once
Bruno Prémont [Wed, 21 Mar 2012 20:34:00 +0000 (21:34 +0100)]
df plugin: when checking / do it just once

Newer system symlink /etc/mtab to /proc/mounts which makes root
filesystem seem mounted twice, once as type rootfs and once for the
real device.

When / is selected for df plugin, skip the rootfs mount-point as
real root is usually mounted right on top of it.

Not skipping it causes rrdtool to complain about two updates for the
same timestamp, the first entry for rootfs passes but rrdtool complains
when stats for the second occurrence for real filesystem is being
considered.

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agosnmp plugin: Check for SNMP_ENDOFMIBVIEW.
Florian Forster [Fri, 7 Sep 2012 08:11:42 +0000 (10:11 +0200)]
snmp plugin: Check for SNMP_ENDOFMIBVIEW.

Some implementations of SNMP will send a special "variable" when you're
leaving the requested subtree with type "endOfMibView" aka.
"SNMP_ENDOFMIBVIEW". Examples of such implementations are Citrix
Netscalers and IBM's General Parallel File System (GPFS). Reading past
this special variable will result in weird values being returned.

This adds an appropriate check to csnmp_check_res_left_subtree().

Thanks to "Mark" for reporting this issue and clarifying.

12 years agosrc/Makefile.am: Unconditionally link collectd with libm.
Florian Forster [Wed, 5 Sep 2012 06:43:18 +0000 (08:43 +0200)]
src/Makefile.am: Unconditionally link collectd with libm.

Under FreeBSD, running src/utils_format_json.c fails because isfinite()
cannot be resolved. The GNU manpages for isnan() and isfinite() also
advise users to link with libm and AIX has had the library being linked
in for a while. Since it's such a basic library it seems easier to just
link with it unconditionally.

Fixes Github issue #122.

12 years agoMerge pull request #124 from tokkee/bj/build
Florian Forster [Tue, 4 Sep 2012 10:45:44 +0000 (03:45 -0700)]
Merge pull request #124 from tokkee/bj/build

Fix some build issues on AIX using automake <= 1.9 and gcc 4.7.1.

12 years agoAdd missing return statements
Benjamin Jacobs [Sun, 2 Sep 2012 21:54:35 +0000 (23:54 +0200)]
Add missing return statements

Fix gcc warn/error: no return statement in function returning non-void [-Werror=return-type]

Signed-off-by: Sebastian Harl <sh@tokkee.org>
12 years agoAutomake 1.9 compatibility: don't use $(builddir)
Benjamin Jacobs [Sun, 2 Sep 2012 21:53:24 +0000 (23:53 +0200)]
Automake 1.9 compatibility: don't use $(builddir)

Automake <= 1.9 don't define $(builddir) which is always defined to
'.' anyway.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
12 years agoMerge branch 'sh/collectd-5.1' into collectd-5.1
Florian Forster [Mon, 27 Aug 2012 08:12:11 +0000 (10:12 +0200)]
Merge branch 'sh/collectd-5.1' into collectd-5.1

12 years agoAdded the instance name to varnish API
Jonathan Huot [Thu, 2 Aug 2012 15:56:05 +0000 (18:56 +0300)]
Added the instance name to varnish API

Fixed issue collectd#110

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge pull request #109 from tokkee/sh/collectd-5.0
Florian Forster [Fri, 10 Aug 2012 07:16:37 +0000 (00:16 -0700)]
Merge pull request #109 from tokkee/sh/collectd-5.0

configure: Define _REENTRANT when compiling on Solaris.

LGTM

12 years agoFix to make write_mongodb work with any version of mongo-c-driver
Chris Lundquist [Fri, 13 Jul 2012 01:06:15 +0000 (01:06 +0000)]
Fix to make write_mongodb work with any version of mongo-c-driver

12 years agoconfigure: Define _REENTRANT when compiling on Solaris.
Mathijs Möhlmann [Tue, 22 Mar 2011 13:26:47 +0000 (14:26 +0100)]
configure: Define _REENTRANT when compiling on Solaris.

On Wed, Mar 16, 2011 at 10:35:07AM +0100, Mathijs Möhlmann wrote:
> I'm using collectd 4.10.2 on Solaris 10 (gcc 3.4.6). Sometimes when I
> start with a clean rrd directory or add a host the .rrd file (rrdtools
> plugin) don't get created and I get the following message:
>
> collectd[2996]: [ID 702911 daemon.error] stat(/usr/local/var/lib/collectd/rrd/asterix/load/load.rrd) failed: Bad file number

This patch fixes this.

Signed-off-by: Sebastian Harl <sh@teamix.net>
12 years agoconfigure, utils_dns: Check for and use netinet/ip_compat.h.
Sebastian Harl [Thu, 2 Aug 2012 10:16:38 +0000 (12:16 +0200)]
configure, utils_dns: Check for and use netinet/ip_compat.h.

This is required on Solaris in order to get the ip6_ext struct.

12 years agomysql plugin: Use the database instance name for identifying read callbacks.
Sebastian Harl [Wed, 1 Aug 2012 07:16:34 +0000 (09:16 +0200)]
mysql plugin: Use the database instance name for identifying read callbacks.

The database instance is specified as argument to the <Database> block.
Without this fix, we cannot specify two database blocks without the
(optional!) 'Database' option as this would result in registering two read
callbacks with the name 'mysql'.

Thanks to Johan Bergström for reporting this on IRC!

12 years agocontrib/migrate-4-5.px: Added missing end quotes in a call to rrd_filter.px.
Sebastian Harl [Sun, 15 Jul 2012 11:04:09 +0000 (13:04 +0200)]
contrib/migrate-4-5.px: Added missing end quotes in a call to rrd_filter.px.

12 years agoFix bad definition of UDP src port in DNS plugin.
Daniel Sutto [Wed, 11 Jul 2012 17:32:16 +0000 (19:32 +0200)]
Fix bad definition of UDP src port in DNS plugin.

12 years agoCorrect compilation on FreeBSD, set HOST_NAME_MAX to _POSIX_HOST_NAME_MAX if isn...
biancalana [Fri, 6 Jul 2012 01:07:15 +0000 (22:07 -0300)]
Correct compilation on FreeBSD, set HOST_NAME_MAX to _POSIX_HOST_NAME_MAX if isn't defined

12 years agocontrib/migrate-4-5.px: Break up "df" RRD files into multiple files.
Florian Forster [Thu, 5 Jul 2012 13:48:29 +0000 (15:48 +0200)]
contrib/migrate-4-5.px: Break up "df" RRD files into multiple files.

12 years agocollectd.conf(5): Improve description of the configuration syntax.
Florian Forster [Thu, 5 Jul 2012 06:32:28 +0000 (08:32 +0200)]
collectd.conf(5): Improve description of the configuration syntax.

12 years agoMerge pull request #97 from tokkee/sh/swap
Florian Forster [Mon, 2 Jul 2012 20:00:34 +0000 (13:00 -0700)]
Merge pull request #97 from tokkee/sh/swap

swap plugin: Don't report an error if there is no swap space on Linux.

12 years agoswap plugin: Don't report an error if there is no swap space on Linux.
Sebastian Harl [Sat, 30 Jun 2012 14:33:09 +0000 (16:33 +0200)]
swap plugin: Don't report an error if there is no swap space on Linux.

… rather, simply record zeros in that case. Swap may be switched on and off at
arbitrary times and/or might be added at "later" times. Thus, storing zero in
case the swap plugin is enabled sounds like the best approach to me.

12 years agoFix for config file parsing ("memcachec plugin: Option `Server' not allowed here.")
Pascal Hofmann [Thu, 14 Jun 2012 19:54:47 +0000 (21:54 +0200)]
Fix for config file parsing ("memcachec plugin: Option `Server' not allowed here.")

12 years agoFix out-of-bound index in rrdtool.c
Will Hawkins [Fri, 22 Jun 2012 18:45:45 +0000 (14:45 -0400)]
Fix out-of-bound index in rrdtool.c

Fix a reference to argv[1] that is (always?)
outside the bounds of the argv array. It happens
during a log statement that seems to want
to actually refer to the rrd filename.

12 years agooracle plugin: Add database name and query name (if applicable) to error messages.
Florian Forster [Tue, 19 Jun 2012 11:14:32 +0000 (13:14 +0200)]
oracle plugin: Add database name and query name (if applicable) to error messages.

12 years agooracle plugin: Report the "connect id" when OCILogon() fails.
Florian Forster [Mon, 18 Jun 2012 08:49:38 +0000 (10:49 +0200)]
oracle plugin: Report the "connect id" when OCILogon() fails.

12 years agocollection3: Use {instance} in Df's grpah title.
Florian Forster [Sun, 17 Jun 2012 18:46:43 +0000 (20:46 +0200)]
collection3: Use {instance} in Df's grpah title.

{type_instance} didn't work when used with other plugins than "df", e.g.
the example configuration of the Oracle plugin uses this.

12 years agosrc/utils_dns.c: Remove duplicate line.
Florian Forster [Fri, 1 Jun 2012 05:45:30 +0000 (07:45 +0200)]
src/utils_dns.c: Remove duplicate line.

12 years agosrc/utils_dns.c: Rename the "s_addr" and "d_addr" variables.
Florian Forster [Thu, 31 May 2012 13:09:43 +0000 (15:09 +0200)]
src/utils_dns.c: Rename the "s_addr" and "d_addr" variables.

On Solaris, there is a macro called "s_addr" resulting in syntax errors
when this is used as a variable name. The variables have been renamed to
circumvent this problem. Thanks to Maciej Bliziński for reporting this
problem and helping to debug it!

12 years agocollection3: Filter out identifiers with control characters.
Florian Forster [Sun, 27 May 2012 09:13:04 +0000 (11:13 +0200)]
collection3: Filter out identifiers with control characters.

Otherwise XML errors will prevent the page from rendering.

12 years agosrc/utils_avltree.c: Add sanity check to c_avl_destroy().
Florian Forster [Sun, 27 May 2012 09:10:56 +0000 (11:10 +0200)]
src/utils_avltree.c: Add sanity check to c_avl_destroy().

12 years agosrc/utils_rrdcreate.c: Handle "last update" in a saner way.
Florian Forster [Sat, 12 May 2012 15:29:44 +0000 (17:29 +0200)]
src/utils_rrdcreate.c: Handle "last update" in a saner way.

12 years agonetapp plugin: Close connection on communication errors.
Florian Forster [Sat, 12 May 2012 14:17:17 +0000 (16:17 +0200)]
netapp plugin: Close connection on communication errors.

12 years agocollectd.conf(5): Fix typo.
Florian Forster [Sat, 5 May 2012 16:05:12 +0000 (18:05 +0200)]
collectd.conf(5): Fix typo.

12 years agocollectdctl: Fix PUTVAL for data sets with multiple data sources.
Florian Forster [Thu, 19 Apr 2012 12:25:59 +0000 (14:25 +0200)]
collectdctl: Fix PUTVAL for data sets with multiple data sources.

Thanks to Cyril Feraudet for pointing out this problem!

12 years agocontrib/collection3: Ignore control characters.
Florian Forster [Mon, 16 Apr 2012 13:02:04 +0000 (15:02 +0200)]
contrib/collection3: Ignore control characters.

While they are correctly encoded, e.g. as "&#15;", browsers will
complain about invalid XML and not render the page. Ignore all control
characters other than whitespace.

12 years agoCreate directories with permission 0777.
Florian Forster [Fri, 6 Apr 2012 14:18:18 +0000 (16:18 +0200)]
Create directories with permission 0777.

Let umask work its magic. Thanks to "Poil" for reporting this problem.
Fixes GitHub issue #63.

12 years agovarnish plugin: Make argument "stats" const. collectd-5.1.0
Florian Forster [Mon, 2 Apr 2012 08:14:12 +0000 (10:14 +0200)]
varnish plugin: Make argument "stats" const.

12 years agoethstat plugin: Fix a typo.
Florian Forster [Mon, 2 Apr 2012 08:04:23 +0000 (10:04 +0200)]
ethstat plugin: Fix a typo.

12 years agoBump version to 5.1.0; Update ChangeLog.
Florian Forster [Sun, 1 Apr 2012 15:15:20 +0000 (17:15 +0200)]
Bump version to 5.1.0; Update ChangeLog.

12 years agoMerge branch 'collectd-5.0'
Florian Forster [Sun, 1 Apr 2012 10:07:20 +0000 (12:07 +0200)]
Merge branch 'collectd-5.0'

12 years agoMerge branch 'collectd-4.10' into collectd-5.0 collectd-5.0.4
Florian Forster [Sun, 1 Apr 2012 10:07:09 +0000 (12:07 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
ChangeLog

12 years agoChangeLog: Correct date. collectd-4.10.7
Florian Forster [Sun, 1 Apr 2012 10:06:42 +0000 (12:06 +0200)]
ChangeLog: Correct date.

12 years agoBump version to 5.0.4; Update ChangeLog.
Florian Forster [Sun, 1 Apr 2012 10:06:24 +0000 (12:06 +0200)]
Bump version to 5.0.4; Update ChangeLog.

12 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Sun, 1 Apr 2012 10:01:58 +0000 (12:01 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
ChangeLog
src/collectd.conf.pod
src/common.c
src/network.c
src/processes.c
version-gen.sh

12 years agoBump version to 4.10.7; Update ChangeLog.
Florian Forster [Sun, 1 Apr 2012 09:51:38 +0000 (11:51 +0200)]
Bump version to 4.10.7; Update ChangeLog.

12 years agoRevert "Proposal fix for large "MaxPacketSize" use."
Florian Forster [Sat, 31 Mar 2012 15:27:14 +0000 (17:27 +0200)]
Revert "Proposal fix for large "MaxPacketSize" use."

This reverts commit 12213f8dfeee3feb3846aa658def0bb79c1211d0.

12 years agonetwork plugin: Do not forward received notifications.
Florian Forster [Fri, 23 Mar 2012 21:21:43 +0000 (22:21 +0100)]
network plugin: Do not forward received notifications.

The network plugin would send out all notifications it got through its
callback, even the ones it received itself and even when forwarding was
disabled.

With this patch the network plugin will only transmit notifications created
locally -- forwarding of notifications is not implemented due to missing
loop-detection. For loop-detection we would have to keep track of the last
timestamp of each notifications, and since each host/plugin/type/-instance
field may be empty, this is not as straight forward as with value lists. If
someone needs this, they will need to invest some work I'm afraid.

12 years agoMerge pull request #56 from octo/ci/nfs
Florian Forster [Fri, 23 Mar 2012 13:17:00 +0000 (06:17 -0700)]
Merge pull request #56 from octo/ci/nfs

NFS plugin: Add Solaris support.

12 years agoMerge branch 'ff/zfs'
Florian Forster [Fri, 23 Mar 2012 12:53:39 +0000 (13:53 +0100)]
Merge branch 'ff/zfs'

12 years agozfs_arc plugin: Move reading of kstat values into separate functions.
Florian Forster [Fri, 23 Mar 2012 12:52:51 +0000 (13:52 +0100)]
zfs_arc plugin: Move reading of kstat values into separate functions.

This way error handling can be done in a central place and we can do this more
carefully overall.

12 years agoMerge pull request #60 from octo/ar/zfs
Florian Forster [Fri, 23 Mar 2012 12:48:19 +0000 (05:48 -0700)]
Merge pull request #60 from octo/ar/zfs

more zfs kstat values

12 years agozfs_arc plugin: Add copyright header for Aurelien Rougemont.
Florian Forster [Thu, 22 Mar 2012 08:05:12 +0000 (09:05 +0100)]
zfs_arc plugin: Add copyright header for Aurelien Rougemont.

12 years agoProposal fix for large "MaxPacketSize" use.
Cyril Feraudet [Mon, 19 Mar 2012 10:08:06 +0000 (11:08 +0100)]
Proposal fix for large "MaxPacketSize" use.

When we use a "MaxPacketSize" over two thousand of octets (to pass huge
message in notification for example), buffer may not be flushed for a
while.
By flushing buffer when there is about 1400 octets, we're sure there is
no data too longer in.

12 years agozfs_arc plugin: Fix the "hash collision" and "mutex miss" metrics.
Florian Forster [Wed, 21 Mar 2012 06:41:38 +0000 (07:41 +0100)]
zfs_arc plugin: Fix the "hash collision" and "mutex miss" metrics.

12 years agozfs_arc plugin: Fix typo in variable name.
Florian Forster [Tue, 20 Mar 2012 21:40:39 +0000 (22:40 +0100)]
zfs_arc plugin: Fix typo in variable name.

12 years agozfs_arc plugin: Introduce the single-valued "mutex_operation" type.
Florian Forster [Tue, 20 Mar 2012 21:39:39 +0000 (22:39 +0100)]
zfs_arc plugin: Introduce the single-valued "mutex_operation" type.

12 years agozfs_arc plugin: Introduce the single-valued "cache_eviction" type.
Florian Forster [Tue, 20 Mar 2012 21:32:14 +0000 (22:32 +0100)]
zfs_arc plugin: Introduce the single-valued "cache_eviction" type.

12 years agozfs_arc plugin: Convert to use DERIVE.
Florian Forster [Tue, 20 Mar 2012 21:29:59 +0000 (22:29 +0100)]
zfs_arc plugin: Convert to use DERIVE.

12 years agoadd types for deleted, evict, hash, mutex
Aurelien Rougemont [Thu, 1 Mar 2012 13:48:45 +0000 (14:48 +0100)]
add types for deleted, evict, hash, mutex

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoadd hash_collisions, deleted, mutex_miss, evict_*
Aurelien Rougemont [Thu, 1 Mar 2012 13:40:10 +0000 (14:40 +0100)]
add hash_collisions, deleted, mutex_miss, evict_*

12 years agoFixed Solaris compilation errors
Cosmin Ioiart [Mon, 19 Mar 2012 09:56:03 +0000 (10:56 +0100)]
Fixed Solaris compilation errors

The value returned by get_kstat_value is of type long long whereas values is a union. Fixed the code so that the value gets assigned to one of the union members, in this case counter.

12 years agoFixed solaris configure script generation errors
Cosmin Ioiart [Mon, 19 Mar 2012 09:54:57 +0000 (10:54 +0100)]
Fixed solaris configure script generation errors

The brackets in configure.in and the changes in version-gen.sh are needed in order for the build.sh script to generate the configure script correctly. Else the generated script won't work.

12 years agosrc/common.h: Add comment about return value of read_file_contents().
Florian Forster [Mon, 19 Mar 2012 09:47:22 +0000 (10:47 +0100)]
src/common.h: Add comment about return value of read_file_contents().

12 years agonfs plugin: Minor coding style fixes.
Florian Forster [Sun, 18 Mar 2012 10:35:13 +0000 (11:35 +0100)]
nfs plugin: Minor coding style fixes.

12 years agonfs plugin: Remove duplicated code.
Florian Forster [Sun, 18 Mar 2012 10:27:03 +0000 (11:27 +0100)]
nfs plugin: Remove duplicated code.

Changes include:

* Calculate nfs[234]_procedures_names_num at compile time.
* Made nfs_procedures_submit() more versatile, so it can be used from the Linux
  and the Solaris code.
* Switched to plugin_dispatch_values_secure(), since the code is using the same
  value_list_t for multiple values.
* Broke out nfs_submit_fields() from the Linux code. This removed quite a bit
  of code duplication between the v2/v3 code.
* Broke out nfs_read_kstat() which does the get_kstat_value() call in a loop
  rather than duplicating all the NFS procedure names.

12 years agoEnable modules for Solaris
Cosmin Ioiart [Thu, 8 Mar 2012 10:12:53 +0000 (11:12 +0100)]
Enable modules for Solaris

Enabling nfs,processes and protocols modules for Solaris when running the
configure script.

12 years agoFix Linux compilation errors
Cosmin Ioiart [Tue, 13 Mar 2012 07:38:16 +0000 (08:38 +0100)]
Fix Linux compilation errors

Fixed compilation errors for the linux platform

12 years agoAdded safe-guard for kstat libraries
Cosmin Ioiart [Thu, 23 Feb 2012 14:34:32 +0000 (15:34 +0100)]
Added safe-guard for kstat libraries

12 years agoAdded Solaris support for nfs3 and nfs4 (client/server)
Cosmin Ioiart [Thu, 23 Feb 2012 13:47:47 +0000 (14:47 +0100)]
Added Solaris support for nfs3 and nfs4 (client/server)

12 years agotcpconns plugin: Include <bsd/nlist.h> rather than <nlist.h>.
Florian Forster [Sun, 18 Mar 2012 08:14:54 +0000 (09:14 +0100)]
tcpconns plugin: Include <bsd/nlist.h> rather than <nlist.h>.

It appears that <nlist.h> is being deprecated / moved.
This hopefully fixes Debian bug #664429.

12 years agoMerge branch 'jr/varnish'
Florian Forster [Sat, 17 Mar 2012 10:45:44 +0000 (11:45 +0100)]
Merge branch 'jr/varnish'

12 years agoMerge pull request #48 from octo/pk/processes
Florian Forster [Sat, 17 Mar 2012 10:41:47 +0000 (03:41 -0700)]
Merge pull request #48 from octo/pk/processes

Fix processes plugin under FreeBSD.

12 years agoprocesses plugin: Minimize whitespace-only changes.
Florian Forster [Sat, 17 Mar 2012 10:41:04 +0000 (11:41 +0100)]
processes plugin: Minimize whitespace-only changes.

12 years agoprocesses plugin: Some more minor coding style fixes.
Florian Forster [Sat, 17 Mar 2012 10:34:43 +0000 (11:34 +0100)]
processes plugin: Some more minor coding style fixes.

12 years agoMerge pull request #52 from octo/cf/ethstat
Florian Forster [Sat, 17 Mar 2012 10:20:22 +0000 (03:20 -0700)]
Merge pull request #52 from octo/cf/ethstat

ethstat support

12 years agoethstat plugin: Implement the "MappedOnly" option.
Florian Forster [Sat, 17 Mar 2012 10:18:57 +0000 (11:18 +0100)]
ethstat plugin: Implement the "MappedOnly" option.

12 years agoethstat plugin: Fix indentation. It was a mess, sorry.
Florian Forster [Sat, 17 Mar 2012 09:54:37 +0000 (10:54 +0100)]
ethstat plugin: Fix indentation. It was a mess, sorry.

12 years agosrc/common.c: parse_value: Strip trailing whitespace before parsing.
Florian Forster [Fri, 16 Mar 2012 17:26:08 +0000 (18:26 +0100)]
src/common.c: parse_value: Strip trailing whitespace before parsing.

This hopefully avoids the annoying "trailing garbage" message when the buffer
only contains a newline or space at the end.

12 years agocollectd.conf(5): Document the "Hits" and "Hysteresis" threshold options.
Florian Forster [Fri, 16 Mar 2012 16:44:50 +0000 (17:44 +0100)]
collectd.conf(5): Document the "Hits" and "Hysteresis" threshold options.

Fixes GitHub issue #53.

12 years agoMakefile adds dependency on $(LIBLTDL), which is valued "-lltdl"
Clemens Lang [Sat, 10 Mar 2012 01:30:26 +0000 (02:30 +0100)]
Makefile adds dependency on $(LIBLTDL), which is valued "-lltdl"

When building on OS X, the collectd build failed, because the collectd target
has a dependency on "-lltdl", which is the value the variable $(LIBLTDL) has.
Obviously, this should be the file name instead. I am however not sure how to
specify the correct filename in this case.

Fixes GitHub issue #54.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoethstat plugin: Implement the "Map" option.
Florian Forster [Mon, 12 Mar 2012 12:35:38 +0000 (13:35 +0100)]
ethstat plugin: Implement the "Map" option.

12 years agoethstat plugin: Add documentation.
Florian Forster [Mon, 12 Mar 2012 06:38:19 +0000 (07:38 +0100)]
ethstat plugin: Add documentation.

12 years agoethstat plugin: Use the system header files if available.
Florian Forster [Sun, 11 Mar 2012 18:22:06 +0000 (19:22 +0100)]
ethstat plugin: Use the system header files if available.

And disable the plugin when they are not.

12 years agoethstat module: Fix allocation of "ifacelist".
Florian Forster [Sun, 11 Mar 2012 14:53:39 +0000 (15:53 +0100)]
ethstat module: Fix allocation of "ifacelist".

And remove uses of strcpy(3).

12 years agoethstat plugin: Fix includes.
Florian Forster [Sun, 11 Mar 2012 14:49:55 +0000 (15:49 +0100)]
ethstat plugin: Fix includes.

12 years agoethstat plugin: Collect performance statistics from NICs.
Cyril Feraudet [Tue, 4 Oct 2011 13:00:04 +0000 (15:00 +0200)]
ethstat plugin: Collect performance statistics from NICs.

Hi all,

For my needs at work I wrote a plugin for collectd and I wish to share it with
you.

This plugins, temporary called ethstat and wrote in C, collect lot of
performance counter about network interface as "ethtool -S ethX" do by asking
NIC driver module.

At the moment this plugin work only under Linux. Any help would be great for
make it working under Solaris, AIX and co ...

If you think this plugin may be included to collectd sources, what is the
procedure to do it ?

Regards,
Cyril Feraudet

To be added to configuration file to make it work :

LoadPlugin ethstat

<Plugin ethstat>
 Iface "eth0"
 #Iface "eth1"
 #Iface "eth2"
 #Iface "eth3"
</Plugin>

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agovarnish plugin: Simplify the v2/v3 define structs.
Florian Forster [Sun, 11 Mar 2012 14:14:40 +0000 (15:14 +0100)]
varnish plugin: Simplify the v2/v3 define structs.

This somewhat duplicates the code in the read callback, but it's easier to read
than having four or so defines in one function.

Addresses GitHub issue #14.

12 years agovarnish plugin: Closed VSM
Jérôme Renard [Tue, 20 Dec 2011 14:22:55 +0000 (15:22 +0100)]
varnish plugin: Closed VSM

12 years agovarnish plugin: Switched to AC_CHECK_HEADERS
Jérôme Renard [Wed, 26 Oct 2011 23:20:47 +0000 (01:20 +0200)]
varnish plugin: Switched to AC_CHECK_HEADERS

12 years agovarnish plugin: Fixed wrong function name
Jérôme Renard [Wed, 26 Oct 2011 23:02:39 +0000 (01:02 +0200)]
varnish plugin: Fixed wrong function name

12 years agovarnish plugin: Added basic Varnish 3.0 support
Jérôme Renard [Wed, 26 Oct 2011 21:15:00 +0000 (23:15 +0200)]
varnish plugin: Added basic Varnish 3.0 support

12 years agovarnish plugin: Added Varnish version detection flag
Jérôme Renard [Wed, 26 Oct 2011 19:14:15 +0000 (21:14 +0200)]
varnish plugin: Added Varnish version detection flag

12 years agoamqp plugin: Fix compabitility with current librabbitmq.
Florian Forster [Sun, 11 Mar 2012 13:47:24 +0000 (14:47 +0100)]
amqp plugin: Fix compabitility with current librabbitmq.

In particular, add compatibility to the 0.9.1 and current development version.
Unfortunately, no version macro exists, so we need to do some autoconf trickery
:(

Fixes GitHub issue #6.

12 years agoMerge pull request #44 from octo/ff/perl
Florian Forster [Sun, 11 Mar 2012 12:11:33 +0000 (05:11 -0700)]
Merge pull request #44 from octo/ff/perl

Fix race condition in the Perl plugin.