Pavel Rochnyack [Mon, 23 Oct 2017 14:00:52 +0000 (21:00 +0700)]
lvm plugin: Fix compilation issues
Florian Forster [Mon, 23 Oct 2017 13:20:40 +0000 (15:20 +0200)]
Merge remote-tracking branch 'github/pr/2492'
Florian Forster [Wed, 18 Oct 2017 18:59:49 +0000 (20:59 +0200)]
src/daemon/plugin.c: Fix some coding style.
Primarily to test the clang-format bot.
Florian Forster [Sun, 22 Oct 2017 17:59:19 +0000 (19:59 +0200)]
lvm update: Check for the CAP_SYS_ADMIN capability.
Fixes: #2426
Florian Forster [Sun, 22 Oct 2017 08:12:16 +0000 (10:12 +0200)]
Merge remote-tracking branch 'github/pr/2464'
Florian Forster [Sat, 21 Oct 2017 19:37:21 +0000 (21:37 +0200)]
clang-format src/postgresql.c
daniacs [Fri, 20 Oct 2017 16:36:12 +0000 (14:36 -0200)]
Update postgresql.c
A simple way collectd to identify itself to pg_stat_activity view.
Pavel Rochnyack [Fri, 20 Oct 2017 14:00:29 +0000 (21:00 +0700)]
Merge branch 'collectd-5.7'
Pavel Rochnyack [Fri, 20 Oct 2017 13:54:09 +0000 (20:54 +0700)]
Merge branch 'collectd-5.6' into collectd-5.7
Pavel Rochnyak [Fri, 20 Oct 2017 13:15:57 +0000 (20:15 +0700)]
Merge pull request #2346 from trenkel/master
Add CollectdError exception which can be thrown without causing a stacktrace to be logged.
rmakulov [Mon, 17 Jul 2017 09:12:45 +0000 (12:12 +0300)]
Fix left ssnprintf in test
Pavel Rochnyack [Fri, 20 Oct 2017 12:10:48 +0000 (19:10 +0700)]
python plugin: Passed through clang-format
Pavel Rochnyak [Fri, 20 Oct 2017 06:34:43 +0000 (13:34 +0700)]
Merge pull request #2071 from maryamtahhan/feat_ipmi_analog
ipmi plugin: add more analog sensors support
Aleksei Zakharov [Thu, 19 Oct 2017 09:58:30 +0000 (09:58 +0000)]
ceph plugin: Move comment to right place
Aleksei Zakharov [Thu, 19 Oct 2017 08:44:28 +0000 (08:44 +0000)]
Add comment about "avgtime" usage
Aleksei Zakharov [Thu, 19 Oct 2017 08:40:28 +0000 (08:40 +0000)]
Fix parse_keys() to use cut_suffixes array
Aleksei Zakharov [Thu, 19 Oct 2017 07:25:34 +0000 (07:25 +0000)]
ceph plugin: Make cut_suffix void, change var names
Florian Forster [Thu, 19 Oct 2017 07:21:50 +0000 (09:21 +0200)]
Merge remote-tracking branch 'github/pr/2467'
Florian Forster [Thu, 19 Oct 2017 05:26:34 +0000 (07:26 +0200)]
clang-format -style=file -i src/daemon/{collectd,configfile,globals}.c
campbellsean@google.com [Wed, 18 Oct 2017 20:48:50 +0000 (16:48 -0400)]
Minor changes to address PR comments.
campbellsean@google.com [Wed, 18 Oct 2017 20:39:29 +0000 (16:39 -0400)]
Tidy up formatting with clang-format.
Florian Forster [Wed, 18 Oct 2017 18:54:37 +0000 (20:54 +0200)]
Merge remote-tracking branch 'github/pr/2490'
Florian Forster [Wed, 18 Oct 2017 13:07:29 +0000 (15:07 +0200)]
rrdtool plugin: Small code cleanup.
Primarily to test the clang-format bot.
Florian Forster [Wed, 18 Oct 2017 18:27:04 +0000 (20:27 +0200)]
Merge remote-tracking branch 'github/pr/2488'
Florian Forster [Wed, 18 Oct 2017 18:00:13 +0000 (20:00 +0200)]
clang-format -style=file -i src/snmp.c
Carlos Vicente [Wed, 18 Oct 2017 17:12:05 +0000 (17:12 +0000)]
Set timeout initially to 0 per reviewer's suggestion
Carlos Vicente [Wed, 18 Oct 2017 14:21:56 +0000 (14:21 +0000)]
Adress reviewer's suggestions and add documentation
Florian Forster [Wed, 18 Oct 2017 09:17:48 +0000 (11:17 +0200)]
Merge remote-tracking branch 'github/pr/2489'
Pavel Rochnyak [Wed, 18 Oct 2017 09:02:55 +0000 (16:02 +0700)]
Merge pull request #2485 from rpv-tomsk/processes
processes: Improved documentation
Pavel Rochnyack [Sun, 15 Oct 2017 15:33:50 +0000 (22:33 +0700)]
processes: Improved documentation
Florian Forster [Wed, 18 Oct 2017 06:54:53 +0000 (08:54 +0200)]
snmp plugin: Use cf_util_get_boolean() for boolean config options.
alex2grad [Wed, 18 Oct 2017 06:42:21 +0000 (02:42 -0400)]
filecount: Controls whether or not to include only regular files in the count (#2483)
Carlos Vicente [Tue, 17 Oct 2017 16:39:48 +0000 (16:39 +0000)]
Address reviewer's suggestions
Carlos Vicente [Tue, 17 Oct 2017 14:49:08 +0000 (14:49 +0000)]
Add timeout and retry config options for SNMP plugin
Mytnyk, Volodymyr [Tue, 17 Oct 2017 09:26:58 +0000 (10:26 +0100)]
ipmi: make unhandled sensor msg more informative
Change-Id: I5fc6056b2d0c5bb5cb1b28c3d24aaca163eb245b
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
tcarreira [Thu, 12 Oct 2017 15:37:28 +0000 (16:37 +0100)]
[2475] write_prometheus plugin: Fix port listening
Signed-off-by: Florian Forster <octo@collectd.org>
Pavel Rochnyak [Mon, 16 Oct 2017 13:41:33 +0000 (20:41 +0700)]
Merge pull request #2482 from outini/master
Implementation of "Prefix" option for write_http plugin
Pavel Rochnyack [Mon, 16 Oct 2017 12:46:06 +0000 (19:46 +0700)]
write_http: Allow to set empty metrics prefix in KAIROSDB format
Pavel Rochnyack [Mon, 16 Oct 2017 12:05:20 +0000 (19:05 +0700)]
write_http: Added strdup() result check
Denis 'jawa' Pompilio [Mon, 16 Oct 2017 08:15:50 +0000 (10:15 +0200)]
Setting metrics_prefix as char const *
Denis 'jawa' Pompilio [Fri, 13 Oct 2017 12:28:44 +0000 (14:28 +0200)]
Added denis pompilio to contributors
Denis 'jawa' Pompilio [Thu, 12 Oct 2017 15:33:13 +0000 (17:33 +0200)]
Implementation of "Prefix" for write_http plugin
This option is only available for the KAIROSDB format
This option defaults to "collectd"
Aleksei Zakharov [Thu, 12 Oct 2017 10:43:54 +0000 (10:43 +0000)]
Add sstrncpy if count_parts>2 but no suffix
Sean Campbell [Thu, 12 Oct 2017 01:31:45 +0000 (21:31 -0400)]
Leftover reference to hostname_g[].
Sean Campbell [Wed, 11 Oct 2017 21:50:56 +0000 (17:50 -0400)]
Make g_strings in perl.c not global so that hostname_g as a char* doesn't break it.x
Aleksei Zakharov [Wed, 11 Oct 2017 17:26:24 +0000 (17:26 +0000)]
Clang-format done
Aleksei Zakharov [Wed, 11 Oct 2017 17:15:30 +0000 (17:15 +0000)]
Fix unit test
".sum" is not cutted in parse_keys() now.
Mytnyk, VolodymyrX [Mon, 28 Nov 2016 16:57:49 +0000 (16:57 +0000)]
ipmi: add more analog sensors support
- Add support of new analog sensors:
System Airflow, PS1 Input Power, MTT CPU1, MTT CPU2
- Extend list of sensors to support "memory" sensor type.
- Map sensors with a 'percent' flag to 'percent' type
and add sensor type as a prefix to type_instance in
this case. The type_instance of non % sensors will
remain the same (just sensor name).
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Pavel Rochnyak [Wed, 11 Oct 2017 15:25:35 +0000 (22:25 +0700)]
Merge pull request #2300 from rpv-tomsk/fix-sread
Remove close() call from sread()
Florian Forster [Wed, 11 Oct 2017 12:46:43 +0000 (14:46 +0200)]
Merge remote-tracking branch 'github/pr/2135'
Mytnyk, Volodymyr [Tue, 10 Oct 2017 15:13:46 +0000 (16:13 +0100)]
python: Addressed review comments
- Run clang-format
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Pavel Rochnyack [Mon, 31 Jul 2017 05:13:15 +0000 (12:13 +0700)]
Changed return type of sread() and swrite() from 'ssize_t' to 'int'
Functions 'sread()' and 'swrite()', unlike 'read()' and 'write()', does not return the number of bytes actually read/written.
They return error status, which is returned as 'int' type in Collectd code.
Pavel Rochnyack [Tue, 4 Jul 2017 09:14:05 +0000 (16:14 +0700)]
Proper check for `swrite()` return value
The `swrite()` can return positive value from `errno` in case of error.
Pavel Rochnyack [Fri, 26 May 2017 06:14:19 +0000 (12:14 +0600)]
Remove close() call from sread()
The sread() function should not close fd in any cases, that is unexpected.
Florian Forster [Tue, 10 Oct 2017 20:38:05 +0000 (22:38 +0200)]
write_prometheus plugin: Implement logging callback.
Pavel Rochnyak [Tue, 10 Oct 2017 13:15:43 +0000 (20:15 +0700)]
Merge pull request #2024 from rpv-tomsk/master-ipmi
ipmi plugin: Implemented IPMI LAN connection and plugin improved
Pavel Rochnyack [Tue, 10 Oct 2017 10:37:03 +0000 (17:37 +0700)]
ipmi plugin: style
Pavel Rochnyack [Tue, 10 Oct 2017 10:31:18 +0000 (17:31 +0700)]
ipmi plugin: Refactored to use c_ipmi_notification_init_()
Pavel Rochnyack [Tue, 10 Oct 2017 09:58:37 +0000 (16:58 +0700)]
ipmi plugin: Fixed remarks found while review
Pavel Rochnyack [Mon, 9 Oct 2017 20:08:38 +0000 (03:08 +0700)]
memcached: Fix hitratio calculation
If there is no requests, NAN is reported as hitratio.
If there is no hits - zero is reported.
Pavel Rochnyack [Mon, 9 Oct 2017 15:27:41 +0000 (22:27 +0700)]
ipmi plugin: Use cf_util_get_boolean()
Pavel Rochnyack [Mon, 9 Oct 2017 14:34:49 +0000 (21:34 +0700)]
memcached: style changes
Pavel Rochnyack [Mon, 9 Oct 2017 09:25:16 +0000 (16:25 +0700)]
memcached: Replace gauge_t with derive_t
Pavel Rochnyack [Mon, 9 Oct 2017 10:22:00 +0000 (17:22 +0700)]
memcached: Fix CPU usage reporting
Signed-off-by: Florian Forster <octo@collectd.org>
Pavel Rochnyack [Wed, 27 Sep 2017 12:07:37 +0000 (19:07 +0700)]
memcached: Renamed calculate_rate to calculate_ratio_percent
Pavel Rochnyack [Sun, 30 Jul 2017 10:33:49 +0000 (17:33 +0700)]
memcached: Fix hitratio reporting
When Collectd calculates 'hitratio', it divides two continiously-grown values of Memcached stats.
As result, reported metric contains the average since Memcached start, which is incorrect.
Pavel Rochnyack [Mon, 9 Oct 2017 10:22:00 +0000 (17:22 +0700)]
memcached: Fix CPU usage reporting
Pavel Rochnyack [Mon, 9 Oct 2017 05:52:21 +0000 (12:52 +0700)]
ipmi plugin: Added a define for errors / messages buffer size
Pavel Rochnyack [Sun, 8 Oct 2017 06:41:29 +0000 (13:41 +0700)]
ipmi plugin: Notify about IPMI connection state change
Pavel Rochnyack [Sun, 8 Oct 2017 06:23:32 +0000 (13:23 +0700)]
ipmi plugin: Improvements
* Do not request reading unless domain is connected
* Report instance name in error messages
Aleksei Zakharov [Fri, 6 Oct 2017 22:38:27 +0000 (22:38 +0000)]
Make node_handler_fetch_data() stateless
This code also works with previous ceph versions now.
Wilfried Goesgens [Sun, 8 Oct 2017 11:52:15 +0000 (13:52 +0200)]
style
Pavel Rochnyack [Sun, 20 Mar 2016 08:51:26 +0000 (14:51 +0600)]
statsd: Document collectd behaviour when receiving the 0.000 timer value
Signed-off-by: Florian Forster <octo@collectd.org>
Pavel Rochnyack [Sat, 7 Oct 2017 19:30:13 +0000 (02:30 +0700)]
ipmi plugin: Code cleanup
Wilfried Goesgens [Sat, 7 Oct 2017 19:14:46 +0000 (21:14 +0200)]
Currently curl_json will barely ignore boolean values in a non erroneous
way, so that if you have an array like this:
you will be able to access the 123 number like
We now rather call our number parser with 0 for false, 1 for true.
Pavel Rochnyack [Fri, 4 Nov 2016 21:11:54 +0000 (03:11 +0600)]
ipmi plugin: Implemented IPMI LAN connection and plugin improved
* Added instances support
* Removed the sensor removal in case of reading errors
* Added the lock to do not request new readings until previous reading is complete
* Disabled SDRs local cache
* Added the check for sensors 'is readable' flag
* Added the check for sensor event reading type (if sensor is discrete or not)
* Added checks for sensor states 'scanning disabled' and 'initial update in progress'
* Changes in error reporting
Sean Campbell [Fri, 6 Oct 2017 20:55:37 +0000 (16:55 -0400)]
Fixed issues with initializing hostname.
campbellsean@google.com [Fri, 6 Oct 2017 18:23:18 +0000 (14:23 -0400)]
Fix kstat_ctl_t definition in globals.
campbellsean@google.com [Fri, 6 Oct 2017 17:47:45 +0000 (13:47 -0400)]
Cleanup some defines and includes.
campbellsean@google.com [Fri, 6 Oct 2017 17:44:38 +0000 (13:44 -0400)]
Adds setter for hostname_g and eliminates hostname_g_size variable.
campbellsean@google.com [Fri, 6 Oct 2017 17:40:43 +0000 (13:40 -0400)]
Add MIT license to new globals files.
Florian Forster [Fri, 6 Oct 2017 13:33:29 +0000 (15:33 +0200)]
Merge remote-tracking branch 'github/pr/2469'
Florian Forster [Fri, 6 Oct 2017 13:32:01 +0000 (15:32 +0200)]
Merge remote-tracking branch 'github/pr/2453'
Florian Forster [Fri, 6 Oct 2017 12:50:06 +0000 (14:50 +0200)]
Merge remote-tracking branch 'github/pr/2398'
Florian Forster [Fri, 6 Oct 2017 12:45:05 +0000 (14:45 +0200)]
libcollectdclient/network_parse.c: Ensure memory allocated in parse_values() is always freed.
Shoutout to scan-build for finding this one!
Florian Forster [Fri, 6 Oct 2017 11:14:01 +0000 (13:14 +0200)]
Merge remote-tracking branch 'github/pr/2091'
Mytnyk, Volodymyr [Thu, 5 Oct 2017 15:12:42 +0000 (16:12 +0100)]
ipmi: Run code through clang-format
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Mytnyk, Volodymyr [Thu, 5 Oct 2017 13:44:14 +0000 (14:44 +0100)]
ipmi: Addressed review comments
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
Mytnyk, VolodymyrX [Thu, 5 Jan 2017 17:14:07 +0000 (17:14 +0000)]
collectd-python(5): Fix documentation of Notification.dispatch().
Cherry-picked from PR #2135
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Fri, 6 Oct 2017 07:50:40 +0000 (09:50 +0200)]
Merge branch 'collectd-5.7'
Florian Forster [Fri, 6 Oct 2017 07:50:06 +0000 (09:50 +0200)]
Merge branch 'collectd-5.6' into collectd-5.7
Florian Forster [Fri, 6 Oct 2017 06:53:37 +0000 (08:53 +0200)]
Bump version to 5.6.3; Update ChangeLog.
Damian Bogel [Wed, 9 Sep 2015 19:03:25 +0000 (15:03 -0400)]
Reading configuration file is now done outside main().
Damian Bogel [Wed, 9 Sep 2015 15:37:05 +0000 (11:37 -0400)]
Common stuff now builds as a library.
Florian Forster [Fri, 6 Oct 2017 05:26:57 +0000 (07:26 +0200)]
Merge remote-tracking branch 'github/pr/2466' into collectd-5.7
Serhiy Pshyk [Fri, 6 Oct 2017 01:24:11 +0000 (02:24 +0100)]
intel_pmu: address PR comments
Signed-off-by: Serhiy Pshyk <serhiyx.pshyk@intel.com>
Florian Forster [Thu, 5 Oct 2017 20:17:46 +0000 (22:17 +0200)]
write_prometheus plugin: Don't construct struct sockaddr_in6 manually.
On FreeBSD, the struct is an incomplete type.
Florian Forster [Thu, 5 Oct 2017 18:17:21 +0000 (20:17 +0200)]
write_prometheus plugin: Add support for libmicrohttpd < 0.9.0.
0.9.0 was released in July 2010, yet Precise, which we're still building for,
ships 0.4.6. *sigh*
Florian Forster [Thu, 5 Oct 2017 13:23:28 +0000 (15:23 +0200)]
write_prometheus plugin: Fall back to IPv4 socket if IPv6 fails.
Unfortunately, for libmicrohttpd "dual stack" means "enforce IPv6 (but
allow IPv4, too)". That means that on systems without IPv6,
libmicrohttpd'd initialization fails (when the dual stack flag is set).
To work around this limitation we open the socket ourselves and pass it
to libmicrohttpd to use.
Fixes: #2149
Aleksei Zakharov [Thu, 5 Oct 2017 08:27:27 +0000 (11:27 +0300)]
Replace avgcount_exists with latency_next_metric