collectd.git
12 years agoARG_MAX on Solaris is *very* large, 2 MB. Allocating that much on the
hume-github [Thu, 27 Sep 2012 13:43:09 +0000 (10:43 -0300)]
ARG_MAX on Solaris is *very* large, 2 MB.  Allocating that much on the
stack (local variable) overflows the thread stack and crashes the
process in weird and interesting ways.

"int i" is a useless variable and breaks the build with -Werror.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoprocesses plugin: Coding style and whitespace changes.
Florian Forster [Mon, 19 Mar 2012 07:43:49 +0000 (08:43 +0100)]
processes plugin: Coding style and whitespace changes.

12 years agoprocesses plugin: Use stack memory when reading the command line.
Florian Forster [Mon, 19 Mar 2012 07:43:22 +0000 (08:43 +0100)]
processes plugin: Use stack memory when reading the command line.

Also remove the call to the non-threadsafe strtok(3) call and fix the
size passed to sstrncpy().

12 years agoprocesses plugin: Call ps_submit_fork_rate() from read_fork_rate().
Florian Forster [Sun, 18 Mar 2012 20:01:53 +0000 (21:01 +0100)]
processes plugin: Call ps_submit_fork_rate() from read_fork_rate().

This avoids the "return ULONG_MAX" hack to signal a problem.

12 years agoBuffer and memory allocation related bug fixes and changes
Cosmin Ioiart [Wed, 7 Mar 2012 11:33:12 +0000 (12:33 +0100)]
Buffer and memory allocation related bug fixes and changes

Replaced "free" with "sfree" for memory deallocation.
Added memset(...) to initialized newly allocated memory
Removed buffer "termination".

12 years agoAdded support for the Solaris OS processes
Cosmin Ioiart [Tue, 6 Mar 2012 14:58:25 +0000 (15:58 +0100)]
Added support for the Solaris OS processes

  Added support for process information on the Solaris OS. The information comes mainly from
  /proc/PID/status, /proc/PID/psinfo , /proc/PID/usage and kstat
  Added a few "solaris" specific process states as well

12 years agoMerge branch 'collectd-5.1'
Florian Forster [Sun, 23 Sep 2012 10:22:37 +0000 (12:22 +0200)]
Merge branch 'collectd-5.1'

12 years agoMerge branch 'collectd-5.0' into collectd-5.1
Florian Forster [Sun, 23 Sep 2012 10:22:27 +0000 (12:22 +0200)]
Merge branch 'collectd-5.0' into collectd-5.1

12 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Sun, 23 Sep 2012 10:20:49 +0000 (12:20 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

Conflicts:
src/utils_db_query.c
src/zfs_arc.c

12 years agoFix for Solaris when setting ip-opt multicast-loop (must be a char, not int).
hume-github [Tue, 18 Sep 2012 18:19:39 +0000 (15:19 -0300)]
Fix for Solaris when setting ip-opt multicast-loop (must be a char, not int).
General logging additions for tracking down the problem.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMultithreading fix: localize unneeded global variable
hume-github [Tue, 18 Sep 2012 18:12:25 +0000 (15:12 -0300)]
Multithreading fix: localize unneeded global variable

12 years agoethstat plugin: Initialize realloc'ated memory.
Florian Forster [Sun, 23 Sep 2012 10:00:43 +0000 (12:00 +0200)]
ethstat plugin: Initialize realloc'ated memory.

The last element in "interfaces" is not guaranteed to be zeroed, resulting in a
segfault when cf_util_get_string() tries to free the "pointer".

Thanks to Mark T. Voelker for reporting and analyzing this bug!
This should fix Github issue #133.

12 years agoethstat plugin: Fix off-by-one error.
Florian Forster [Sun, 23 Sep 2012 09:56:58 +0000 (11:56 +0200)]
ethstat plugin: Fix off-by-one error.

This hopefully fixes Github issue #135.

12 years agolibs varnish & varnishcompat are NOT needed. "pkg-config --libs varnishapi" output...
JonathanHuot [Thu, 13 Sep 2012 16:27:57 +0000 (18:27 +0200)]
libs varnish & varnishcompat are NOT needed. "pkg-config --libs varnishapi" output only libvarnishapi as well

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agobindings/Makefile: perl: Use INSTALL_BASE rather than PREFIX.
Sebastian Harl [Wed, 13 Jun 2012 12:33:05 +0000 (14:33 +0200)]
bindings/Makefile: perl: Use INSTALL_BASE rather than PREFIX.

Some versions of Perl / ExtUtils::MakeMaker will else abort with an error
message explaining INSTALL_BASE and PREFIX may not be used both. However, I
don't know where the other definition comes from.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoconfigure: Don't add -liptc to the global LIBS setting.
Sebastian Harl [Wed, 13 Jun 2012 12:31:00 +0000 (14:31 +0200)]
configure: Don't add -liptc to the global LIBS setting.

AC_SEARCH_LIBS() would do that, so save and restore LIBS when calling that
macro.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoconfigure: Use AC_INCLUDES_DEFAULT when checking any libkvm stuff.
Sebastian Harl [Fri, 18 May 2012 20:31:13 +0000 (22:31 +0200)]
configure: Use AC_INCLUDES_DEFAULT when checking any libkvm stuff.

kvm.h requires sys/types.h to be included. Using AC_INCLUDES_DEFAULT will
hopefully make sure that we're save for a bit ;-)

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agocurl_xml plugin: Mark read-only strings as const.
Florian Forster [Thu, 13 Sep 2012 08:53:19 +0000 (10:53 +0200)]
curl_xml plugin: Mark read-only strings as const.

12 years agofix Host config being ignored
Fabien Wernli [Mon, 28 Nov 2011 09:46:18 +0000 (10:46 +0100)]
fix Host config being ignored

Change-Id: I8a109818d8a821e2f3e0660fbb6ba1843279fcc2
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoapcups plugin: Retry sending the "status" command.
Florian Forster [Thu, 13 Sep 2012 08:18:14 +0000 (10:18 +0200)]
apcups plugin: Retry sending the "status" command.

If that fails more than twice in the first 10 iterations, gracefully shut
down the socket in all future iterations.

This should fix Github issue #15.

12 years agoapcups plugin: Add function net_shutdown().
Florian Forster [Thu, 13 Sep 2012 08:05:35 +0000 (10:05 +0200)]
apcups plugin: Add function net_shutdown().

12 years agoapcups plugin: Make sure the socket is closed on errors.
Florian Forster [Thu, 13 Sep 2012 08:04:26 +0000 (10:04 +0200)]
apcups plugin: Make sure the socket is closed on errors.

12 years agosrc/utils_db_query.c: Use the right field when checking for size.
Florian Forster [Wed, 12 Sep 2012 20:51:58 +0000 (22:51 +0200)]
src/utils_db_query.c: Use the right field when checking for size.

12 years agoswap plugin: Add the "ReportBytes" option.
Florian Forster [Wed, 12 Sep 2012 16:55:08 +0000 (18:55 +0200)]
swap plugin: Add the "ReportBytes" option.

When enabled, swap I/O is reported in bytes, not pages. Only valid for Linux.

This should fix Github issue #10.

12 years agoRevert "swap plugin: Add the "ReportBytes" option."
Florian Forster [Wed, 12 Sep 2012 19:31:41 +0000 (21:31 +0200)]
Revert "swap plugin: Add the "ReportBytes" option."

This reverts commit 25fd1667c186eb871a4b66f9866d6446e41f1bc2.

12 years agoswap plugin: Add the "ReportBytes" option.
Florian Forster [Wed, 12 Sep 2012 16:55:08 +0000 (18:55 +0200)]
swap plugin: Add the "ReportBytes" option.

When enabled, swap I/O is reported in bytes, not pages. Only valid for Linux.

This should fix Github issue #10.

12 years agoexec plugin: Really remove STDERR from the select() set.
Florian Forster [Wed, 12 Sep 2012 16:25:20 +0000 (18:25 +0200)]
exec plugin: Really remove STDERR from the select() set.

select(2) is actually using a variable called "copy", which we didn't set in
this case.

Fixes Github issue #12. Thanks to Tetsuya Kawaguchi for reporting this problem.

12 years agoconfigure.in: Make sure sa_familiy_t is defined when checking rtnl_dump_filter().
Florian Forster [Tue, 11 Sep 2012 07:54:32 +0000 (09:54 +0200)]
configure.in: Make sure sa_familiy_t is defined when checking rtnl_dump_filter().

12 years agonetlink plugin: Check for the number of arguments to 'rtnl_dump_filter'.
Sebastian Harl [Sat, 19 May 2012 10:31:52 +0000 (12:31 +0200)]
netlink plugin: Check for the number of arguments to 'rtnl_dump_filter'.

In recent versions of iproute2, 'rtnl_dump_filter' expects three rather than
five arguments.

This should fix Github issue #7.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoFixed collectd's unixsock read interrupted by SIGCHLD's.
Gerrie Roos [Tue, 17 Apr 2012 13:22:36 +0000 (15:22 +0200)]
Fixed collectd's unixsock read interrupted by SIGCHLD's.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoFixed various collectd memory leaks.
Gerrie Roos [Fri, 25 May 2012 03:38:47 +0000 (05:38 +0200)]
Fixed various collectd memory leaks.

Once I understood what's going on I tried to keep the changes to a minimum.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge branch 'ff/kstat' into collectd-4.10
Florian Forster [Mon, 10 Sep 2012 19:10:45 +0000 (21:10 +0200)]
Merge branch 'ff/kstat' into collectd-4.10

12 years agoSet license info line to ”GPLv2 or newer”
Adrian Perez [Fri, 7 Sep 2012 13:59:32 +0000 (16:59 +0300)]
Set license info line to ”GPLv2 or newer”

Recently I had a request to change the licensing of this file to
use it in a GPLv3 application. This change would make it easier,
while retaining GPLv2 to make the license still match the one in
collectd.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge branch 'collectd-5.1'
Florian Forster [Fri, 7 Sep 2012 09:19:52 +0000 (11:19 +0200)]
Merge branch 'collectd-5.1'

12 years agoMerge branch 'collectd-5.0' into collectd-5.1
Florian Forster [Fri, 7 Sep 2012 09:15:24 +0000 (11:15 +0200)]
Merge branch 'collectd-5.0' into collectd-5.1

Conflicts:
src/swap.c

12 years agoMerge branch 'collectd-4.10' into collectd-5.0
Florian Forster [Fri, 7 Sep 2012 09:05:48 +0000 (11:05 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0

12 years agocorrected high-resolution time conversions after code review
m4rienf [Thu, 6 Sep 2012 19:25:22 +0000 (21:25 +0200)]
corrected high-resolution time conversions after code review

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoUpdated Adrian Perez' 2009 Python network proto classes
m4rienf [Tue, 4 Sep 2012 18:23:43 +0000 (20:23 +0200)]
Updated Adrian Perez' 2009 Python network proto classes

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agosnmp plugin: Fix error message printed by the "Shift" option.
Dan Thomson [Fri, 7 Sep 2012 02:00:11 +0000 (19:00 -0700)]
snmp plugin: Fix error message printed by the "Shift" option.

I noticed a small error in snmp.c in collectd-5.1.0 (might be
elsewhere). The warning message in csnmp_config_add_data_shift says
"Scale config option" instead of "Shift" config option:
[…]

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agodf plugin: when checking / do it just once
Bruno Prémont [Wed, 21 Mar 2012 20:34:00 +0000 (21:34 +0100)]
df plugin: when checking / do it just once

Newer system symlink /etc/mtab to /proc/mounts which makes root
filesystem seem mounted twice, once as type rootfs and once for the
real device.

When / is selected for df plugin, skip the rootfs mount-point as
real root is usually mounted right on top of it.

Not skipping it causes rrdtool to complain about two updates for the
same timestamp, the first entry for rootfs passes but rrdtool complains
when stats for the second occurrence for real filesystem is being
considered.

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Florian Forster <octo@collectd.org>
12 years agosnmp plugin: Check for SNMP_ENDOFMIBVIEW.
Florian Forster [Fri, 7 Sep 2012 08:11:42 +0000 (10:11 +0200)]
snmp plugin: Check for SNMP_ENDOFMIBVIEW.

Some implementations of SNMP will send a special "variable" when you're
leaving the requested subtree with type "endOfMibView" aka.
"SNMP_ENDOFMIBVIEW". Examples of such implementations are Citrix
Netscalers and IBM's General Parallel File System (GPFS). Reading past
this special variable will result in weird values being returned.

This adds an appropriate check to csnmp_check_res_left_subtree().

Thanks to "Mark" for reporting this issue and clarifying.

12 years agosrc/common.c: Add missing semicolon.
Florian Forster [Thu, 6 Sep 2012 15:29:59 +0000 (17:29 +0200)]
src/common.c: Add missing semicolon.

12 years agosrc/common.c: get_kstat_value: Check the arguments and return error codes.
Florian Forster [Thu, 6 Sep 2012 14:12:53 +0000 (16:12 +0200)]
src/common.c: get_kstat_value: Check the arguments and return error codes.

Rather than asserting that an argument is not NULL, check this condition
and return an error code.

This should fix Github issue #71.

12 years agosrc/Makefile.am: Unconditionally link collectd with libm.
Florian Forster [Wed, 5 Sep 2012 06:43:18 +0000 (08:43 +0200)]
src/Makefile.am: Unconditionally link collectd with libm.

Under FreeBSD, running src/utils_format_json.c fails because isfinite()
cannot be resolved. The GNU manpages for isnan() and isfinite() also
advise users to link with libm and AIX has had the library being linked
in for a while. Since it's such a basic library it seems easier to just
link with it unconditionally.

Fixes Github issue #122.

12 years agoMerge pull request #124 from tokkee/bj/build
Florian Forster [Tue, 4 Sep 2012 10:45:44 +0000 (03:45 -0700)]
Merge pull request #124 from tokkee/bj/build

Fix some build issues on AIX using automake <= 1.9 and gcc 4.7.1.

12 years agoAdd missing return statements
Benjamin Jacobs [Sun, 2 Sep 2012 21:54:35 +0000 (23:54 +0200)]
Add missing return statements

Fix gcc warn/error: no return statement in function returning non-void [-Werror=return-type]

Signed-off-by: Sebastian Harl <sh@tokkee.org>
12 years agoAutomake 1.9 compatibility: don't use $(builddir)
Benjamin Jacobs [Sun, 2 Sep 2012 21:53:24 +0000 (23:53 +0200)]
Automake 1.9 compatibility: don't use $(builddir)

Automake <= 1.9 don't define $(builddir) which is always defined to
'.' anyway.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
12 years agosrc/collectd.conf.in: Update memcached config block.
Florian Forster [Mon, 3 Sep 2012 12:51:04 +0000 (14:51 +0200)]
src/collectd.conf.in: Update memcached config block.

12 years agomemcached plugin: Fix some error messages.
Florian Forster [Mon, 3 Sep 2012 06:53:45 +0000 (08:53 +0200)]
memcached plugin: Fix some error messages.

12 years agomemcached plugin: Fix backwards compatibility.
Florian Forster [Mon, 3 Sep 2012 06:52:32 +0000 (08:52 +0200)]
memcached plugin: Fix backwards compatibility.

Don't use the instance name in the identifier when we're using the legacy
configuration mode.

12 years agomemcached plugin: Reorder functions to avoid prototype.
Florian Forster [Mon, 3 Sep 2012 06:25:46 +0000 (08:25 +0200)]
memcached plugin: Reorder functions to avoid prototype.

12 years agomemcached plugin: Refactor the memcached_query_daemon() function.
Florian Forster [Mon, 3 Sep 2012 06:22:16 +0000 (08:22 +0200)]
memcached plugin: Refactor the memcached_query_daemon() function.

The connecting code has been broken out in separate functions and the
writing and reading from the socket no longer uses poll(2),
non-blocking I/O and a custom built retry logic. Instead block on I/O and
let the read-thread-pool do its thing.

12 years agomemcached plugin: Fix backwards compatibility.
Florian Forster [Sun, 2 Sep 2012 11:25:16 +0000 (13:25 +0200)]
memcached plugin: Fix backwards compatibility.

Register a default callback in the init() phase if no configuration is
provided for the plugin. This way doing just "LoadPlugin memcached" will
result in the old behavior i.e. localhost being queried.

12 years agomemcached plugin: Fix the default behavior, i.e. use the documented host and port.
Florian Forster [Sun, 2 Sep 2012 11:03:07 +0000 (13:03 +0200)]
memcached plugin: Fix the default behavior, i.e. use the documented host and port.

12 years agocollectd.conf(5): Document the memcached plugin.
Florian Forster [Sun, 2 Sep 2012 10:58:30 +0000 (12:58 +0200)]
collectd.conf(5): Document the memcached plugin.

The Instance blocks and Socket option were missing.

12 years agomemcached plugin: Specify read-group name when registering callbacks.
Florian Forster [Sun, 2 Sep 2012 10:42:21 +0000 (12:42 +0200)]
memcached plugin: Specify read-group name when registering callbacks.

12 years agomemcached plugin: Rename config callback (add prefix).
Florian Forster [Sun, 2 Sep 2012 10:41:48 +0000 (12:41 +0200)]
memcached plugin: Rename config callback (add prefix).

12 years agomemcached plugin: Replace config_set_string() with cf_util_get_string().
Florian Forster [Sun, 2 Sep 2012 10:41:22 +0000 (12:41 +0200)]
memcached plugin: Replace config_set_string() with cf_util_get_string().

12 years agomultiple memcached instances, v2
Nicolas Szalay [Tue, 13 Mar 2012 08:37:57 +0000 (09:37 +0100)]
multiple memcached instances, v2

12 years agomemcached plugin : added support for multiple instances
Nicolas [Fri, 23 Dec 2011 22:15:22 +0000 (23:15 +0100)]
memcached plugin : added support for multiple instances

12 years agoMerge branch 'sh/collectd-5.1' into collectd-5.1
Florian Forster [Mon, 27 Aug 2012 08:12:11 +0000 (10:12 +0200)]
Merge branch 'sh/collectd-5.1' into collectd-5.1

12 years agoMerge branch 'ms/tcpconns'
Florian Forster [Mon, 27 Aug 2012 06:39:17 +0000 (08:39 +0200)]
Merge branch 'ms/tcpconns'

12 years agotcpconns plugin: Only chose between netlink / proc on the first iteration.
Florian Forster [Mon, 27 Aug 2012 06:35:29 +0000 (08:35 +0200)]
tcpconns plugin: Only chose between netlink / proc on the first iteration.

Rather than going for netlink each iteration and fall back to /proc, try
this on the first iteration only and stick with the result afterwards.
Also contains some improvements to the error handling / reporting.

12 years agoAdded the instance name to varnish API
Jonathan Huot [Thu, 2 Aug 2012 15:56:05 +0000 (18:56 +0300)]
Added the instance name to varnish API

Fixed issue collectd#110

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agolittle style changes (code review)
Michael Stapelberg [Fri, 24 Aug 2012 21:02:26 +0000 (23:02 +0200)]
little style changes (code review)

12 years agosrc/utils_format_json.c: Remove unused arguments.
Florian Forster [Thu, 23 Aug 2012 07:45:57 +0000 (09:45 +0200)]
src/utils_format_json.c: Remove unused arguments.

12 years agowrite_graphite: Use the broken out "format_graphite" module.
Florian Forster [Thu, 23 Aug 2012 07:44:02 +0000 (09:44 +0200)]
write_graphite: Use the broken out "format_graphite" module.

This was broken out for use in the AMQP plugin. De-duplicate the code by
using it from write_graphite as well.

12 years agoAUTHORS: Add Thomas Meson.
Florian Forster [Thu, 23 Aug 2012 07:03:35 +0000 (09:03 +0200)]
AUTHORS: Add Thomas Meson.

Add Florian Forster to the list of copyright holders and authors of
utils_format_graphite.c, since its based on his code.

12 years agoamqp plugin: add support for Graphite output
Thomas Meson [Fri, 10 Aug 2012 22:11:54 +0000 (00:11 +0200)]
amqp plugin: add support for Graphite output

This commit implements "Graphite format" for AMQP Plugin.
The AMQP plugin will be able to directly output a valid
Graphite metric format (<metric name> <value> <timestamp>\n).
This is very useful when the Graphite server is directly reading
from an AMQP broker. You can then avoid having a proxy somewhere
doing the conversion between PUTVAL or JSON metrics into Graphite
format.

Signed-off-by: Florian Forster <octo@collectd.org>
12 years agoMerge pull request #109 from tokkee/sh/collectd-5.0
Florian Forster [Fri, 10 Aug 2012 07:16:37 +0000 (00:16 -0700)]
Merge pull request #109 from tokkee/sh/collectd-5.0

configure: Define _REENTRANT when compiling on Solaris.

LGTM

12 years agoFix to make write_mongodb work with any version of mongo-c-driver
Chris Lundquist [Fri, 13 Jul 2012 01:06:15 +0000 (01:06 +0000)]
Fix to make write_mongodb work with any version of mongo-c-driver

12 years agotcpconns/linux: Use netlink instead of parsing /proc/net/tcp{,6}
Michael Stapelberg [Tue, 7 Aug 2012 10:41:38 +0000 (12:41 +0200)]
tcpconns/linux: Use netlink instead of parsing /proc/net/tcp{,6}

12 years agoconfigure: Define _REENTRANT when compiling on Solaris.
Mathijs Möhlmann [Tue, 22 Mar 2011 13:26:47 +0000 (14:26 +0100)]
configure: Define _REENTRANT when compiling on Solaris.

On Wed, Mar 16, 2011 at 10:35:07AM +0100, Mathijs Möhlmann wrote:
> I'm using collectd 4.10.2 on Solaris 10 (gcc 3.4.6). Sometimes when I
> start with a clean rrd directory or add a host the .rrd file (rrdtools
> plugin) don't get created and I get the following message:
>
> collectd[2996]: [ID 702911 daemon.error] stat(/usr/local/var/lib/collectd/rrd/asterix/load/load.rrd) failed: Bad file number

This patch fixes this.

Signed-off-by: Sebastian Harl <sh@teamix.net>
12 years agoconfigure, utils_dns: Check for and use netinet/ip_compat.h.
Sebastian Harl [Thu, 2 Aug 2012 10:16:38 +0000 (12:16 +0200)]
configure, utils_dns: Check for and use netinet/ip_compat.h.

This is required on Solaris in order to get the ip6_ext struct.

12 years agomysql plugin: Use the database instance name for identifying read callbacks.
Sebastian Harl [Wed, 1 Aug 2012 07:16:34 +0000 (09:16 +0200)]
mysql plugin: Use the database instance name for identifying read callbacks.

The database instance is specified as argument to the <Database> block.
Without this fix, we cannot specify two database blocks without the
(optional!) 'Database' option as this would result in registering two read
callbacks with the name 'mysql'.

Thanks to Johan Bergström for reporting this on IRC!

12 years agocontrib/migrate-4-5.px: Added missing end quotes in a call to rrd_filter.px.
Sebastian Harl [Sun, 15 Jul 2012 11:04:09 +0000 (13:04 +0200)]
contrib/migrate-4-5.px: Added missing end quotes in a call to rrd_filter.px.

12 years agoFix bad definition of UDP src port in DNS plugin.
Daniel Sutto [Wed, 11 Jul 2012 17:32:16 +0000 (19:32 +0200)]
Fix bad definition of UDP src port in DNS plugin.

12 years agoFix bad definition of UDP src port in DNS plugin.
Daniel Sutto [Wed, 11 Jul 2012 17:32:16 +0000 (19:32 +0200)]
Fix bad definition of UDP src port in DNS plugin.

12 years agocollectd.conf(5): Document the "Password" option.
Florian Forster [Mon, 9 Jul 2012 05:49:00 +0000 (07:49 +0200)]
collectd.conf(5): Document the "Password" option.

12 years agoredis plugin: Coding style fixes.
Florian Forster [Mon, 9 Jul 2012 05:48:40 +0000 (07:48 +0200)]
redis plugin: Coding style fixes.

12 years agoredis plugin: Add authentication support.
biancalana [Fri, 6 Jul 2012 02:10:24 +0000 (23:10 -0300)]
redis plugin: Add authentication support.

12 years agoCorrect compilation on FreeBSD, set HOST_NAME_MAX to _POSIX_HOST_NAME_MAX if isn...
biancalana [Fri, 6 Jul 2012 01:07:15 +0000 (22:07 -0300)]
Correct compilation on FreeBSD, set HOST_NAME_MAX to _POSIX_HOST_NAME_MAX if isn't defined

12 years agosrc/utils_format_json.c: Various fixes for the meta data code.
Florian Forster [Fri, 6 Jul 2012 13:39:18 +0000 (15:39 +0200)]
src/utils_format_json.c: Various fixes for the meta data code.

* Moved to a separate function.
* Escape string values.
* Fix format string for [u]int64_t.
* Emit the JSON literals «true» and «false» rather than «0» and «1».
* Make certain keys are always freed.
* Move the meta data information into a separate map.

12 years agoannotate meta data to json objects
Mark Wong [Thu, 20 Jan 2011 23:18:14 +0000 (15:18 -0800)]
annotate meta data to json objects

Run through any metadata and annotate them to json objects when they are
created.

12 years agocontrib/migrate-4-5.px: Break up "df" RRD files into multiple files.
Florian Forster [Thu, 5 Jul 2012 13:48:29 +0000 (15:48 +0200)]
contrib/migrate-4-5.px: Break up "df" RRD files into multiple files.

12 years agocollectd.conf(5): Improve description of the configuration syntax.
Florian Forster [Thu, 5 Jul 2012 06:32:28 +0000 (08:32 +0200)]
collectd.conf(5): Improve description of the configuration syntax.

12 years agoMerge pull request #97 from tokkee/sh/swap
Florian Forster [Mon, 2 Jul 2012 20:00:34 +0000 (13:00 -0700)]
Merge pull request #97 from tokkee/sh/swap

swap plugin: Don't report an error if there is no swap space on Linux.

12 years agoswap plugin: Don't report an error if there is no swap space on Linux.
Sebastian Harl [Sat, 30 Jun 2012 14:33:09 +0000 (16:33 +0200)]
swap plugin: Don't report an error if there is no swap space on Linux.

… rather, simply record zeros in that case. Swap may be switched on and off at
arbitrary times and/or might be added at "later" times. Thus, storing zero in
case the swap plugin is enabled sounds like the best approach to me.

12 years agoMerge pull request #96 from mstap/master
Florian Forster [Sat, 30 Jun 2012 01:09:57 +0000 (18:09 -0700)]
Merge pull request #96 from mstap/master

add collectd systemd service file

12 years agodescribe collectd.service in contrib/README
Michael Stapelberg [Fri, 29 Jun 2012 23:23:55 +0000 (01:23 +0200)]
describe collectd.service in contrib/README

12 years agoAdd collectd systemd unit file
Michael Stapelberg [Fri, 29 Jun 2012 16:45:49 +0000 (18:45 +0200)]
Add collectd systemd unit file

12 years agoFix for config file parsing ("memcachec plugin: Option `Server' not allowed here.")
Pascal Hofmann [Thu, 14 Jun 2012 19:54:47 +0000 (21:54 +0200)]
Fix for config file parsing ("memcachec plugin: Option `Server' not allowed here.")

12 years agoFix out-of-bound index in rrdtool.c
Will Hawkins [Fri, 22 Jun 2012 18:45:45 +0000 (14:45 -0400)]
Fix out-of-bound index in rrdtool.c

Fix a reference to argv[1] that is (always?)
outside the bounds of the argv array. It happens
during a log statement that seems to want
to actually refer to the rrd filename.

12 years agooracle plugin: Add database name and query name (if applicable) to error messages.
Florian Forster [Tue, 19 Jun 2012 11:14:32 +0000 (13:14 +0200)]
oracle plugin: Add database name and query name (if applicable) to error messages.

12 years agooracle plugin: Report the "connect id" when OCILogon() fails.
Florian Forster [Mon, 18 Jun 2012 08:49:38 +0000 (10:49 +0200)]
oracle plugin: Report the "connect id" when OCILogon() fails.

12 years agocollection3: Use {instance} in Df's grpah title.
Florian Forster [Sun, 17 Jun 2012 18:46:43 +0000 (20:46 +0200)]
collection3: Use {instance} in Df's grpah title.

{type_instance} didn't work when used with other plugins than "df", e.g.
the example configuration of the Oracle plugin uses this.

12 years agooracle plugin: Replace the o_config_set_string() function.
Florian Forster [Thu, 14 Jun 2012 12:48:15 +0000 (14:48 +0200)]
oracle plugin: Replace the o_config_set_string() function.

12 years agooracle plugin: Implement the "Host" option.
Florian Forster [Thu, 14 Jun 2012 12:46:03 +0000 (14:46 +0200)]
oracle plugin: Implement the "Host" option.

12 years agosrc/utils_dns.c: Remove duplicate line.
Florian Forster [Fri, 1 Jun 2012 05:45:30 +0000 (07:45 +0200)]
src/utils_dns.c: Remove duplicate line.

12 years agosrc/utils_dns.c: Rename the "s_addr" and "d_addr" variables.
Florian Forster [Thu, 31 May 2012 13:09:43 +0000 (15:09 +0200)]
src/utils_dns.c: Rename the "s_addr" and "d_addr" variables.

On Solaris, there is a macro called "s_addr" resulting in syntax errors
when this is used as a variable name. The variables have been renamed to
circumvent this problem. Thanks to Maciej Bliziński for reporting this
problem and helping to debug it!