Florian Forster [Tue, 2 Sep 2008 09:36:35 +0000 (11:36 +0200)]
Merge branch 'master' into ff/rrdd
Conflicts:
src/rrd_lastupdate.c
src/rrd_update.c
oetiker [Sun, 31 Aug 2008 23:42:02 +0000 (23:42 +0000)]
now the results actually look as they did with the old code only things are FASTER
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1476
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 31 Aug 2008 22:53:49 +0000 (22:53 +0000)]
Improve performance by keeping multiple pango font descriptions. For the first invocation we are about 20% times as fast
for the second one about 4-5 times faster ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1475
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 31 Aug 2008 10:55:24 +0000 (10:55 +0000)]
trying to improve the pango performance I added facilities to cache layout,context and more in between invocations of
the text function, unfortunately it does not seem to help all that much.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1474
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 31 Aug 2008 10:52:49 +0000 (10:52 +0000)]
use the standart info free function
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1473
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 28 Aug 2008 05:49:02 +0000 (05:49 +0000)]
fix handling of error conditions in rrd_tool.c ... errno is not for detection, only for information AFTER detection.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1471
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 28 Aug 2008 04:13:39 +0000 (04:13 +0000)]
free the linebuffer if you don't return it!
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1470
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 22:06:43 +0000 (22:06 +0000)]
some more leak plugging
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1469
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 21:48:50 +0000 (21:48 +0000)]
drop the dummy surface prior to creating the real one
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1468
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 21:46:01 +0000 (21:46 +0000)]
added some freeing for error conditions
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1467
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 21:25:43 +0000 (21:25 +0000)]
fixed indentation ... gnu indent results are not realy beautifl. I might switch to uncrustify.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1466
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 21:25:04 +0000 (21:25 +0000)]
Many rrd_create memory leaks patched ... based on valgrind analysis by Sven Engelhardt. Thanks!
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1465
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 21:18:46 +0000 (21:18 +0000)]
fix indentation
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1464
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 27 Aug 2008 06:52:33 +0000 (06:52 +0000)]
added sparc-sun-solaris2.8 to list of broken isfinite implementations
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1463
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 22 Aug 2008 22:04:37 +0000 (22:04 +0000)]
it is rb_rrd_infocall not rrd_infocall ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1462
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sat, 16 Aug 2008 07:13:01 +0000 (07:13 +0000)]
When in lazy mode, and the graph does not get regenerated, then there are no
results from PRINT either. Fix for #163.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1461
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sat, 16 Aug 2008 07:11:46 +0000 (07:11 +0000)]
documentation updates
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1460
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 12 Aug 2008 06:48:37 +0000 (06:48 +0000)]
make sure imageinfo only reports the filename and not the whole path. This is a regression from 1.2.x where this was implemented properly.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1459
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 4 Aug 2008 20:35:45 +0000 (20:35 +0000)]
The attached patch converts the given string to UTF-8 using glib's
g_locale_to_utf8() function. This function expects the string to be
encoded as specified by the locale settings, so this will fail if e.g.
you're using some script which is encoded in some way incompatible to
the locale settings. In this case, the patch falls back to use the
original string as provided by the user as there is no way to tell how
to interpret that string. So, in this case, you will still get the old
behavior (that pango warning and messed up strings in the graph).
However, imho this is perfectly fine since it should be up to the user
to take care of a sane environment. -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1457
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 29 Jul 2008 14:42:08 +0000 (14:42 +0000)]
newer perlapi docu suggests to use SV * instead of void for managed returns
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1456
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 29 Jul 2008 05:08:46 +0000 (05:08 +0000)]
fixed some c++ style lines -- David Masterson
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1455
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 28 Jul 2008 07:23:15 +0000 (07:23 +0000)]
spelling fix
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1454
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 23 Jul 2008 15:03:43 +0000 (15:03 +0000)]
forward ported patch for rra cur_row randomization in rrd_restore from 1.2.28 to 1.3.1
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1453
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 23 Jul 2008 13:02:26 +0000 (13:02 +0000)]
prepare for the release of rrdtool-1.3.1
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1447
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 23 Jul 2008 12:45:52 +0000 (12:45 +0000)]
added support for restoring rrdtool 1.0.x files ... removed support for old HW patched rrd format created by an early patched version of 1.0.x
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1446
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 22 Jul 2008 15:15:44 +0000 (15:15 +0000)]
Fix for #167 - rrdcreate is arguably missing a check for 'step>=1' for RRAs with AVERAGE as a CF. I ran into this when specifying 0.6 as a step value, assuming floats were also accepted. Patch attached here. -- Bogdan
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1445
a5681a0c-68f1-0310-ab6d-
d61299d08faa
Florian Forster [Fri, 4 Jul 2008 10:19:14 +0000 (12:19 +0200)]
src/rrd_daemon.c: Flush ALL values when/before shutting down.
Florian Forster [Tue, 15 Jul 2008 18:20:17 +0000 (20:20 +0200)]
rrdcached(1): Document which commands are aware of the daemon.
Florian Forster [Tue, 15 Jul 2008 18:11:57 +0000 (20:11 +0200)]
rrdtool(1): Add a pointer to the rrdcached(1) manpage.
Florian Forster [Tue, 15 Jul 2008 18:07:07 +0000 (20:07 +0200)]
rrdxport(1): Add `--daemon' to the synopsis.
Florian Forster [Tue, 15 Jul 2008 18:06:41 +0000 (20:06 +0200)]
rrdfetch(1): Add `--daemon' to the synopsis.
Florian Forster [Tue, 15 Jul 2008 18:06:13 +0000 (20:06 +0200)]
rrdlastupdate(1): Document the new `--daemon' option.
Florian Forster [Tue, 15 Jul 2008 18:05:49 +0000 (20:05 +0200)]
rrdlast(1): Document the new `--daemon' option.
Florian Forster [Tue, 15 Jul 2008 18:05:34 +0000 (20:05 +0200)]
rrdinfo(1): Document the new `--daemon' option.
Florian Forster [Tue, 15 Jul 2008 18:05:11 +0000 (20:05 +0200)]
rrddump(1): Document the new `--daemon' option.
Florian Forster [Tue, 15 Jul 2008 18:04:16 +0000 (20:04 +0200)]
rrdtool(1): Add a pointer to the rrdflush(1) manual page.
Florian Forster [Tue, 15 Jul 2008 18:02:43 +0000 (20:02 +0200)]
rrdflush(1): Added a manual page for the `flush' command.
Florian Forster [Tue, 15 Jul 2008 17:30:18 +0000 (19:30 +0200)]
src/rrd_{fetch,update}.c: Rename the variable `daemon' to `opt_daemon'.
This resolves a stupid warning GCC throws..
Florian Forster [Tue, 15 Jul 2008 17:28:28 +0000 (19:28 +0200)]
src/rrd_info.c: Implement the `--daemon' option for `rrdtool last'.
Florian Forster [Tue, 15 Jul 2008 17:20:42 +0000 (19:20 +0200)]
src/rrd_flush.c: Add the `flush' command to the `rrdtool' application.
Florian Forster [Sun, 13 Jul 2008 14:08:50 +0000 (16:08 +0200)]
src/rrd_dump.c: Rename the `rrdcached' variable to `opt_daemon'.
Florian Forster [Sun, 13 Jul 2008 14:08:21 +0000 (16:08 +0200)]
src/rrd_lastupdate.c: Implement the `--daemon' option for `rrdtool lastupdate'.
The new library function `rrd_lastupdate' takes the usual (argc, argv)
arguments. The `rrd_lastupdate_r' function has been changed to receive
a file name directly instead of using only argv[1].
Florian Forster [Sun, 13 Jul 2008 14:03:10 +0000 (16:03 +0200)]
src/rrd_last.c: Implement the `--daemon' option for `rrdtool last'.
Florian Forster [Sun, 13 Jul 2008 12:49:58 +0000 (14:49 +0200)]
src/rrd_dump.c: Implement the `--daemon' option for `rrdtool dump'.
Florian Forster [Sun, 13 Jul 2008 12:34:33 +0000 (14:34 +0200)]
src/rrd_daemon.c: Stat files before creating a tree-node for them.
This way `rrdtool update' does complain about nonexistent files.
Florian Forster [Thu, 3 Jul 2008 21:23:05 +0000 (23:23 +0200)]
src/rrd_daemon.c: Only increate number of updates and datasets if no failure.
Florian Forster [Thu, 3 Jul 2008 20:50:21 +0000 (22:50 +0200)]
src/librrd.sym: Export the `rrdc_{connect,disconnect,update,flush} symbols.
Florian Forster [Thu, 3 Jul 2008 20:49:51 +0000 (22:49 +0200)]
src/rrd_daemon.c: Create listen threads in the detached state.
Florian Forster [Thu, 3 Jul 2008 15:50:53 +0000 (17:50 +0200)]
src/rrd_daemon.c: Remove remaining debug messages.
Florian Forster [Thu, 3 Jul 2008 15:47:25 +0000 (17:47 +0200)]
src/rrd_update.c: Set `rc' correctly when succeeding.
Florian Forster [Thu, 3 Jul 2008 15:47:03 +0000 (17:47 +0200)]
src/rrd_daemon.c: Instann the SIGTERM handler correctly.
Florian Forster [Thu, 3 Jul 2008 15:16:37 +0000 (17:16 +0200)]
rrdcached(1): Some typo and minor formulation fixes.
Florian Forster [Thu, 3 Jul 2008 15:14:04 +0000 (17:14 +0200)]
rrdcached(1): Documented the protocol used by the daemon.
Some statistic values have been renamed. This has been changed in
src/rrd_daemon.c, too.
Florian Forster [Thu, 3 Jul 2008 12:32:12 +0000 (14:32 +0200)]
src/rrd_daemon.c: Don't close the socket if UPDATE fails.
Florian Forster [Thu, 3 Jul 2008 09:39:13 +0000 (11:39 +0200)]
src/rrd_daemon.c: Use `sread' and `swrite' instead of read(2) and write(2).
The ``secure'' sread assures that the received string ends with a newline,
strips it off the buffer and assures that the returned buffer is null
terminated. swrite returns success only if all bytes could be written.
Florian Forster [Thu, 3 Jul 2008 09:17:59 +0000 (11:17 +0200)]
src/rrd_client.c: Close the socket if writing to it fails.
Florian Forster [Thu, 3 Jul 2008 09:09:53 +0000 (11:09 +0200)]
src/rrd_daemon.c: Implemented the `HELP' command.
Florian Forster [Thu, 3 Jul 2008 08:48:17 +0000 (10:48 +0200)]
src/rrd_daemon.c: Tell the connected party about invalid commands.
Florian Forster [Thu, 3 Jul 2008 08:42:45 +0000 (10:42 +0200)]
src/rrd_daemon.c: Catch invalid uses of `flush'.
And don't run into an assertion in that case.
Florian Forster [Thu, 3 Jul 2008 08:30:33 +0000 (10:30 +0200)]
src/rrd_daemon.c: Impemented the `stats' command.
It currently returns five statistics:
- Number of nodes and depth of the tree.
- Number of nodes in the update queue.
- Total number of updates and values written to disk since startup.
Florian Forster [Thu, 3 Jul 2008 08:08:33 +0000 (10:08 +0200)]
src/rrd_daemon.c: Count some statistics.
Florian Forster [Wed, 2 Jul 2008 21:13:12 +0000 (23:13 +0200)]
src/rrd_xport.c: Allow the short option `-d', too.
Florian Forster [Wed, 2 Jul 2008 21:07:37 +0000 (23:07 +0200)]
rrdcached(1): Removed the note stating that tree nodes are never removed.
Florian Forster [Wed, 2 Jul 2008 21:04:54 +0000 (23:04 +0200)]
src/rrd_daemon.c: Implemented removal of unused tree nodes.
Florian Forster [Wed, 2 Jul 2008 20:20:13 +0000 (22:20 +0200)]
src/rrd_daemon.c: Don't return TRUE in `tree_callback_flush'.
Returning TRUE will stop the traversal, so return FALSE instead.
Florian Forster [Wed, 2 Jul 2008 19:52:52 +0000 (21:52 +0200)]
rrdxport(1): Document the new `--daemon' option.
Florian Forster [Wed, 2 Jul 2008 13:55:25 +0000 (15:55 +0200)]
src/rrd_xport.c: Implement the `--daemon' option for `rrdtool xport'.
Florian Forster [Wed, 2 Jul 2008 13:54:52 +0000 (15:54 +0200)]
src/rrd_fetch.c: Revert `rrd_fetch_r' to the original version again.
Florian Forster [Tue, 1 Jul 2008 14:30:18 +0000 (16:30 +0200)]
Build system: Install `rrd_client.h' during `make install'.
Florian Forster [Tue, 1 Jul 2008 10:01:46 +0000 (12:01 +0200)]
Merge branch 'master' into ff/rrdd
Florian Forster [Tue, 1 Jul 2008 08:02:42 +0000 (10:02 +0200)]
rrdcached(1): Added the `SECURITY CONSIDERATIONS' and `HOW IT WORKS' sections.
oetiker [Tue, 1 Jul 2008 06:35:54 +0000 (06:35 +0000)]
header-fix
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1444
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 1 Jul 2008 06:34:24 +0000 (06:34 +0000)]
improve layout
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1443
a5681a0c-68f1-0310-ab6d-
d61299d08faa
Florian Forster [Tue, 1 Jul 2008 05:52:18 +0000 (07:52 +0200)]
rrdcached(1): Documented the `-p' and `-b' options.
Florian Forster [Sun, 29 Jun 2008 21:38:36 +0000 (23:38 +0200)]
Merge branch 'master' into ff/rrdd
oetiker [Sun, 29 Jun 2008 16:23:50 +0000 (16:23 +0000)]
added rrd filename to illegal update message -- he at uninett.no
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1441
a5681a0c-68f1-0310-ab6d-
d61299d08faa
Florian Forster [Sun, 29 Jun 2008 14:16:50 +0000 (16:16 +0200)]
src/rrd_daemon.c: Use static structs for the signal handler configuration.
Florian Forster [Sun, 29 Jun 2008 14:16:22 +0000 (16:16 +0200)]
src/rrd_daemon.c: Implement PID-file and basedir options.
oetiker [Sun, 29 Jun 2008 14:08:51 +0000 (14:08 +0000)]
rrdtool.spec fix by Anton Blanchard to build without php patch
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1440
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 29 Jun 2008 13:57:00 +0000 (13:57 +0000)]
make sure image-with and image-height get returned even when rrdtool is called with --lazy as reported in bug #163
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1439
a5681a0c-68f1-0310-ab6d-
d61299d08faa
Florian Forster [Sun, 29 Jun 2008 12:32:22 +0000 (14:32 +0200)]
rrdgraph(1): Document the RRDCACHED_ADDRESS environment variable.
Florian Forster [Sun, 29 Jun 2008 12:32:09 +0000 (14:32 +0200)]
rrdfetch(1): Document the RRDCACHED_ADDRESS environment variable.
Florian Forster [Sun, 29 Jun 2008 12:26:23 +0000 (14:26 +0200)]
src/rrd_client.h: Make it possible to set a custom RRDCACHED_DEFAULT_ADDRESS.
Florian Forster [Sun, 29 Jun 2008 12:25:42 +0000 (14:25 +0200)]
rrdcached(1): Documented default settings.
Florian Forster [Sun, 29 Jun 2008 12:25:21 +0000 (14:25 +0200)]
rrdupdate(1): Document the RRDCACHED_ADDRESS environment variable.
Florian Forster [Wed, 25 Jun 2008 12:00:44 +0000 (14:00 +0200)]
src/rrd_{fetch,graph,update}.c: Use the `RRDCACHED_ADDRESS' environment variable..
..as default daemon address.
Florian Forster [Wed, 25 Jun 2008 11:59:28 +0000 (13:59 +0200)]
src/rrd_client.h: Renamed the defines to be more consistent with other names.
Florian Forster [Wed, 25 Jun 2008 11:58:13 +0000 (13:58 +0200)]
rrdgraph(1): Removed a legacy `=back'.
Florian Forster [Tue, 24 Jun 2008 19:17:49 +0000 (21:17 +0200)]
rrdupdate(1): Updated the manpage to reflect the current option handling.
I. e. the section about `--[no]cache' has been removed and the section
about `--daemon' has been updated.
Florian Forster [Tue, 24 Jun 2008 19:12:27 +0000 (21:12 +0200)]
rrdgraph(1): Corrected the example included with `--daemon'.
Florian Forster [Tue, 24 Jun 2008 19:08:26 +0000 (21:08 +0200)]
src/rrd_update.c: Now remove the short options `-c' and `-n', too.
Am I really that stupid? *argh*
Florian Forster [Tue, 24 Jun 2008 19:07:28 +0000 (21:07 +0200)]
src/rrd_tool.c: Add `--daemon' to `rrdtool update's help.
Florian Forster [Tue, 24 Jun 2008 19:06:55 +0000 (21:06 +0200)]
src/rrd_update.c: Remove the long options `--[no]cache'.
Florian Forster [Tue, 24 Jun 2008 19:04:01 +0000 (21:04 +0200)]
src/rrd_client.c: Remove useless `FILE *sh;'.
Florian Forster [Tue, 24 Jun 2008 19:00:33 +0000 (21:00 +0200)]
src/rrd_daemon.c: Removed semi-automatic usage of the daemon.
With remote servers and relative paths failing silently is just too
dangerous. We shouldn't allow the user to shoot herself in the foot.
Florian Forster [Tue, 24 Jun 2008 18:51:45 +0000 (20:51 +0200)]
src/rrd_update.c: Use `-d' rather than `-s' as short option for `--daemon'.
Florian Forster [Tue, 24 Jun 2008 18:50:51 +0000 (20:50 +0200)]
src/rrd_{fetch,graph}.c: Implement `--daemon'.
Both commands not accept the `--daemon' option. When specified, a `flush'
command is send to the daemon just before reading the RRD file, so that
the output will contain the newest data available - even with (very) long
cache timeouts.
Florian Forster [Tue, 24 Jun 2008 12:48:23 +0000 (14:48 +0200)]
src/rrd_client.[ch]: Impelemt `rrdc_flush'.
Florian Forster [Tue, 24 Jun 2008 12:43:15 +0000 (14:43 +0200)]
src/rrd_daemon.c: Accept \r\n style line endings, too.
Florian Forster [Tue, 24 Jun 2008 12:42:47 +0000 (14:42 +0200)]
src/rrd_daemon.c: Don't report end-of-file as an error.