Pavel Rochnyack [Wed, 4 Jul 2018 07:47:18 +0000 (14:47 +0700)]
curl plugin: Added 'Interval' option
Pavel Rochnyack [Wed, 4 Jul 2018 07:20:54 +0000 (14:20 +0700)]
curl_xml plugin: Added 'Interval' option
Pavel Rochnyack [Wed, 4 Jul 2018 07:13:36 +0000 (14:13 +0700)]
core: Added plugin name to (some) error reporting
Pavel Rochnyack [Wed, 4 Jul 2018 06:17:21 +0000 (13:17 +0700)]
tree-wide: Use interval value from plugin context
Pavel Rochnyack [Wed, 4 Jul 2018 06:15:48 +0000 (13:15 +0700)]
core: Cleanup in vl->interval assignment
Pavel Rochnyack [Wed, 4 Jul 2018 05:43:10 +0000 (12:43 +0700)]
core: Set plugin name in context when plugin is autoloaded
Pavel Rochnyack [Wed, 4 Jul 2018 05:00:02 +0000 (12:00 +0700)]
core: Set 'interval' value in plugin context to match read callback interval
Pavel Rochnyack [Wed, 4 Jul 2018 04:33:04 +0000 (11:33 +0700)]
postgresql: Set correct value to 'interval' query parameter (bugfix)
Pavel Rochnyack [Wed, 4 Jul 2018 03:46:09 +0000 (10:46 +0700)]
utils_tail_match: Updated formatting
Pavel Rochnyack [Wed, 4 Jul 2018 03:43:17 +0000 (10:43 +0700)]
utils_tail_match: Removed unused variables
Pavel Rochnyack [Tue, 3 Jul 2018 11:48:02 +0000 (18:48 +0700)]
utils_tail_match: Fix formatting
Pavel Rochnyack [Mon, 2 Jul 2018 06:59:53 +0000 (13:59 +0700)]
statsd: Improve error reporting
Pavel Rochnyak [Fri, 29 Jun 2018 12:56:59 +0000 (19:56 +0700)]
Merge pull request #2844 from elfiesmelfie/fix_snmp_agent
SNMP Agent plugin: Fix coverity scan issues #2814
Pavel Rochnyack [Wed, 27 Jun 2018 11:55:47 +0000 (18:55 +0700)]
cleanup: Remove excessive error reporting
These messages already reported in parse_value()
collectd bot [Wed, 27 Jun 2018 05:54:35 +0000 (07:54 +0200)]
Auto-Merge pull request #2838 from rpv-tomsk/collectd-master
Automatically merged due to "Automerge" label
Pavel Rochnyak [Wed, 27 Jun 2018 05:16:49 +0000 (12:16 +0700)]
Merge pull request #2831 from elieyal/patch-3
network plugin: Add BindAddress option
Pavel Rochnyak [Wed, 27 Jun 2018 04:50:04 +0000 (11:50 +0700)]
Merge pull request #2834 from rpv-tomsk/plugin-context-master-2
notify_email: Include all notification parameters into email
Pavel Rochnyack [Wed, 27 Jun 2018 04:43:52 +0000 (11:43 +0700)]
redis plugin: Report keyspace hitratio
Ruben Kerkhof [Tue, 26 Jun 2018 14:08:22 +0000 (16:08 +0200)]
Merge pull request #2837 from abays/fix-collectd-tg-dtime
Use CLOCK_REALTIME for collectd-tg times (fixes issue 2219)
elieyal [Tue, 26 Jun 2018 10:01:04 +0000 (13:01 +0300)]
Updated change from debug to error
As suggest by @rpv-tomsk
Andrew Bays [Mon, 25 Jun 2018 14:12:07 +0000 (10:12 -0400)]
Use CLOCK_REALTIME for collectd-tg times (fixes issue 2219)
elieyal [Fri, 22 Jun 2018 12:05:59 +0000 (15:05 +0300)]
revert back to DEBUG
will change this later, it's not as simple as it looks.
elieyal [Fri, 22 Jun 2018 09:18:29 +0000 (12:18 +0300)]
chenged debug to error message
Pavel Rochnyack [Fri, 22 Jun 2018 08:07:37 +0000 (15:07 +0700)]
notify_email: Include all notification parameters into email
collectd bot [Fri, 22 Jun 2018 06:34:01 +0000 (08:34 +0200)]
Auto-Merge pull request #2833 from rpv-tomsk/plugin-context-master-2
Automatically merged due to "Automerge" label
Pavel Rochnyack [Fri, 22 Jun 2018 05:01:31 +0000 (12:01 +0700)]
cleanup: cf_util_get* instead of local copy in plugins, prefixed error reporting
Closes: #2011 (superseedes)
Issue: #1949
Issue: #2799
Issue: #2821
elieyal [Thu, 21 Jun 2018 16:19:18 +0000 (19:19 +0300)]
removed some detaild in the BindAddress documentation
Removed some details.
Pavel Rochnyack [Thu, 21 Jun 2018 13:51:58 +0000 (20:51 +0700)]
snmp_agent: Try to fix tests
This adressed to fix Solaris 10 builds.
Issue: #2814
elieyal [Thu, 21 Jun 2018 09:29:19 +0000 (12:29 +0300)]
network plugin: Added documentation to BindAddress option
Added the BindAddress explanation in the network plugin section on how to use the BindAddress.
elieyal [Thu, 21 Jun 2018 08:49:04 +0000 (11:49 +0300)]
Fixed all comments by @rubenk
elieyal [Wed, 20 Jun 2018 14:32:40 +0000 (17:32 +0300)]
Fixed leak and hint
Added suggested fixes
Mozejko, MarcinX [Wed, 13 Jun 2018 06:54:49 +0000 (07:54 +0100)]
SNMP Agent plugin: Fix coverity issues
Change-Id: Icb74f9978833191a390c952a09695ccb60ff8452
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Pavel Rochnyak [Wed, 20 Jun 2018 10:55:56 +0000 (17:55 +0700)]
Merge pull request #2821 from rpv-tomsk/plugin-context-master-2
RFE: Add plugin name field into plugin context use it to improve error reporting
Pavel Rochnyack [Wed, 20 Jun 2018 08:12:37 +0000 (15:12 +0700)]
plugin_mmock.c: Added daemon_log()
Pavel Rochnyack [Wed, 20 Jun 2018 04:11:08 +0000 (11:11 +0700)]
common.c: Use plugin-name prefixed error reporting
elieyal [Wed, 20 Jun 2018 06:24:15 +0000 (09:24 +0300)]
upddated correct file
Sorry,
committed the patch by mistake. now fixed.
elieyal [Wed, 20 Jun 2018 06:21:34 +0000 (09:21 +0300)]
Fixed additional comments
Added "network plugin" prefix to Errors
return -1; added to sfree
Pavel Rochnyack [Wed, 20 Jun 2018 03:49:46 +0000 (10:49 +0700)]
core: Introduced daemon_log() for messages prefixed with plugin name
Pavel Rochnyack [Sat, 16 Jun 2018 05:10:11 +0000 (12:10 +0700)]
bind plugin: Switched to use of cf_util_get_boolean() and cf_util_get_string()
Pavel Rochnyack [Sat, 16 Jun 2018 05:01:50 +0000 (12:01 +0700)]
configfile.c: Use plugin name from plugin context in error reporting
This commit also removes 'plugin: ' prefix from `plugin_log()`.
Pavel Rochnyack [Sat, 16 Jun 2018 04:07:22 +0000 (11:07 +0700)]
Updated codestyle
Florian Forster [Tue, 4 Oct 2016 18:48:17 +0000 (20:48 +0200)]
src/daemon/plugin.[ch]: Add the plugin name to the context.
Issue: #1949
Pavel Rochnyack [Tue, 19 Jun 2018 16:19:34 +0000 (23:19 +0700)]
redis plugin: Fix memleak
Ruben Kerkhof [Tue, 19 Jun 2018 15:15:19 +0000 (17:15 +0200)]
Reset LDFLAGS before testing for strtok_r
They may contain all kinds of things that make the test fail.
See #2823 for details
collectd bot [Tue, 19 Jun 2018 11:57:21 +0000 (13:57 +0200)]
Auto-Merge pull request #2826 from rpv-tomsk/collectd-master
Automatically merged due to "Automerge" label
elieyal [Tue, 19 Jun 2018 11:35:51 +0000 (14:35 +0300)]
Fixed all comments
Pavel Rochnyak [Tue, 19 Jun 2018 10:52:48 +0000 (17:52 +0700)]
Merge pull request #2819 from rpv-tomsk/snmp-fix-2291-1
snmp plugin: HostOID, FilterOID and other options added
Pavel Rochnyack [Tue, 19 Jun 2018 08:43:05 +0000 (15:43 +0700)]
snmp_agent: Try to fix tests
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Tue, 19 Jun 2018 08:25:06 +0000 (15:25 +0700)]
snmp_agent: Try to fix tests
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Tue, 19 Jun 2018 08:08:54 +0000 (15:08 +0700)]
snmp_agent: Remove structure initialization
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Tue, 19 Jun 2018 04:41:42 +0000 (11:41 +0700)]
redis plugin: Added option ReportCpuUsage for reported CPU consumption
Pavel Rochnyack [Tue, 19 Jun 2018 04:11:09 +0000 (11:11 +0700)]
snmp_agent: Replace strndup() with internal implementation
This adressed to fix Solaris 10 builds.
Closes: #2814
Pavel Rochnyack [Mon, 18 Jun 2018 14:34:41 +0000 (21:34 +0700)]
redis plugin: Simplified commands statistics parser
Pavel Rochnyack [Mon, 18 Jun 2018 13:49:29 +0000 (20:49 +0700)]
redis plugin: Added commands statistics reporting
Pavel Rochnyack [Mon, 18 Jun 2018 11:03:51 +0000 (18:03 +0700)]
redis plugin: report CPU usage
elieyal [Mon, 18 Jun 2018 07:59:59 +0000 (10:59 +0300)]
Add Bind Address option
This change allows to Bind Address to an IP address instead of the binding to the Interface Name in the server section.
Example:
<Server "239.192.74.66" "25826">
SecurityLevel Encrypt
Username "user"
Password "secret"
BindAddress "10.9.25.59"
ResolveInterval 14400
</Server>
Credit to: Ofir Hermesh
Pavel Rochnyack [Sun, 17 Jun 2018 13:49:35 +0000 (20:49 +0700)]
redis plugin: Reworked to use plugin_register_complex_read()
Pavel Rochnyack [Sun, 17 Jun 2018 12:37:48 +0000 (19:37 +0700)]
redis plugin: Implemented persistent connections
Pavel Rochnyack [Sun, 17 Jun 2018 12:09:21 +0000 (19:09 +0700)]
write_redis plugin: Fixed bug of Timeout option
Documentation states what Timeout is set in milliseconds.
Code was fixed to match documentation.
Pavel Rochnyack [Sun, 17 Jun 2018 10:22:10 +0000 (17:22 +0700)]
redis plugin: Report query errors
Pavel Rochnyack [Sun, 17 Jun 2018 10:09:11 +0000 (17:09 +0700)]
redis plugin: Update documentation
Pavel Rochnyack [Sun, 17 Jun 2018 10:08:49 +0000 (17:08 +0700)]
redis plugin: Change text of some error messages
Pavel Rochnyack [Sun, 17 Jun 2018 09:10:54 +0000 (16:10 +0700)]
redis plugin: Check for / report connection errors
Pavel Rochnyack [Sun, 17 Jun 2018 08:51:33 +0000 (15:51 +0700)]
redis plugin: Fixed bug of Timeout option
Documentation states what Timeout is set in milliseconds.
Code was fixed to match documentation.
collectd bot [Sun, 17 Jun 2018 07:34:05 +0000 (09:34 +0200)]
Auto-Merge pull request #2825 from rpv-tomsk/collectd-master
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sun, 17 Jun 2018 06:30:24 +0000 (13:30 +0700)]
rrdtool plugin: Added more error reporting
Issue: #2823
collectd bot [Sat, 16 Jun 2018 08:37:32 +0000 (10:37 +0200)]
Auto-Merge pull request #2822 from rpv-tomsk/issue-976
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sat, 16 Jun 2018 07:41:46 +0000 (14:41 +0700)]
ntpd plugin: Added new refclock_names
Pavel Rochnyack [Sat, 16 Jun 2018 07:35:18 +0000 (14:35 +0700)]
ntpd plugin: Don't treat normal peers as refclocks.
Don't try to interpret the srcadr field as a refclock
identifier unless it actually is a refclock identifier.
Now Collectd logs all stats for peers rather than skipping
delay for most of them and offset for a few.
Closes: #976
Pavel Rochnyack [Fri, 15 Jun 2018 11:46:55 +0000 (18:46 +0700)]
snmp plugin: Updated documentation for 'Ignore' option
Pavel Rochnyack [Fri, 15 Jun 2018 11:38:33 +0000 (18:38 +0700)]
snmp plugin: polished a code
Pavel Rochnyack [Fri, 15 Jun 2018 11:11:17 +0000 (18:11 +0700)]
snmp plugin: Removed newly-added 'suffix skipped' notice
Pavel Rochnyack [Fri, 15 Jun 2018 10:31:07 +0000 (17:31 +0700)]
snmp plugin: FilterOID option implementation
Added new options `FilterOID`, `FilterValues` and `FilterIgnoreSelected`.
These allows to ignore parts of the MIB by its values.
Closes: #2637
Pavel Rochnyack [Fri, 15 Jun 2018 09:35:09 +0000 (16:35 +0700)]
snmp plugin: HostOID option implementation
+ Allow to use `TypeInstanceOID` and `PluginInstanceOID` together.
+ Added `TypeInstancePrefix`, `PluginInstancePrefix` and `HostPrefix` options.
* Option `InstancePrefix` marked as deprecated.
+ Added documentation for new feature.
Closes: #174
Pavel Rochnyack [Fri, 15 Jun 2018 05:05:58 +0000 (12:05 +0700)]
snmp plugin: Replace reserved chars in hostname value
Pavel Rochnyack [Thu, 14 Jun 2018 15:57:14 +0000 (22:57 +0700)]
snmp plugin: added NOTICE when suffix (row of values) is skipped
Pavel Rochnyack [Thu, 14 Jun 2018 15:25:10 +0000 (22:25 +0700)]
snmp plugin: Implemented HostnameOID option
Pavel Rochnyack [Thu, 14 Jun 2018 14:46:01 +0000 (21:46 +0700)]
snmp plugin: Refactored filling cells of table
This also fixes a bug when `Ignore` option was ignored for numeric Instance OIDS.
Pavel Rochnyack [Thu, 14 Jun 2018 14:11:01 +0000 (21:11 +0700)]
snmp plugin: Rename types and fields to more common names
Pavel Rochnyack [Thu, 14 Jun 2018 13:56:34 +0000 (20:56 +0700)]
snmp plugin: codestyle
Pavel Rochnyack [Thu, 14 Jun 2018 13:31:08 +0000 (20:31 +0700)]
snmp plugin: Pass variable to csnmp_instance_list_add()
Instead of scanning `res->variables` use directly-passed variable.
Pavel Rochnyack [Thu, 14 Jun 2018 13:14:56 +0000 (20:14 +0700)]
snmp plugin: Added types into list of requested snmp OIDS
Issue: #174
Pavel Rochnyak [Thu, 14 Jun 2018 03:29:51 +0000 (10:29 +0700)]
Merge pull request #2817 from rpv-tomsk/snmp-fix-2291-1
snmp plugin: Implemented new configuration options
Pavel Rochnyack [Wed, 13 Jun 2018 11:12:05 +0000 (18:12 +0700)]
snmp plugin: Implemented new configuration options
Added new options `PluginInstance`, `TypeInstance`, `TypeInstanceOID` and `PluginInstanceOID`.
These allows flexible configuration of reported metrics.
Existing `Instance` option marked as deprecated.
Closes: #2636
Pavel Rochnyack [Wed, 13 Jun 2018 03:38:23 +0000 (10:38 +0700)]
docs: Fix typo
Pavel Rochnyack [Tue, 12 Jun 2018 16:07:45 +0000 (23:07 +0700)]
snmp plugin: Allow to set plugin value in reported metrics
collectd bot [Sat, 9 Jun 2018 16:20:41 +0000 (18:20 +0200)]
Auto-Merge pull request #2813 from rpv-tomsk/master
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sat, 9 Jun 2018 15:18:11 +0000 (22:18 +0700)]
config parser: Improved error reporting on global options
Some functions could return error code without any messages.
Pavel Rochnyack [Sat, 9 Jun 2018 11:30:29 +0000 (18:30 +0700)]
perl plugin: Restore missing include of "collectd.h"
Restore include which was removed in
fa36b45bfafec663e49639d40f4671e018e7ee10 (#2769).
This adressed to solve compilation issue on Solaris platform.
Ruben Kerkhof [Fri, 8 Jun 2018 16:24:19 +0000 (18:24 +0200)]
Merge pull request #2702 from elfiesmelfie/feat_snmp_agent
snmp_agent: new features
Mozejko, MarcinX [Thu, 7 Jun 2018 12:51:52 +0000 (13:51 +0100)]
SNMP Agent plugin: Fix minor issues
Change-Id: I5437f7d7d9abbbb0b466ed836475b35bba42fadb
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Ruben Kerkhof [Thu, 7 Jun 2018 10:13:08 +0000 (12:13 +0200)]
Merge pull request #2804 from rubenk/remove-poison
Stop poisoning function in debug mode
Ruben Kerkhof [Thu, 7 Jun 2018 08:22:24 +0000 (10:22 +0200)]
Merge pull request #2808 from elfiesmelfie/fix_virt_shadow_warning
src/virt.c: Fix one 'shadow type' warning
Mozejko, MarcinX [Mon, 4 Jun 2018 14:13:35 +0000 (15:13 +0100)]
SNMP Agent plugin: Fix compability with netsnmp library version < 5.4.5
Fix valgrind issues in snmp_agent_test.c.
Remove unused variable from snmp_agent.c.
Change-Id: I201a39743af3b59827acada9b24a15672d97436a
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Sean Campbell [Wed, 6 Jun 2018 14:04:53 +0000 (10:04 -0400)]
Refactor collectd binary to separate Unix-specific code.
Move OS-specific code from collectd.c into cmd.c.
This makes it easier to use the non-Linux-specific code when we port to Windows.
Antoine Naud [Fri, 25 May 2018 14:42:51 +0000 (15:42 +0100)]
src/virt.c: Fix one -Wshadow type warning
This commit fixes:
src/virt.c:1827:76: warning: declaration shadows a variable in the global scope
[-Wshadow]
static int domain_lifecycle_event_cb(__attribute__((unused)) virConnectPtr conn,
^
src/virt.c:471:22: note: previous declaration is here
static virConnectPtr conn;
Change-Id: I5303f834c5f13802909f8bd03afba0f4a23934d4
Signed-off-by: Antoine Naud <antoinex.naud@intel.com>
Mozejko, MarcinX [Tue, 27 Feb 2018 09:54:13 +0000 (09:54 +0000)]
SNMP Agent plugin: Fix - not every OID is unregistered from snmp table
Problem occures when a metric has more than one OID assigned. Then,
during the table unregistration, plugin thinks that there are some OIDs
left in the table and keeps index keys also registered. It's because
plugin registers all the OIDs for the particular metric, but unregisters only
the first one which is wrong.
Change-Id: I6daae1ceeebf30b98f22075940b29936ee3d110d
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Mozejko, MarcinX [Thu, 25 Jan 2018 10:26:31 +0000 (10:26 +0000)]
SNMP Agent plugin: Fix klockwork issues
Change-Id: I2a451f1cd0426dbdeec878d584bbb51dce00c10a
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Mozejko, MarcinX [Wed, 20 Dec 2017 13:28:48 +0000 (13:28 +0000)]
SNMP Agent plugin: Redesign way of registering OIDs
Now every metric is registered individually, so when any of them is removed
from collectd cache it is also unregistered from SNMP.
Change-Id: I3548bd9b7f9a5fb574bc34e300175e4cab63b0b4
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Mozejko, MarcinX [Wed, 20 Dec 2017 13:19:36 +0000 (13:19 +0000)]
SNMP Agent plugin:
Support for complicated data definitions
Add unit tests for functions:
snmp_agent_oid_to_string()
snmp_agent_prep_index_list()
snmp_agent_fill_index_list()
snmp_agent_config_index_key_source()
snmp_agent_config_index_key_regex()
snmp_agent_config_index_key()
snmp_agent_format_name()
snmp_agent_parse_index_key()
snmp_agent_create_token()
snmp_agent_delete_token()
snmp_agent_get_token()
snmp_agent_tokenize()
snmp_agent_build_name()
Change-Id: I31a8a5c771fa4c7d0122705fe79f021bc71c9904
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>