oetiker [Tue, 21 Dec 2010 16:06:32 +0000 (16:06 +0000)]
rrdcached: Fix permissions of the default socket.
If neither the "-l" nor the "-P" options have been given, a UNIX domain
socket at a default location is created. However, due to a missing
initialization in this case, the "permissions" field will be left at
zero (no command allowed).
This patch fixes this problem by allowing all commands on the default
socket if no "-P" option is given. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2152
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 20 Dec 2010 07:03:40 +0000 (07:03 +0000)]
add extra space to LDFLAGS when building ruby bindings ... otherwhise this will break if there is already content in LDFLAGS ... fix for #284 thanks dam at opencsw.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2151
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 17 Dec 2010 16:09:07 +0000 (16:09 +0000)]
the aix linker does not have -Wl flag
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2149
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 7 Dec 2010 17:58:56 +0000 (17:58 +0000)]
added not on using LINE AREA or PRINT
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2148
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 11 Nov 2010 16:12:17 +0000 (16:12 +0000)]
introduce "epoch" as a new base time reference, meaning timestamp 0.
This disambiguates between some "at-style" time specs:
11111111 yields an error message:
did you really mean month
1111111?
and
19711205 denotes Dec 12, 1971 and not the timestamp.
The patch allows to write:
epoch+11111111s or epoch+19711205s
-- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2147
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 11 Nov 2010 16:06:55 +0000 (16:06 +0000)]
Here is a patch that fixes a serious endless loop problem on 32 bit
architectures near the timestamp 2^31 (oh yes - y2k038 is showing its ugly
face) when using the graph command(s). Once the endtime of a graph is
above the mentioned timestamp, mktime always returns -1 (and correctly
so), causing some loops to loop forever. The patch fixes this, causing
some strange output, but there is no other sane way to handle this (expect
by switching to a 64 bit platform). -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2146
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 9 Nov 2010 16:37:18 +0000 (16:37 +0000)]
add hosts_access support to rrdcached -- Shaun Reitan mailinglists@unix-scripts.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2145
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 9 Nov 2010 16:15:06 +0000 (16:15 +0000)]
make sure we do not try to draw points all that far outside the drawing area
since some versions of cairo seem to go unstable when this happens. -- Peter Stamfest
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2142
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 2 Nov 2010 12:15:02 +0000 (12:15 +0000)]
rrdcached uses tcp and not udp thanks Shaun for finding this
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2141
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 25 Oct 2010 05:45:05 +0000 (05:45 +0000)]
follow the normal code path for exiting rrd_update if there is a problem with rrdc, plugging a memory leak on the way -- Christian Magnusson
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2139
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 25 Oct 2010 05:40:26 +0000 (05:40 +0000)]
free addrinfo list after use ... -- Christian Magnusson
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2138
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 22 Oct 2010 21:02:20 +0000 (21:02 +0000)]
fix for the memory leak in info fixes the memory leak in "INFO".
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2137
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 11 Oct 2010 07:48:45 +0000 (07:48 +0000)]
* introduce a new rrd_create_r2 call to fix the no-overwrite api mess
* various fixes to new rrd_cached comands as suggested by kevin
1. Remove opt_no_overwrite and the rrd_create_set_no_overwrite function as they are ugly. Make opt_no_overwrite a local var.
2. Add 'no_overwrite' param to the rrd_create_r and rename as rrd_create_r2, add rrd_create_r that calls rrd_create_r2 with a 0 for the no_overwrite function, preserving the API parameter format but allowing an extended arg list that can be used by rrd_create and rrd_handle_request_create
3. Add -O option to rrdcached command line to force no-overwrite on any creates
4. Add -O option on create via rrdcached to optionally add no-overwrite (cannot remove it is it was previously set at start)
5. Fix rrd_handle_request_last to check the queue instead of forcing a flush. Remove -no-flush option from LAST command since it is now no longer relevant as we're querying the cache chain
6. Fix ulong/unsigned long issue for compilation under windows
7. Change rrd_handle_request_create to only accept timestamp parameters, not at-syntax, in order to be threadsafe. This is no loss since the rrd_client already pre-parses any at-style syntax
8. Reinstate missing free() in rrd_info.c and rrd_last.c
-- steve shipway
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2136
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sat, 9 Oct 2010 09:50:44 +0000 (09:50 +0000)]
Ensure that response_read() always calls fflush() or fclose().
This fixes defect #278 (unknown commands from Solaris client). -- kevin brintnall
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2135
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 28 Sep 2010 15:44:19 +0000 (15:44 +0000)]
fix ruby bindings to be compatible with curent ruby implementations fix for #279
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2132
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 23 Sep 2010 06:08:09 +0000 (06:08 +0000)]
Summary of changes:
1. Add INFO <filename>, FIRST <filename> <index>, LAST <filename> and
CREATE <rrdfile> [-b start][-s step][-O] <DSdefs> <RRAdefs> to the rrdcached
functions.
2. Add rrd_create_set_no_overwrite as a function in rrd_create.c to allow
the overwrite flag to be set from rrd_daemon.c
3. Add rrdc_info, rrdc_first, rrdc_last, rrdc_create functions in
rrd_client.c
4. Add rrdcached support to rrd_info(), rrd_first(), rrd_last() and
rrd_create()
5. Add --noflush (-F) option to rrd_info(), rrd_last() to prevent cache
flushing before function call if required for efficiency
6. Add --daemon option to rrd_info(), rrd_first() for rrdcached support
7. Add buffer_add_ulong function to rrd_client.c (used by new rrdc_*
functions)
8. Add rrd_clear_error() call to rrd_create_r () to clean up bug if create
called more than once
9. Add -O option to rrdcached to force no-overwrite mode in CREATE function
10. All relevant documentation updated
-- Steve Shipway steve steveshipway.org
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2130
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 10 Sep 2010 09:16:49 +0000 (09:16 +0000)]
fix use of %s in strftime rrdgraph (G)PRINT commands ... bug (#277) found by Denis, fix by tobi
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2129
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 8 Sep 2010 16:41:23 +0000 (16:41 +0000)]
it seems that strcasecmp and strcasencmp have issues on windows replace
with stricmp and strnicmp -- jkane mail.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2128
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 8 Sep 2010 12:15:13 +0000 (12:15 +0000)]
fix use of setlocale all over the place ...
- old_locale = setlocale(LC_NUMERIC, "C");
+ old_locale = setlocale(LC_NUMERIC, NULL);
+ setlocale(LC_NUMERIC, "C");
the original version never restored the locale since it held a copy of the
new locale and not the old one despite the name. bug found by Pawe? 'Reef' Polewicz
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2127
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 31 Aug 2010 07:31:43 +0000 (07:31 +0000)]
fix MSVC2008 compilation ... it does not understand char *const *argv iin rrd_getopt
-- jkane mail.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2124
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 25 Aug 2010 20:15:26 +0000 (20:15 +0000)]
make sure an extra %s in the secondi axis format does not kill us
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2123
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 24 Aug 2010 05:19:55 +0000 (05:19 +0000)]
its filename not filtname
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2121
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 24 Aug 2010 05:19:46 +0000 (05:19 +0000)]
document version variable
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2120
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 23 Aug 2010 05:28:23 +0000 (05:28 +0000)]
in remote mode, make argument count for remote commmands strict as suggested by Dave Peticolas
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2119
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 22 Aug 2010 17:56:02 +0000 (17:56 +0000)]
First bug: in function rrd_fetch_fn_libdbi() variable 'struct sql_table_helper table_help'
field 'filename' is uninitialized. So, if a sql error happens, it does not print an error like this
rrd_set_error( "libdbi: problems connecting to db with connect string %s - error: %s",th->filename,dbi_errstr);
instead of, it dumps core.
Second bug: when the output data buffer is allocated, it allocated for 'rows-1' max index, but in
'fetch loop' 'idx' may be equal to 'rows', so it needs one more extra record in data.
-- Pavel Nikiforov pavel artx.ru
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2118
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 17 Aug 2010 21:41:03 +0000 (21:41 +0000)]
hunting down pango allocation issues ... now the memory loss in rrd_graph seems to be independant of the number
of graphs generated. fix for #208
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2117
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 26 Jul 2010 05:35:11 +0000 (05:35 +0000)]
rrdcached: Let the -s, -m and -P options affect the default socket as well -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2116
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sat, 10 Jul 2010 10:21:54 +0000 (10:21 +0000)]
print \n for log messages while runing rrdcached in the foreground ... suggested by Bernard Li
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2115
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 7 Jul 2010 21:06:55 +0000 (21:06 +0000)]
one with is enough ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2113
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 5 Jul 2010 15:29:56 +0000 (15:29 +0000)]
do not try to whisk i18n support into existance ... use it when its there
don't when it is not, rrdtool works fine either way.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2104
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 5 Jul 2010 13:19:18 +0000 (13:19 +0000)]
* make rrd_getopt compile on solaris
* unify isinf isnan definitions for compilation and configuration
* replace round by rint if round is not available
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2103
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 4 Jul 2010 20:59:49 +0000 (20:59 +0000)]
backport FP_* fixes and revert FPCLASSIFY fix since there the FP_* values are defines.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2101
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 4 Jul 2010 20:53:15 +0000 (20:53 +0000)]
do NOT assume that FP_* is defined, it can also be a typedef enum ... bug report by Michael Zehender
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2100
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 2 Jul 2010 12:53:49 +0000 (12:53 +0000)]
updated build tips for updated win32 port by Chris Larsen
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2099
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 2 Jul 2010 05:33:10 +0000 (05:33 +0000)]
rrd_update and rrd_rpncalc - fix casts introduced by win32 patch to make gcc happy too
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2098
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 1 Jul 2010 22:21:43 +0000 (22:21 +0000)]
there are bash scripts so lets have bash execute them
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2096
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 1 Jul 2010 20:49:42 +0000 (20:49 +0000)]
* patches to make rrdtool compile on win32 (trunk and 1.4)
* dotnet bindings (trunk) by Euphoria Audio
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2095
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 30 Jun 2010 12:48:47 +0000 (12:48 +0000)]
src/rrd_client.c: Fix a potential segmentation fault in "get_path".
The "get_path" function is called at least from "rrdc_update" without
checking for a connection first. In that case the "sd_path" pointer may be
NULL, so dereferencing it without checking for NULL is not good behavior.
This patch checks all arguments of the "get_path" function and returns an
error if any pointer is NULL. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2094
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 25 Jun 2010 21:41:50 +0000 (21:41 +0000)]
fixed solaris regression introduced in r1904 ... now the isnan macro should work again ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2093
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 11 Jun 2010 15:31:12 +0000 (15:31 +0000)]
Add rrd_update_v_r to librrd -- Frederik Kriewitz
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2092
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 11 Jun 2010 15:13:05 +0000 (15:13 +0000)]
Tiny, tiny documentation fix -- Peter Valdemar Mørch
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2091
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 11 Jun 2010 15:09:28 +0000 (15:09 +0000)]
rrd_daemon handle_request_fetch needs to convert to absolute path -- Thorsten von Eicken
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2090
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 11 Jun 2010 13:47:24 +0000 (13:47 +0000)]
update to the time_clean function by Jean-Edouard Babin
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2088
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 11 Jun 2010 13:45:15 +0000 (13:45 +0000)]
integrated VDEF never patch
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2087
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 2 Jun 2010 20:15:20 +0000 (20:15 +0000)]
MAC OS X ships with binaries named 'libtool' and 'libtoolize' which are
not the GNU tools. Those are prefixed with letter 'g'. -- Antoine Musso
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2086
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 2 Jun 2010 04:49:53 +0000 (04:49 +0000)]
rrd_open: include rrd_tool.h at the very start so that utime.h gets included if HAVE_BROKEN_MS_ASYNC
got set by configure. -- Antoine MUSSO
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2085
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 2 Jun 2010 04:45:21 +0000 (04:45 +0000)]
rrd_client.c: gcc 4.0.1 produced a warning and require same types. Warning shown was:
"assignement discards qualifers from pointer target type" -- Antoine MUSSO
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2084
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 28 May 2010 04:55:14 +0000 (04:55 +0000)]
[rrd_client.c] RRD client should resolve all paths when talking to a unix socket. This allows realpath() to resolve symbolic links, "..", etc. reported by: Eduardo Bragatto -- kevin brintnall
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2083
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 27 May 2010 06:09:47 +0000 (06:09 +0000)]
make the xport command handles the --daemon option properly -- unknown contributor #265
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2082
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 12 May 2010 08:45:09 +0000 (08:45 +0000)]
rrd_daemon: after fetching data must be freed ! -- Thorsten von Eicken
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2081
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 11 May 2010 14:55:18 +0000 (14:55 +0000)]
extend floss exception to php 3.01 license
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2080
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 10 May 2010 11:54:57 +0000 (11:54 +0000)]
time on it's own does not work
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2078
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 30 Apr 2010 16:14:00 +0000 (16:14 +0000)]
Document restricted time parsing when using the daemon. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2077
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 30 Apr 2010 16:13:40 +0000 (16:13 +0000)]
RRDCacheD: Fix a typo in an error message. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2076
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 30 Apr 2010 15:50:16 +0000 (15:50 +0000)]
rrd_client.c: explicitly close the connection on error in
response_read. I've found it to get stuck otherwise. -- Thorsten von Eicken
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2075
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 29 Apr 2010 05:44:24 +0000 (05:44 +0000)]
"rrd_parsetime" uses (many) global variables and is thus not
thread-safe. Using it in the FETCH command reproducably segfaults the
caching daemon.
This replacement will only work with "simple" integers, i. e. times
specified as "
1272470594" (sometime on April 28th) or "-3600" (one hour
ago). -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2074
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Thu, 29 Apr 2010 05:40:59 +0000 (05:40 +0000)]
when using CDEF datasources in rrd, the rpnp in process_pdp_st (allocated in rpn_expand) in is never freed -- Frederik Kriewitz
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2073
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 26 Apr 2010 12:38:11 +0000 (12:38 +0000)]
When specifying a relative path (-j option) rrd_cached would segfault when
trying to read past journals (journal_init function). Added an extra check
to journal_init before reading the directory, and, when parsing the command
line options, to expand the relative path to an absolute path. -- Adrian-Ioan Vasile yoyo@opennet.ro
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2072
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 26 Apr 2010 12:36:17 +0000 (12:36 +0000)]
check for round function as it is in -lm in solaris ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2071
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 26 Apr 2010 05:58:15 +0000 (05:58 +0000)]
Relicense the RRDCacheD client interface under the MIT license. This
allows the interface to be used from non-GPL applications by copying the
source code files into the projects source tree. -- Florian Forster rrdtool@octo.it
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2070
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 18 Apr 2010 16:33:54 +0000 (16:33 +0000)]
make rrdtool compile with gcc 4.5 if -std=c99 is set -- anicka@suse.cz
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2069
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 7 Apr 2010 13:01:39 +0000 (13:01 +0000)]
mark unused arguments in the same way throughout the code
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2067
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 2 Apr 2010 22:49:45 +0000 (22:49 +0000)]
fixed info interface documentation
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2064
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 19:18:06 +0000 (19:18 +0000)]
Rather than calling "FLUSH" for each RRD file needed for drawing a
graph and then accessing the file directly, use the "FLUSH" command to
receive the data required for drawing a graph.
The daemon can now be specified in one of three ways:
* A new option has been added to the "DEF" option. If the "DEF" command
includes the option "daemon=...", then the given daemon is used for
accessing that file only. This option takes precedence over all
other options. The value given follows the same syntax as other ways
to specify a daemon address, thouh colons need to be escaped from
rrdgraph(1).
Example:
'DEF:v1=path/to/example.rrd:value:AVERAGE:daemon=collect1.octo.cx'
* The "--daemon" option can be given to the overall "rrdtool graph"
command. When given, this address is used for all file accesses
except those which explicitely contain a "daemon=..." option.
* If the "RRDCACHED_ADDRESS" environment variable is set, it's value
is used as the daemon address. This is the lowest priority option
and only used if no other option is given.
One nice detail is that with ":daemon=...", the cache address can be
specified for each "DEF:" definition. It is therefore possible to graph
values stored on several servers in one graph ? even if several RRD
files have the same name. -- Florian
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2062
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 19:10:58 +0000 (19:10 +0000)]
src/rrd_format.c: Implemented "cf_to_string"
A simple helper function to turn an "enum cf_en" to a string. The returned
pointer points to static memory and doesn't need to be freed. -- Florian
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2061
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 17:05:33 +0000 (17:05 +0000)]
src/rrd_fetch.c: Use "rrdc_fetch" if daemon is available.
Instead of flushing the file via the connection to the daemon and then
accessing it directly, use the "FETCH" command to access the file via
the RRDCacheD. This removes ambiguities with absolute and relative paths
and makes it possible to read data from files that are not available
locally. -- Florian
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2060
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 17:03:57 +0000 (17:03 +0000)]
Add a "FETCH" command to RRDCacheD which behaves like a (simplified
version of) rrdfetch(1).
This has advantages over calling "FLUSH" from within the "client",
especially if the daemon is accessed using a network socket. For one, it
makes it easy to separate collecting and storing of data on one side and
creating graphs on another, possibly more public server. Without this
command this is only possible using networked file systems and similar
techniques.
When talking to an instance of RRDCacheD via a network socket, only
relative pathnames are allowed. If the RRD file is to be accessed
afterwards (why else would one call "FLUSH"?), the client has to be in a
specific directory so the *same* relative path can be used. If the file
is on a share mounted via the network, the required CWD may differ from
the CWD of the server, making developing and deploying solutions using
separated storing and graphing unnecessarily hard.
The data can be accessed using "rrdc_fetch" which should be a drop-in
replacement for "rrd_fetch_r". This makes it easy for programs using the
RRDtool C API to use this new functionality. -- Florian Forster
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2059
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 16:32:54 +0000 (16:32 +0000)]
* GRAD element for graph, it acts more or less like an AREA,
except you can specify a second color and a height which is used to
create a gradient from one color to the next
by Rian Shelley
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2058
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 16:26:55 +0000 (16:26 +0000)]
when printing time_t use %lld with (long long int) for portability
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2057
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 16:25:34 +0000 (16:25 +0000)]
use long long int instead of just long long
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2056
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 16:24:15 +0000 (16:24 +0000)]
add documentation on -a
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2055
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 16:23:33 +0000 (16:23 +0000)]
rename chunk option from -m to -a -- tobi
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2054
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 29 Mar 2010 15:48:24 +0000 (15:48 +0000)]
* Add utility functions to allocate pointers in variable size chunks.
* Introduce "-m" argument to reduce calls to realloc(). -- kevin
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2053
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 28 Mar 2010 09:04:49 +0000 (09:04 +0000)]
* do add intl directory back to Makefile.am ... no use distributing the stuff if we don't use it
* link pangocairo and not pango ... thanks Stephen S. Disbrow for finding this
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2052
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 26 Mar 2010 20:35:39 +0000 (20:35 +0000)]
added solaris build hint by fabien wernli
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2050
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Wed, 24 Mar 2010 17:19:57 +0000 (17:19 +0000)]
rrdcached: Updated help output
rrdcached: Exit with status != 0, if an invalid command line option was used. -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2049
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 17:21:38 +0000 (17:21 +0000)]
Wall is not a portable cc option ... if this is to be used we would have to check
which C compiler is in use ... so lets drop it for now
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2045
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 17:02:55 +0000 (17:02 +0000)]
include gettext 0.17 ... for those who do not have it on board
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2044
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 16:56:11 +0000 (16:56 +0000)]
wait before release to prevent timeout on scp
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2043
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 16:05:55 +0000 (16:05 +0000)]
prepare for the release of rrdtool-1.4.3
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2042
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 16:05:23 +0000 (16:05 +0000)]
fixed spelling a bit
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2041
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 16:03:53 +0000 (16:03 +0000)]
do not autogen the CHANGES file anymore
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2040
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 15:05:43 +0000 (15:05 +0000)]
we are in 2010 now
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2039
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 15:00:13 +0000 (15:00 +0000)]
update date
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2038
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 14:51:06 +0000 (14:51 +0000)]
rrdcached: Log to stderr (in addition to syslog) when running in foreground. -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2037
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 14:50:32 +0000 (14:50 +0000)]
rrdcached: Do not put any code in assert(). -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2036
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 14:49:26 +0000 (14:49 +0000)]
rrdcached: Added -m command line option. This option may be used to specify
the file permissions of a UNIX socket. The option affects the following
sockets only, i.e., it's possible to specify different modes for different
sockets. -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2035
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 14:47:35 +0000 (14:47 +0000)]
rrdcached: Let -s affect the following sockets only. This way, it's possible
to specify different groups for different sockets. -- Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2034
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 22 Mar 2010 09:05:39 +0000 (09:05 +0000)]
add 'm' as a shortcut for 'zoom' in rrd_graph (1.4 code+docu)
(1.3 only docu). Fix for Debian Bug 573299 provided by Sebastian Harl
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2033
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 15 Mar 2010 08:43:22 +0000 (08:43 +0000)]
in rrd_cgi RRD::TIME::LAST do not raise argc when calling rrd_last since the strftime argument which
is provided is already in the count but does not get passed to rrd_last. Thanks to Robert Luberda (fixing Debian Bug #573638.)
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2030
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 8 Mar 2010 17:13:16 +0000 (17:13 +0000)]
Obviously this will only work if rrdcached is running as root which in
my case it has to be (as upstart can't currently monitor non-root
daemons). As you may have RRD data sources (data loggers) and RRD
consumers (e.g. CGI scripts) that both need to talk to the cache
daemon one solution is to set the group permissions of the socket.
This offer some flexibility over trying to get every RRD user/daemon
running under the same user context. -- Alex Bennee ajb pitcairn.cambridgebroadband.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2029
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Mon, 8 Mar 2010 17:10:02 +0000 (17:10 +0000)]
added --no-overwrite option to rrdtool create. It prevents rrdtool from clobbering existing rrd files. -- Chris - LINX
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2028
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 2 Mar 2010 23:22:35 +0000 (23:22 +0000)]
I think I just solved a longstanding bug in the rrd_update routine
... I am writing a tool for seeding new rrd files from an existing
one ... essentially enabeling arbitrary restructuring ...
while doing this I found the following:
pdp: 1 2 | 3 4 5 6 7 | 8 9
for a consolidation of 5 steps I get
AVG RRA .. | 5 | ..
MIN RRA .. | 2 | ..
MAX RRA .. | 7 | ..
while I would have expected to get
AVG RRA .. | 5 | ..
MIN RRA .. | 3 | ..
MAX RRA .. | 7 | ..
the behavior has been like this at least since 1.2
looking at the code I found that the behavior had been introduced
by a patch optimizing rrd_update for updates covering multiple pdps
in one go ... in that optimization, the normal case where an update
covers exactly ONE pdp had been sort of neglected ... so much for
tunel vision.
The problem was, that the cdp value for MIN and MAX got initialized
from the last pdp value BEFORE the consolidation interval ... for
normal data no one would notice (or did notice) but it is still
wrong ...
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2024
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 2 Mar 2010 16:54:04 +0000 (16:54 +0000)]
added additional dependencies on Makefile to make sure bindings makefiles get rebuild after reconfig
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2023
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 16 Feb 2010 13:04:18 +0000 (13:04 +0000)]
reset rrd_state for grapv in ruby bindings -- Sven Engelhardt
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2022
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sat, 13 Feb 2010 11:30:17 +0000 (11:30 +0000)]
make sure we only use _NL_TIME_WEEK_1STDAY if we actually have it ... thanks kevin for the report
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2020
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 7 Feb 2010 19:55:47 +0000 (19:55 +0000)]
use _NL_TIME_WEEK_1STDAY to determin the first day of the week.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2018
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Sun, 7 Feb 2010 19:48:01 +0000 (19:48 +0000)]
use locale information from LC_TIME first_weekday to determine if the week should start sunday or monday.
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2017
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Fri, 5 Feb 2010 18:28:41 +0000 (18:28 +0000)]
new rb_rrd_xport function for ruby bindings. -- Pavel Pachkovskij pavel.pachkovskij azati.com
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2016
a5681a0c-68f1-0310-ab6d-
d61299d08faa
oetiker [Tue, 2 Feb 2010 17:07:20 +0000 (17:07 +0000)]
make sure that (argv-1)[0] points to something sensible ... hack to undo the damage caused by a sensless optimization. see bug #251
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2013
a5681a0c-68f1-0310-ab6d-
d61299d08faa