collectd.git
16 years agocollectd.conf(5): Added documentation for the ipmi plugin.
Peter Holik [Tue, 19 Aug 2008 09:08:53 +0000 (11:08 +0200)]
collectd.conf(5): Added documentation for the ipmi plugin.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd(1), collectd{-exec,.conf}(5): Fixed some minor POD errors.
Sebastian Harl [Sat, 16 Aug 2008 17:35:58 +0000 (19:35 +0200)]
collectd(1), collectd{-exec,.conf}(5): Fixed some minor POD errors.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 19 Aug 2008 07:45:35 +0000 (09:45 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agobuild system: Automatically enable the swap plugin if the kvm library is found.
Florian Forster [Tue, 19 Aug 2008 07:44:56 +0000 (09:44 +0200)]
build system: Automatically enable the swap plugin if the kvm library is found.

This fixes a bug introduced with the previous commit.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 19 Aug 2008 07:26:13 +0000 (09:26 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agoMerge branch 'collectd-4.3' of /var/lib/git/collectd into collectd-4.3
Florian Forster [Tue, 19 Aug 2008 07:25:46 +0000 (09:25 +0200)]
Merge branch 'collectd-4.3' of /var/lib/git/collectd into collectd-4.3

16 years agobuild system: Define which version of libkvm has been checked for.
Florian Forster [Tue, 19 Aug 2008 07:24:33 +0000 (09:24 +0200)]
build system: Define which version of libkvm has been checked for.

The used `kvm_getswapinfo' is apparently an extension not all versions of the
kvm library support.

16 years agotcpconns plugin: Fix another format string.
Florian Forster [Mon, 18 Aug 2008 16:19:26 +0000 (18:19 +0200)]
tcpconns plugin: Fix another format string.

16 years agotcpconns plugin: Fix formatstrings.
Florian Forster [Mon, 18 Aug 2008 14:18:41 +0000 (16:18 +0200)]
tcpconns plugin: Fix formatstrings.

16 years agosnmp plugin: Fix a possible memory leak.
Florian Forster [Mon, 18 Aug 2008 08:48:21 +0000 (10:48 +0200)]
snmp plugin: Fix a possible memory leak.

The result was not freed when `csnmp_instance_list_add' failed. This
rarely happens in 4.3, but later versions will be more strict in the
function, so this became a problem.

16 years agocontrib/collection3: Added a couple more graph definitions.
Florian Forster [Wed, 13 Aug 2008 09:45:45 +0000 (11:45 +0200)]
contrib/collection3: Added a couple more graph definitions.

16 years agocontrib/collection3: Added the forgotten Collectd::Graph::Config module.
Florian Forster [Wed, 13 Aug 2008 07:48:50 +0000 (09:48 +0200)]
contrib/collection3: Added the forgotten Collectd::Graph::Config module.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 12 Aug 2008 09:31:26 +0000 (11:31 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agosrc/utils_threshold.c: Free allocated memory before returning..
Peter Holik [Tue, 12 Aug 2008 09:04:27 +0000 (11:04 +0200)]
src/utils_threshold.c: Free allocated memory before returning..

..in an error condition.

16 years agomemory plugin: The variable is named cache, not cached, at least on libstatgrab ...
Michael Stapelberg [Sat, 9 Aug 2008 12:42:24 +0000 (14:42 +0200)]
memory plugin: The variable is named cache, not cached, at least on libstatgrab >= 0.16

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigure.in: Look for ip_vs.h in the kernel sources.
Boian Berberov [Mon, 11 Aug 2008 14:57:57 +0000 (16:57 +0200)]
configure.in: Look for ip_vs.h in the kernel sources.

Developers,

I am writing an updated ebuild for gentoo and I made this patch that allows
ip_vs.h to be located and the ipvs module to build. Normally I would include
this with the ebuild, but I thought it may be beneficial to send it to you.
Please review it and let me know what you think. I am still inexperienced with
autotools so the patch may not be well put together. If you would consider
applying it or a similar patch, please let me know so I can adjust the ebuild
accordingly.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocontrib/collection3: Add JavaScript code to unify the timespan of all graphs.
Florian Forster [Mon, 28 Jul 2008 09:06:51 +0000 (11:06 +0200)]
contrib/collection3: Add JavaScript code to unify the timespan of all graphs.

Using the new ``Set all images to this timespan'' button one can now easily
show the same timespan in all graphs. This allows to compare different graphs
much more easily.

16 years agocontrib/collection3: Update `json.cgi' to use the new config parsing function.
Florian Forster [Mon, 28 Jul 2008 09:05:39 +0000 (11:05 +0200)]
contrib/collection3: Update `json.cgi' to use the new config parsing function.

16 years agocontrob/collection3: Implement zooming using the mouse wheel.
Florian Forster [Sun, 27 Jul 2008 15:23:03 +0000 (17:23 +0200)]
controb/collection3: Implement zooming using the mouse wheel.

Also you can now re-center the graph with a double click.

16 years agocontrib/collection3: Add a generic `instance' placeholder.
Florian Forster [Sun, 27 Jul 2008 15:22:26 +0000 (17:22 +0200)]
contrib/collection3: Add a generic `instance' placeholder.

It will be replaced by either the type or plugin instance, depending on
which is defined.. This is handy for temperatures and stuff like that,
where sometimes the type instance doesn't exist.

16 years agocontrib/collection3: Move configuration logic into Collectd::Graph::Config.
Florian Forster [Sun, 27 Jul 2008 15:21:04 +0000 (17:21 +0200)]
contrib/collection3: Move configuration logic into Collectd::Graph::Config.

16 years agocontrib/collection3: Updated the `collection3' stuff in contrib/.
Florian Forster [Sun, 27 Jul 2008 11:08:28 +0000 (13:08 +0200)]
contrib/collection3: Updated the `collection3' stuff in contrib/.

16 years agoChangeLog: Updated after the merge. collectd-4.4.2
Florian Forster [Tue, 15 Jul 2008 14:39:29 +0000 (16:39 +0200)]
ChangeLog: Updated after the merge.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 15 Jul 2008 14:32:37 +0000 (16:32 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agoBumped version to 4.4.2; Updated ChangeLog.
Florian Forster [Tue, 15 Jul 2008 14:29:39 +0000 (16:29 +0200)]
Bumped version to 4.4.2; Updated ChangeLog.

16 years agoconfigfile.c: Fixed a typo.
Sebastian Harl [Sat, 12 Jul 2008 09:36:04 +0000 (11:36 +0200)]
configfile.c: Fixed a typo.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoipmi plugin: Fix a typo: sstrerror_r -> sstrerror.
Peter Holik [Tue, 15 Jul 2008 06:21:21 +0000 (08:21 +0200)]
ipmi plugin: Fix a typo: sstrerror_r -> sstrerror.

16 years agosnmp plugin: More format string fixes.
Florian Forster [Mon, 14 Jul 2008 17:38:11 +0000 (19:38 +0200)]
snmp plugin: More format string fixes.

16 years agontpd plugin: Use the standard types `uint8_t' etc. instead of `u_char' etc.
Florian Forster [Mon, 14 Jul 2008 15:35:42 +0000 (17:35 +0200)]
ntpd plugin: Use the standard types `uint8_t' etc. instead of `u_char' etc.

16 years agovserver plugin: Use `readdir_r' instead of `readdir'.
Florian Forster [Mon, 14 Jul 2008 15:27:36 +0000 (17:27 +0200)]
vserver plugin: Use `readdir_r' instead of `readdir'.

`readdir' is not thread safe, so use the (more thread safe) `readdir_r'.
Also, don't use the non-standard `d_type' member of the `dirent'
structure - it's not portable.

I'm aware that this plugin is very Linux specific and Linux most likely
will never use another C library than the GNU libc, but using this
member prevents me from compiling with the most restrictive `strict'
settings..

16 years agosrc/{collectd.h,perl.c}: Poison sprintf after perl.h has been included.
Florian Forster [Mon, 14 Jul 2008 13:47:02 +0000 (15:47 +0200)]
src/{collectd.h,perl.c}: Poison sprintf after perl.h has been included.

16 years agosnmp plugin: Fix two format strings.
Florian Forster [Mon, 14 Jul 2008 09:57:41 +0000 (11:57 +0200)]
snmp plugin: Fix two format strings.

16 years agosrc/collectd.h: Don't include <pth.h>.
Florian Forster [Mon, 14 Jul 2008 08:04:37 +0000 (10:04 +0200)]
src/collectd.h: Don't include <pth.h>.

We don't use it, we don't check for it. Why on earth is it still in there..?

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Mon, 14 Jul 2008 07:44:29 +0000 (09:44 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

Conflicts:

src/ntpd.c

16 years agoconfigure.in: Use pkg-config to detect the upsclient library.
Florian Forster [Mon, 14 Jul 2008 07:41:55 +0000 (09:41 +0200)]
configure.in: Use pkg-config to detect the upsclient library.

The libupsclient-config script is gone in newer versions, so we use pkg-config
instead.

16 years agontpd plugin: Fix two format strings.
Florian Forster [Mon, 14 Jul 2008 07:39:47 +0000 (09:39 +0200)]
ntpd plugin: Fix two format strings.

16 years agocontrib/collection3: Add an basic, extensible, modular graphing front-end.
Florian Forster [Tue, 8 Jul 2008 11:08:13 +0000 (13:08 +0200)]
contrib/collection3: Add an basic, extensible, modular graphing front-end.

16 years agoemail plugin: Don't print `pthread_t'.
Florian Forster [Sun, 6 Jul 2008 13:24:59 +0000 (15:24 +0200)]
email plugin: Don't print `pthread_t'.

It may be a struct, so printing it is not portable.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Sun, 6 Jul 2008 13:04:41 +0000 (15:04 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agosrc/plugin.c: Initialize plugins before checking if read callbacks are available.
Sebastian Harl [Wed, 2 Jul 2008 14:26:46 +0000 (16:26 +0200)]
src/plugin.c: Initialize plugins before checking if read callbacks are available.

plugin_init_all() checks if any read callbacks are available before starting
the read threads. A few plugins register their read callback from their
init callback though. By initializing the plugins before that the read
threads are still started correctly if all plugins register the read
callback in the init callback.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agorrdtool plugin: Use a hack to case the `argv' pointers in a portable way.
Florian Forster [Wed, 2 Jul 2008 13:21:55 +0000 (15:21 +0200)]
rrdtool plugin: Use a hack to case the `argv' pointers in a portable way.

16 years agoChangeLog: Recoded to UTF-8.
Florian Forster [Wed, 25 Jun 2008 13:36:09 +0000 (15:36 +0200)]
ChangeLog: Recoded to UTF-8.

16 years agoemail plugin: Don't unlink the socket file on startup.
Sebastian Harl [Tue, 17 Jun 2008 17:59:14 +0000 (19:59 +0200)]
email plugin: Don't unlink the socket file on startup.

Usually, collectd runs as user root, thus making it an unsafe operation to
unconditionally remove the file even though one should be able to assume
that it "belongs" to collectd.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/common.c: Not enough memory is an error, not a debug message!
Florian Forster [Fri, 20 Jun 2008 12:47:16 +0000 (14:47 +0200)]
src/common.c: Not enough memory is an error, not a debug message!

16 years agocontrib/examples/: Be more verbose about how to handle types.
Sebastian Harl [Mon, 16 Jun 2008 21:35:28 +0000 (23:35 +0200)]
contrib/examples/: Be more verbose about how to handle types.

As suggested by Wolfgang Kroener.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/common.c: Add end-of-line characters to strsplit()
Michał Mirosław [Sat, 14 Jun 2008 00:29:05 +0000 (02:29 +0200)]
src/common.c: Add end-of-line characters to strsplit()

This fixes plugins that use it to break lines read using fgets()
and forget that "\n" is left at the buffer's end. At least
battery and wireless plugins is affected.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/collectd.conf.in: Fix the NotificationExec example.
Florian Forster [Fri, 13 Jun 2008 12:57:39 +0000 (14:57 +0200)]
src/collectd.conf.in: Fix the NotificationExec example.

16 years agosrc/utils_dns.c: Fix version information for __NAMESER >= 19961001.
Florian Forster [Wed, 11 Jun 2008 13:29:02 +0000 (15:29 +0200)]
src/utils_dns.c: Fix version information for __NAMESER >= 19961001.

Thanks to Oleg for reporting this.
Resolves: #22

16 years agoReplace all occurrences of `strcpy' with `sstrncpy', again.
Florian Forster [Wed, 11 Jun 2008 12:32:19 +0000 (14:32 +0200)]
Replace all occurrences of `strcpy' with `sstrncpy', again.

This changes all files that are new in 4.4.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Wed, 11 Jun 2008 12:30:56 +0000 (14:30 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agosrc/collectd.h: Use `#pragma GCC poison' to disable evil functions.
Florian Forster [Wed, 11 Jun 2008 12:30:39 +0000 (14:30 +0200)]
src/collectd.h: Use `#pragma GCC poison' to disable evil functions.

16 years agolibvirt plugin: Replace `strcat' with `strncat'.
Florian Forster [Wed, 11 Jun 2008 12:30:02 +0000 (14:30 +0200)]
libvirt plugin: Replace `strcat' with `strncat'.

16 years agoReplace all occurrences of `strcpy' with `sstrncpy'.
Florian Forster [Wed, 11 Jun 2008 12:29:31 +0000 (14:29 +0200)]
Replace all occurrences of `strcpy' with `sstrncpy'.

16 years agonginx plugin: Use `strtok_r' instead of `strtok'.
Florian Forster [Wed, 11 Jun 2008 12:24:34 +0000 (14:24 +0200)]
nginx plugin: Use `strtok_r' instead of `strtok'.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 10 Jun 2008 15:09:46 +0000 (17:09 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agowireless plugins: Interpret noise/power values >100 as (dBm + 256).
JoW [Mon, 9 Jun 2008 11:27:16 +0000 (13:27 +0200)]
wireless plugins: Interpret noise/power values >100 as (dBm + 256).

Hi list,

I currently develop an embedded statistics application and web interface
for OpenWrt Kamikaze based on Collectd and RRDTool.

While working with the wireless plugin I noticed some incompatibilities
with different drivers, namely the Broadcom proprietary driver and madwifi.

  /proc/net/wireless on Broadcom:

   Inter-| sta-|   Quality        |   Discarded packets               | Missed | WE
    face | tus | link level noise |  nwid  crypt   frag  retry   misc | beacon | 18
      wl0: 0000    2.  179.  163.       0      0   8040    723      0        0

  With the Broadcom proprietary driver you get the actual signal and noise
  dbm units by substracting 255 from the values in /proc:

   level: 179 - 255 = -76 dBm
   noise: 163 - 255 = -92 dBm

  /proc/net/wireless on Atheros SoC:

   Inter-| sta-|   Quality        |   Discarded packets               | Missed | WE
    face | tus | link level noise |  nwid  crypt   frag  retry   misc | beacon | 22
     ath0: 0004   21.  -73.  -94.   21841      0      0      0      0        0

  Madwifi writes the actual dBm values into /proc.

So we have (at least for now) three possible types of values:

   ( x > 0.0   && x <= 100.0 ) current implementation: x is in percent (?)

   ( x > 100.0 && x <= 255.0 ) broadcom: range intersects with percents but
values below 100.0 (100.0 - 255.0 = -155.0 dBm)
are somewhat unlikely to occur

   ( x < 0.0 ) atheros: value is already in dBm

A patch which implements the two additional possibilities in collectd's wireless
plugin can be found in the OpenWrt Trac:

https://dev.openwrt.org/browser/packages/utils/collectd/patches/200-wireless-compat.patch

The patch was made against v4.4.0 of collectd but should work with v4.4.1 too.
It would be nice to have this in the next release or so :)

Greetings,
JoW

16 years agodisk plugin: Use correct name under Linux 2.4
Alessandro Iurlano [Sat, 7 Jun 2008 13:16:18 +0000 (15:16 +0200)]
disk plugin: Use correct name under Linux 2.4

Hello everybody.

I have noticed that disk graphs are displayed by collection.cgi as
disk (71687000) instead of the correct disk name on 2.4.x linux
kernels.
The problem seems caused by the fact that the position of disk name of
/proc/partitions (used in 2.4 kernels) differs from /proc/diskstats
(used in 2.6 kernels).

I include as attachment a patch that seems to fix this problem.
I have tested it on 2.4.20 (REDHAT 9) and 2.6.24.4 (Debian Sid) systems.

Thanks a lot for Collectd. It is a _very_ useful program.

Alessandro

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agonetwork plugin: Don't blindly re-initialize everything in the init callback.
Florian Forster [Sat, 7 Jun 2008 18:39:04 +0000 (20:39 +0200)]
network plugin: Don't blindly re-initialize everything in the init callback.

Under Solaris the init functions are called every time the kstat chain
is updated. Since, among other things, send_buffer_fill was set to zero
here, the plugin ``forgot'' about values.

Thank you very much to Eric LeBlanc for debugging this issue.

16 years agosrc/collectd.h: Try even harder to determine endianess.
Florian Forster [Fri, 6 Jun 2008 10:32:13 +0000 (12:32 +0200)]
src/collectd.h: Try even harder to determine endianess.

NexentaStor 1.0.2 doesn't have <endian.h>, for example :/

16 years agosrc/plugin.h: Use __attribute__((format)) for plugin_log.
Florian Forster [Fri, 6 Jun 2008 10:21:01 +0000 (12:21 +0200)]
src/plugin.h: Use __attribute__((format)) for plugin_log.

All __attribute__'s will be automatically set to /**/ when not using the
GNU CC via a macro in src/collectd.h. This way this should be portable.

16 years agoBumped version to 4.4.1; Updated ChangeLog. collectd-4.4.1
Florian Forster [Tue, 3 Jun 2008 17:09:14 +0000 (19:09 +0200)]
Bumped version to 4.4.1; Updated ChangeLog.

16 years agoCollectd.pm: Updated copyright information.
Sebastian Harl [Thu, 29 May 2008 22:13:07 +0000 (00:13 +0200)]
Collectd.pm: Updated copyright information.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Fixed a segfault that appeared in Perl 5.10.
Sebastian Harl [Thu, 29 May 2008 22:12:36 +0000 (00:12 +0200)]
perl plugin: Fixed a segfault that appeared in Perl 5.10.

In Perl 5.10, av_clear() (amongst others) does no longer allow NULL for
the passed array object pointer, thus we have to check for it ourselves.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Don't abort if initializing the interpreter failed.
Sebastian Harl [Thu, 29 May 2008 22:09:18 +0000 (00:09 +0200)]
perl plugin: Don't abort if initializing the interpreter failed.

There is no reason to shutdown collectd completely just because of some
Perl specific error. An error message is logged in this case, so the user
has means to detect it.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/collectd.conf.in: Fix a typo.
Florian Forster [Sat, 31 May 2008 08:35:40 +0000 (10:35 +0200)]
src/collectd.conf.in: Fix a typo.

The config for the disk plugin was in a block for the `df' plugin.
Thanks to onebinary for pointing this out :)

16 years agoMerge branch 'collectd-4.4' of octo@verplant.org:/var/lib/git/collectd into collectd-4.4
Florian Forster [Tue, 27 May 2008 15:52:36 +0000 (17:52 +0200)]
Merge branch 'collectd-4.4' of octo@verplant.org:/var/lib/git/collectd into collectd-4.4

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 27 May 2008 11:16:46 +0000 (13:16 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agobuild.sh: Check for lex and yacc.
Sebastian Harl [Sat, 24 May 2008 20:29:56 +0000 (22:29 +0200)]
build.sh: Check for lex and yacc.

Warn the user, if lex(1) and yacc(1) cannot be found. This is not
necessarily an error, as flex(1) or bison(1) might be available.

As suggested by Kevin Trumbull (onebinary) on IRC.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/liboconfig/oconfig.c: Declare "c_file" as "const char *".
Sebastian Harl [Sat, 24 May 2008 18:32:43 +0000 (20:32 +0200)]
src/liboconfig/oconfig.c: Declare "c_file" as "const char *".

This fixes an "assignment discards qualifiers from pointer target type"
warning. That string stores the name of the config file which is not
going to be modified by liboconfig.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/utils_llist.c: Improved robustness against NULL pointers.
Sebastian Harl [Thu, 22 May 2008 11:36:00 +0000 (13:36 +0200)]
src/utils_llist.c: Improved robustness against NULL pointers.

All functions searching for some list entry now return NULL if the given
list equals NULL. Imho, that's the expected behavior. Also, it removes the
need to check the lists from the calling function while that function
usually checks the returned list entry anyway.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd-nagios: Updated to the new "unixsock" protocol.
Sebastian Harl [Wed, 21 May 2008 14:50:07 +0000 (16:50 +0200)]
collectd-nagios: Updated to the new "unixsock" protocol.

When disambiguating the protocol used by the unixsock plugin in commit
90287c6d240a168fca8d01f8330e2e2263e1f0a4 ("Disambiguated the protocol used
by the unixsock (and other) plugins.") the formatting of the return values
of the "GETVAL" command has been modified. This patch updates
collectd-nagios to handle the new format correctly.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/{email,ntpd,utils_cmd_getval}.c: Fix formatting errors.
Florian Forster [Mon, 26 May 2008 13:27:35 +0000 (15:27 +0200)]
src/{email,ntpd,utils_cmd_getval}.c: Fix formatting errors.

16 years agosrc/utils_threshold.c: Fix wrong output (was `min, min', should be `min, max') in...
Dieter Bloms [Sun, 25 May 2008 09:15:15 +0000 (11:15 +0200)]
src/utils_threshold.c: Fix wrong output (was `min, min', should be `min, max') in the created notification.

Resolves: #16

16 years agosrc/collectd.conf.in: Add sample section for the disk plugin.
Florian Forster [Sun, 25 May 2008 09:11:28 +0000 (11:11 +0200)]
src/collectd.conf.in: Add sample section for the disk plugin.

Resolves: #15

16 years agocontrib/cussh.pl: Implemented a `HELP' command.
Florian Forster [Tue, 13 May 2008 15:05:30 +0000 (17:05 +0200)]
contrib/cussh.pl: Implemented a `HELP' command.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 13 May 2008 14:58:11 +0000 (16:58 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

Conflicts:

contrib/cussh.pl

16 years agocontrib/cussh.pl: Remove left over merge stuff..
Florian Forster [Tue, 13 May 2008 14:56:17 +0000 (16:56 +0200)]
contrib/cussh.pl: Remove left over merge stuff..

How the hell did that get there..?

16 years agocontrib/cussh.pl: Improve parsing of identifiers.
Florian Forster [Tue, 13 May 2008 14:51:26 +0000 (16:51 +0200)]
contrib/cussh.pl: Improve parsing of identifiers.

16 years agosrc/utils_threshold.c: Fix the `Instance' option inside of `Type' blocks.
Florian Forster [Tue, 13 May 2008 10:08:14 +0000 (12:08 +0200)]
src/utils_threshold.c: Fix the `Instance' option inside of `Type' blocks.

Thanks to `kyrone' for pointing this out.

16 years agoteamspeak2 plugin: Fix out-of-bounds access to two arrays.
René Rebe [Tue, 13 May 2008 08:11:00 +0000 (10:11 +0200)]
teamspeak2 plugin: Fix out-of-bounds access to two arrays.

Hi,

while updating our T2 SDE (http://www.t2-project.org) package I
noticed some out-of-bounds acces in the teamspeak2 support:

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoChangeLog: Add a note about changes to the threshold handling. collectd-4.4.0
Florian Forster [Tue, 6 May 2008 19:13:51 +0000 (21:13 +0200)]
ChangeLog: Add a note about changes to the threshold handling.

16 years agoAUTHORS: Added Luke Herberling and Oleg King.
Florian Forster [Tue, 6 May 2008 17:19:31 +0000 (19:19 +0200)]
AUTHORS: Added Luke Herberling and Oleg King.

16 years agoBumped version to 4.4.0; Updated ChangeLog.
Florian Forster [Tue, 6 May 2008 14:55:35 +0000 (16:55 +0200)]
Bumped version to 4.4.0; Updated ChangeLog.

16 years agosrc/collectd.conf.in: Added the new powerdns and tail plugins.
Florian Forster [Tue, 6 May 2008 14:46:42 +0000 (16:46 +0200)]
src/collectd.conf.in: Added the new powerdns and tail plugins.

16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 6 May 2008 14:14:18 +0000 (16:14 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 6 May 2008 14:13:35 +0000 (16:13 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

configure.in

16 years agopowerdns plugin: Fix some bugs after testing the plugin.
Florian Forster [Tue, 6 May 2008 14:01:01 +0000 (16:01 +0200)]
powerdns plugin: Fix some bugs after testing the plugin.

16 years agoconfigure.in: Don't use `test -a'. collectd-4.2
Florian Forster [Tue, 6 May 2008 12:29:56 +0000 (14:29 +0200)]
configure.in: Don't use `test -a'.

Some old/weird versions of sh and/or test don't support the `-a' (`and')
argument.

16 years agocollectd-nagios: Open two different I/O streams for reading and writing.
Sebastian Harl [Thu, 1 May 2008 23:14:32 +0000 (01:14 +0200)]
collectd-nagios: Open two different I/O streams for reading and writing.

Full-duplex standard I/O streams are not really supported on sockets.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agodaemon: Ignore SIGPIPE.
Sebastian Harl [Thu, 1 May 2008 23:13:24 +0000 (01:13 +0200)]
daemon: Ignore SIGPIPE.

The default action for the PIPE signal is to terminate the process. This
is not really what we want for collectd, as e.g. a client of the unixsock
plugin (which might even be running without root privileges) could kill
the daemon by closing the socket right after sending a request.

The signal now gets ignored and each I/O function is checked for success.
To simply that, the unixsock's output stream is now configured to be line
buffered, removing the need to call fflush() (which could fail as well and
would have to be checked for success).

While I was at it, I renamed the sigaction struct for SIGCHLD to fit the
coding style used elsewhere in collectd.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoAdd libiptc.
Sebastian Harl [Thu, 1 May 2008 10:48:02 +0000 (12:48 +0200)]
Add libiptc.

libiptc is not meant to be a public interface by upstream. Debian has thus
removed it from all packages. To be able to use it, we need to take care
of it ourselves.

The configure script now checks, if libiptc is available and uses the
shipped version as a fallback.

The following changes to the libiptc sources were required:
 * added copyright headers mentioning the "Netfilter Core Team" as author
 * changed libiptc/* includes to * only
 * made libiptc.c:standard_target_map() static

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.3' into collectd-4.4
Florian Forster [Tue, 6 May 2008 11:45:14 +0000 (13:45 +0200)]
Merge branch 'collectd-4.3' into collectd-4.4

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Tue, 6 May 2008 11:44:46 +0000 (13:44 +0200)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agocollectd.conf(5): Documented the powerdns plugin.
Florian Forster [Mon, 5 May 2008 15:30:33 +0000 (17:30 +0200)]
collectd.conf(5): Documented the powerdns plugin.

16 years agopowerdns plugin: Promoted the "not found" message from DEBUG to INFO.
Florian Forster [Mon, 5 May 2008 15:30:13 +0000 (17:30 +0200)]
powerdns plugin: Promoted the "not found" message from DEBUG to INFO.

Since users may configure this themselves, they should know when it
doesn't work, so it's not a debug issue anymore.

16 years agopowerdns plugin: Fix a bug when checking the configuration options.
Florian Forster [Mon, 5 May 2008 15:29:10 +0000 (17:29 +0200)]
powerdns plugin: Fix a bug when checking the configuration options.

16 years agopowerdns plugin: Trim the default recursor command.
Florian Forster [Mon, 5 May 2008 15:28:27 +0000 (17:28 +0200)]
powerdns plugin: Trim the default recursor command.

16 years agoMerge branch 'collectd-4.4' of git://git.verplant.org/collectd into collectd-4.4
Florian Forster [Mon, 5 May 2008 14:44:49 +0000 (16:44 +0200)]
Merge branch 'collectd-4.4' of git://git.verplant.org/collectd into collectd-4.4

16 years agoMerge branch 'collectd-4.4' of octo@verplant.org:/var/lib/git/collectd into collectd-4.4
Florian Forster [Mon, 5 May 2008 14:44:11 +0000 (16:44 +0200)]
Merge branch 'collectd-4.4' of octo@verplant.org:/var/lib/git/collectd into collectd-4.4

16 years agopowerdns plugin: Add defaults that are used if no fields are configured.
Florian Forster [Mon, 5 May 2008 14:20:38 +0000 (16:20 +0200)]
powerdns plugin: Add defaults that are used if no fields are configured.