Florian Forster [Mon, 3 Sep 2012 06:53:45 +0000 (08:53 +0200)]
memcached plugin: Fix some error messages.
Florian Forster [Mon, 3 Sep 2012 06:52:32 +0000 (08:52 +0200)]
memcached plugin: Fix backwards compatibility.
Don't use the instance name in the identifier when we're using the legacy
configuration mode.
Florian Forster [Mon, 3 Sep 2012 06:25:46 +0000 (08:25 +0200)]
memcached plugin: Reorder functions to avoid prototype.
Florian Forster [Mon, 3 Sep 2012 06:22:16 +0000 (08:22 +0200)]
memcached plugin: Refactor the memcached_query_daemon() function.
The connecting code has been broken out in separate functions and the
writing and reading from the socket no longer uses poll(2),
non-blocking I/O and a custom built retry logic. Instead block on I/O and
let the read-thread-pool do its thing.
Florian Forster [Sun, 2 Sep 2012 11:25:16 +0000 (13:25 +0200)]
memcached plugin: Fix backwards compatibility.
Register a default callback in the init() phase if no configuration is
provided for the plugin. This way doing just "LoadPlugin memcached" will
result in the old behavior i.e. localhost being queried.
Florian Forster [Sun, 2 Sep 2012 11:03:07 +0000 (13:03 +0200)]
memcached plugin: Fix the default behavior, i.e. use the documented host and port.
Florian Forster [Sun, 2 Sep 2012 10:58:30 +0000 (12:58 +0200)]
collectd.conf(5): Document the memcached plugin.
The Instance blocks and Socket option were missing.
Florian Forster [Sun, 2 Sep 2012 10:42:21 +0000 (12:42 +0200)]
memcached plugin: Specify read-group name when registering callbacks.
Florian Forster [Sun, 2 Sep 2012 10:41:48 +0000 (12:41 +0200)]
memcached plugin: Rename config callback (add prefix).
Florian Forster [Sun, 2 Sep 2012 10:41:22 +0000 (12:41 +0200)]
memcached plugin: Replace config_set_string() with cf_util_get_string().
Nicolas Szalay [Tue, 13 Mar 2012 08:37:57 +0000 (09:37 +0100)]
multiple memcached instances, v2
Nicolas [Fri, 23 Dec 2011 22:15:22 +0000 (23:15 +0100)]
memcached plugin : added support for multiple instances
Florian Forster [Mon, 27 Aug 2012 06:39:17 +0000 (08:39 +0200)]
Merge branch 'ms/tcpconns'
Florian Forster [Mon, 27 Aug 2012 06:35:29 +0000 (08:35 +0200)]
tcpconns plugin: Only chose between netlink / proc on the first iteration.
Rather than going for netlink each iteration and fall back to /proc, try
this on the first iteration only and stick with the result afterwards.
Also contains some improvements to the error handling / reporting.
Michael Stapelberg [Fri, 24 Aug 2012 21:02:26 +0000 (23:02 +0200)]
little style changes (code review)
Florian Forster [Thu, 23 Aug 2012 07:45:57 +0000 (09:45 +0200)]
src/utils_format_json.c: Remove unused arguments.
Florian Forster [Thu, 23 Aug 2012 07:44:02 +0000 (09:44 +0200)]
write_graphite: Use the broken out "format_graphite" module.
This was broken out for use in the AMQP plugin. De-duplicate the code by
using it from write_graphite as well.
Florian Forster [Thu, 23 Aug 2012 07:03:35 +0000 (09:03 +0200)]
AUTHORS: Add Thomas Meson.
Add Florian Forster to the list of copyright holders and authors of
utils_format_graphite.c, since its based on his code.
Thomas Meson [Fri, 10 Aug 2012 22:11:54 +0000 (00:11 +0200)]
amqp plugin: add support for Graphite output
This commit implements "Graphite format" for AMQP Plugin.
The AMQP plugin will be able to directly output a valid
Graphite metric format (<metric name> <value> <timestamp>\n).
This is very useful when the Graphite server is directly reading
from an AMQP broker. You can then avoid having a proxy somewhere
doing the conversion between PUTVAL or JSON metrics into Graphite
format.
Signed-off-by: Florian Forster <octo@collectd.org>
Michael Stapelberg [Tue, 7 Aug 2012 10:41:38 +0000 (12:41 +0200)]
tcpconns/linux: Use netlink instead of parsing /proc/net/tcp{,6}
Daniel Sutto [Wed, 11 Jul 2012 17:32:16 +0000 (19:32 +0200)]
Fix bad definition of UDP src port in DNS plugin.
Florian Forster [Mon, 9 Jul 2012 05:49:00 +0000 (07:49 +0200)]
collectd.conf(5): Document the "Password" option.
Florian Forster [Mon, 9 Jul 2012 05:48:40 +0000 (07:48 +0200)]
redis plugin: Coding style fixes.
biancalana [Fri, 6 Jul 2012 02:10:24 +0000 (23:10 -0300)]
redis plugin: Add authentication support.
Florian Forster [Fri, 6 Jul 2012 13:39:18 +0000 (15:39 +0200)]
src/utils_format_json.c: Various fixes for the meta data code.
* Moved to a separate function.
* Escape string values.
* Fix format string for [u]int64_t.
* Emit the JSON literals «true» and «false» rather than «0» and «1».
* Make certain keys are always freed.
* Move the meta data information into a separate map.
Mark Wong [Thu, 20 Jan 2011 23:18:14 +0000 (15:18 -0800)]
annotate meta data to json objects
Run through any metadata and annotate them to json objects when they are
created.
Florian Forster [Sat, 30 Jun 2012 01:09:57 +0000 (18:09 -0700)]
Merge pull request #96 from mstap/master
add collectd systemd service file
Michael Stapelberg [Fri, 29 Jun 2012 23:23:55 +0000 (01:23 +0200)]
describe collectd.service in contrib/README
Michael Stapelberg [Fri, 29 Jun 2012 16:45:49 +0000 (18:45 +0200)]
Add collectd systemd unit file
Florian Forster [Thu, 14 Jun 2012 12:48:15 +0000 (14:48 +0200)]
oracle plugin: Replace the o_config_set_string() function.
Florian Forster [Thu, 14 Jun 2012 12:46:03 +0000 (14:46 +0200)]
oracle plugin: Implement the "Host" option.
Florian Forster [Mon, 2 Apr 2012 08:14:12 +0000 (10:14 +0200)]
varnish plugin: Make argument "stats" const.
Florian Forster [Mon, 2 Apr 2012 08:04:23 +0000 (10:04 +0200)]
ethstat plugin: Fix a typo.
Florian Forster [Sun, 1 Apr 2012 15:15:20 +0000 (17:15 +0200)]
Bump version to 5.1.0; Update ChangeLog.
Florian Forster [Sun, 1 Apr 2012 10:07:20 +0000 (12:07 +0200)]
Merge branch 'collectd-5.0'
Florian Forster [Sun, 1 Apr 2012 10:07:09 +0000 (12:07 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0
Conflicts:
ChangeLog
Florian Forster [Sun, 1 Apr 2012 10:06:42 +0000 (12:06 +0200)]
ChangeLog: Correct date.
Florian Forster [Sun, 1 Apr 2012 10:06:24 +0000 (12:06 +0200)]
Bump version to 5.0.4; Update ChangeLog.
Florian Forster [Sun, 1 Apr 2012 10:01:58 +0000 (12:01 +0200)]
Merge branch 'collectd-4.10' into collectd-5.0
Conflicts:
ChangeLog
src/collectd.conf.pod
src/common.c
src/network.c
src/processes.c
version-gen.sh
Florian Forster [Sun, 1 Apr 2012 09:51:38 +0000 (11:51 +0200)]
Bump version to 4.10.7; Update ChangeLog.
Florian Forster [Sat, 31 Mar 2012 15:27:14 +0000 (17:27 +0200)]
Revert "Proposal fix for large "MaxPacketSize" use."
This reverts commit
12213f8dfeee3feb3846aa658def0bb79c1211d0.
Florian Forster [Fri, 23 Mar 2012 21:21:43 +0000 (22:21 +0100)]
network plugin: Do not forward received notifications.
The network plugin would send out all notifications it got through its
callback, even the ones it received itself and even when forwarding was
disabled.
With this patch the network plugin will only transmit notifications created
locally -- forwarding of notifications is not implemented due to missing
loop-detection. For loop-detection we would have to keep track of the last
timestamp of each notifications, and since each host/plugin/type/-instance
field may be empty, this is not as straight forward as with value lists. If
someone needs this, they will need to invest some work I'm afraid.
Florian Forster [Fri, 23 Mar 2012 13:17:00 +0000 (06:17 -0700)]
Merge pull request #56 from octo/ci/nfs
NFS plugin: Add Solaris support.
Florian Forster [Fri, 23 Mar 2012 12:53:39 +0000 (13:53 +0100)]
Merge branch 'ff/zfs'
Florian Forster [Fri, 23 Mar 2012 12:52:51 +0000 (13:52 +0100)]
zfs_arc plugin: Move reading of kstat values into separate functions.
This way error handling can be done in a central place and we can do this more
carefully overall.
Florian Forster [Fri, 23 Mar 2012 12:48:19 +0000 (05:48 -0700)]
Merge pull request #60 from octo/ar/zfs
more zfs kstat values
Florian Forster [Thu, 22 Mar 2012 08:05:12 +0000 (09:05 +0100)]
zfs_arc plugin: Add copyright header for Aurelien Rougemont.
Cyril Feraudet [Mon, 19 Mar 2012 10:08:06 +0000 (11:08 +0100)]
Proposal fix for large "MaxPacketSize" use.
When we use a "MaxPacketSize" over two thousand of octets (to pass huge
message in notification for example), buffer may not be flushed for a
while.
By flushing buffer when there is about 1400 octets, we're sure there is
no data too longer in.
Florian Forster [Wed, 21 Mar 2012 06:41:38 +0000 (07:41 +0100)]
zfs_arc plugin: Fix the "hash collision" and "mutex miss" metrics.
Florian Forster [Tue, 20 Mar 2012 21:40:39 +0000 (22:40 +0100)]
zfs_arc plugin: Fix typo in variable name.
Florian Forster [Tue, 20 Mar 2012 21:39:39 +0000 (22:39 +0100)]
zfs_arc plugin: Introduce the single-valued "mutex_operation" type.
Florian Forster [Tue, 20 Mar 2012 21:32:14 +0000 (22:32 +0100)]
zfs_arc plugin: Introduce the single-valued "cache_eviction" type.
Florian Forster [Tue, 20 Mar 2012 21:29:59 +0000 (22:29 +0100)]
zfs_arc plugin: Convert to use DERIVE.
Aurelien Rougemont [Thu, 1 Mar 2012 13:48:45 +0000 (14:48 +0100)]
add types for deleted, evict, hash, mutex
Signed-off-by: Florian Forster <octo@collectd.org>
Aurelien Rougemont [Thu, 1 Mar 2012 13:40:10 +0000 (14:40 +0100)]
add hash_collisions, deleted, mutex_miss, evict_*
Cosmin Ioiart [Mon, 19 Mar 2012 09:56:03 +0000 (10:56 +0100)]
Fixed Solaris compilation errors
The value returned by get_kstat_value is of type long long whereas values is a union. Fixed the code so that the value gets assigned to one of the union members, in this case counter.
Cosmin Ioiart [Mon, 19 Mar 2012 09:54:57 +0000 (10:54 +0100)]
Fixed solaris configure script generation errors
The brackets in configure.in and the changes in version-gen.sh are needed in order for the build.sh script to generate the configure script correctly. Else the generated script won't work.
Florian Forster [Mon, 19 Mar 2012 09:47:22 +0000 (10:47 +0100)]
src/common.h: Add comment about return value of read_file_contents().
Florian Forster [Sun, 18 Mar 2012 10:35:13 +0000 (11:35 +0100)]
nfs plugin: Minor coding style fixes.
Florian Forster [Sun, 18 Mar 2012 10:27:03 +0000 (11:27 +0100)]
nfs plugin: Remove duplicated code.
Changes include:
* Calculate nfs[234]_procedures_names_num at compile time.
* Made nfs_procedures_submit() more versatile, so it can be used from the Linux
and the Solaris code.
* Switched to plugin_dispatch_values_secure(), since the code is using the same
value_list_t for multiple values.
* Broke out nfs_submit_fields() from the Linux code. This removed quite a bit
of code duplication between the v2/v3 code.
* Broke out nfs_read_kstat() which does the get_kstat_value() call in a loop
rather than duplicating all the NFS procedure names.
Cosmin Ioiart [Thu, 8 Mar 2012 10:12:53 +0000 (11:12 +0100)]
Enable modules for Solaris
Enabling nfs,processes and protocols modules for Solaris when running the
configure script.
Cosmin Ioiart [Tue, 13 Mar 2012 07:38:16 +0000 (08:38 +0100)]
Fix Linux compilation errors
Fixed compilation errors for the linux platform
Cosmin Ioiart [Thu, 23 Feb 2012 14:34:32 +0000 (15:34 +0100)]
Added safe-guard for kstat libraries
Cosmin Ioiart [Thu, 23 Feb 2012 13:47:47 +0000 (14:47 +0100)]
Added Solaris support for nfs3 and nfs4 (client/server)
Florian Forster [Sun, 18 Mar 2012 08:14:54 +0000 (09:14 +0100)]
tcpconns plugin: Include <bsd/nlist.h> rather than <nlist.h>.
It appears that <nlist.h> is being deprecated / moved.
This hopefully fixes Debian bug #664429.
Florian Forster [Sat, 17 Mar 2012 10:45:44 +0000 (11:45 +0100)]
Merge branch 'jr/varnish'
Florian Forster [Sat, 17 Mar 2012 10:41:47 +0000 (03:41 -0700)]
Merge pull request #48 from octo/pk/processes
Fix processes plugin under FreeBSD.
Florian Forster [Sat, 17 Mar 2012 10:41:04 +0000 (11:41 +0100)]
processes plugin: Minimize whitespace-only changes.
Florian Forster [Sat, 17 Mar 2012 10:34:43 +0000 (11:34 +0100)]
processes plugin: Some more minor coding style fixes.
Florian Forster [Sat, 17 Mar 2012 10:20:22 +0000 (03:20 -0700)]
Merge pull request #52 from octo/cf/ethstat
ethstat support
Florian Forster [Sat, 17 Mar 2012 10:18:57 +0000 (11:18 +0100)]
ethstat plugin: Implement the "MappedOnly" option.
Florian Forster [Sat, 17 Mar 2012 09:54:37 +0000 (10:54 +0100)]
ethstat plugin: Fix indentation. It was a mess, sorry.
Florian Forster [Fri, 16 Mar 2012 17:26:08 +0000 (18:26 +0100)]
src/common.c: parse_value: Strip trailing whitespace before parsing.
This hopefully avoids the annoying "trailing garbage" message when the buffer
only contains a newline or space at the end.
Florian Forster [Fri, 16 Mar 2012 16:44:50 +0000 (17:44 +0100)]
collectd.conf(5): Document the "Hits" and "Hysteresis" threshold options.
Fixes GitHub issue #53.
Clemens Lang [Sat, 10 Mar 2012 01:30:26 +0000 (02:30 +0100)]
Makefile adds dependency on $(LIBLTDL), which is valued "-lltdl"
When building on OS X, the collectd build failed, because the collectd target
has a dependency on "-lltdl", which is the value the variable $(LIBLTDL) has.
Obviously, this should be the file name instead. I am however not sure how to
specify the correct filename in this case.
Fixes GitHub issue #54.
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Mon, 12 Mar 2012 12:35:38 +0000 (13:35 +0100)]
ethstat plugin: Implement the "Map" option.
Florian Forster [Mon, 12 Mar 2012 06:38:19 +0000 (07:38 +0100)]
ethstat plugin: Add documentation.
Florian Forster [Sun, 11 Mar 2012 18:22:06 +0000 (19:22 +0100)]
ethstat plugin: Use the system header files if available.
And disable the plugin when they are not.
Florian Forster [Sun, 11 Mar 2012 14:53:39 +0000 (15:53 +0100)]
ethstat module: Fix allocation of "ifacelist".
And remove uses of strcpy(3).
Florian Forster [Sun, 11 Mar 2012 14:49:55 +0000 (15:49 +0100)]
ethstat plugin: Fix includes.
Cyril Feraudet [Tue, 4 Oct 2011 13:00:04 +0000 (15:00 +0200)]
ethstat plugin: Collect performance statistics from NICs.
Hi all,
For my needs at work I wrote a plugin for collectd and I wish to share it with
you.
This plugins, temporary called ethstat and wrote in C, collect lot of
performance counter about network interface as "ethtool -S ethX" do by asking
NIC driver module.
At the moment this plugin work only under Linux. Any help would be great for
make it working under Solaris, AIX and co ...
If you think this plugin may be included to collectd sources, what is the
procedure to do it ?
Regards,
Cyril Feraudet
To be added to configuration file to make it work :
LoadPlugin ethstat
<Plugin ethstat>
Iface "eth0"
#Iface "eth1"
#Iface "eth2"
#Iface "eth3"
</Plugin>
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Sun, 11 Mar 2012 14:14:40 +0000 (15:14 +0100)]
varnish plugin: Simplify the v2/v3 define structs.
This somewhat duplicates the code in the read callback, but it's easier to read
than having four or so defines in one function.
Addresses GitHub issue #14.
Jérôme Renard [Tue, 20 Dec 2011 14:22:55 +0000 (15:22 +0100)]
varnish plugin: Closed VSM
Jérôme Renard [Wed, 26 Oct 2011 23:20:47 +0000 (01:20 +0200)]
varnish plugin: Switched to AC_CHECK_HEADERS
Jérôme Renard [Wed, 26 Oct 2011 23:02:39 +0000 (01:02 +0200)]
varnish plugin: Fixed wrong function name
Jérôme Renard [Wed, 26 Oct 2011 21:15:00 +0000 (23:15 +0200)]
varnish plugin: Added basic Varnish 3.0 support
Jérôme Renard [Wed, 26 Oct 2011 19:14:15 +0000 (21:14 +0200)]
varnish plugin: Added Varnish version detection flag
Florian Forster [Sun, 11 Mar 2012 13:47:24 +0000 (14:47 +0100)]
amqp plugin: Fix compabitility with current librabbitmq.
In particular, add compatibility to the 0.9.1 and current development version.
Unfortunately, no version macro exists, so we need to do some autoconf trickery
:(
Fixes GitHub issue #6.
Florian Forster [Sun, 11 Mar 2012 12:11:33 +0000 (05:11 -0700)]
Merge pull request #44 from octo/ff/perl
Fix race condition in the Perl plugin.
Florian Forster [Sun, 11 Mar 2012 12:04:13 +0000 (13:04 +0100)]
collectd.conf(5): Improve the network plugin's documentation.
The example given was confusing since it didn't make it clear enough, that only
one "Server" stanza is required.
Resolves GitHub issue #19.
Florian Forster [Sun, 11 Mar 2012 11:57:10 +0000 (12:57 +0100)]
network plugin: Fix compiler warnings.
Resolves GitHub issue #49.
Florian Forster [Sun, 11 Mar 2012 11:13:37 +0000 (12:13 +0100)]
snmp plugin: Keep track of signedness of ASN values.
Prior to this, the signed variant was used when casting to gauge_t. This caused
problems with values larger than 2^31-1, since they were casted to negative
values.
Hopefully fixes GitHub issue #50.
Florian Forster [Sun, 19 Feb 2012 22:01:35 +0000 (23:01 +0100)]
processes plugin: A few coding style fixes for the FreeBSD code.
Change-Id: I3469a605c0dc0b7ce51049636ab3f82b03fdfa17
Phil Kulin [Sun, 8 Jan 2012 16:50:27 +0000 (19:50 +0300)]
collectd-5.0.1-mine.patch some processes.c fixes for FreeBSD
I welcome from rainy Ingermanland!
Our thoughts are now occupied by Putin and vodka, however...
I have paid attention to a little incorrect data which is given out by
a processes plugin on my beautifull FreeBSD system.
I have corrected them and in process have made absolutely slightly
have improved accuracy and productivity of a processes plugin for
FreeBSD systems.
- Fix strange plural call of getpagesize(). Has entered a global
variable and initialization procedure for FreeBSD
- Data was summarized on all processes including threads. It led to
absolutely uncertain result. Fix based on codebase of FreeBSD top
programm. KERN_PROC_ALL attribute keep for future purposes.
- Gets command argument failed for some processes as system and some
other. It led to error messages to console. Fix based on codebase of
FreeBSD top programm.
- System and user CPU times turned out from the sum of miliseconds
and... Oh! microseconds in one glass with overflow possibility. Fixed.
My girlfriend has left me for such Christmas vacation, but I am
assured that have made good business.
Patch in mail attachment.
--
Non nobis Domine non nobis sed Nomini Tuo da gloriam
Phil Kulin
Change-Id: Ib88faadf5a0fd335b426e9024b0a2e438ddbaf1f
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Fri, 9 Mar 2012 15:58:15 +0000 (16:58 +0100)]
write_mongodb plugin: Fix reconnection behavior.
The previous code would never detect a disconnect and act appropriately. In the
process, manual tracking of the connection state is removed in favor of
mongo_is_connected().
Florian Forster [Wed, 7 Mar 2012 10:10:06 +0000 (11:10 +0100)]
write_mongodb plugin: Export DS names and DS types.
The values are exported as an array now. This is very close to the way data is
exported as JSON.
Florian Forster [Wed, 7 Mar 2012 09:54:36 +0000 (01:54 -0800)]
Merge pull request #43 from octo/ff/numa
numa plugin: Add plugin for Non-Uniform Memory Access (NUMA).
Florian Forster [Wed, 7 Mar 2012 09:53:21 +0000 (10:53 +0100)]
collectd.conf.in: Add the numa plugin.
Florian Forster [Mon, 5 Mar 2012 09:35:58 +0000 (10:35 +0100)]
write_mongodb plugin: Actually store time as "date" type.
Jason Schmidlapp [Thu, 1 Mar 2012 01:27:50 +0000 (20:27 -0500)]
Fixed memory leak in collectdclient library.
Signed-off-by: Florian Forster <octo@collectd.org>