Florian Forster [Fri, 6 Dec 2013 09:52:22 +0000 (10:52 +0100)]
src/oping.h: Don't use the ncurses internal _nc_unicode_locale() function.
The "-u" and "-U" options are now handled in a single variable so that the
last option "wins".
Antoine Beaupré [Fri, 6 Dec 2013 05:16:28 +0000 (00:16 -0500)]
add commandline flag for forcing or disabling unicode
note that "forcing" may not work: ncurses still expects your locale to
be correct, so maybe the force flag should also explicitely set a utf8
locale?
Antoine Beaupré [Fri, 6 Dec 2013 05:07:09 +0000 (00:07 -0500)]
move unicode detection to a separate function
this will ease transition to a commandline option override
Antoine Beaupré [Fri, 6 Dec 2013 04:35:00 +0000 (23:35 -0500)]
autodetect unicode, and fallback to ACS scancodes on failure
this is fairly ugly - we use a hidden ncurses function to detect
unicode (but at least we don't reimplement it), then we mess around
with the character arrays to display the rights symbols
i am not sure i like this, but i prefer to braindump than to stall, so
let's move forward.
Florian Forster [Thu, 5 Dec 2013 17:15:52 +0000 (18:15 +0100)]
Refactor the graph printing into its own function.
This makes it much easier and cleaner to add a second, non-Unicode
implementation and possibly even a non-color version.
Antoine Beaupré [Tue, 3 Dec 2013 05:33:39 +0000 (00:33 -0500)]
switch to ncursesw in the build chain
Antoine Beaupré [Tue, 3 Dec 2013 04:15:13 +0000 (23:15 -0500)]
better wrapping: add a cursor and respect inner borders
Antoine Beaupré [Tue, 3 Dec 2013 03:57:00 +0000 (22:57 -0500)]
rework scaling algorithm so it covers the whole range
i did this after some stress testing, now it covers the whole range on input
Antoine Beaupré [Tue, 3 Dec 2013 03:32:46 +0000 (22:32 -0500)]
cleanup safety checks
make sure that if we go beyond the max ratio, we just mark it as one
Antoine Beaupré [Tue, 3 Dec 2013 03:32:15 +0000 (22:32 -0500)]
wrap around the window once the histogram grows too big
Antoine Beaupré [Tue, 3 Dec 2013 03:29:53 +0000 (22:29 -0500)]
remove a little quirk i introduced by mistake
this was breaking the border
Antoine Beaupré [Tue, 3 Dec 2013 03:29:24 +0000 (22:29 -0500)]
make histogram colors with a nicer background
Antoine Beaupré [Tue, 3 Dec 2013 03:10:41 +0000 (22:10 -0500)]
restore usual ping display, now that histograms are in a different window
Antoine Beaupré [Tue, 3 Dec 2013 03:06:26 +0000 (22:06 -0500)]
put histograms into the independent window, to eventually restore ping times display
Antoine Beaupré [Tue, 3 Dec 2013 01:45:58 +0000 (20:45 -0500)]
implement some prettyping-inspired display instead of textual
this is a first stab at porting "prettyping.sh" into noping. the idea
is to show a histogram of ping times instead of numerical values. with
some work, we could actually show both, but this focuses on
implementing the hard part (the histogram) properly.
it is very rudimentary for now:
* the math may be wrong for the size of the bar, I was mostly in a
rush to make unicode work and have something pretty quickly.
* all hosts are on the same line: each should have its own line
* the histogram should be displayed in a separate window
* it should use background colors as well
* it should fallback when the terminal is not unicode-capable
* the scaling logic is fully automatic, which necessarily gives weird
results at first
this requires switching to the ncursesw library and other unicode
ncurses hackery described in this post:
http://newsgroups.derkeiler.com/Archive/Rec/rec.games.roguelike.development/2010-09/msg00050.html
pretty ping is a awk/bash script, MIT-licensed, available here:
https://bitbucket.org/denilsonsa/small_scripts/src/tip/prettyping.sh
Florian Forster [Tue, 31 Jan 2012 16:20:15 +0000 (17:20 +0100)]
Bump ABI version; update ChangeLog.
Clayton O'Neill [Sun, 30 Oct 2011 23:36:46 +0000 (19:36 -0400)]
Mac OX S 10.7 compile fixes.
I've attached a patch that's required to be able to compile liboping on
MacOS 10.7 (Lion). The issue is that the IPv6 API's are changing from
RFC 2292 to 3542, and Apple's headers require you to state which API you
want to use by defining a constant. I've changed it to use either based
on the presence of constants, but to prefer 3542 on MacOS.
One problem I see with this is that if you have both multicast and
unicast TTL's set, then this won't report both of them, but I'm not sure
if that's even valid and it would require more significant rework.
Also, I noticed you have fixed the IP_RECVTOS issue in head. That patch
is also required to be able to compile on Solaris and MacOS.
Signed-off-by: Florian Forster <octo@verplant.org>
Barak A. Pearlmutter [Thu, 1 Sep 2011 11:48:57 +0000 (12:48 +0100)]
guard use of IP_RECVTOS which is unavailable on kfreebsd
Florian Forster [Sat, 27 Aug 2011 15:12:19 +0000 (17:12 +0200)]
configure.ac: autoconf 2.65 works just fine, too.
Florian Forster [Fri, 2 Sep 2011 02:55:32 +0000 (22:55 -0400)]
README: Add note about capabilities.
Florian Forster [Sun, 13 Mar 2011 19:26:43 +0000 (20:26 +0100)]
Manual pages: Update the copyright information.
Florian Forster [Sun, 13 Mar 2011 19:18:47 +0000 (20:18 +0100)]
Bump version to 1.6.2; Update ChangeLog.
Florian Forster [Sat, 27 Aug 2011 15:12:19 +0000 (17:12 +0200)]
configure.ac: autoconf 2.67 works just fine.
Florian Forster [Sat, 27 Aug 2011 15:00:37 +0000 (08:00 -0700)]
Merge pull request #1 from barak/master
upstream update + tweaks
Barak A. Pearlmutter [Sun, 21 Aug 2011 13:32:21 +0000 (15:32 +0200)]
git ignore more build debris
Barak A. Pearlmutter [Sun, 21 Aug 2011 13:03:11 +0000 (15:03 +0200)]
Update configure.ac and Makefile.am per autotools
Tweak configure.ac and Makefile.am per autoreconf instructions.
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
libtoolize: `AC_PROG_RANLIB' is rendered obsolete by `LT_INIT'
Accept autoupdate modifications.
Manually integrate portions of autoscan configure.scan.
Florian Forster [Thu, 10 Mar 2011 16:10:16 +0000 (17:10 +0100)]
src/Makefile.am: Make setcap and chmod fault-tolerant.
This is required because this weird Debian fakeroot utility gives the
impression as if the install was run by root, when in fact it isn't.
What good this should do is beyond me.
Florian Forster [Mon, 7 Mar 2011 08:12:06 +0000 (09:12 +0100)]
src/liboping.c: Fix a compiler warning
… regarding a non-static format string. Thanks to Brian Edwards for
reporting this problem.
Florian Forster [Sun, 6 Mar 2011 08:46:54 +0000 (09:46 +0100)]
Bump version to 1.6.1; Update ChangeLog.
Florian Forster [Sun, 6 Mar 2011 08:41:02 +0000 (09:41 +0100)]
Update and unify copyright headers.
Florian Forster [Sun, 6 Mar 2011 08:34:22 +0000 (09:34 +0100)]
Build system: Automatically set capabilities flag / set-UID bit when installing as root.
Gaetan Bisson [Mon, 28 Feb 2011 13:41:24 +0000 (14:41 +0100)]
noping: Fix compatibility with ncurses 5.8.
Hello,
My name is Gaetan and I maintain liboping in Arch Linux; our distro is
in the process of switching to ncurses-5.8, and I wanted to report that
I had to patch liboping to make noping work with the newer ncurses.
Specifically, if I update ncurses and run the old noping binary, then
nothing is displayed in the ncurses window (although the summary output
displayed on stdout at the end is correct). Same if I recompile noping
against the new ncurses library.
The reason seems to be that calling newwin() with ncols=0 does not
produce a full width window anymore. Anyway, the simple patch attached
fixed this issue for me.
Cheers.
Signed-off-by: Florian Forster <octo@verplant.org>
Florian Forster [Wed, 16 Feb 2011 08:45:35 +0000 (09:45 +0100)]
src/oping.c: Fix a compiler warning about uninitialized variables.
Some verions of GGC don't notice that usage_qos_exit() won't return and
complain about the variables "prec" and "class" being used uninitalized.
This commit adds the "noreturn" attribute to that function and
initializes the variables. Thanks to James Bromberger for reporting this
problem.
Florian Forster [Wed, 26 Jan 2011 08:48:28 +0000 (09:48 +0100)]
Bump version to 1.6.0; Update ChangeLog.
Florian Forster [Wed, 26 Jan 2011 08:45:11 +0000 (09:45 +0100)]
README: Remove whitespace.
Florian Forster [Sat, 15 Jan 2011 19:36:25 +0000 (20:36 +0100)]
src/liboping.c: Change coding style a bit.
Bruno Prémont [Sat, 15 Jan 2011 18:44:49 +0000 (19:44 +0100)]
liboping: use SO_TIMESTAMP when available
Current implementation of liboping relies on getting enough CPU shares
and getting those in a timely manner in order to determine correct ping
response times.
Avoid this limitation when kernel is able to provide packet reception
times using SO_TIMESTAMP. (as is done by iputils's ping utility)
Signed-off-by: Florian Forster <octo@verplant.org>
Florian Forster [Sat, 27 Nov 2010 12:24:59 +0000 (13:24 +0100)]
README: Document Linux capabilities and UNIX set-UID root solutions.
Florian Forster [Wed, 17 Nov 2010 10:04:47 +0000 (11:04 +0100)]
oping(8): Document the new SetUID behavior in connection with the "-f" option.
Florian Forster [Wed, 17 Nov 2010 09:09:47 +0000 (10:09 +0100)]
Bump version to 1.5.1; Update ChangeLog.
Florian Forster [Wed, 17 Nov 2010 09:02:56 +0000 (10:02 +0100)]
src/oping.c: Mark unused argument to avoid compiler warnings.
Florian Forster [Wed, 17 Nov 2010 09:02:37 +0000 (10:02 +0100)]
src/oping.c: Remove __attribute__ flags when using non-GNU compiler.
Florian Forster [Wed, 17 Nov 2010 08:01:19 +0000 (09:01 +0100)]
src/liboping.c: Always set the QoS member. Default to 0.
This should fix the following warning / error:
liboping.c:599: warning: comparison is always true due to limited
range of data type
Thanks to James Bromberger for reporting this!
Florian Forster [Fri, 29 Oct 2010 08:09:58 +0000 (10:09 +0200)]
oping: Add alias for the "Voice Admit" DSCP.
Florian Forster [Wed, 27 Oct 2010 13:40:32 +0000 (15:40 +0200)]
Bump version to 1.5.0; Update ChangeLog.
Florian Forster [Wed, 27 Oct 2010 13:40:06 +0000 (15:40 +0200)]
ping_iterator_get_info(3): Document the "PING_INFO_RECV_QOS" flag.
Florian Forster [Wed, 27 Oct 2010 13:18:15 +0000 (15:18 +0200)]
src/oping.h: Change the default payload message.
Florian Forster [Wed, 27 Oct 2010 12:32:13 +0000 (14:32 +0200)]
Merge branch 'vm/qos'
Florian Forster [Wed, 27 Oct 2010 12:31:54 +0000 (14:31 +0200)]
oping(8): Document the displayed "qos=" field.
Florian Forster [Wed, 27 Oct 2010 10:11:51 +0000 (12:11 +0200)]
src/oping.c: Only print QoS information if it's not 0/0.
Florian Forster [Wed, 27 Oct 2010 09:27:42 +0000 (11:27 +0200)]
AUTHORS: Add Vladimir Melnikov.
Florian Forster [Wed, 27 Oct 2010 09:05:35 +0000 (11:05 +0200)]
src/oping.c: Add function for formatted printing of the QoS byte.
Florian Forster [Wed, 27 Oct 2010 08:30:40 +0000 (10:30 +0200)]
oping(8): Document the "be" and "cs<n>" DSCP abbreviations.
Florian Forster [Wed, 27 Oct 2010 07:59:09 +0000 (09:59 +0200)]
Rename "ToS" to "QoS" everywhere, to account for DSCP being used in IPv6 …
… and recommended for IPv4.
Florian Forster [Wed, 27 Oct 2010 07:53:18 +0000 (09:53 +0200)]
src/oping.c: Remove useless "strlen".
Florian Forster [Wed, 27 Oct 2010 06:58:08 +0000 (08:58 +0200)]
src/oping.c: Add the "be" and "cs[0-7]" DSCPs.
Florian Forster [Tue, 26 Oct 2010 16:22:37 +0000 (18:22 +0200)]
oping(8): Document the "-Q" option.
Florian Forster [Tue, 26 Oct 2010 15:42:38 +0000 (17:42 +0200)]
src/oping.c: Implement named arguments for DiffServ flags.
Florian Forster [Tue, 26 Oct 2010 14:20:51 +0000 (16:20 +0200)]
oping: Improve parsing of the "-z" argument.
Florian Forster [Tue, 26 Oct 2010 13:49:09 +0000 (15:49 +0200)]
Fix printing the ToS value.
Apparently "%#04x" prints 0 as "0000" instead of "0x00". *sigh*
Florian Forster [Tue, 26 Oct 2010 13:48:24 +0000 (15:48 +0200)]
ping_set_tos: Improve error handling.
Florian Forster [Tue, 26 Oct 2010 13:47:49 +0000 (15:47 +0200)]
ping_receive_one: Fix a typo.
Florian Forster [Tue, 26 Oct 2010 13:17:10 +0000 (15:17 +0200)]
src/liboping.c: Fix building with debugging enabled.
Florian Forster [Tue, 26 Oct 2010 13:11:24 +0000 (15:11 +0200)]
Rename "PING_INFO_TOS" → "PING_INFO_RECV_TOS".
Florian Forster [Tue, 26 Oct 2010 13:10:04 +0000 (15:10 +0200)]
ping_setopt(3): Document the new "PING_OPT_TOS" option.
Florian Forster [Tue, 26 Oct 2010 13:09:45 +0000 (15:09 +0200)]
src/liboping.c: Set the "IP_RECVTOS" and "IPV6_RECVTCLASS" socket options.
Florian Forster [Tue, 26 Oct 2010 13:09:10 +0000 (15:09 +0200)]
src/liboping.c: Use an uint8_t for storing the ToS.
Vladimir Melnikov [Tue, 26 Oct 2010 12:20:03 +0000 (14:20 +0200)]
Implement support for QoS / ToS fields.
Hello Florian,
I've made some functionality extension to debug QoS in the network -
ability to set tos (present in most standard "pings") and to verify
received tos field (didn't see any ping command with this feature).
May be it will need to someone else.
Best regards,
Vladimir
Florian Forster [Tue, 13 Jul 2010 14:07:53 +0000 (16:07 +0200)]
src/Makefile.am: Use "LDADD" for applications, "LIBADD" for the library.
Use "LDFLAGS" only for "-version-info".
Florian Forster [Sun, 27 Jun 2010 09:52:01 +0000 (11:52 +0200)]
Relicense: Use the LGPL v2.1 (or later) for liboping.
The "oping" and "noping" utilities are still GPL v2.
Sebastian Harl, the only other copyright holder on the library, agrees
with this license change.
Florian Forster [Sun, 13 Jun 2010 18:33:57 +0000 (20:33 +0200)]
oping(8): Document the colors used by noping.
Florian Forster [Sun, 13 Jun 2010 17:58:30 +0000 (19:58 +0200)]
Bumbed version to 1.4.0, updated ChangeLog.
Florian Forster [Sun, 13 Jun 2010 17:50:26 +0000 (19:50 +0200)]
oping(8): Document "noping", too.
Florian Forster [Sun, 13 Jun 2010 17:47:55 +0000 (19:47 +0200)]
README: Document "oping" and "noping".
Florian Forster [Sun, 13 Jun 2010 17:39:30 +0000 (19:39 +0200)]
README: Convert to Unicode.
Florian Forster [Sun, 13 Jun 2010 17:35:29 +0000 (19:35 +0200)]
src/oping.c: Define NCURSES_OPAQUE.
Florian Forster [Sat, 12 Jun 2010 14:04:02 +0000 (16:04 +0200)]
src/oping.c: Resizing the scrolling region seems to work with this parameters.
I don't understand what I'm doing different to previously, but whatever
it is it seems to do the trick.
Florian Forster [Fri, 11 Jun 2010 22:28:01 +0000 (00:28 +0200)]
noping: Further cleanup of the curses stuff.
Florian Forster [Tue, 8 Jun 2010 16:43:11 +0000 (18:43 +0200)]
noping: Use colors to highlight "unusual" response times.
Florian Forster [Tue, 8 Jun 2010 16:04:11 +0000 (18:04 +0200)]
noping: Print host name in bold.
Florian Forster [Tue, 8 Jun 2010 15:52:38 +0000 (17:52 +0200)]
noping: Handle resizing of X windows gracefully.
Florian Forster [Tue, 8 Jun 2010 14:02:46 +0000 (16:02 +0200)]
src/oping.c: Move "context_get_packet_loss" into a separate function.
Florian Forster [Tue, 8 Jun 2010 08:20:59 +0000 (10:20 +0200)]
src/oping.c: Move calculation of average and stddev to separate functions.
Florian Forster [Tue, 8 Jun 2010 07:37:33 +0000 (09:37 +0200)]
src/oping.c: Add ncurses based front-end.
Florian Forster [Tue, 8 Jun 2010 07:27:48 +0000 (09:27 +0200)]
src/oping.c: Move printing header and footer into separate functions.
Florian Forster [Tue, 26 Jan 2010 20:11:51 +0000 (21:11 +0100)]
contrib/liboping.spec: Added "provided as is" header.
Benjamin Petrin [Tue, 26 Jan 2010 20:06:13 +0000 (21:06 +0100)]
contrib/liboping.spec: Added example spec file.
I'm using collectd and the ping plugin for a project I'm working on. I noticed
that collectd is distributing a starter spec file for building RPMs but that
there wa s no such spec file for liboping. I created one which I have attached
to this email. I'm not too familiar with creating RPMs but I think it's a good
start and I was able to get a package built and installed using it. I'm giving
it to you so if you wish to put in on your website for others to start with
when creating packages t hen you may. I hope others may find this useful.
Vadim Zeitlin [Sun, 20 Dec 2009 20:45:48 +0000 (21:45 +0100)]
minor doc fixes for liboping
Hello,
I was reading the documentation of your liboping library as I'd like to
use it for a small project of mine and couldn't help noticing a few typos
in the docs, please find attached a tiny patch fixing them.
Thanks for writing this library!
VZ
Signed-off-by: Florian Forster <octo@verplant.org>
Florian Forster [Sun, 20 Dec 2009 11:13:28 +0000 (12:13 +0100)]
ChangeLog: Oops, there were actually a couple more changes in that release.
Florian Forster [Sun, 20 Dec 2009 09:25:51 +0000 (10:25 +0100)]
Bumped version to 1.3.4 and updated ChangeLog.
Florian Forster [Thu, 10 Dec 2009 15:43:54 +0000 (16:43 +0100)]
src/liboping.c: ping_receive_all: Clear the timer when a FD signals an error.
The loop likely never ends if the error isn't handled, so the least we
can do is ignore the file descriptor in the future.
Florian Forster [Thu, 1 Oct 2009 12:33:02 +0000 (14:33 +0200)]
bindings/perl: Bumped version to 1.21 and updated Changes.
Fredrik Soderblom [Thu, 1 Oct 2009 12:24:46 +0000 (14:24 +0200)]
bindings/perl/Oping.xs: Fix an off-by-one error when allocating a Perl string.
In the previous code the null byte was included in the Perl string,
making the string handling awkward.
Florian Forster [Thu, 1 Oct 2009 08:28:10 +0000 (10:28 +0200)]
oping: Temporarily drop privileges if supported by the system.
This tries to solve the read-from-any-file-issue more elegantly by
dropping privileges first thing after start-up and regaining privileges
just to open the sockets.
This has the advantage that the "-f" option is available for all users
again and files are opened according to *their* permissions.
Systems not supporting the _POSIX_SAVED_IDS feature still behave as
before, i. e. if real and effective user IDs don't match, only "-" may
be specified as input file.
Florian Forster [Tue, 29 Sep 2009 16:10:57 +0000 (18:10 +0200)]
ChangeLog: Updated the changelog to reflect the last change.
Florian Forster [Tue, 29 Sep 2009 16:09:27 +0000 (18:09 +0200)]
oping: Allow “-f -” even if uid and euid differ.
Thanks to Sebastian for the idea :)
Florian Forster [Tue, 29 Sep 2009 16:00:25 +0000 (18:00 +0200)]
Bumped version to 1.3.3; Updated ChangeLog.
Florian Forster [Tue, 29 Sep 2009 15:44:05 +0000 (17:44 +0200)]
oping: Disable the “-f” option when real and effective user IDs don't match.
Thanks to Steve Kemp who reported this issue as Debian bug #548684.
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548684>
Florian Forster [Mon, 27 Jul 2009 08:31:11 +0000 (10:31 +0200)]
Bumped version to 1.3.2; Updated ChangeLog.
Sebastian Harl [Wed, 22 Jul 2009 13:35:55 +0000 (15:35 +0200)]
src/oping.h: Do not check HAVE_*_H for system headers.
Imho, this is not a good thing to do for an installed header since it requires
every user to define those macros as well.