From: oetiker Date: Sat, 21 Jul 2007 19:53:52 +0000 (+0000) Subject: for now, do not release fetched data ... in the future we may call rrd_dontneed and... X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=fe9e42840cd23de01465e48a2ab6e9ac337dfed2;p=rrdtool.git for now, do not release fetched data ... in the future we may call rrd_dontneed and let the users decied with an option if they want to keep the data in cache ... git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1165 a5681a0c-68f1-0310-ab6d-d61299d08faa --- diff --git a/src/rrd_fetch.c b/src/rrd_fetch.c index c065793..b419f53 100644 --- a/src/rrd_fetch.c +++ b/src/rrd_fetch.c @@ -420,17 +420,6 @@ int rrd_fetch_fn( rrd_set_error("fetching cdp from rra"); goto err_free_data; } -#ifdef HAVE_POSIX_FADVISE - /* don't pollute the buffer cache with data read from the file. We do this while reading to - keep damage minimal */ - if (0 != - posix_fadvise(rrd_file->fd, rrd_file->header_len, 0, - POSIX_FADV_DONTNEED)) { - rrd_set_error("setting POSIX_FADV_DONTNEED on '%s': %s", - filename, rrd_strerror(errno)); - goto err_close; /*XXX: should use err_free_all_ds_namv */ - } -#endif #ifdef DEBUG fprintf(stderr, "post fetch %li -- ", i); @@ -445,16 +434,7 @@ int rrd_fetch_fn( #endif } -#ifdef HAVE_POSIX_FADVISE - /* and just to be sure we drop everything except the header at the end */ - if (0 != - posix_fadvise(rrd_file->fd, rrd_file->header_len, 0, - POSIX_FADV_DONTNEED)) { - rrd_set_error("setting POSIX_FADV_DONTNEED on '%s': %s", filename, - rrd_strerror(errno)); - goto err_free; /*XXX: should use err_free_all_ds_namv */ - } -#endif + rrd_close(rrd_file); return (0); err_free_data: