From: Junio C Hamano Date: Sat, 23 Jul 2005 02:09:05 +0000 (-0700) Subject: [PATCH] Audit rev-parse users. X-Git-Tag: v0.99.2~30 X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=f6e1a4d6dc4d1b3d82d5e87fdd817b3994dda5e0;p=git.git [PATCH] Audit rev-parse users. This patch changes rev-parse users that pass a single argument that is supposed to be a rev parameter to use "--verify". Signed-off-by: Junio C Hamano Signed-off-by: Junio C Hamano --- diff --git a/git-checkout-script b/git-checkout-script index 7e70338c..a3774071 100755 --- a/git-checkout-script +++ b/git-checkout-script @@ -22,7 +22,7 @@ while [ "$#" != "0" ]; do force=1 ;; *) - rev=$(git-rev-parse --verify --revs-only "$arg^0") || exit + rev=$(git-rev-parse --verify "$arg^0") || exit if [ -z "$rev" ]; then echo "unknown flag $arg" exit 1 diff --git a/git-cherry b/git-cherry index e2a1a2db..f3bfbf3a 100755 --- a/git-cherry +++ b/git-cherry @@ -28,11 +28,11 @@ The output is intended to be used as: ' case "$#" in -1) linus=`git-rev-parse "$1"` && - junio=`git-rev-parse HEAD` || exit +1) linus=`git-rev-parse --verify "$1"` && + junio=`git-rev-parse --verify HEAD` || exit ;; -2) linus=`git-rev-parse "$1"` && - junio=`git-rev-parse "$2"` || exit +2) linus=`git-rev-parse --verify "$1"` && + junio=`git-rev-parse --verify "$2"` || exit ;; *) echo >&2 "$usage"; exit 1 ;; esac diff --git a/git-commit-script b/git-commit-script index 04d16ae9..dae487f3 100755 --- a/git-commit-script +++ b/git-commit-script @@ -16,7 +16,7 @@ do -m) shift case "$#" in 0) usage ;; - *) use_commit=`git-rev-parse "$1"` || + *) use_commit=`git-rev-parse --verify "$1"` || exit ;; esac ;; diff --git a/git-rebase-script b/git-rebase-script index 10ab700d..5b791c6b 100755 --- a/git-rebase-script +++ b/git-rebase-script @@ -11,11 +11,11 @@ upstream tree.' : ${GIT_DIR=.git} case "$#" in -1) linus=`git-rev-parse "$1"` && - junio=`git-rev-parse HEAD` || exit +1) linus=`git-rev-parse --verify "$1"` && + junio=`git-rev-parse --verify HEAD` || exit ;; -2) linus=`git-rev-parse "$1"` && - junio=`git-rev-parse "$2"` || exit +2) linus=`git-rev-parse --verify "$1"` && + junio=`git-rev-parse --verify "$2"` || exit ;; *) echo >&2 "$usage"; exit 1 ;; esac diff --git a/git-resolve-script b/git-resolve-script index fffcb07d..52dd83ba 100755 --- a/git-resolve-script +++ b/git-resolve-script @@ -6,8 +6,8 @@ # . git-sh-setup-script || die "Not a git archive" -head=$(git-rev-parse --revs-only "$1") -merge=$(git-rev-parse --revs-only "$2") +head=$(git-rev-parse --verify "$1") +merge=$(git-rev-parse --verify "$2") merge_msg="$3" dropheads() {