From: Thorsten von Eicken <tve@voneicken.com>
Date: Sun, 30 Mar 2008 17:16:20 +0000 (+0200)
Subject: rrdtool plugin: Reduce the filesize of files created per default.
X-Git-Tag: collectd-4.4.0~56
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=e8871c4de3f5f070efe3461a1362ccee4d5dec58;p=collectd.git

rrdtool plugin: Reduce the filesize of files created per default.

When creating an RRD file, the rrdtool plugin doesn't do what it's supposed to
do. Instead of creating 5 RRAs it creates 4 and in doing so it skips the first
one. The result is about 2x the number of datapoints total. The fix below works
for me. It's for 4.2.2 but it looks like this hasn't changed in the latest 4.3
beta.

Resolves: #5
---

diff --git a/src/rrdtool.c b/src/rrdtool.c
index ab245241..93c9d7a8 100644
--- a/src/rrdtool.c
+++ b/src/rrdtool.c
@@ -195,7 +195,7 @@ static int rra_get (char ***ret, const value_list_t *vl)
 		span = rts[i];
 
 		if ((span / ss) < rrarows)
-			continue;
+			span = ss * rrarows;
 
 		if (cdp_len == 0)
 			cdp_len = 1;