From: Sergey Vlasov Date: Fri, 23 Sep 2005 12:28:33 +0000 (+0400) Subject: [PATCH] Fix "git-local-fetch -s" with packed source repository X-Git-Tag: v0.99.7c~2^2~3 X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=e2b77f026a251a47ebdf634107e76f7b457087af;p=git.git [PATCH] Fix "git-local-fetch -s" with packed source repository "git-local-fetch -s" did not work with a packed repository, because symlink() happily created a link to a non-existing object file, therefore fetch_file() always returned success, and fetch_pack() was not called. Fixed by calling stat() before symlink() to ensure the file really exists. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano --- diff --git a/local-fetch.c b/local-fetch.c index a3e35f9c..6216c68a 100644 --- a/local-fetch.c +++ b/local-fetch.c @@ -65,9 +65,17 @@ static int copy_file(const char *source, const char *dest, const char *hex) return -1; } } - if (use_symlink && !symlink(source, dest)) { - pull_say("symlink %s\n", hex); - return 0; + if (use_symlink) { + struct stat st; + if (stat(source, &st)) { + fprintf(stderr, "cannot stat %s: %s\n", source, + strerror(errno)); + return -1; + } + if (!symlink(source, dest)) { + pull_say("symlink %s\n", hex); + return 0; + } } if (use_filecopy) { int ifd, ofd, status;