From: Florian Forster <octo@crystal.wlan.home.verplant.org>
Date: Fri, 20 Apr 2007 06:33:07 +0000 (+0200)
Subject: rrdtool plugin: config: Copy `value' before modifying it.
X-Git-Tag: collectd-4.0.0~77
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=c6597ef738a9b8633e09546c93859402f7598e1e;p=collectd.git

rrdtool plugin: config: Copy `value' before modifying it.
---

diff --git a/src/rrdtool.c b/src/rrdtool.c
index 814b3e39..b4bb3fbe 100644
--- a/src/rrdtool.c
+++ b/src/rrdtool.c
@@ -772,9 +772,14 @@ static int rrd_config (const char *key, const char *value)
 		char *saveptr = NULL;
 		char *dummy;
 		char *ptr;
+		char *value_copy;
 		int *tmp_alloc;
 
-		dummy = value;
+		value_copy = strdup (value);
+		if (value_copy == NULL)
+			return (1);
+
+		dummy = value_copy;
 		while ((ptr = strtok_r (dummy, ", \t", &saveptr)) != NULL)
 		{
 			dummy = NULL;
@@ -784,6 +789,7 @@ static int rrd_config (const char *key, const char *value)
 			if (tmp_alloc == NULL)
 			{
 				fprintf (stderr, "rrdtool: realloc failed.\n");
+				free (value_copy);
 				return (1);
 			}
 			rra_timespans_custom = tmp_alloc;
@@ -791,7 +797,7 @@ static int rrd_config (const char *key, const char *value)
 			if (rra_timespans_custom[rra_timespans_custom_num] != 0)
 				rra_timespans_custom_num++;
 		} /* while (strtok_r) */
-
+		free (value_copy);
 	}
 	else if (strcasecmp ("XFF", key) == 0)
 	{