From: Andrés J. Díaz <ajdiaz@connectical.com>
Date: Mon, 18 May 2009 12:09:11 +0000 (+0200)
Subject: src/plugin.c: Initiate the threshold checking again.
X-Git-Tag: collectd-4.6.3~11
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=b235b6a85baf902d4c8e11095310f20462c103a2;p=collectd.git

src/plugin.c: Initiate the threshold checking again.

Hi,

I have the same problem in my instalation, exactly the same scenario, I found a
possible explanation in the plugin.c module. While in the 4.5 branch exists a
callback to function ut_check_threshold (defined in utils_threshold.c), in the
4.6.2 (and also in 4.6.1, I think), the callback is missing, so threshold
checking never runs.

In fact, a grep -r ut_check_threshold over src dir, only show the definition of
the function in ut_check_threshold module.

I'm not sure if it's really a bug, but when I patched my code, it works fine
for me :) I'm using the 4.6.2 version from tar.gz.

Best regards,
  Andrés

The regression was introduced in 65954d9b.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
---

diff --git a/src/plugin.c b/src/plugin.c
index 74565c35..a3a71611 100644
--- a/src/plugin.c
+++ b/src/plugin.c
@@ -961,6 +961,9 @@ int plugin_dispatch_values (value_list_t *vl)
 	/* Update the value cache */
 	uc_update (ds, vl);
 
+	/* Initiate threshold checking */
+	ut_check_threshold (ds, vl);
+
 	if (post_cache_chain != NULL)
 	{
 		status = fc_process_chain (ds, vl, post_cache_chain);