From: Mark Wooding <mdw@distorted.org.uk>
Date: Wed, 1 Feb 2006 11:44:39 +0000 (+0000)
Subject: http-fetch: Tidy control flow in process_alternate_response
X-Git-Tag: v1.2.0~57^3
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=a3f583cbf7929f290a47dc0a952ee6b0faa9d279;p=git.git

http-fetch: Tidy control flow in process_alternate_response

It's a bit convoluted.  Tidy it up.

Signed-off-by: Mark Wooding <mdw@distorted.org.uk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/http-fetch.c b/http-fetch.c
index 555e95d5..bddbd6b1 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -468,13 +468,11 @@ static void process_alternates_response(void *callback_data)
 					 alt_req->url);
 			active_requests++;
 			slot->in_use = 1;
-			if (start_active_slot(slot)) {
-				return;
-			} else {
+			if (!start_active_slot(slot)) {
 				got_alternates = -1;
 				slot->in_use = 0;
-				return;
 			}
+			return;
 		}
 	} else if (slot->curl_result != CURLE_OK) {
 		if (slot->http_code != 404 &&