From: Sebastian Harl <sh@tokkee.org>
Date: Fri, 20 Feb 2009 12:20:02 +0000 (+0100)
Subject: perl plugin: Deprecated the use of plugin_register() to register data-sets.
X-Git-Tag: collectd-4.7.0~133
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=8f4bc7d5dcaf6fb96caa8d222382916990cbdac1;p=collectd.git

perl plugin: Deprecated the use of plugin_register() to register data-sets.

A custom types.db file should be used instead.
---

diff --git a/src/collectd-perl.pod b/src/collectd-perl.pod
index acb8abda..0f48ba58 100644
--- a/src/collectd-perl.pod
+++ b/src/collectd-perl.pod
@@ -297,6 +297,10 @@ there is a large number of predefined data-sets available in the B<types.db>
 file which are automatically registered with collectd - see L<types.db(5)> for
 a description of the format of this file.
 
+B<Note>: Using B<plugin_register> to register a data-set is deprecated. Add
+the new type to a custom L<types.db(5)> file instead. This functionality might
+be removed in a future version of collectd.
+
 If the I<type> argument is any of the other types (B<TYPE_INIT>, B<TYPE_READ>,
 ...) then I<data> is expected to be a function name. If the name is not
 prefixed with the plugin's package name collectd will add it automatically.
diff --git a/src/perl.c b/src/perl.c
index 142e9c0e..efd13abd 100644
--- a/src/perl.c
+++ b/src/perl.c
@@ -1527,6 +1527,9 @@ static XS (Collectd_plugin_register_ds)
 
 	dXSARGS;
 
+	log_warn ("Using plugin_register() to register new data-sets is "
+			"deprecated - add new entries to a custom types.db instead.");
+
 	if (2 != items) {
 		log_err ("Usage: Collectd::plugin_register_data_set(type, dataset)");
 		XSRETURN_EMPTY;