From: Marco Roeland <marco.roeland@xs4all.nl>
Date: Sat, 11 Mar 2006 08:55:50 +0000 (+0100)
Subject: imap-send: cleanup execl() call to use NULL sentinel instead of 0
X-Git-Tag: v1.3.0-rc1~21^2~14
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=8e7f9035b8271469747e3745aa7e095e12f74e5e;p=git.git

imap-send: cleanup execl() call to use NULL sentinel instead of 0

Some versions of gcc check that calls to the exec() family have the proper
sentinel for variadic calls. This should be (char *) NULL according to the
man page. Although for all other purposes the 0 is equivalent, gcc
nevertheless does emit a warning for 0 and not for NULL. This also makes the
usage consistent throughout git.

The whitespace in function calls throughout imap-send.c has its own style,
so I left it that way.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/imap-send.c b/imap-send.c
index fddaac00..203284d8 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -945,7 +945,7 @@ imap_open_store( imap_server_conf_t *srvc )
 				_exit( 127 );
 			close( a[0] );
 			close( a[1] );
-			execl( "/bin/sh", "sh", "-c", srvc->tunnel, 0 );
+			execl( "/bin/sh", "sh", "-c", srvc->tunnel, NULL );
 			_exit( 127 );
 		}