From: Sergey Vlasov <vsu@altlinux.ru>
Date: Fri, 23 Sep 2005 12:28:23 +0000 (+0400)
Subject: [PATCH] git-local-fetch: Fix error checking and leak in setup_indices()
X-Git-Tag: v0.99.7c~2^2~5
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=8be707de55e473a5d850a1fcdc6e30589a37d548;p=git.git

[PATCH] git-local-fetch: Fix error checking and leak in setup_indices()

setup_indices() did not check the return value of opendir(), and
did not have a corresponding closedir() call.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/local-fetch.c b/local-fetch.c
index 81765323..b3947a96 100644
--- a/local-fetch.c
+++ b/local-fetch.c
@@ -38,6 +38,8 @@ static int setup_indices(void)
 	unsigned char sha1[20];
 	sprintf(filename, "%s/objects/pack/", path);
 	dir = opendir(filename);
+	if (!dir)
+		return -1;
 	while ((de = readdir(dir)) != NULL) {
 		int namelen = strlen(de->d_name);
 		if (namelen != 50 || 
@@ -46,6 +48,7 @@ static int setup_indices(void)
 		get_sha1_hex(de->d_name + 5, sha1);
 		setup_index(sha1);
 	}
+	closedir(dir);
 	return 0;
 }