From: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
Date: Thu, 19 Jan 2017 12:31:52 +0000 (+0000)
Subject: mcelog: Free notification metadata
X-Git-Tag: collectd-5.8.0~239^2~2
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=82f58bee213fb6bf2d3f1ecaf789baf1e2593cea;p=collectd.git

mcelog: Free notification metadata

Change-Id: I68f883415a1c5d75cecb748b6c5788b536903333
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
---

diff --git a/src/mcelog.c b/src/mcelog.c
index 484464f9..b5f91f18 100644
--- a/src/mcelog.c
+++ b/src/mcelog.c
@@ -161,6 +161,8 @@ static void mcelog_dispatch_notification(notification_t *n) {
   sstrncpy(n->host, hostname_g, sizeof(n->host));
   sstrncpy(n->type, "gauge", sizeof(n->type));
   plugin_dispatch_notification(n);
+  if (n->meta)
+    plugin_notification_meta_free(n->meta);
 }
 
 static int socket_reinit(socket_adapter_t *self) {
@@ -221,37 +223,44 @@ static int mcelog_prepare_notification(notification_t *n,
     if (plugin_notification_meta_add_string(n, MCELOG_DIMM_NAME, mr.dimm_name) <
         0) {
       ERROR("%s: add DIMM name meta data failed", MCELOG_PLUGIN);
+      plugin_notification_meta_free(n->meta);
       return (-1);
     }
   if (plugin_notification_meta_add_signed_int(n, MCELOG_CORRECTED_ERR,
                                               mr.corrected_err_total) < 0) {
     ERROR("%s: add corrected errors meta data failed", MCELOG_PLUGIN);
+    plugin_notification_meta_free(n->meta);
     return (-1);
   }
   if (plugin_notification_meta_add_signed_int(
           n, "corrected memory timed errors", mr.corrected_err_timed) < 0) {
     ERROR("%s: add corrected timed errors meta data failed", MCELOG_PLUGIN);
+    plugin_notification_meta_free(n->meta);
     return (-1);
   }
   if (plugin_notification_meta_add_string(n, "corrected errors time period",
                                           mr.corrected_err_timed_period) < 0) {
     ERROR("%s: add corrected errors period meta data failed", MCELOG_PLUGIN);
+    plugin_notification_meta_free(n->meta);
     return (-1);
   }
   if (plugin_notification_meta_add_signed_int(n, MCELOG_UNCORRECTED_ERR,
                                               mr.uncorrected_err_total) < 0) {
     ERROR("%s: add corrected errors meta data failed", MCELOG_PLUGIN);
+    plugin_notification_meta_free(n->meta);
     return (-1);
   }
   if (plugin_notification_meta_add_signed_int(
           n, "uncorrected memory timed errors", mr.uncorrected_err_timed) < 0) {
     ERROR("%s: add corrected timed errors meta data failed", MCELOG_PLUGIN);
+    plugin_notification_meta_free(n->meta);
     return (-1);
   }
   if (plugin_notification_meta_add_string(n, "uncorrected errors time period",
                                           mr.uncorrected_err_timed_period) <
       0) {
     ERROR("%s: add corrected errors period meta data failed", MCELOG_PLUGIN);
+    plugin_notification_meta_free(n->meta);
     return (-1);
   }