From: Florian Forster <octo@collectd.org>
Date: Mon, 5 Jun 2017 05:33:36 +0000 (+0200)
Subject: intel_rdt plugin: Remove unnecessary goto.
X-Git-Tag: collectd-5.7.2~1^2
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=6cc3518e81c3a5efa89be19930d4608272197733;p=collectd.git

intel_rdt plugin: Remove unnecessary goto.
---

diff --git a/src/intel_rdt.c b/src/intel_rdt.c
index 73288366..6f157b8f 100644
--- a/src/intel_rdt.c
+++ b/src/intel_rdt.c
@@ -527,43 +527,36 @@ rdt_preinit_error1:
 }
 
 static int rdt_config(oconfig_item_t *ci) {
-  int ret = 0;
-
-  ret = rdt_preinit();
-  if (ret != 0) {
+  if (rdt_preinit() != 0) {
     g_state = CONFIGURATION_ERROR;
     /* if we return -1 at this point collectd
       reports a failure in configuration and
       aborts
     */
-    goto exit;
+    return (0);
   }
 
   for (int i = 0; i < ci->children_num; i++) {
     oconfig_item_t *child = ci->children + i;
 
     if (strcasecmp("Cores", child->key) == 0) {
-
-      ret = rdt_config_cgroups(child);
-      if (ret != 0) {
+      if (rdt_config_cgroups(child) != 0) {
         g_state = CONFIGURATION_ERROR;
         /* if we return -1 at this point collectd
            reports a failure in configuration and
            aborts
          */
-        goto exit;
+	return (0);
       }
 
 #if COLLECT_DEBUG
       rdt_dump_cgroups();
 #endif /* COLLECT_DEBUG */
-
     } else {
       ERROR(RDT_PLUGIN ": Unknown configuration parameter \"%s\".", child->key);
     }
   }
 
-exit:
   return (0);
 }