From: Pavel Rochnyack <pavel2000@ngs.ru>
Date: Mon, 22 Jul 2019 16:45:18 +0000 (+0700)
Subject: virt: Fix memory leak with libvirt MetadataXPath enabled
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=6a942c698e7d0cb946125514dae5e91431dc8871;p=collectd.git

virt: Fix memory leak with libvirt MetadataXPath enabled

Issue: #3225
---

diff --git a/src/virt.c b/src/virt.c
index 5c894c2a..2028b049 100644
--- a/src/virt.c
+++ b/src/virt.c
@@ -816,6 +816,7 @@ metadata_end:
 
 static void init_value_list(value_list_t *vl, virDomainPtr dom) {
   const char *name;
+  char *metaname;
   char uuid[VIR_UUID_STRING_BUFLEN];
 
   sstrncpy(vl->plugin, PLUGIN_NAME, sizeof(vl->plugin));
@@ -846,9 +847,10 @@ static void init_value_list(value_list_t *vl, virDomainPtr dom) {
         SSTRNCAT(vl->host, uuid, sizeof(vl->host));
       break;
     case hf_metadata:
-      name = metadata_get_hostname(dom);
-      if (name)
-        SSTRNCAT(vl->host, name, sizeof(vl->host));
+      metaname = metadata_get_hostname(dom);
+      if (metaname)
+        SSTRNCAT(vl->host, metaname, sizeof(vl->host));
+      sfree(metaname);
       break;
     }
   }
@@ -874,9 +876,10 @@ static void init_value_list(value_list_t *vl, virDomainPtr dom) {
         SSTRNCAT(vl->plugin_instance, uuid, sizeof(vl->plugin_instance));
       break;
     case plginst_metadata:
-      name = metadata_get_hostname(dom);
-      if (name)
-        SSTRNCAT(vl->plugin_instance, name, sizeof(vl->plugin_instance));
+      metaname = metadata_get_hostname(dom);
+      if (metaname)
+        SSTRNCAT(vl->plugin_instance, metaname, sizeof(vl->plugin_instance));
+      sfree(metaname);
       break;
     }
   }