From: Pavel Roskin <proski@gnu.org>
Date: Wed, 21 Dec 2005 20:35:48 +0000 (-0500)
Subject: [PATCH] quote.c: Make loop control more readable.
X-Git-Tag: v1.0.0b^2~1
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=50e7b06730915dd7439e880fe84439a4483ccbb4;p=git.git

[PATCH] quote.c: Make loop control more readable.

quote_c_style_counted() in quote.c uses a hard-to-read  construct.
Convert this to a more traditional form of the for loop.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/quote.c b/quote.c
index 76eb1442..7218a708 100644
--- a/quote.c
+++ b/quote.c
@@ -126,8 +126,10 @@ static int quote_c_style_counted(const char *name, int namelen,
 
 	if (!no_dq)
 		EMIT('"');
-	for (sp = name; (ch = *sp++) && (sp - name) <= namelen; ) {
-
+	for (sp = name; sp < name + namelen; sp++) {
+		ch = *sp;
+		if (!ch)
+			break;
 		if ((ch < ' ') || (ch == '"') || (ch == '\\') ||
 		    (ch == 0177)) {
 			needquote = 1;