From: Junio C Hamano Date: Fri, 25 Nov 2005 19:10:49 +0000 (-0800) Subject: config.c: avoid shadowing global. X-Git-Tag: v0.99.9k^2~6 X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=3a2f2bb354d920e3f1b7f4334d3656c77e9fb423;p=git.git config.c: avoid shadowing global. This is purely cosmetic, but avoid shadowing "FILE *config_file" global in git_config_set_multivar() function. Signed-off-by: Junio C Hamano --- diff --git a/config.c b/config.c index 18d59ee6..5cc85350 100644 --- a/config.c +++ b/config.c @@ -398,7 +398,7 @@ int git_config_set_multivar(const char* key, const char* value, int i; struct stat st; int fd; - char* config_file = strdup(git_path("config")); + char* config_filename = strdup(git_path("config")); char* lock_file = strdup(git_path("config.lock")); const char* last_dot = strrchr(key, '.'); @@ -444,7 +444,7 @@ int git_config_set_multivar(const char* key, const char* value, /* * If .git/config does not exist yet, write a minimal version. */ - if (stat(config_file, &st)) { + if (stat(config_filename, &st)) { static const char contents[] = "#\n" "# This is the config file\n" @@ -523,7 +523,7 @@ int git_config_set_multivar(const char* key, const char* value, return 5; } - in_fd = open(config_file, O_RDONLY, 0666); + in_fd = open(config_filename, O_RDONLY, 0666); contents = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, in_fd, 0); close(in_fd); @@ -564,12 +564,12 @@ int git_config_set_multivar(const char* key, const char* value, st.st_size - copy_begin); munmap(contents, st.st_size); - unlink(config_file); + unlink(config_filename); } close(fd); - if (rename(lock_file, config_file) < 0) { + if (rename(lock_file, config_filename) < 0) { fprintf(stderr, "Could not rename the lock file?\n"); return 4; }