From: Florian Forster <octo@leeloo.lan.home.verplant.org>
Date: Mon, 16 Mar 2009 08:38:42 +0000 (+0100)
Subject: src/liboping/liboping.c: Fix a problem with strict aliasing.
X-Git-Tag: collectd-4.6.2~2^2~2
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=2d8915c37b7be045e6e638ff67e0b1168b4136a6;p=collectd.git

src/liboping/liboping.c: Fix a problem with strict aliasing.

Just remove the code since it's dead anyway.

Thanks to Alan Pevec <apevec at gmail.com> for pointing this out :)
---

diff --git a/src/liboping/liboping.c b/src/liboping/liboping.c
index 13bcc920..fb3f8431 100644
--- a/src/liboping/liboping.c
+++ b/src/liboping/liboping.c
@@ -921,9 +921,6 @@ int ping_host_add (pingobj_t *obj, const char *host)
 {
 	pinghost_t *ph;
 
-	struct sockaddr_storage sockaddr;
-	socklen_t               sockaddr_len;
-
 	struct addrinfo  ai_hints;
 	struct addrinfo *ai_list, *ai_ptr;
 	int              ai_return;
@@ -982,30 +979,13 @@ int ping_host_add (pingobj_t *obj, const char *host)
 	{
 		ph->fd = -1;
 
-		sockaddr_len = sizeof (sockaddr);
-		memset (&sockaddr, '\0', sockaddr_len);
-
 		if (ai_ptr->ai_family == AF_INET)
 		{
-			struct sockaddr_in *si;
-
-			si = (struct sockaddr_in *) &sockaddr;
-			si->sin_family = AF_INET;
-			si->sin_port   = htons (ph->ident);
-			si->sin_addr.s_addr = htonl (INADDR_ANY);
-
 			ai_ptr->ai_socktype = SOCK_RAW;
 			ai_ptr->ai_protocol = IPPROTO_ICMP;
 		}
 		else if (ai_ptr->ai_family == AF_INET6)
 		{
-			struct sockaddr_in6 *si;
-
-			si = (struct sockaddr_in6 *) &sockaddr;
-			si->sin6_family = AF_INET6;
-			si->sin6_port   = htons (ph->ident);
-			si->sin6_addr   = in6addr_any;
-
 			ai_ptr->ai_socktype = SOCK_RAW;
 			ai_ptr->ai_protocol = IPPROTO_ICMPV6;
 		}