From: Mark Wooding <mdw@distorted.org.uk>
Date: Fri, 3 Feb 2006 20:27:02 +0000 (+0000)
Subject: daemon: Provide missing argument for logerror() call.
X-Git-Tag: v1.2.0~67
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=1fda3d557b7c9e19e008c3a3d77f1922341796d7;p=git.git

daemon: Provide missing argument for logerror() call.

Could cause a crash if --base-path set.  Unlikely to be a security the
concern: message doesn't go to the client, so we can't leak anything
(except by dumping core), and we've already forked, so it's not a denial
of service.

Signed-off-by: Mark Wooding <mdw@distorted.org.uk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/daemon.c b/daemon.c
index bb014fa9..532bb0c3 100644
--- a/daemon.c
+++ b/daemon.c
@@ -147,7 +147,7 @@ static char *path_ok(char *dir)
 		static char rpath[PATH_MAX];
 		if (*dir != '/') {
 			/* Forbid possible base-path evasion using ~paths. */
-			logerror("'%s': Non-absolute path denied (base-path active)");
+			logerror("'%s': Non-absolute path denied (base-path active)", dir);
 			return NULL;
 		}
 		snprintf(rpath, PATH_MAX, "%s%s", base_path, dir);