From: Florian Forster <octo@collectd.org>
Date: Mon, 12 Sep 2016 06:47:16 +0000 (+0200)
Subject: conntrack plugin: Use parse_value_file().
X-Git-Tag: collectd-5.7.0~98^2~4
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=0cf23dfad554180158e44b4a7292f72f27549c31;p=collectd.git

conntrack plugin: Use parse_value_file().
---

diff --git a/src/conntrack.c b/src/conntrack.c
index ce90ede3..4a72b2f6 100644
--- a/src/conntrack.c
+++ b/src/conntrack.c
@@ -74,61 +74,26 @@ static void conntrack_submit (const char *type, const char *type_instance,
 static int conntrack_read (void)
 {
 	value_t conntrack, conntrack_max, conntrack_pct;
-	FILE *fh;
-	char buffer[64] = { 0 };
-	size_t buffer_len;
 
-	fh = fopen (old_files?CONNTRACK_FILE_OLD:CONNTRACK_FILE, "r");
-	if (fh == NULL)
-		return (-1);
-
-	if (fgets (buffer, sizeof (buffer), fh) == NULL)
+	char const *path = old_files ? CONNTRACK_FILE_OLD : CONNTRACK_FILE;
+	if (parse_value_file (path, &conntrack, DS_TYPE_GAUGE) != 0)
 	{
-		fclose (fh);
+		ERROR ("conntrack plugin: Reading \"%s\" failed.", path);
 		return (-1);
 	}
-	fclose (fh);
 
-	/* strip trailing newline. */
-	buffer_len = strlen (buffer);
-	while ((buffer_len > 0) && isspace ((int) buffer[buffer_len - 1]))
+	path = old_files ? CONNTRACK_MAX_FILE_OLD : CONNTRACK_MAX_FILE;
+	if (parse_value_file (path, &conntrack_max, DS_TYPE_GAUGE) != 0)
 	{
-		buffer[buffer_len - 1] = 0;
-		buffer_len--;
-	}
-
-	if (parse_value (buffer, &conntrack, DS_TYPE_GAUGE) != 0)
-		return (-1);
-
-	conntrack_submit ("conntrack", NULL, conntrack);
-
-	fh = fopen (old_files?CONNTRACK_MAX_FILE_OLD:CONNTRACK_MAX_FILE, "r");
-	if (fh == NULL)
-		return (-1);
-
-	memset (buffer, 0, sizeof (buffer));
-	if (fgets (buffer, sizeof (buffer), fh) == NULL)
-	{
-		fclose (fh);
+		ERROR ("conntrack plugin: Reading \"%s\" failed.", path);
 		return (-1);
 	}
-	fclose (fh);
-
-	/* strip trailing newline. */
-	buffer_len = strlen (buffer);
-	while ((buffer_len > 0) && isspace ((int) buffer[buffer_len - 1]))
-	{
-		buffer[buffer_len - 1] = 0;
-		buffer_len--;
-	}
-
-	if (parse_value (buffer, &conntrack_max, DS_TYPE_GAUGE) != 0)
-		return (-1);
 
-	conntrack_submit ("conntrack", "max", conntrack_max);
 	conntrack_pct.gauge = (conntrack.gauge / conntrack_max.gauge) * 100;
-	conntrack_submit ("percent", "used", conntrack_pct);
 
+	conntrack_submit ("conntrack", NULL,   conntrack);
+	conntrack_submit ("conntrack", "max",  conntrack_max);
+	conntrack_submit ("percent",   "used", conntrack_pct);
 
 	return (0);
 } /* static int conntrack_read */